> > Use @code instead of @param here.
Fixed.
- Shanthoosh
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/#review164786
--
rated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/#review164765
-------
On Feb. 8, 2017, 9:37 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is
/scala/org/apache/samza/config/KafkaConfig.scala
9320cf744ff90d647a198b51cb06d2a526fe68fa
Diff: https://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
/scala/org/apache/samza/config/KafkaConfig.scala
9320cf744ff90d647a198b51cb06d2a526fe68fa
Diff: https://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
DAYS.toMillis(1)
Fixed.
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/#review164701
---
On Feb. 8, 2017, 7
been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
,
Shanthoosh Venkataraman
/samza/job/yarn/SamzaAppMasterMetrics.scala
8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca
Diff: https://reviews.apache.org/r/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
/TestSamzaRestService.java
PRE-CREATION
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca
Diff: https://reviews.apache.org/r/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh
tricsConfig constructure takes a subset.
> >
> > I think it takes the root and expects to find the "metrics" prefix
>
> Jake Maes wrote:
> s/constructure/constructor
>
> phonetic brain fail
>
> Shanthoosh Venkataraman wrote:
> Yes,
eek Maheshwari wrote:
> > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line
> > 91
> > <https://reviews.apache.org/r/53297/diff/5/?file=1560180#file1560180line91>
> >
> > See previous comment about just passing the entir
he samza-rest server? The monitor? The
> > container being monitored?
>
> Shanthoosh Venkataraman wrote:
> I think `execution unit` is a misnomer. By execution unit, I meant the
> origin of the metrics (physical hostname in which the samza rest process is
> running/
is used when metrics are reported?
> >
> > Is there a reason for this to be configurable / adding a new config
> > key?
> >
> > If it's configurable, we should document it somewhere?
>
> Shanthoosh Venkataraman wrote:
> Container name here refers
/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
/SamzaAppMasterMetrics.scala
8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca
Diff: https://reviews.apache.org/r/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
estResource literal etc)
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53297/#review155511
---
On Nov. 9, 2016, 10
is used when metrics are reported?
> >
> > Is there a reason for this to be configurable / adding a new config
> > key?
> >
> > If it's configurable, we should document it somewhere?
>
> Shanthoosh Venkataraman wrote:
> Container name here refers
efined, it's defaulted to hostName on which SamzaRest is
running. Resources will report metrics alongside monitors. Added relevent
documentation for it.
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https:
/SamzaAppMasterMetrics.scala
8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca
Diff: https://reviews.apache.org/r/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
on functionalities) shared
between samza-core & samza-rest into samza-common is a longer term goal which
is required to remove dependencies. However, for the scope of this patch, doing
this will be a overkill. Punted for now.
- Shanthoosh
------
<https://reviews.apache.org/r/52168/diff/8/?file=1552723#file1552723line99>
> >
> > Not required for the other place they're used?
>
> Shanthoosh Venkataraman wrote:
> Yes.
>
> Prateek Maheshwari wrote:
> "Yes, it's required" or "Yes, i
line 22
> > <https://reviews.apache.org/r/52168/diff/10/?file=1553937#file1553937line22>
> >
> > I don't think the line that `Additional operations will be added later`
> > is meaningful. You can maybe remove it?
Done.
- Shanthoosh
/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
sing a proper name
here. For instance, in SamzaContainerMetrics source string is assigned to value
"unknown". I'm most certain that this string is a placeholder to register
MetricsRegistry instances with MetricsReporter and not used when reporting the
actual metrics.
- Shanth
mza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala,
> > line 340
> > <https://reviews.apache.org/r/52168/diff/8/?file=1552723#file1552723line340>
> >
> > Previous line.
Done.
> On Nov. 3, 2016, 6:32 a.m., Prateek Maheshwari wro
/MockTaskProxy.java
PRE-CREATION
samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
/MockTaskProxy.java
PRE-CREATION
samza-rest/src/test/java/org/apache/samza/rest/resources/mock/MockTaskProxyFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca
Diff: https://reviews.apache.org/r/53297/diff/
Testing
---
Unit tests are done to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
/MockTaskProxyFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
> > getChangeLogDeleteRetentionsInMs
Done.
- Shanthoosh
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/#review153478
--
/scala/org/apache/samza/config/KafkaConfig.scala
973ab8cfb3d248bec7efe5e338f5e667f097556d
Diff: https://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
ps://reviews.apache.org/r/52476/#review153468
-------
On Oct. 22, 2016, 10:06 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail.
CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
------
On Oct. 20, 2016, 9:52 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52492/
> ---
22
> > <https://reviews.apache.org/r/52476/diff/3/?file=1539990#file1539990line122>
> >
> > Mention somewhere in the message that this means that the store is
> > stale.
Done.
- Shanthoosh
---
This is an a
/scala/org/apache/samza/config/KafkaConfig.scala
973ab8cfb3d248bec7efe5e338f5e667f097556d
Diff: https://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
------
On Oct. 19, 2016, 1:11 a.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53002/
> ---
,
Shanthoosh Venkataraman
/mock/MockMonitorFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/53002/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
/scala/org/apache/samza/config/KafkaConfig.scala
973ab8cfb3d248bec7efe5e338f5e667f097556d
Diff: https://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
elete.retention.ms
> > 2. Rename the property so it's one of the "topic-level-property" so it gets
> > automatically passed to kafka. This is convenient but wouldn't apply to
> > other systems, which could be useful if those other systems have a delete
> > reten
> On Oct. 13, 2016, 12:55 a.m., Jake Maes wrote:
> > docs/learn/documentation/versioned/rest/resources/tasks.md, line 55
> > <https://reviews.apache.org/r/52168/diff/5/?file=1533539#file1533539line55>
> >
> > What is the value of the container name?
&
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52476/#review151439
---
On Oct. 4, 2016, 11:33 p.m., Shanthoosh Venkataraman wrote:
>
> --
.apache.org/r/52168/#review152418
---
On Oct. 13, 2016, 11:57 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
tor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
ration specific to it.
- Shanthoosh Venkataraman
On Oct. 10, 2016, 11:10 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
a rest API at
> > those urls
Moved all the url constants to query into ResourceConstants class.
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52492/#review152039
--
esources/ResourceConstants.java
PRE-CREATION
samza-rest/src/test/java/org/apache/samza/monitor/TestYarnLocalStoreMonitor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Sh
-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
est/java/org/apache/samza/monitor/TestLocalStoreMonitor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52492/diff/
Testing
---
Unit testing and manual testing are done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
://reviews.apache.org/r/52476/diff/
Testing
---
Unit testing and manual testing has been done to verify the functionality.
Thanks,
Shanthoosh Venkataraman
273
---
On Oct. 3, 2016, 5 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52476/
>
://reviews.apache.org/r/51703/diff/
Testing
---
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
Diff: https://reviews.apache.org/r/51703/diff/
Testing
---
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
.apache.org/r/51703/#review150435
---
On Sept. 24, 2016, 12:34 a.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
taining to config parsing out
> > into a separate class.
Whole functionality of parsing the configs are migrated to MonitorLoader class.
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https://rev
/SamzaMonitorService.java
(lines 74 - 75)
<https://reviews.apache.org/r/51703/#comment218128>
Instantiation of monitors through reflection using monitorFactoryClassName
can possibly throw InstantiationException. This catch block handles that.
- Shanthoosh Venkataraman
On Sept. 14, 2016, 8:
te the monitor
instances from factory, can throw InstantiationException. This catch block
handles that.
- Shanthoosh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review150206
-
-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
/samza/rest/resources/mock/MockTaskProxyFactory.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52168/diff/
Testing
---
Manual and unit testing has been done to verify the apis.
Thanks,
Shanthoosh Venkataraman
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/#review148730
---
On Sept. 14, 2016, 8:37 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> Th
bility in allowing
many custom MonitorFactory implementations.
- Shanthoosh Venkataraman
On Sept. 14, 2016, 8:37 p.m., Shanthoosh Venkataraman wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java
c4f3f735f78d56f8bb3ef203a05e2bec92489767
Diff: https://reviews.apache.org/r/51703/diff/
Testing
---
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
-CREATION
Diff: https://reviews.apache.org/r/51703/diff/
Testing
---
Unit tests are used to verify the intended functionality.
Thanks,
Shanthoosh Venkataraman
72 matches
Mail list logo
