://reviews.apache.org/r/52526/diff/
Testing
---
Tested in my dev with the following cases:
1. one server is down before client connection
2. one server is down after client connection and during client request
Thanks,
Li Li
://reviews.apache.org/r/52526/diff/
Testing
---
Tested in my dev with the following cases:
1. one server is down before client connection
2. one server is down after client connection and during client request
Thanks,
Li Li
solution is to make invokeImpl synchronized
- Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52526/#review155003
----------
://reviews.apache.org/r/52526/diff/
Testing
---
Tested in my dev with the following cases:
1. one server is down before client connection
2. one server is down after client connection and during client request
Thanks,
Li Li
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52526/#review154867
-----------
On Nov. 2, 2016, 6:08 p.m., Li Li wrote:
>
> ---
> This is an autom
he.org/r/52526/#comment224721>
actually client will be closed in cient.connectWithRetry(). But I will move
it to the client
- Li Li
On Nov. 2, 2016, 6:08 p.m., Li Li wrote:
>
> ---
> This is an automatically generate
automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52916/
> ---
>
> (Updated Nov. 3, 2016, 3:58 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Li Li, and
> Sravya Tirukkovalur.
/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
(line 253)
<https://reviews.apache.org/r/52916/#comment224516>
remove this line?
- Li Li
On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov
3f57a003903961a6aea98bd583a14b65bd2b98a2
Diff: https://reviews.apache.org/r/52526/diff/
Testing
---
Tested in my dev with the following cases:
1. one server is down before client connection
2. one server is down after client connection and during client request
Thanks,
Li Li
/#comment224014>
i see. sure.
- Li Li
On Oct. 27, 2016, 4:41 p.m., Li Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52582/#review154180
---
Ship it!
Ship It!
- Li Li
On Oct. 28, 2016, 8:03 p.m., Anne
in the same
patch?
sentry-tests/sentry-tests-solr/pom.xml (line 83)
<https://reviews.apache.org/r/52582/#comment223651>
I am not sure if it is good to resolve two jiras in a same patch. Maybe
better make this change in a separate patch?
- Li Li
On Oct. 24, 2016, 11:18 p.m., A
server is down after client connection and during client request
Thanks,
Li Li
/sentry/provider/db/service/thrift/TestSentryServiceFailureCase.java
d1ac44766b049fb6fb6e6ce822cc0b63c0f6d66e
Diff: https://reviews.apache.org/r/53175/diff/
Testing
---
Thanks,
Li Li
comment
- Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53175/#review153827
---
On Oct. 25, 2016, 9:51 p.m., Li Li wrote:
>
> ---
>
s should focused in non pool as
well.
- Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53175/#review153822
-------
On Oct. 25, 2016, 8:20 p.m., Li Li wrote:
>
> ---
9e90af8f5b638d346e3f48405441ad97b9ef09ad
Diff: https://reviews.apache.org/r/53175/diff/
Testing
---
Thanks,
Li Li
-jdo.version is
already set to 3.2.0-m3 here.
- Li Li
On Oct. 20, 2016, 12:21 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52888/#review152697
---
Ship it!
Ship It!
- Li Li
On Oct. 14, 2016, 4:08 p.m., Colm
and during client request
Thanks,
Li Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52138/#review152359
---
Ship it!
Ship It!
- Li Li
On Oct. 12, 2016, 7:15 a.m., Hao
other cases (print help)?
Better ask someone else to do a code review since I am not familiar with test
framework.
- Li Li
On Oct. 11, 2016, 4:29 a.m., Anne Yu wrote:
>
> ---
> This is an automatically generated e
> On Oct. 11, 2016, 6:20 p.m., Li Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java,
> > line 77
> > <https://reviews.apache.org/r/52138/diff/6/?file=1525949#file1525949line77>
> >
> > I
/sentry/service/thrift/HMSFollower.java
(line 77)
<https://reviews.apache.org/r/52138/#comment221011>
I think we should set fullUpdateComplete to static, so that when the last
HMSFollower update it to true, the next HMSFollower won't do full update again.
- Li Li
On Oct. 6, 2016, 10:
/reviews.apache.org/r/52138/
> -------
>
> (Updated Oct. 6, 2016, 10:22 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya
> Tirukkovalur.
>
>
> Repository: sentry
>
e.org/r/52675/#comment220802>
use a final member var for column s1 here?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java
(line 298)
<https://reviews.apache.org/r/52675/#comment220803>
remove the space between i and '++
added in
a pool, which will be shared by multiple threads. And all threads will share
the state of the connections, which is curFreshestEndpointIdx and endpoints in
the code. If thread A failed to connect to nth server, then thread B after A
will skip n and try n+1.
- Li Li
On Oct. 7, 2016,
ETest case showing the timeout used?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/RulesForE2ETest.java
(line 47)
<https://reviews.apache.org/r/52582/#comment220416>
use final static var for all the timeout?
- Li Li
On Oct. 5, 2016, 1
doop/hive/common/FileUtils.java
good catch! will fix it
- Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45859/#review151825
-------
sentry.service.web.authentication.type
is set to KERBEROS, only the SENTRY_WEB_SECURITY_ALLOW_CONNECT_USERS can see
this page. Also this webpage can be seen only when
SENTRY_WEB_ADMIN_SERVLET_ENABLED is true.
Thanks,
Li Li
ly, visit:
https://reviews.apache.org/r/45859/#review151614
-------
On Oct. 7, 2016, 12:26 a.m., Li Li wrote:
>
> ---
> This is an automatically generated e-mail.
, and
after each full retry, we will have a small random sleep.
Thanks,
Li Li
sentry.service.web.authentication.type
is set to KERBEROS, only the SENTRY_WEB_SECURITY_ALLOW_CONNECT_USERS can see
this page. Also this webpage can be seen only when
SENTRY_WEB_ADMIN_SERVLET_ENABLED is true.
Thanks,
Li Li
when
SENTRY_WEB_ADMIN_SERVLET_ENABLED is true.
Thanks,
Li Li
5b0e12bbf12510d8d424aa2b7f51076a913234c5
Diff: https://reviews.apache.org/r/52526/diff/
Testing
---
Thanks,
Li Li
/TestSentryVersion.java
e401859ab492c1d2a7634361fa301b3350661929
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
57d579cc6179319e3525424d652d224323e21457
Diff: https://reviews.apache.org/r/52150/diff/
Testing
---
Thanks,
Li Li
<https://reviews.apache.org/r/52138/#comment218199>
shall we update currentEventID with eventIDBefore(or
eventIDAfter).getEventId(),
so that client will process notification events from eventIDBefore + 1 ?
- Li Li
On Sept. 23, 2016, 6:15 a.m., H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52138/#review150190
---
Ship it!
Ship It!
- Li Li
On Sept. 23, 2016, 6:15 a.m., Hao
omplete is always false now.
- Li Li
On Sept. 23, 2016, 12:50 a.m., Hao Hao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52138/
> ---
ps://reviews.apache.org/r/52150/#review150040
-----------
On Sept. 22, 2016, 5:27 a.m., Li Li wrote:
>
> ---
> This is an automatically generated e-mail.
> On Sept. 22, 2016, 6:34 p.m., Sravya Tirukkovalur wrote:
> > Thanks for the patch Li Li! This change seems to be from design V2.1. I
> > think it makes sense to mention that in the jira and also wait for a few
> > days for the community to review the new design befo
(line 220)
<https://reviews.apache.org/r/52138/#comment217891>
Shall we update currentEventID before retry?
Shall we use !equals instead of != ?
- Li Li
On Sept. 22, 2016, 8:39 p.m., Hao Hao wrote:
>
> ---
> This is an automat
/sentry/service/thrift/PoolClientInvocationHandler.java
(line 278)
<https://reviews.apache.org/r/50578/#comment217665>
endpointIdx -> i ?
also in line282
Also consider the situation when exec[i] == null
- Li Li
On Aug. 2, 2016, 9:55 p.m., Hao
/main/resources/realm.properties
PRE-CREATION
sentry-service/sentry-service-server/src/main/webapp/SentryService.html
9eb5f0eb4743c1215caf99a90bc89e810b21db87
Diff: https://reviews.apache.org/r/45859/diff/
Testing
---
Thanks,
Li Li
sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html
ee112ce8d39626784d5d73ef0a4c28f43e7c4f1f
Diff: https://reviews.apache.org/r/45859/diff/
Testing
---
Thanks,
Li Li
Thanks, Hao!
I just updated the wiki.
Best,
Li
On Wed, Mar 30, 2016 at 3:00 PM, Hao Hao <hao@cloudera.com> wrote:
> Hi Li,
>
> Just grant the edit permission to you. Thanks!
>
> Best,
> Hao
>
> On Wed, Mar 30, 2016 at 2:23 PM, Li Li <l...@cloudera.com>
46 matches
Mail list logo
