Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

> On May 10, 2018, 10:19 p.m., kalyan kumar kalvagadda wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java > > Lines 420 (patched) > > > >

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202875 ---

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202720 --- Ship it! Ship It! - Sergio Pena On May 8, 2018, 8:20 p.m.,

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202682 --- Ship it! Ship It! - Na Li On May 8, 2018, 8:20 p.m., Arjun

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 8, 2018, 8:20 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202681 ---

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 8, 2018, 7 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202511 ---

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 9:26 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 9:11 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 8:44 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/ --- (Updated May 4, 2018, 8:23 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202280 ---

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202279 --- By isEmpty(), do you mean to exclude URIs that are blank but not

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

> On May 2, 2018, 2:09 p.m., Ben Iglauer wrote: > > Does SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED end in a space? If not, > > SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED + "to EMPTY URI path" will not > > be formatted correctly. Yes it does. See here: public static final String

Re: Review Request 66898: SENTRY-2214: Sentry should not allow URI grants to EMPTY or NULL locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66898/#review202277 --- Does SentryHiveConstants.PRIVILEGE_NOT_SUPPORTED end in a space?