Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-09-21 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review149898 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-08-04 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144804 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-08-02 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144570 --- Fix it, then Ship it! sentry-provider/sentry-provider-db/src/m

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-08-02 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- (Updated Aug. 2, 2016, 9:55 p.m.) Review request for sentry and Sravya Tirukkov

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Hao Hao
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java, > > lines 273-278 > > > > > > It is

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Sravya Tirukkovalur
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java, > > lines 273-278 > > > > > > It is

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Hao Hao
> On July 29, 2016, 5:17 p.m., Rahul Sharma wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestPoolClientInvocationHandler.java, > > line 26 > > > > > > Can check out if

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-29 Thread Rahul Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144126 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- (Updated July 29, 2016, 12:47 a.m.) Review request for sentry and Sravya Tirukk

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
> On July 28, 2016, 10:18 p.m., Sravya Tirukkovalur wrote: > > Thanks for picking this up Hao! Appreciate it! Do we need to update the non > > pool java clients as well? Yeah, good point. Tend to deprecated non pool java clients in this case. Do you know any reason why we have to keep it? >

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Sravya Tirukkovalur
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/#review144007 --- Thanks for picking this up Hao! Appreciate it! Do we need to updat

Re: Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- (Updated July 28, 2016, 9:14 p.m.) Review request for sentry and Sravya Tirukko

Review Request 50578: Sentry-1411: The sentry client should retry RPCs if it gets a SentryStandbyException

2016-07-28 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50578/ --- Review request for sentry and Sravya Tirukkovalur. Repository: sentry Descrip