Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/ --- (Updated April 27, 2018, 3:13 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread Na Li via Review Board
> On April 25, 2018, 8:21 p.m., Sergio Pena wrote: > > Lina, would it be better to create another patch to fix the 2.1.0 versions? > > So we can have this patch to add the index only instead of several new > > files, what do you think? > > Na Li wrote: > Sergio, I don't want to take the tr

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread Na Li via Review Board
> On April 23, 2018, 9:59 p.m., kalyan kumar kalvagadda wrote: > > You need to update the new version in SentryStoreSchemaInfo.java.Please > > make this change ans run the upgrade/install tests to make sure thay are > > fine. it is done - Na

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202067 --- Ship it! Ship It! - Sergio Pena On April 27, 2018, 3:13 p.m.

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

2018-04-27 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 27, 2018, 3:47 p.m.) Review request for sentry. Repository: se

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66764/#review202069 --- Lina, This index might not be needed for every database. we need i

Re: Review Request 66764: SENTRY-2210: AUTHZ_PATH should have index on the foreign key AUTHZ_OBJ_ID

2018-04-27 Thread Na Li via Review Board
> On April 27, 2018, 3:51 p.m., kalyan kumar kalvagadda wrote: > > Lina, This index might not be needed for every database. we need it for > > Oracle database for sure. > > > > For example, mysql creates an index automaticallym when a cloumn is added > > as a foreign key. Adding a duplicate in

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-27 Thread Steve Moist via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/ --- (Updated April 27, 2018, 4:47 p.m.) Review request for sentry. Changes --

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

2018-04-27 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review202072 --- Ship it! Thanks, the change looks better. FYI, keeping the lev

Re: Review Request 66792: SENTRY-1949: Old full snapshots are never cleaned up

2018-04-27 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66792/#review202073 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr