Re: Migrating existing loggers to Lombok

I prefer option-1. Changing complete code involves change a ton of class. It's a huge effort. Even if you take option-2 if would take a very only time to change all the classes. Let's be practical. *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer t. (469) 279- <00>5732 cloudera.com

Re: Migrating existing loggers to Lombok

Stephen, I prefer option 2), so our code can be more consistent. Thanks, Lina On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist wrote: > Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers > in the SPI portion of Sentry. For consistency’s sake, we should migrate > the

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review209000 --- Ship it! Ship It! - kalyan kumar kalvagadda On Sept. 24,

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

> On Sept. 24, 2018, 11:23 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > > Lines 915 (patched) > > > > > > you have

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/ --- (Updated Sept. 25, 2018, 9:23 p.m.) Review request for sentry, Na Li and

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209007 ---

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

> On Sept. 25, 2018, 11:22 p.m., Na Li wrote: > > sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift > > Lines 419 (patched) > > > > > > I heard today that it is possible to assign

Re: Review Request 68822: SENTRY-2371 Add a new thrift API for getting all privileges a user has

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68822/#review209014 --- Ship it! Ship It! - Na Li On Sept. 25, 2018, 9:23 p.m., Hao

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/ --- (Updated Sept. 26, 2018, 5:11 a.m.) Review request for sentry, kalyan kumar

Review Request 68838: SENTRY-2410: CREATE privileges on Hive does not allow a user to list all tables of a database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68838/ --- Review request for sentry, Na Li and Sergio Pena. Bugs: SENTRY-2410

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208999 --- Ship it! Ship It! - Dan Burkert On Sept. 24, 2018, 11:45

Re: Review Request 68788: SENTRY-2413: Provide a configuration option to permit specific DB privileges to be granted explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68788/#review208992 --- Ship it! Ship It! - kalyan kumar kalvagadda On Sept. 21,

Re: Review Request 68838: SENTRY-2410: CREATE privileges on Hive does not allow a user to list all tables of a database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68838/#review208995 ---

Migrating existing loggers to Lombok

Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers in the SPI portion of Sentry. For consistency’s sake, we should migrate the existing Sentry code to use the Lombok annotations instead of using the existing logger.getLogger(class). I see 2 ways of doing it. 1) As

Re: Review Request 68831: SENTRY-2417: fix LocalGroupMappingService INI format class docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68831/#review208994 --- Ship it! Ship It! - Na Li On Sept. 24, 2018, 11:45 p.m.,

[VOTE] Release Sentry version 2.1.0

This is the release of Apache Sentry, version 2.1.0. It fixes the following issues: https://issues.apache.org/jira/projects/SENTRY/versions/12342213 Maven artifacts are available https://repository.apache.org/content/repositories/orgapachesentry-1015/ Tag to be voted