Re: Review Request 56191: SENTRY-1619: Fix the secure HMS connection code in HMSFollower

> On Feb. 1, 2017, 11:17 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 182 > > <https://reviews.apache.org/r/56191/diff/1/?file=1621825#file1621825line182> > >

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

tiple places. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java <https://reviews.apache.org/r/55999/#comment235640> This looks like a stray change - Alexander Kolbasov On Jan. 31, 2017, 11:27 p.m., Nac

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55246/#review164091 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 3, 2017, 5

Re: Review Request 56356: SENTRY-1615 SentryStore should not allocate empty objects that are immediately returned

/org/apache/sentry/provider/db/service/persistent/SentryStore.java 321c094366caa2b4a56758781e5fc5a2fc9218d0 Diff: https://reviews.apache.org/r/56356/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 56356: SENTRY-1615 SentryStore should not allocate empty objects that are immediately returned

ion instead. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56356/#review164439 --- On Feb. 7, 2017, 12:47 a.m., Alexander Kolbasov wrote: > > ---

Review Request 56356: SENTRY-1615 SentryStore should not allocate empty objects that are immediately returned

sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtFunctionScope.java cebad987c89c7950e28c700c3fe398d409280163 Diff: https://reviews.apache.org/r/56356/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Sentry roadmap

> On Feb 5, 2017, at 4:24 AM, Bruno Quinart wrote: > > Hi dev Hi Bruno, > > Is there a roadmap to a new version of Sentry available? Sentry HA is a major new feature, but there is no particular reason preventing a new release of Sentry cut before that if there is a

Re: Review Request 56134: SENTRY-1593 Implementing client failover for Generic policy clients and namenode clients

thrift/SentryGenericServiceClient.java (line 29) <https://reviews.apache.org/r/56134/#comment236228> We have a single implementor - do we actually need to define this as an interface? Can we just define the class we want (SentryGenericServiceClientDefaultImpl)? - Alexander Kolbasov On Feb. 6

Re: Review Request 55744: SENTRY-1559 Remove fencing support

sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java 7c080fab53d902eb6ce909139cf6f0a9c288ba54 Diff: https://reviews.apache.org/r/55744/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java c9da3ab0a901095acc0d78ce2ed0da0f0038ee56 Diff: https://reviews.apache.org/r/56411/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 56271: SENTRY-1621: HMSFollower to retry connecting to HMS upon connection loss

-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 262) <https://reviews.apache.org/r/56271/#comment235649> can client.close() throw any exception? If it does, you'll miss resetting of kerberos context. - Alexander Kolbasov On Feb. 3, 2017, 4:42 a.m.,

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

ment235633> This seems to be a copy and paste from SentryPlugin.getAuthzOb() - is it possible to just call that one? - Alexander Kolbasov On Feb. 3, 2017, 12:24 a.m., Hao Hao wrote: > > --- > This is an automatically gen

Re: Review Request 56191: SENTRY-1619: Fix the secure HMS connection code in HMSFollower

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56191/#review164066 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 2, 2017, 6

Re: Review Request 56411: SENTRY-1624 DefaultSentryValidator doesn't correctly construct SentryOnFailureHookContextImpl

ink we have any test cases for this. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/#review164577 --- On

[DISCUSS] Extending Sentry protocol

Hello everyone, I would like to extend the Hive-to-Sentry API with a new call needed to synchronize between Hive operations and async Hive notification processing by Sentry. I would like to do it without incrementing the version number - do you think that it is reasonable, or *any* API changes

Re: Review Request 56403: SENTRY-1387 Add HDFS sync tests for drop partition for external/implicit locations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56403/#review164612 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 7, 2017, 8

Re: Review Request 56000: SENTRY-1604 Sentry JSON message factory: Need more information in alter partition event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56000/#review164613 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 4, 2017, 5

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

db/src/main/java/org/apache/sentry/provider/db/service/persistent/UpdateTransactionBlock.java (line 30) <https://reviews.apache.org/r/55246/#comment233945> Will this work for both path update and perm update? - Alexander Kolbasov On Jan. 19, 2017, 2:05 a.m., Hao Hao wrote: > > -

Re: Review Request 55999: SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications

verted to foreach loop sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java (line 134) <https://reviews.apache.org/r/55999/#comment235057> This can be converted to forea

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

I don't think we need hashCode and equals for DeltaTransactionBlock - Alexander Kolbasov On Jan. 27, 2017, 7:41 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 55246: SENTRY-1536: Refactor SentryStore transaction management to allow for extra transactions for a single permission update

tained description of the class. For example: "Implementation of TransactionBlock that persists PathsUpdate or PermissionsUpdate." Please also comment on the assumptions and what exceptions are thrown if these assumptions are wrong. - Alexander Kolbasov On Jan. 27, 2017, 7:

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

) <https://reviews.apache.org/r/54454/#comment233900> It is usuallu better to use isEmpty instead of length() - Alexander Kolbasov On Jan. 17, 2017, 7:28 p.m., kalyan kumar kalvagadda wrote: > >

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

of querying for the operation type - why would someone need it? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56481/#review166218 --- On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote: > > -

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56481/#review166270 ------- On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote: > > --

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

ps://reviews.apache.org/r/56481/#review166228 ------- On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

ckier since I test for keys and values and it is difficult to guarantee specific generated names. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56481/#review166266

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

QueryParamBuilder to subclass QueryPart and be a > > container for a single List to include both simple query parts > > and nested queries, so they're kept in the order of their addition. > > Alexander Kolbasov wrote: > Why would you think that the original order of the co

Re: Review Request 56892: SENTRY-1635: Limit HMS connections only to the leader of the sentry servers

close() generates exception, we don't sent client to null and don't clean kerberos context. Can this be refactored so that we always set client to null and kerberos context to null even if we get exception? We may I don't want to have closed client or kereros context lying around. - Alexander

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

ache.org/r/56481/#review166208 --- On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

valueToken, fieldValue); > > > > Or am I missing something? If there is a reason not to support the same > > field appearing in the query more than once, it needs to be documented and > > an exception should be thrown when someone tries to override an existing &g

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

valueToken, fieldValue); > > > > Or am I missing something? If there is a reason not to support the same > > field appearing in the query more than once, it needs to be documented and > > an exception should be thrown when someone tries to override an existing &g

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

big deal but if you make another round of changes may be you can put a comment about it here. - Alexander Kolbasov On Feb. 21, 2017, 11:30 p.m., Lei Xu wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/56481/#review166225 --- On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote: > > --- > This is an a

Review Request 56861: SENTRY-1636 Remove thrift dependency on fb303

--- I re-generated all Thrift files to verify that there are no actual changes in the generated code. Thanks, Alexander Kolbasov

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 17a4a937221891a72ee44db92976cfa5cab40bc4 Diff: https://reviews.apache.org/r/56481/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 56481: SENTRY-1625: PrivilegeOperatePersistence can use QueryParamBuilder

-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 17a4a937221891a72ee44db92976cfa5cab40bc4 Diff: https://reviews.apache.org/r/56481/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 57065: SENTRY-1600 Define Thrift API for HMS to Sentry notification barrier

/sentry-provider-db/src/main/resources/sentry_policy_service.thrift 4075e3a049773795ecbd40a0293505bb4cc3b317 Diff: https://reviews.apache.org/r/57065/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

/sentry/provider/db/service/persistent/SentryStore.java (line 428) <https://reviews.apache.org/r/56720/#comment238138> I mean the two statements doing the purge should stay unless you thing there is a reason not to. - Alexander Kolbasov On Feb. 21, 2017, 9:47 p.m., Lei Xu

Re: Review Request 56931: [2/2] SENTRY-1635: Limit HMS connections only to the leader of the sentry servers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56931/#review166369 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 22, 2017, 4

Re: Review Request 54532: SENTRY-378: Changed usages of SentryAccessDeniedException to SentryConfigurationException when retrieving Sentry version information in SentryStore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54532/#review165906 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 16, 2017, 5

Re: Review Request 56720: SENTRY-1611. Periodically purge MSentryPerm/PathChange table.

it is weird that we are creating SentryStore in HMSFollower - something is wrong here. - Alexander Kolbasov On Feb. 16, 2017, 11:37 p.m., Lei Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad error messages for Sentry exceptions

che.org/r/54798/#comment233223> Should we do something similar for SentryNoSuchObjectException? - Alexander Kolbasov On Jan. 17, 2017, 7:34 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-

Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS updates

visit: https://reviews.apache.org/r/55595/#review162362 --- On Jan. 17, 2017, 1:43 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generat

Re: Review Request 55595: SENTRY-1428: Only leader should follow HMS updates

://reviews.apache.org/r/55595/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 55741: SENTRY-1599 CloseablePersistenceManager is no longer needed

/provider/db/service/persistent/TransactionManager.java ee13f9f4d7e9ee0fd523d1144750222f0979c293 Diff: https://reviews.apache.org/r/55741/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 55744: SENTRY-1559 Remove fencing support

77aaac5fd14ac7d3b721261b898120bf15cc0daa sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java 7c080fab53d902eb6ce909139cf6f0a9c288ba54 Diff: https://reviews.apache.org/r/55744/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 55594: SENTRY-1594 TransactionBlock should become generic

85a5326ba52fc532f3d933f7e62a352f4d4080df Diff: https://reviews.apache.org/r/55594/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 55595: SENTRY-1428: Only leader should follow HMS updates

--- Thanks, Alexander Kolbasov

Re: Review Request 56954: SENTRY-1639 Refactor the usage of configuration constants related to transport

> On Feb. 27, 2017, 12:52 a.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java, > > line 26 > > <https://reviews.apache.org/r/56954/diff/1/?file=1

Re: Review Request 56952: SENTRY-1637. Periodically purge Delta change tables.

ne 190) <https://reviews.apache.org/r/56952/#comment239119> Please add comment explaining what's going on here. - Alexander Kolbasov On Feb. 24, 2017, 10:47 p.m., Lei Xu wrote: > > --- > This is an automatically generated e-

Sentry merge with Sentry HA

As we are making good progress with Sentry HA we need to start thinking about merging the Sentry HA into Sentry 1.8 code base. It seems that there are not that many commits (about a dozen) that never made it to Sentry HA branch, but some of these were refactoring changes which will complicate

Re: Review Request 55904: SENTRY-1612: HMSFollower should persist full HMS snapshot into SentryDB if there is not one.

iginal), 302 (patched) <https://reviews.apache.org/r/55904/#comment239497> Incomplete fraze? retrieve full HMS snapshot from ... ? - Alexander Kolbasov On March 1, 2017, 8:20 p.m., Hao Hao wrote: > > --- > This is a

Re: Review Request 54454: SENTRY-1548 Setting GrantOption to UNSET upsets Sentry

views.apache.org/r/54454/ > --- > > (Updated Feb. 28, 2017, 2:21 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, > and Vadim Spector. > > > Bugs: SENTRY-1548 > https://issues.apache.org/jira/browse/SENTRY-1548 > > >

Re: Review Request 55706: SENTRY-1566: Make full Perm/Path snapshot available for NN plugin

are unique. So you get something along the lines of: roles = getAllRoles for(role: roles) { retval.put(role.getRoleName()) = roleGroups(role) } where roleFroups returns names of groups belonging to a role. - Alexander Kolbasov On Feb. 3, 2017, 7:53 a.m., H

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

will move if this makes things easier. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57219/#review167618 --- On March 1, 201

Re: Review Request 57220: SENTRY-1638. Update MSentryPermChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57220/#review167595 --- Ship it! Ship It! - Alexander Kolbasov On March 1, 2017, 10

Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad error messages for Sentry exceptions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54798/#review167624 --- Ship it! Ship It! - Alexander Kolbasov On Feb. 28, 2017, 5

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

/TestCounterWait.java PRE-CREATION Diff: https://reviews.apache.org/r/57219/diff/3/ Changes: https://reviews.apache.org/r/57219/diff/2-3/ Testing --- The new CounterWait class has a unit test. End to end functionality will be tested once HMS part is implemented. Thanks, Alexander Kolbasov

Re: Review Request 57219: SENTRY-1601 Implement HMS Notification barrier on the server side

/thrift/TestCounterWait.java PRE-CREATION Diff: https://reviews.apache.org/r/57219/diff/4/ Changes: https://reviews.apache.org/r/57219/diff/3-4/ Testing --- The new CounterWait class has a unit test. End to end functionality will be tested once HMS part is implemented. Thanks, Alexander

Re: Review Request 56954: SENTRY-1639 Added code changes to refactor the usage of configuration constants related to transport

rt/SentryPolicyClientTransportConfig.java (line 30) <https://reviews.apache.org/r/56954/#comment238923> See comments from the similar HDFS class. - Alexander Kolbasov On Feb. 22, 2017, 9:53 p.m., kalyan kumar kalvagadda wrote: > > ---

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

/sentry/service/thrift/HMSFollower.java (lines 238 - 257) <https://reviews.apache.org/r/52138/#comment218202> I think that we should set currentEventId to eventIDBefore. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

method since it will prevent it from ever running again. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

t mechanisms. - Alexander Kolbasov On Oct. 4, 2016, 10:23 p.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[DISCUSS] Changing transaction isolation level used by Sentry

I think it is worth some discussion in the list. I think that the default read-committed isolation level used by Sentry is not sufficient - please see https://issues.apache.org/jira/browse/SENTRY-1486. So the proposal is to change it to repeatable-read. Does anyone have objections to it? - Alex

Re: Review Request 45859: SENTRY-1120: Show role / privileges info in Sentry Service Webpage

/sentry/provider/db/service/thrift/SentryAdminServlet.java (line 92) <https://reviews.apache.org/r/45859/#comment220049> Since you are going to the trouble of disabling cache it makes sense to disable it for different browsers and proxies. - Alexander Kolbasov On Oct. 7, 2016, 12:26 a.

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

Please add a comment explaining what happens when the max is reached. - Alexander Kolbasov On Sept. 23, 2016, 6:15 a.m., Hao Hao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 24, 2016, 11:59 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 215-216 > > <https://reviews.apache.org/r/52138/diff/3/?file=1509069#file1509069line215> >

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

> On Sept. 23, 2016, 4:41 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > lines 239-257 > > <https://reviews.apache.org/r/52138/diff/3/?file=1509069#file1509069lin

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be reoved

8b3599fd9cb4dd80700c6bf405d35db16a72e3d7 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestNotificationHandlerInvoker.java 6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 Diff: https://reviews.apache.org/r/52916/diff/ Testing --- Thanks, Alexander

Re: Apache Sentry in Maven Central

Thanks Colm! On Tue, Oct 25, 2016 at 9:46 AM Lenni Kuff wrote: > Excellent, thanks Colm. > > On Tue, Oct 25, 2016 at 9:13 AM, Colm O hEigeartaigh > wrote: > > > Hi all, > > > > I've uploaded the Sentry artifacts for 1.7.0 to the Maven staging repo >

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

changes mixed up. - Alexander Kolbasov On Oct. 25, 2016, 3 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

change the text? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java (line 88) <https://reviews.apache.org/r/51449/#comment223364> Please add comments for new configuration parameters - Alexander Kolbasov On Oct. 25, 2016, 3 a.m., Colin Ma wro

Re: Review Request 53038: SENTRY-1507

/sentry-tests-solr/pom.xml a60b4eed4dde6c182b061681305013b3bd548cc3 sentry-tests/sentry-tests-sqoop/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51449/#review153930 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 26, 2016, 8

Re: Review Request 53038: SENTRY-1507

/sentry-tests-solr/pom.xml a60b4eed4dde6c182b061681305013b3bd548cc3 sentry-tests/sentry-tests-sqoop/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

don't have time to address them, please ship as is and we'll address them later. - Alexander Kolbasov On Nov. 5, 2016, 1:29 a.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

ntry/service/thrift/RetryClientInvocationHandler.java (line 97) <https://reviews.apache.org/r/52526/#comment225300> Adding 'continue' above will get rid of this check - Alexander Kolbasov On Nov. 5, 2016, 1:29 a.m., Li Li wrote: > > --

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52526/#review155403 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 9, 2016, 3

[DISCUSS] Changing role <-> priv relationship from M:N to 1:N

Hello, I would like to start a discussion about the relationship model between roles and permissions in Sentry. Currently it uses N:M model where a single permission may belong to multiple roles and a single role can have multiple permissions. Given that all permission manipulations are always

Re: [DISCUSS] Changing role <-> priv relationship from M:N to 1:N

> > On Wed, Nov 9, 2016 at 2:11 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > >> Hello, >> >> I would like to start a discussion about the relationship model between >> roles and permissions in Sentry. Currently it uses N:M model where a s

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

e will close already reconnected client and try to connect it again which isn't good, - Alexander Kolbasov On Nov. 4, 2016, 6:26 p.m., Li Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 53038: SENTRY-1507

/pom.xml f70c5c326a4cf3e98fab60dd9c74f8d2144ea4a3 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

9/#comment223088> I am not sure that it is a good idea to ignore interrupts - someone may try to shut down the daemon and we shouldn't prevent this. I think we should return either the original exception here or InterruptedExcept

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

would be the commit message? The current one is a duplicate of the information in the JIRA - I think it should be enough to reference JIRA. - Alexander Kolbasov On Oct. 20, 2016, 3:46 a.m., Colin Ma wrote: > > --- > This is an auto

Re: Review Request 51449: SENTRY-1422: JDO deadlocks while processing grant while a background thread processes Notificationlogs

his variable. - Alexander Kolbasov On Oct. 14, 2016, 2:48 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

ing is datanucleus.cache.level2.type set to none which is done above. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53920/#review156683 ------- On Nov. 19, 2016, 1:45 a.m., Alexander Kolbasov wrote: > &

Re: Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

/53920/diff/ Testing --- Thanks, Alexander Kolbasov

Alternative Sentry CLI

I'd like to have a useful Sentry CLI that is simple enough to send various Thrift requests to the running Sentry server, so I wrote one. It is work in progress, so a bunch of functionality is missing. Kerberos isn't supported at all. The tool and its documentation are available from

Re: Review Request 53921: SENTRY-1533: Sentry console metrics reporting interval should be configurable

/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff06582708ac73d969e1bbdfcec7b672bc9c65c5 Diff: https://reviews.apache.org/r/53921/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 53921: SENTRY-1533: Sentry console metrics reporting interval should be configurable

/provider/db/service/thrift/SentryPolicyStoreProcessor.java ff06582708ac73d969e1bbdfcec7b672bc9c65c5 Diff: https://reviews.apache.org/r/53921/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53905: SENTRY-1518: Add metrics for SentryStore transactions

3d0a6ab0b514cb9fbead4b8e527f7cb84865ce28 Diff: https://reviews.apache.org/r/53905/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53920: SENTRY-1534: Oracle supports serializable instead of repeatable-read

ec47909ab3098a890019bc19179786a2c5d7d87c sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798dca6b3ad8c9b9eee1eea5380001d1d0cd9 Diff: https://reviews.apache.org/r/53920/diff/ Testing --- Thanks, Alexander Kolbasov

Review Request 53872: SENTRY-1525: Provide script to run Sentry directly from the repo

Tirukkovalur, and Vadim Spector. Repository: sentry Description --- SENTRY-1525: Provide script to run Sentry directly from the repo Diffs - bin/run_sentry.sh PRE-CREATION Diff: https://reviews.apache.org/r/53872/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

nt223844> What does "function" mean here? Please add comment explaining what this max retry means - is it per connection attempt or for lifetime? Also please add a comment explaining what happens after retries. ALternatively you may put a big block comment explaining

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

s is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52526/ > --- > > (Updated Oct. 27, 2016, 4:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravy

Re: Review Request 53038: SENTRY-1507

-tests-solr/pom.xml 2f802ab101327edb7f0cbcd08bce24c2f37f59e1 sentry-tests/sentry-tests-sqoop/pom.xml c494b5a1404b13868f43f387eee6953557482975 Diff: https://reviews.apache.org/r/53038/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154680 --- On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov wrote: > > ---

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

ws.apache.org/r/52916/#review154821 --- On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 52916: SENTRY-1505 CommitContext isn't used by anything and should be removed

6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 Diff: https://reviews.apache.org/r/52916/diff/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 52526: SENTRY-1477: Sentry clients should retry with another server when they get connection errors

. To reply, visit: > https://reviews.apache.org/r/52526/ > --- > > (Updated Nov. 2, 2016, 6:08 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya > Tirukkovalur. > > > R

  1   2   3   4   5   6   7   8   >