Re: Review Request 63086: SENTRY-1993: StringIndexOutOfBoundsException in HMSPathsDumper.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63086/#review188432 --- Ship it! Ship It! - Alexander Kolbasov On Oct. 17, 2017, 7

Re: Do Sentry sync-up meetings exist?

to move our current apache-sentry > slack to this official apache slack. > > On Mon, Oct 16, 2017 at 3:14 AM, Colm O hEigeartaigh <cohei...@apache.org> > wrote: > >> I believe you can sign up here: https://the-asf.slack.com/ >> >> Colm. >> >> On Thu,

Re: Shading of conflicting dependencies

Agreed, this would be a very useful thing to do. I remember spending a lot of time trying to make Sentry work with DataNucleus 4 - the problem was that e2e tests combine Sentry with Hive in the same JVM and this created a conflict on the DataNucleus libraries and test failures. Looking at the

Re: Shading of conflicting dependencies

> > > wrote: > > > > > >> +1 > > >> > > >> I like the idea. It's hard to upgrade our libraries to newer ones when > > >> other components break due to Sentry being a plugin. I was once > thought > > of > > >&

Re: Contributorship

Added you as a contributor in JIRA On Tue, Nov 14, 2017 at 2:52 PM, Liam Sargent wrote: > Hello all, > > I would like to request the contributor role on issues.apache.org for the > SENTRY project. My apache username is "liamsargent" > > Thank you in advance, > Liam

Re: Becoming contributor

I added you to the contributors group - please let me know if this isnt working for you. On Tue, Nov 14, 2017 at 11:46 AM, Xinran Yu Tinney wrote: > Hi, >I would like to become Sentry contributor and my Apache Jira username is > xyu2017. > > Thanks! > > Xinran Tinney

2.0 release and SENTRY-1812

Colm, do you plan to include SENTRY-1812 in 2.0 release?

Re: [VOTE] Release Sentry version 2.0.0

Kalyan, Thank you for posting Release 2.0 candidate. What kind if testing would you recommend for us to perform to vote Yes/No? Can you post some recommendations, please? - Alex On Tue, Nov 28, 2017 at 4:38 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > This is the release of

Re: [VOTE] Release Sentry version 2.0.0

< > kkal...@cloudera.com> wrote: > > > Sergio, > > > > I know that you tried to start sentry standalone, Did you see this issue? > > > > > > -Kalyan > > > > On Wed, Nov 29, 2017 at 12:16 PM, Alexander Kolbasov <ak...@cloudera.com > &g

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

424 (patched) <https://reviews.apache.org/r/63881/#comment270166> Message can be quite big - do we really want to log it? - Alexander Kolbasov On Nov. 29, 2017, 5:28 p.m., Arjun Mishra wrote: > > --- > This is an aut

Re: [VOTE] Release Sentry version 2.0.0

t; Does anyone has a better suggestion? > >>> > > >>> > -Kalyan > >>> > > >>> > On Wed, Nov 29, 2017 at 12:32 PM, Sergio Pena < > >>> sergio.p...@cloudera.com> > >>> > wrote: > >>> > > >

Re: [VOTE] Release Sentry version 2.0.0

t problems do you guys have with the Web UI? > > - Sergio > > On Wed, Nov 29, 2017 at 6:23 PM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > When I disabled Web UI the problem went away, so it is directly related > to > > Web UI. > > > > On We

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64230/#review192423 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 30, 2017, 11

Re: Review Request 64002: SENTRY-2068: Disable HTTP TRACE method from the Sentry Web Server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64002/#review191759 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 22, 2017, 3

Avoiding merge commits to master.

This is a reminder for developers to avoid merge commits to master. There might be cases where this is unavoidable, please send a note here if you think you MUST have a merge commit. Otherwise, please make an effort co collapse all intermediate changes/merges and create a single commit per

Re: [VOTE] Release Sentry version 2.0.0

I tried to start Sentry server on Mac and got a weird error . I am running from the dist directory that I just built with mvn clean install on the 2.0.0 branch. 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting server java.lang.SecurityException: class "javax.servlet.DispatcherType"'s

Re: [VOTE] Release Sentry 2.0.0 RC2

Would you mind submitting the vote on Monday? This will give people 72 working hours to look at it. Thanks, - Alex. > On Dec 1, 2017, at 11:11 PM, Kalyan Kumar Kalvagadda > wrote: > > This is the release of Apache Sentry, version 2.0.0. > > It fixes the following

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

> On Dec. 15, 2017, 7:51 p.m., Alexander Kolbasov wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > > Line 45 (original), 49 (patched) > > <https://reviews.apache.org/r/64259/diff/2/?file=1912668#file1912668line49> >

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

8 (patched) <https://reviews.apache.org/r/64545/#comment272156> Drop incarnationId from here - Alexander Kolbasov On Dec. 12, 2017, 5:10 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

e which does that. - Alexander Kolbasov On Dec. 18, 2017, 4:36 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

t is Command, not Object sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java Lines 126 (patched) <https://reviews.apache.org/r/64259/#comment272654> Add `break` - Alexander Kolbasov On Dec. 11, 2017, 8:03 p.m., Xinran Tinney wrote: > > --

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64545/#review193753 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 14, 2017, 1

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

/sentry/service/thrift/LeaderStatusMonitor.java Line 281 (original), 282 (patched) <https://reviews.apache.org/r/64545/#comment272308> Note that in single node mode none of these are relevant since it is always a leader. - Alexander Kolbasov On Dec. 13, 2017, 5:45 p.m., Arjun Mishra

Re: 1.7.1 version in JIRA

Done On Wed, Dec 13, 2017 at 6:26 AM, Colm O hEigeartaigh wrote: > Can someone add a 1.7.1 version in JIRA please? > > Colm. > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com >

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

> On Dec. 12, 2017, 1:26 a.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java > > Line 57 (original), 56 (patched) > > <https://reviews.apache.org/r/63596/diff/6/?file=1

Re: Review Request 64545: SENTRY-2078: Have sentry server print an obvious INFO level log message when it becomes the writer

> On Dec. 13, 2017, 6:42 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java > > Line 281 (original), 282 (patched) > > <https://reviews.apache.org/r/64545/diff/5-6/?file=19

Re: Cutting sentry 2.0.0 off master

We can still create 2.0 branch and just be more selective about what goes there - we may choose to skip some commits from master. - Alex. On Fri, Nov 17, 2017 at 12:24 PM, Sergio Pena wrote: > +1 > > Sounds good Kalyan. I'm still finding the test failures and seems

Interesting coincedence

1. SENTRY-2000 is"Cut 2.0.0 branch" !

Re: Review Request 63975: SENTRY-2066: DB name is not set for AlterTable

/sentry/binding/hive/HiveAuthzBindingHook.java Lines 283 (patched) <https://reviews.apache.org/r/63975/#comment269413> Why do we need an extra boolean Can we just check for currDB == null ? Or it isn't null in this case? - Alexander Kolbasov On Nov. 21, 2017, 3:32 a.m., Na Li

Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

ines 291 (patched) <https://reviews.apache.org/r/63874/#comment269556> Use switch() for comparing against enums - Alexander Kolbasov On Nov. 20, 2017, 3:05 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically ge

Inconsistent commit messages

Hello, I noticed that recently our commit messages became veru inconsistent: The format we used to have: SENTRY-2014: incorrect handling of HDFS paths with multiple forward slashes (Vadim Spector, reviewed by Sergio Pena and Arjun Mishra) SENTRY-2015 - Refactor Command implementations -

Re: Inconsistent commit messages

t 10:41 PM, Na Li <lina...@cloudera.com> wrote: > > > Sasha, > > > > I agree we should have consistent format. It is better to include author, > > then followed by reviewer. So we can have all information at a glance. > > > > Lina > > > > On

Broken master

Looks like master is broken now which blocks anyone from doing anything. Do we know what commit broke it? Do we know how this commit managed to get through? Once we know the commit it should be reverted ASAP. - Alex.

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

/sentry/provider/db/service/persistent/TestSentryStore.java Lines 3469 (patched) <https://reviews.apache.org/r/63645/#comment267763> While this may be a useful test, it is better to write specific unit test for the String manipulation functions directly. - Alexander Kolbasov On Nov. 7, 2

Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

/db/service/thrift/SentryPolicyStoreProcessor.java 71eb9c1b6d02326fc9a7b702652253bd9b57d725 Diff: https://reviews.apache.org/r/63647/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 63645: SENTRY-2032: Leading Slashes need to removed when creating HMS path entries

o replace all since we do path.split("/+"). We only need to remove leading slashes, so this check should be changed to startsWith("/") - Alexander Kolbasov On Nov. 7, 2017, 9:16 p.m., Arjun Mishra wrote: > > ---

Re: Review Request 63647: SENTRY-2036: sentry_sync_notifications() should set ID when it returns errors

iew190589 --- On Nov. 7, 2017, 9:58 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63647/ >

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/#review190635 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 9, 2017, 7

Re: Review Request 63667: SENTRY-2037: Remove not needed sentry-binding-hive-v2 dependency from the main pom.xml

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63667/#review190651 --- Ship it! Ship It! - Alexander Kolbasov On Nov. 8, 2017, 3

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java Lines 35 (patched) <https://reviews.apache.org/r/63687/#comment268200> Can you add Javadoc to the class explaining that by contract keys are always case-insensitive? - Alexander Kolbasov On Nov. 9, 2017, 11:44 p.m.,

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

rt key and value to the canonical case in constructor? - Alexander Kolbasov On Nov. 8, 2017, 11:43 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

173 (original), 157 (patched) <https://reviews.apache.org/r/63415/#comment267960> Looks like this method is never used sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/GenericPrivilegeConverter.java Line 182 (original), 161 (patched) <

Sentry as a library

What do you think about providing a ‘sentry service as a library’ which is a wrapper that can run inside HMS and other consumers that will talk to the underlying database, understand schemas, etc and provide all information to a client without going through Thrift interface to the server? -

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

e/sentry/service/thrift/SentryHMSClient.java Lines 209 (patched) <https://reviews.apache.org/r/63881/#comment271316> It is visuall better to rearrange these to show the lower ID first. It would be nice to see something like `received non-consequitive event sequence 10, 12` - Alexander Kol

Re: [RESULT][VOTE] Release Sentry version 2.0.0

Thanks Kalyan! On Thu, Dec 7, 2017 at 11:36 AM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > Voting is now closed and has passed with the following tally, > > Binding +1s: Sergio Pena, Alexander Kolbasov, Colm o hEigeartaigh > > > Thanks to everyone

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

nding/hive/authz/DefaultSentryAccessController.java Line 144 (original), 144 (patched) <https://reviews.apache.org/r/64392/#comment271549> Change to `"Sentry failed to drop role: "` - Alexander Kolbasov On Dec.

Re: [VOTE] Sentry Release 2.0.0 RC3

+1 On Tue, Dec 5, 2017 at 9:01 AM, Colm O hEigeartaigh wrote: > +1 from me. Checked digests and signatures, built the tag and source > distribution, tested the binary distribution. > > Colm. > > On Tue, Dec 5, 2017 at 4:30 PM, Sergio Pena > wrote:

Re: Review Request 64392: SENTRY-2092: Drop Role log message shows Creating role

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64392/#review193060 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 6, 2017, 11

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

values. - Alexander Kolbasov On Dec. 11, 2017, 9:02 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

/64241/#comment270832> Is there anything that checks correctness of pointers? What would happen if release manager forgets to add the file? pom.xml Lines 734 (patched) <https://reviews.apache.org/r/64241/#comment270821> This looks like an unrelated change - can you move this to a diffe

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64241/#review192594 --- Ship it! Ship It! - Alexander Kolbasov On Dec. 1, 2017, 11

Re: Review Request 64273: SENTRY-2084: Exclude javax.jms:jms from sentry distribution

) <https://reviews.apache.org/r/64273/#comment270851> Please add comment explaining why this is excluded - Alexander Kolbasov On Dec. 1, 2017, 11:19 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically g

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

ry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java Lines 40 (patched) <https://reviews.apache.org/r/63415/#comment266852> Please do not use lambdas for Sentry code - currently it sho

Re: [VOTE] - Release Apache Sentry 1.7.1

+1 On Wed, Dec 20, 2017 at 7:04 AM, Sergio Pena wrote: > Agree. I checked the rest of the release (checksums, gpg, build) and it is > good. > > +1 > > On Wed, Dec 20, 2017 at 2:51 AM Colm O hEigeartaigh > wrote: > > > Yeah I saw that afterwards +

Re: Review Request 67174: SENTRY-2156: Update provider-db backend code to grant privileges to user

if you modify the if statement above: ```if (...) { return true; } // handle the more complicated case ``` - Alexander Kolbasov On May 17, 2018, 1:28 a.m., Na Li wrote: > > --- > Thi

Re: Thoughts on using lombok?

Brian, This seems interesting. How does it interplay with IntelliJ/Eclipse ability to find all usages of the method - will we still be able to find all references to constructors/getters/setters e.t.c. ? > On May 24, 2018, at 12:54 PM, Brian Towles wrote: > > Howdy all,

Re: Sentry Release Schedule for FGP and ABAC

Stephen, a lot depends on your plans in terms of breaking functionality. For example, one of the reasons Sentry HA was developed on a feature branch was because it was a serious change in architecture and in broke functionality for a while. I think some of the merge problems which Sergio referred

Organizing JIRAs as subtasks for ABAC and FGP

It is rather difficult to navigate multiple JIRAs associated with ABAC and FGP. I wold suggest moving all jiras as subtask of two uber-jiras - one for FGP and one for ABAC. What do you think? - Alex

Re: HMS catalogs and Sentry

n HMS? I was looking at the > JIRA > > > but I don't see how catalogs will be used. > > > > > > Nevertheless, if HMS is going to support catalogs, then we should > support > > > them when we decide to move to Hive 3.0 at some point. > > > Should we

Re: Sentry Release Schedule for FGP and ABAC

branch. I don’t want everyone to ignore it for a few months and then > start > > re-reveiwing with it as we merge it back into master when we get to the > end. > > > > Does this sound good to the community? > > > > > On Apr 30, 2018, at 6:35 PM, Alexander Kolbasov <a

Re: Quick tips for code reviews

+1 > On Apr 30, 2018, at 08:25, Sergio Pena wrote: > > Hey All, > > I just want to share with the community about some helpful tips when > submitting patches for review that are useful for reviewers: > > - Add a link to the review board on the JIRA related to the

Re: questions on sentry

u have any idea on my second question? > > Chen > > On Wed, Oct 18, 2017 at 10:59 PM Alexander Kolbasov <ak...@cloudera.com> > wrote: > >> Hi Chen, >> >> Apache Sentry goal is to provide security features for other Apache >> products - mainly

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

ed sleep time. You need to make sure that you never sleep longer then the remaining time left. - Alexander Kolbasov On Jan. 23, 2018, 11:40 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mai

[DISCUSS] Sentry roadmap after 2.0

Now that we have Sentry 2.0 release, I think it is a good time to step back from fixing bugs and immediate problems and start discussions on roadmap for Sentry going forward. Do we want to just keep it as is and improve things here and there or we want to add new features? What do people think?

Re: [DISCUSS] Sentry roadmap after 2.0

gt; On Thu, Jan 25, 2018 at 11:58 AM, Alexander Kolbasov <ak...@cloudera.com> > wrote: > > > Now that we have Sentry 2.0 release, I think it is a good time to step > back > > from fixing bugs and immediate problems and start discussions on roadmap > > for Sentry going

Re: [DISCUSS] Sentry roadmap after 2.0

n database > > and revokes privileges on the tables with in that database, > > 2. This needs new look into privilege model that sentry currently > > has. > > > > > > -Kalyan > > > > > > -Kalyan > > > > On Thu, Jan 25, 2018 at

Re: [DISCUSS] Sentry roadmap after 2.0

or wants to grant role with select > > on > > > the > > > all tables in a database except for couple to them, he needs to > > > individual > > >select privileges for each table. > > > 1. Implementation should let you add a grant privilege

Re: [DISCUSS] Sentry roadmap after 2.0

to user. Ideally, user-based-privileges feature should be > >> allowing > >> >administrator to grant privileges to individual users directly. > >> > - I'm working on this to come up with a scope doc. > >> > 2. Currently sentry stores only grant pr

Re: [DISCUSS] Sentry roadmap after 2.0

Agreed, making 2.1 with just user-level privileges improvements (plus set of accumulated bug fixes) sounds reasonable. On Thu, Jan 25, 2018 at 11:41 AM, Alexander Kolbasov <ak...@cloudera.com> wrote: > Looks like we have a consensus of doing user-level privileges improvements > fo

Re: [DISCUSS] Sentry roadmap after 2.0

ased privilege. I will add more > sub-tasks > > to it > > > > On Thu, Jan 25, 2018 at 1:42 PM, Alexander Kolbasov <ak...@cloudera.com> > > wrote: > > > >> Agreed, making 2.1 with just user-level privileges improvements (plus > set >

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

s JIRA is moot and we shouldn't fix it in the first place. - Alexander Kolbasov On Jan. 23, 2018, 11:40 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: How to run bin/run_sentry.sh

It is easy. Your current directory should be within the got repo and the actual script can be anywhere. Just run it with whatever argument you want to pass to main. The script users maven to build and run sentry so it doesn't depend on any class path. On Fri, Jan 12, 2018 at 12:30 Xinran Yu

Re: How to run bin/run_sentry.sh

ervice", but seems not working. >> >> 2018-01-12 14:56 GMT-06:00 Alexander Kolbasov <ak...@cloudera.com>: >> >>> It is easy. Your current directory should be within the got repo and the >>> actual script can be anywhere. Just run it with whatever a

Question about user-level privileges

I am wondering what is the relationship between "users" as defined in Sentry and users as defined in Unix or LDAP or Active Directory. Should it be allowed to assign permissions to a user that doesn't exist? Should there be any validation if users? Should these be treated together or

Re: How to run bin/run_sentry.sh

ownership of files? > Also, Lina, I have run the command but it seems something removed the > JAVA_HOME, please see the attachment. > > 2018-01-12 16:57 GMT-06:00 Alexander Kolbasov <ak...@cloudera.com>: > >> Running it via studio is not the best idea since it will chang

Re: Issues with Codahale/Dropwizard metrics dependencies

Hi Liam, I don’t think there is a particular reason other then historical development. I think we should just align with whatever version is used by majority of other components or just use the latest version. I don’t see any reason to run with old version. - Alex > On Feb 1, 2018, at 12:55

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

ntryStore.java Lines 3496 (patched) <https://reviews.apache.org/r/65268/#comment276416> Please provide more information - how much longer did it take? Was it one nanosecond or 2 hours? - Alexander Kolbasov On Jan. 31, 2018, 12:30 a.m., kalyan kumar kalvagadda wrote: > > --

Re: How to run bin/run_sentry.sh

only sentry-site.xml I found is shown in the picture below, it > seems still something is missing. > > Thanks! > > 2018-01-30 18:34 GMT-06:00 Alexander Kolbasov <ak...@cloudera.com>: > >> The way run_sentry works - it actually runs mvn exec:java which builds >>

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

ment explaining what are you testing here. Looks like the name is not telling the truth - you are testing something complicated about notifications. What you really need is a test that verifies that your failed transactions fail more or less within allotted time, but this test doesn't t

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

apache.org/r/65268/#comment276696> Do you need space after `giving up` ? - Alexander Kolbasov On Feb. 5, 2018, 3:02 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

ain/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java Lines 232 (patched) <https://reviews.apache.org/r/65268/#comment276690> Given exponential nature, how quickly do we usually reach this point? - Alexander Kolbasov On Feb. 5, 2018, 3:02 p.m., kalyan kuma

Please welcome Kalyan Kalvagadda to Apache PMC!

Please welcome Kalyan Kalvagadda who is joining Apache Sentry PMC! - Alex

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

on has a limit of 500 ms but you only retried for 283 milliseconds, you could easily try harder. - Alexander Kolbasov On Feb. 5, 2018, 3:02 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

= "Retried for " + maxRetryDurationMills + " milliseconds. Giving up " + ex.getMessage(); LOGGER.error(message, ex); throw new Exception(message, ex); } } ` -

Fwd: Travel Assistance applications open. Please inform your communities

> Begin forwarded message: > > From: Gavin McDonald > Subject: Travel Assistance applications open. Please inform your communities > Date: February 14, 2018 at 1:34:11 AM PST > To: travel-assista...@apache.org > Reply-To: priv...@sentry.apache.org > Reply-To:

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 18, 2018, 5:29 a.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Line 96 (original), 96 (patched) > > <https://reviews.apache.org/r/65

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

ent278192> 30 sec is too much for this test - it delays the whole test for 30 sec. Can you test it with the whole test taking ~2 seconds? - Alexander Kolbasov On Feb. 12, 2018, 11:50 p.m., kalyan kumar kalv

[DISCUSS] Allowing Java 8 features in Sentry

Hello Sentry hackers, We are now compiling Sentry with Java 8. I would like to propose allowing Java 8 features in Sentry code. As of now it is difficult to enforce strict Java 7 compatibility, so we may just as well embrace the reality and start using Java 8 which hopefully will improve the

[DISCUSS] Adjustments to the commit process

Hello everyone, I would like to propose an adjustment to the commit process in Sentry project. The idea is to require that commit should not be done by the person providing the change but by some other committer. This committer's responsibility is to ensure that all code review concerns were

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

413 (patched) <https://reviews.apache.org/r/65704/#comment278247> What does this have to do with the JIRA that you are fixing? Looks like some kinnd of separate issue. - Alexander Kolbasov On Feb. 22, 2018, 6:55

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

/sentry/binding/util/SentryAuthorizerUtil.java Lines 227 (patched) <https://reviews.apache.org/r/65642/#comment277920> It is better to use TimeUnit class for time conversions - Alexander Kolbasov On Feb. 14, 2018, 12:51 a.m., Na Li

Re: [DISCUSS] Adjustments to the commit process

reasonable to me as long as they can get someone to do the commit > > in a reasonable timeframe. I wouldn’t want to have to wait days for it > to > > get in after it has been properly reviewed. > > > > > On Feb 22, 2018, at 12:22 PM, Alexander Kolbasov <ak...@clo

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

> On Feb. 22, 2018, 6:56 p.m., Alexander Kolbasov wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java > > Lines 146 (patched) > > <https://reviews.apache.org/r/65

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > > <https://reviews.apache.org/r/64

Re: [VOTE] - Release Apache Sentry 1.7.1

Thanks Colm! Happy new year! On Sun, Dec 24, 2017 at 05:31 Colm O hEigeartaigh <cohei...@apache.org> wrote: > With 3 binding +1 votes, and no other votes, this vote passes. I'll do the > release. > > Colm. > > On Wed, Dec 20, 2017 at 5:18 PM, Alexander Kolbasov <

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

> On Dec. 18, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > > Line 267 (original), 271 (patched) > > <https://reviews.apache.org/r/64

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

://reviews.apache.org/r/68488/#comment291383> Typo? "Provider manager *what*" sentry-spi/src/main/java/org/apache/sentry/spi/Spi.java Lines 24 (patched) <https://reviews.apache.org/r/68488/#comment291384> Is this file coming from somewhere? - Alexander Kolbasov O

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 29, 2018, 8:29 p.m., Steve Moist wrote: > > lombok.config > > Lines 1 (patched) > > > > > > In introducing lombok into sentry. Will the configs for the existing > > sl4j need to be updated or modified? > >

Arjun Mishra - New Apache Sentry Committer

It is my pleasure to introduce a new Apache Sentry committer who is very familiar to people on this list - Arjun Mishra! Welcome Arjun! - Alex

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

/hdfs/PathDeltaRetriever.java Line 20 (original), 20 (patched) <https://reviews.apache.org/r/67846/#comment288761> Shouldn't this be done automatically by the shading plugin? - Alexander Kolbasov On July 6, 2018, 7:06 p.m., Steve Moist

<    2   3   4   5   6   7   8   >