Re: Review Request 60880: SENTRY-1839 Duplicate file in sentry-binding-hive-common package

2017-07-17 Thread Colm O hEigeartaigh
te a lot of code duplicated in the two implementations. Is it possible to try to keep the base class in the common module, and just abstract the differences that can be subclassed in the individual modules? - Colm O hEigeartaigh On July 14, 2017, 7:49 p.m., kalyan kumar kalva

Re: Review Request 60904: SENTRY-1849 Fix the pom file to use appropriate hive dependencies based on hive-authz profile

2017-07-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60904/#review180729 --- > RELEASE Is this a mistake? - Colm O hEigeartaigh On July

Re: Sentry 2.0.0 depends on multiple versions of Hive

2017-07-18 Thread Colm O hEigeartaigh
at > effort otherwise we could take approach-3. > > > My next steps would be based on what I hear form the community. > > -Kalyan > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 60904: SENTRY-1849 Fix the pom file to use appropriate hive dependencies based on hive-authz profile

2017-07-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60904/#review180910 --- Ship it! Ship It! - Colm O hEigeartaigh On July 18, 2017

Re: Review Request 60869: SENTRY-1846 - Use a consistent configuration variable for the sentry provider property

2017-07-19 Thread Colm O hEigeartaigh
ccessController.java c63cf642 sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java b31f4faf Diff: https://reviews.apache.org/r/60869/diff/2/ Changes: https://reviews.apache.org/r/60869/diff/1-2/ Testing --- Thanks, Colm O hEigeartaigh

JIRA versions

2017-07-20 Thread Colm O hEigeartaigh
ame release. Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: JIRA versions

2017-07-24 Thread Colm O hEigeartaigh
agree with you. > > -Kalyan > > On Thu, Jul 20, 2017 at 10:25 AM, Colm O hEigeartaigh > > wrote: > > > Hi all, > > > > Now that the ha branch is associated with the "2.0.0" release, perhaps in > > JIRA we could remove the "sentry-ha-redes

Re: JIRA versions

2017-07-24 Thread Colm O hEigeartaigh
I still see the following version in JIRA: https://issues.apache.org/jira/projects/SENTRY/versions/12336080 Colm. On Mon, Jul 24, 2017 at 3:57 PM, Alexander Kolbasov wrote: > Done! > > On Mon, Jul 24, 2017 at 10:21 AM, Colm O hEigeartaigh > wrote: > >> Can someone wit

Re: JIRA versions

2017-07-24 Thread Colm O hEigeartaigh
; Removed. > > > > On Mon, Jul 24, 2017 at 5:02 PM, Colm O hEigeartaigh < > cohei...@apache.org> > > wrote: > > > > > I still see the following version in JIRA: > > > > > > https://issues.apache.org/jira/projects/SENTRY/versions/1233

Re: DISCUSSION: Prepare master for next release (2.0.0)

2017-07-27 Thread Colm O hEigeartaigh
e to do this as soon as possible. This change will be > disruptive, > > > and all contributors will have to update their master with the new one. > > > > > > Can we do this today or tomorrow? Anytime no later than Friday so that > we > > > have the most updated master to the community. > > > > > > - Sergio > > > > > > > > > -- > Thanks, > Vamsee > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 60880: SENTRY-1839 Duplicate file in sentry-binding-hive-common package

2017-07-27 Thread Colm O hEigeartaigh
> On July 17, 2017, 5:02 p.m., Colm O hEigeartaigh wrote: > > I think more work could be done on having a common base. Just to take one > > example, the only substantive difference between the two > > SentryFilterDDLTask implementations is: > > > > < re

Re: Access to the sentry git repository

2017-07-28 Thread Colm O hEigeartaigh
only way to do this is to > delete master branch, but this requires changing > 'receive.denyDeleteCurrent' pproperty *on the server*. > > Is there a way to set this property either via some web interface or by > logging to an appropriate host? > > - Alex >

Re: Review Request 60880: SENTRY-1839 Duplicate file in sentry-binding-hive-common package

2017-07-28 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60880/#review181667 --- Ship it! Ship It! - Colm O hEigeartaigh On July 14, 2017, 7

Re: Sentry master is moved to sentry-ha-redesign branch

2017-07-29 Thread Colm O hEigeartaigh
branch. The > merge > > > replaced all the conflicts with the version of sentry-ha-redesign. > > > > > > Please stop using sentry-ha-redesign branch and continue working on > > master > > > for all 2.0.0 work. > > > > > > Best, > > > > > > - Alex Kolbasov. > > > > > > > > > > > -- > > Thanks, > > Vamsee > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [DISCUSS] Sentry 1.8.0 release

2017-08-01 Thread Colm O hEigeartaigh
> On Mon, Jul 10, 2017 at 9:46 AM, Sergio Pena > wrote: > >> Great, I'm gonna go ahead and create an umbrella jira. I will take a look >> at the priority of those jiras meant for 1.8.0, and link them to the >> umbrella jira as blockers if they have to be there. >

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-01 Thread Colm O hEigeartaigh
he v2 follower module. The bindings module for hive v2 has different (more recent) versions. Also in the "sentry-provider-db" pom, change the "versions" from "2.0.0-SNAPSHOT" to "${project.version}" (sentry-binding-hive-conf + the two hive follower dependencie

Re: [DISCUSS] Sentry 1.8.0 release

2017-08-01 Thread Colm O hEigeartaigh
here was an error stating that i do > not have privileges to do so. > > > > -Kalyan > > On Tue, Aug 1, 2017 at 4:43 AM, Colm O hEigeartaigh > wrote: > > > I would have thought Kalyan had permission to update the KEYS file with > his > > own key as he

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-02 Thread Colm O hEigeartaigh
> On Aug. 1, 2017, 9:50 a.m., Colm O hEigeartaigh wrote: > > I'm not sure the datanucleus properties are correct in the v2 follower > > module. The bindings module for hive v2 has different (more recent) > > versions. > > Also in the "sentry-provide

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-02 Thread Colm O hEigeartaigh
he headers: * * http://www.apache.org/licenses/LICENSE-2.0 * - Colm O hEigeartaigh On Aug. 2, 2017, 11:51 a.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-02 Thread Colm O hEigeartaigh
> On Aug. 2, 2017, 1:08 p.m., Colm O hEigeartaigh wrote: > > Your merge seems to have added "" tags to the Apache headers: > > > > * > > * http://www.apache.org/licenses/LICENSE-2.0 > > * > > kalyan kumar kalvagadda wrote: > we d

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-02 Thread Colm O hEigeartaigh
SentryJSONMessageDeserializer extends MessageDeserializer { - Colm O hEigeartaigh On Aug. 2, 2017, 1:38 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61264: SENTRY-1843: Fork sentry-binding-hive-follower package to support Hive 2.x

2017-08-02 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61264/#review182014 --- Ship it! Ship It! - Colm O hEigeartaigh On Aug. 2, 2017, 1

Re: [VOTE] Release Sentry version 1.8.0

2017-08-03 Thread Colm O hEigeartaigh
ote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Thanks, > - Sergio Pena > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 61254: SENTRY-1847: Integrate sentry with Hive 2.0.0

2017-08-03 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61254/#review182102 --- Ship it! Ship It! - Colm O hEigeartaigh On Aug. 2, 2017, 8

Maven artifacts for 1.8.0

2017-08-08 Thread Colm O hEigeartaigh
I created some Maven artifacts for 1.8.0: https://repository.apache.org/content/repositories/orgapachesentry-1003/ Please take a look and let me know if there are any objections, I will publish them later this week if I don't hear anything. Colm. -- Colm O hEigeartaigh Talend Comm

Review Request 61499: SENTRY-1873 - Upgrade PMD plugin and fix related issues

2017-08-08 Thread Colm O hEigeartaigh
-hive/src/test/java/org/apache/sentry/tests/e2e/tools/CreateSentryTestScaleData.java cd9fa282 Diff: https://reviews.apache.org/r/61499/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: PMD violation caused by too many static imports

2017-08-10 Thread Colm O hEigeartaigh
Yes, done. Colm. On Thu, Aug 10, 2017 at 4:04 PM, Alexander Kolbasov wrote: > I recently saw PMD violation caused by too many static imports. I think > this one should be disabled. Colm - can you tweak PMD configuration for > that? > > Thanks, > > - Alex > -- Col

Re: Permissions to edit wiki page for Sentry

2017-08-10 Thread Colm O hEigeartaigh
ges? > > Thanks, > > - Alex > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Sentry 2.0.0 depends on multiple versions of Hive

2017-08-11 Thread Colm O hEigeartaigh
; >> > > > > >> > Hello all, > > > > >> > > > > > >> > Either way we need to fix couple of things first. > > > > >> > > > > > >> > 1. Fix the test failures when hive-authz2 and datanucleus4 >

Re: Maven artifacts for 1.8.0

2017-08-11 Thread Colm O hEigeartaigh
Now uploaded to maven central. Colm. On Tue, Aug 8, 2017 at 3:44 PM, Alexander Kolbasov wrote: > Thanks Colm! > > On Tue, Aug 8, 2017 at 2:48 AM, Colm O hEigeartaigh > wrote: > > > I created some Maven artifacts for 1.8.0: > > > > https://repositor

Re: Maven artifacts for 1.8.0

2017-08-14 Thread Colm O hEigeartaigh
ere instructions for it? > > On Fri, Aug 11, 2017 at 3:53 AM, Colm O hEigeartaigh > wrote: > >> Now uploaded to maven central. >> >> Colm. >> >> On Tue, Aug 8, 2017 at 3:44 PM, Alexander Kolbasov >> wrote: >> >> > Thanks Colm! >>

Re: [DISCUSSION] Move to JDK8 and Datanucleus 4

2017-08-30 Thread Colm O hEigeartaigh
ed to version 4 as well. We already have > > > support for version 4, so the question here is if we should drop > > > Datanucleus 3 support and just use version 4 as the default. > > > > > > Sentry 2.0 is our current major version development, so it makes sense > to > > > do this move in this version. > > > > > > What do you all think? > > > > > > - Sergio > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Review Request 62411: SENTRY-1958: Bump to Hive version 2.0

2017-09-21 Thread Colm O hEigeartaigh
pache.org/r/62411/ > --- > > (Updated Sept. 19, 2017, 3:10 p.m.) > > > Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and > kalyan kumar kalvagadda. > > > Bugs: sentry-1958 > https://issues.apache.org/jira/browse/sentry-1958 > > > Repository:

Re: [DISCUSS] Allow JDK8 specific features on Sentry 2.0

2017-09-28 Thread Colm O hEigeartaigh
Sentry 2.x will make these > > > > > backports > > > > > > harder because JDK7 is still in use. > > > > > > > > > > > > Maintenance releases are not active but companies are still > pretty > > > > active > >

Re: Review Request 62631: SENTRY-1962: Merge hive 2.0 authz1/authz2 profile dependencies

2017-09-28 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62631/#review186583 --- Ship it! Ship It! - Colm O hEigeartaigh On Sept. 27, 2017

Re: Concerns about Hive authz2 support

2017-10-02 Thread Colm O hEigeartaigh
le and just add the > hive-authz2 classes to the current sentry-binding-hive module so that users > are allowed to switch either to v1 or v2 (for testing). Also for the tests, > find a way to run all sentry-tests-hive with v1 and v2 to validate the > quality of it. > > What d

Re: Sentry CLI

2017-10-02 Thread Colm O hEigeartaigh
model as well. Any volunteers? > > - Alex > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Code consolidation query

2017-10-02 Thread Colm O hEigeartaigh
x27;d like to remove CommandUtil altogether and just reference the methods in SentryServiceUtil. Should these extra pieces also be in SentryServiceUtil? Or is there a reason that they are different? Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Concerns about Hive authz2 support

2017-10-03 Thread Colm O hEigeartaigh
>> possible to bypass the client security checks. >> >> See https://cwiki.apache.org/confluence/display/Hive/SQL+Sta >> ndard+Based+Hive+Authorization >> >> The above problem is the reason Hive introduced a new authorization API >> called authz2. However, I saw that some o

Review Request 62745: SENTRY-1210 - Refactor the SentryShellSolr and SentryShellKafka

2017-10-03 Thread Colm O hEigeartaigh
/generic/tools/TestSentryShellSolr.java d4e26e82 Diff: https://reviews.apache.org/r/62745/diff/1/ Testing --- Tested that the binary "sentryShell" can list privileges correctly for both Kafka and Solr. Thanks, Colm O hEigeartaigh

Re: Do Sentry sync-up meetings exist?

2017-10-04 Thread Colm O hEigeartaigh
in other Apache communities where they have these google chat > > sync-up meetings every 1 or 2 months to talk about what they'd like to do > > next in their products. Do you guys think this should be a reasonable > thing > > to do? > > > > - Sergio > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Review Request 62767: SENTRY-1973 - Use KafkaPrivilegeModel to retrieve Kafka validators

2017-10-04 Thread Colm O hEigeartaigh
/db/generic/tools/KafkaTSentryPrivilegeConverter.java 688bc9e4 Diff: https://reviews.apache.org/r/62767/diff/1/ Testing --- Tested the SentryShell works ok. Thanks, Colm O hEigeartaigh

Re: Review Request 62767: SENTRY-1973 - Use KafkaPrivilegeModel to retrieve Kafka validators

2017-10-04 Thread Colm O hEigeartaigh
/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 183e83d3 Diff: https://reviews.apache.org/r/62767/diff/2/ Changes: https://reviews.apache.org/r/62767/diff/1-2/ Testing --- Tested the SentryShell works ok. Thanks, Colm O hEigeartaigh

Re: Do Sentry sync-up meetings exist?

2017-10-05 Thread Colm O hEigeartaigh
k.com/ > > > >> - I created room in my private slack account - sent Colm an invite. > >> > >> > >>> On Oct 4, 2017, at 1:36 AM, Colm O hEigeartaigh > >> wrote: > >>> > >>> Where is the Slack room? I don't see it in

Re: Proposal to have sentry 1.9 release.

2017-10-05 Thread Colm O hEigeartaigh
ich is > > well tested locally at cloudera. This feature is something that the > > community is waiting for quite some time. Why don't we release current > > master as sentry 1.9 release? > > > > Sentry 1.9.0 if released, would below features. > > > >1. Sentry-HA > >2. Integration with Hive 2.0 using auth-V1. > > > > Seeking inputs from every one in this regard. > > > > > > -Kalyan > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Code consolidation query

2017-10-05 Thread Colm O hEigeartaigh
ryPrivilege.getURI())); > if (mSentryPrivilege.getGrantOption() != null) { > privilege.setGrantOption(TSentryGrantOption.valueOf(mSentryPrivilege. > getGrantOption().toString().toUpperCase())); > } else { > privilege.setGrantOption(TSentryGrantOption.UNSET); > } > }

Review Request 62791: SENTRY-1974 - Consolidate the Solr + Kafka PrivilegeValidators into a single GenericPrivilegeValidator

2017-10-05 Thread Colm O hEigeartaigh
://reviews.apache.org/r/62791/diff/1/ Testing --- Tested Solr + Kafka privileges in the Shell. Thanks, Colm O hEigeartaigh

Re: Review Request 62791: SENTRY-1974 - Consolidate the Solr + Kafka PrivilegeValidators into a single GenericPrivilegeValidator

2017-10-06 Thread Colm O hEigeartaigh
/TestSentryConfigToolSolr.java d199d20e Diff: https://reviews.apache.org/r/62791/diff/2/ Changes: https://reviews.apache.org/r/62791/diff/1-2/ Testing --- Tested Solr + Kafka privileges in the Shell. Thanks, Colm O hEigeartaigh

Review Request 62812: SENTRY-1975 - Add sqoop support to SentryShellGeneric

2017-10-06 Thread Colm O hEigeartaigh
/diff/1/ Testing --- Tested sentryShell with sqoop privileges. Thanks, Colm O hEigeartaigh

Re: Do Sentry sync-up meetings exist?

2017-10-16 Thread Colm O hEigeartaigh
I believe you can sign up here: https://the-asf.slack.com/ Colm. On Thu, Oct 5, 2017 at 8:51 PM, Alexander Kolbasov wrote: > Yes, moving to the official ASF slack team would make a lot of sense. What > should we do to move there? > > > On Thu, Oct 5, 2017 at 1:48 AM, Colm

Re: Proposal to release Sentry 2.0.0

2017-10-16 Thread Colm O hEigeartaigh
tAnalyze schematic hooks. > > > I think you are referring to some planned follow-up work to actually > > solve > > > the authorization problem for Hive 2 - right? Yes. > > > > > > > > > > > > > > > > > > > I have created a

Review Request 63026: SENTRY-1979 - Consolidate code for converting Hive privilege objects to Strings

2017-10-16 Thread Colm O hEigeartaigh
/TestSentryShellHive.java 81059c5f Diff: https://reviews.apache.org/r/63026/diff/1/ Testing --- Tested the Hive Shell. Thanks, Colm O hEigeartaigh

Re: Proposal to release Sentry 2.0.0

2017-10-16 Thread Colm O hEigeartaigh
de for Solr 6, but he > will try to see if Solr 7 is easy to do, but the initial expectations were > to have Solr 6. > > What do you think about the plans? Any comments regarding about them? Would > you like to see something else or different? > > Sergio. > > On Mon, Oct

Review Request 63069: SENTRY-1996 - Rename Sqoop SentryAuthorizationHander

2017-10-17 Thread Colm O hEigeartaigh
2687bc52 Diff: https://reviews.apache.org/r/63069/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-20 Thread Colm O hEigeartaigh
> On Oct. 19, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote: > > I'm fine with bumping up the jetty version but the only concern is that the > > Solr tests will be failing unitl changes for SENTRY-1475 are committed. Agreed, probably best waiting until the Solr upgrade happens, assuming of co

Review Request 63185: SENTRY-2013 - Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

2017-10-20 Thread Colm O hEigeartaigh
estBase.java b27dbc27 Diff: https://reviews.apache.org/r/63185/diff/1/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-22 Thread Colm O hEigeartaigh
er-db/src/test/java/org/apache/sentry/provide r/db/service/thrift/TestSentryWebServerWithKerberos.java" intentional? - Colm O hEigeartaigh On Oct. 22, 2017, 3:10 a.m., Sergio Pena wrote: > > --- > This is an automatically g

Re: Review Request 63160: SENTRY-1667: Switching to Jetty v9 library

2017-10-22 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63160/#review188909 --- Ship it! Ship It! - Colm O hEigeartaigh On Oct. 22, 2017, 3

Review Request 63215: SENTRY-2015 - Refactor Command implementations

2017-10-23 Thread Colm O hEigeartaigh
/org/apache/sentry/provider/db/tools/command/hive/RevokeRoleFromGroupsCmd.java 86773ca4 Diff: https://reviews.apache.org/r/63215/diff/1/ Testing --- Tested the SentryShell with both Hive + Generic. Thanks, Colm O hEigeartaigh

Re: Review Request 63185: SENTRY-2013 - Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

2017-10-25 Thread Colm O hEigeartaigh
estBase.java b27dbc27 Diff: https://reviews.apache.org/r/63185/diff/2/ Changes: https://reviews.apache.org/r/63185/diff/1-2/ Testing --- Thanks, Colm O hEigeartaigh

Re: Review Request 63185: SENTRY-2013 - Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

2017-10-25 Thread Colm O hEigeartaigh
e functionality at all. - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63185/#review188994 --- On Oct. 25, 2017, 8:5

Re: Review Request 63303: SENTRY-1992 Improve parameter handling for SentryGenericProviderBackend

2017-10-26 Thread Colm O hEigeartaigh
atic final String COMPONENT_TYPE= "sentry.provider.backend.generic.component-type"; Apart from that it looks fine to me. - Colm O hEigeartaigh On Oct. 25, 2017, 7:01 p.m., Mano Kovacs wrote: > > --- > This is an autom

Re: Review Request 63303: SENTRY-1992 Improve parameter handling for SentryGenericProviderBackend

2017-10-27 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63303/#review189415 --- Ship it! Ship It! - Colm O hEigeartaigh On Oct. 27, 2017

Review Request 63518: SENTRY-1997 - "Bump sqoop dependency version to 1.99.7"

2017-11-02 Thread Colm O hEigeartaigh
0f0496bc Diff: https://reviews.apache.org/r/63518/diff/1/ Testing --- Tested successfully with a deployment as well. Thanks, Colm O hEigeartaigh

Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-08 Thread Colm O hEigeartaigh
tryShellHive.java adfd102c Diff: https://reviews.apache.org/r/63668/diff/1/ Testing --- Tested the script. Thanks, Colm O hEigeartaigh

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

2017-11-10 Thread Colm O hEigeartaigh
ointerException at org.apache.sentry.core.model.sqoop.SqoopModelAuthorizables.create(SqoopModelAuthorizables.java:31) Reading the privileges seems to work fine. - Colm O hEigeartaigh On Nov. 9, 2017, 3:32 p.m., Mano Kovacs wrote: > > --- > This is an automaticall

Re: Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-14 Thread Colm O hEigeartaigh
sts the roles that are associated with all of the available groups. - Colm --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63668/#review190862 ------

Re: Review Request 63668: SENTRY-2038 - Some ShellCommand improvements

2017-11-15 Thread Colm O hEigeartaigh
Sqoop.java 7bafd8c4 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java adfd102c Diff: https://reviews.apache.org/r/63668/diff/2/ Changes: https://reviews.apache.org/r/63668/diff/1-2/ Testing ------- Tested the script. Thanks, Colm O hEigeartaigh

Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

2017-11-16 Thread Colm O hEigeartaigh
rvice. Thanks, Colm O hEigeartaigh

Re: Review Request 63415: SENTRY-2012 Make SentryShellGeneric extendible

2017-11-17 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63415/#review191314 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 16, 2017, 6

Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

2017-11-17 Thread Colm O hEigeartaigh
anges: https://reviews.apache.org/r/63874/diff/1-2/ Testing --- Tested the CLI against the Sentry service. Thanks, Colm O hEigeartaigh

HDFS tests failing

2017-11-17 Thread Colm O hEigeartaigh
cted:<1> but was:<0> [ERROR] Run 3: TestSentryHDFSServiceProcessor.testRequestSyncUpdatesWhenPubSubNotifyReturnsFullPathsUpdate:172 expected:<1> but was:<0> [ERROR] Run 4: TestSentryHDFSServiceProcessor.testRequestSyncUpdatesWhenPubSubNotifyReturnsFullPathsUpdate:172 expecte

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Colm O hEigeartaigh
rrier on the HMS plugin side > 2. SENTRY-2048 Bump Hive version to 2.3.2 > > If we cut the branch, we can limit commits to sentry 2.0.0 to that are > needed and isolate the root cause for the test failures and stabilize 2.0.0 > branch. > > -Kalyan > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Cutting sentry 2.0.0 off master

2017-11-17 Thread Colm O hEigeartaigh
wrote: > Colm/Mano Kovacs, > > Do you have an ETA on SENTRY-1812 and SENTRY-2012? > > -Kalyan > > -Kalyan > > On Fri, Nov 17, 2017 at 11:00 AM, Colm O hEigeartaigh > wrote: > >> Fine with me, but I'd like to see the fixes for SENTRY-1812 and >>

Re: HDFS tests failing

2017-11-17 Thread Colm O hEigeartaigh
> [ERROR] Run 3: > > TestSentryHDFSServiceProcessor.testRequestSyncUpdatesWhenPubS > > ubNotifyReturnsFullPathsUpdate:172 > > expected:<1> but was:<0> > > [ERROR] Run 4: > > TestSentryHDFSServiceProcessor.testRequestSyncUpdatesWhenPubS > > ubNotifyRet

Re: Review Request 63874: SENTRY-1812 - Provide interactive Sentry CLI

2017-11-20 Thread Colm O hEigeartaigh
anges: https://reviews.apache.org/r/63874/diff/2-3/ Testing --- Tested the CLI against the Sentry service. Thanks, Colm O hEigeartaigh

Re: New release branch 2.0.0

2017-11-28 Thread Colm O hEigeartaigh
ranch should be named branch-2.0 as the Wiki suggests (git > >> > > checkout -b branch-1.8). It is better to name a branch this way so > we > >> can > >> > > commit bugfixes on it for future 2.0.x bugfix releases. > >> > > > >> > > On Mon, Nov 27, 2017 at 8:19 AM, Kalyan Kumar Kalvagadda < > >> > > kkal...@cloudera.com> wrote: > >> > > > >> > > > I've just created new release branch for upcoming 2.0.0 release. > >> Please > >> > > > continue committing to master branch as usual. > >> > > > I'll cherry-pick commits to branch-2.0.0 on need basis. > >> > > > > >> > > > -Kalyan > >> > > > > >> > > > >> > > >> > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: New release branch 2.0.0

2017-11-28 Thread Colm O hEigeartaigh
.staging.https". is that the correct one? > > On Tue, Nov 28, 2017 at 10:14 AM, Colm O hEigeartaigh > wrote: > >> Have you got a "apache.releases.https" server defined in your maven >> settings.xml, with a corresponding username + password? >> &g

Re: New release branch 2.0.0

2017-11-28 Thread Colm O hEigeartaigh
; * >> >> >> >> > > I'm running below command. > >> mvn -s ~/.m2/settings.xml clean deploy -Psign-artifacts > > > I still observe the same issue. > > -Kalyan > > On Tue, Nov 28, 2017 at 10:46 AM, Colm O hEigeartaigh > w

Re: 2.0 release and SENTRY-1812

2017-11-28 Thread Colm O hEigeartaigh
Yes, it's already merged and the Jira is resolved. Colm. On 28 Nov 2017 7:04 p.m., "Alexander Kolbasov" wrote: Colm, do you plan to include SENTRY-1812 in 2.0 release?

Re: [VOTE] Release Sentry version 2.0.0

2017-11-29 Thread Colm O hEigeartaigh
rce:tag=release-2.0.0, SHA= > 18fe7c596fa1ffad3e656a42d534ac190876b642 > (You can get the hash of the tag by doing "git rev-list release-1.8.0 | > head -n 1" ) > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > -Kalyan > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [VOTE] Release Sentry version 2.0.0

2017-11-29 Thread Colm O hEigeartaigh
e. >> >> I'm not sure if these are blockers. I will wait for other to respond on >> this. >> >> While I'm waiting, I will start working on the duplicate jar dependency >> issue. >> >> >> -Kalyan >> >> On Wed, Nov 29, 2017 at 6

Re: [VOTE] Release Sentry version 2.0.0

2017-11-29 Thread Colm O hEigeartaigh
; SentryService.java:422) > > > > at > > > > org.apache.sentry.service.thrift.SentryService. > > > > runServer(SentryService.java:268) > > > > at > > > > org.apache.sentry.service.thrift.SentryService.call( > > > > SentryService.java:198) > > > > ... 5 more > > > > > > > > On Tue, Nov 28, 2017 at 4:38 PM, Kalyan Kumar Kalvagadda < > > > > kkal...@cloudera.com> wrote: > > > > > > > > > This is the release of Apache Sentry, version 2.0.0. > > > > > > > > > > It fixes the following issues: > > > > > *https://issues.apache.org/jira/projects/SENTRY/versions/12341081 > > > > > <https://issues.apache.org/jira/projects/SENTRY/versions/12341081 > >* > > > > > > > > > > Source and bin files : > > > > > *http://home.apache.org/~kalyan/apache-sentry-2.0.0-src-rc-1/ > > > > > <http://home.apache.org/~kalyan/apache-sentry-2.0.0-src-rc-1/>* > > > > > > > > > > Maven artifacts are available > > > > > here:https://repository.apache.org/content/ > > > repositories/orgapachesentry- > > > > > 1005/ > > > > > > > > > > > > > > > Tag to be voted on > > > > > *https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0 > > > > > <https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0>* > > > > > > > > > > Sentry's KEYS containing the PGP key we used to sign the release: > > > > > http://www.apache.org/dist/sentry/KEYS > > > > > > > > > > we are voting on the source:tag=release-2.0.0, SHA= > > > > > 18fe7c596fa1ffad3e656a42d534ac190876b642 > > > > > (You can get the hash of the tag by doing "git rev-list > > release-1.8.0 > > > | > > > > > head -n 1" ) > > > > > > > > > > Vote will be open for 72 hours. > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > -Kalyan > > > > > > > > > > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [VOTE] Release Sentry version 2.0.0

2017-11-29 Thread Colm O hEigeartaigh
pache.sentry.service.thrift.SentryService.call( > > > > SentryService.java:198) > > > > ... 5 more > > > > > > > > On Tue, Nov 28, 2017 at 4:38 PM, Kalyan Kumar Kalvagadda < > > > > kkal...@cloudera.com> wrote: > > > > > > > > > This is the release of Apache Sentry, version 2.0.0. > > > > > > > > > > It fixes the following issues: > > > > > *https://issues.apache.org/jira/projects/SENTRY/versions/12341081 > > > > > <https://issues.apache.org/jira/projects/SENTRY/versions/12341081 > >* > > > > > > > > > > Source and bin files : > > > > > *http://home.apache.org/~kalyan/apache-sentry-2.0.0-src-rc-1/ > > > > > <http://home.apache.org/~kalyan/apache-sentry-2.0.0-src-rc-1/>* > > > > > > > > > > Maven artifacts are available > > > > > here:https://repository.apache.org/content/ > > > repositories/orgapachesentry- > > > > > 1005/ > > > > > > > > > > > > > > > Tag to be voted on > > > > > *https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0 > > > > > <https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0>* > > > > > > > > > > Sentry's KEYS containing the PGP key we used to sign the release: > > > > > http://www.apache.org/dist/sentry/KEYS > > > > > > > > > > we are voting on the source:tag=release-2.0.0, SHA= > > > > > 18fe7c596fa1ffad3e656a42d534ac190876b642 > > > > > (You can get the hash of the tag by doing "git rev-list > > release-1.8.0 > > > | > > > > > head -n 1" ) > > > > > > > > > > Vote will be open for 72 hours. > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > -Kalyan > > > > > > > > > > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Colm O hEigeartaigh
d be using to update the license file > in the repo? > > -Kalyan > > On Wed, Nov 29, 2017 at 1:52 PM, Colm O hEigeartaigh > wrote: > >> Hi Kalyan, >> >> Anything Apache related you can immediately discount - so Hadoop, Hive, >> HBase, Solr, Zookeeper, etc.

Re: Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-12-01 Thread Colm O hEigeartaigh
he license. Same for the licenses above it. - Colm O hEigeartaigh On Dec. 1, 2017, 2:03 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

2017-12-04 Thread Colm O hEigeartaigh
f this fix? - Colm O hEigeartaigh On Dec. 1, 2017, 9:15 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Colm O hEigeartaigh
ository.apache.org/content/repositories/ > > > > > orgapachesentry-1005/> > > > > > > > > > > > > > > > > > > Tag to be voted on > > > > > > *https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0 > > > > > > <https://git-wip-us.apache.org/repos/asf/sentry/?p= > > > > > sentry.git;a=tag;h=refs/tags/release-2.0.0>* > > > > > > > > > > > > Sentry's KEYS containing the PGP key we used to sign the release: > > > > > > http://www.apache.org/dist/sentry/KEYS > > > > > > > > > > > > we are voting on the source:tag=release-2.0.0, SHA= > > > > > > c1ca5b22ba8a3a34398e0d62802cf65cfc47b4d1 > > > > > > (You can get the hash of the tag by doing "git rev-list > > > release-2.0.0 | > > > > > > head -n 1" ) > > > > > > > > > > > > Vote will be open for 72 hours. > > > > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > -Kalyan > > > > > > > > > > > > > > > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: [VOTE] Release Sentry 2.0.0 RC2

2017-12-04 Thread Colm O hEigeartaigh
It's a "-1" from me unfortunately, as the source distribution does not build. I've submitted a patch here: https://issues.apache.org/jira/browse/SENTRY-2086 Colm. On Mon, Dec 4, 2017 at 2:30 PM, Colm O hEigeartaigh wrote: > It's a lot easier IMO just letting the M

Re: [VOTE] Sentry Release 2.0.0 RC3

2017-12-05 Thread Colm O hEigeartaigh
6106ee068ad5ae176fe0b225> > > (You can get the hash of the tag by doing "git rev-list release-2.0.0 | > > head -n 1" ) > > > > Vote will be open for a minimum 72 hours. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > -Kalyan > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Need permissions to update upstream wiki

2017-12-06 Thread Colm O hEigeartaigh
changes to upstream wiki page. > https://cwiki.apache.org/confluence/display/SENTRY/How+to+Release but I do > not have permissions to do it. > It would be great if any one who is authorized to grant me permission can > help me with that. > > > -Kalyan > --

Re: Need permissions to update upstream wiki

2017-12-06 Thread Colm O hEigeartaigh
What's your cwiki username though? Colm. On Wed, Dec 6, 2017 at 4:56 PM, Kalyan Kumar Kalvagadda < kkal...@cloudera.com> wrote: > Colm, > > My apache user name is just kalyan. > > -Kalyan > > On Wed, Dec 6, 2017 at 3:55 AM, Colm O hEigeartaigh > wrote: &g

Re: [RESULT][VOTE] Release Sentry version 2.0.0

2017-12-08 Thread Colm O hEigeartaigh
Pena, Alexander Kolbasov, Colm o hEigeartaigh > > > Thanks to everyone who voted! I'll continue with the rest of the > release process. > > > -Kalyan > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Issue with SimpleCacheProviderBackend

2017-12-12 Thread Colm O hEigeartaigh
able hierarchy looks like: Server [name=server1] Database [name=authz] Table [name=words] There is no "column" here, and a match is not made against the cached privilege as a result. Is this a bug or am I missing some configuration switch? Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Issue with SimpleCacheProviderBackend

2017-12-12 Thread Colm O hEigeartaigh
That would be great, thanks! Colm. On Tue, Dec 12, 2017 at 4:36 PM, Na Li wrote: > Colm, > > I suspect it is a bug in SENTRY-1291. I can take a look later today. > > Thanks, > > Lina > > On Tue, Dec 12, 2017 at 4:32 AM, Colm O hEigeartaigh > wrote: > >

Re: Issue with SimpleCacheProviderBackend

2017-12-13 Thread Colm O hEigeartaigh
n add a e2e test case and set break point at where the authorization > object hierarchy to a list of authorization objects, which is used to do > exact match with cache > > Sent from my iPhone > > > On Dec 12, 2017, at 11:27 AM, Colm O hEigeartaigh > wrote: > > > &g

1.7.1 version in JIRA

2017-12-13 Thread Colm O hEigeartaigh
Can someone add a 1.7.1 version in JIRA please? Colm. -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com

Re: Issue with SimpleCacheProviderBackend

2017-12-18 Thread Colm O hEigeartaigh
it and no one is actually using the fix. Anyone wants to do > it? > > > > - Alex > > > > On Wed, Dec 13, 2017 at 4:44 AM, Na Li wrote: > > > > > Colm, > > > > > > Glad you find the cause! > > > > > > You can revert Sent

[VOTE] - Release Apache Sentry 1.7.1

2017-12-18 Thread Colm O hEigeartaigh
This is a vote to release Apache Sentry 1.7.1. Artifacts: https://dist.apache.org/repos/dist/dev/sentry/1.7.1/ Git tag: https://github.com/apache/sentry/tree/release-1.7.1 Issues fixed: https://issues.apache.org/jira/projects/SENTRY/versions/12342308 +1 from me. Colm. -- Colm O

Re: Issue with SimpleCacheProviderBackend

2017-12-18 Thread Colm O hEigeartaigh
ar Kalvagadda < kkal...@cloudera.com> wrote: > Colm, > > I will look closer into this today and see If i can help you out. > > -Kalyan > > On Mon, Dec 18, 2017 at 4:52 AM, Colm O hEigeartaigh > wrote: > >> Hi, >> >> I've done some further analy

  1   2   3   >