Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210936 --- Ship it! Ship It! - Steve Moist On Nov. 27, 2018, 3:32

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

> On Nov. 20, 2018, 6:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > > Lines 32 (patched) > > > > > > Why do we have 2 different copyrights? Is

Re: Review Request 69351: SENTRY-2458: Split web service from server service modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210669 --- sentry-dist/pom.xml Lines 66 (patched)

Re: Review Request 69285: Signal Handle Unregister

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69285/#review210670 --- Ship it! Ship It! - Steve Moist On Nov. 19, 2018, 4:32

Re: Review Request 69285: Signal Handle Unregister

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69285/#review210387 ---

Re: Review Request 68573: SENTRY-2311 Intellij is broken by shaded jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68573/ --- (Updated Sept. 7, 2018, 4:52 p.m.) Review request for sentry. Bugs:

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68657/#review208414 ---

Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68647/#review208413 --- Ship it! Ship It! - Steve Moist On Sept. 6, 2018, 5:36

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208318 --- Ship it! Ship It! - Steve Moist On Aug. 31, 2018, 4:03

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review208179 --- sentry-spi/pom.xml Lines 45 (patched)

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? > > Brian Towles wrote: > Lombok only hooks on the compile and modified the output classes

Re: Review Request 68573: SENTRY-2311 Intellij is broken by shaded jars

> On Aug. 30, 2018, 8:51 p.m., Na Li wrote: > > have you tested that Intellij and CLI works fine with this change? Yes. - Steve --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68573: SENTRY-2311 Intellij is broken by shaded jars

> On Aug. 30, 2018, 8:50 p.m., Na Li wrote: > > sentry-dist/src/license/THIRD-PARTY.properties > > Lines 16 (patched) > > > > > > do we need to change this file? no real change No I'll remove it. - Steve

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

> On Aug. 27, 2018, 8:32 p.m., Steve Moist wrote: > > pom.xml > > Lines 410 (patched) > > > > > > Why is this provided? > > Brian Towles wrote: > Lombok only hooks on the compile and modified the output classes

Review Request 68573: SENTRY-2311 Intellij is broken by shaded jars

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68573/ --- Review request for sentry. Bugs: SENTRY-2311

Re: Review Request 68488: SENTRY-2367: Implement subsystem to allow for pluggable attribute providers and transports

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68488/#review207990 --- pom.xml Lines 410 (patched)

Review Request 68113: SENTRY-2230 Change sentry-service-server to use ${project.version}

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68113/ --- Review request for sentry. Bugs: SENTRY-2230

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 9, 2018, 7:28 p.m.) Review request for sentry. Repository:

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

> On July 9, 2018, 5:53 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > > Line 20 (original), 20 (patched) > > > > > > Shouldn't this

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 9, 2018, 7:17 p.m.) Review request for sentry. Repository:

Re: Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- (Updated July 6, 2018, 7:06 p.m.) Review request for sentry. Repository:

Review Request 67846: SENTRY-2283 Multiple versions of metrics on the classpath causes Sentry to not startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67846/ --- Review request for sentry. Repository: sentry Description --- Excluding

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203990 --- Ship it! Ship It! - Steve Moist On May 25, 2018, 1:59 p.m.,

Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column privileges for views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67180/#review203365 ---

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203363 --- Can't we tease apart that database models and possibly JPA layer

Re: Review Request 67093: SENTRY-2208: Refactor out Sentry service into own module from sentry-provider-db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67093/#review203362 ---

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/ --- (Updated May 9, 2018, 8:12 p.m.) Review request for sentry. Repository:

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/#review202380 ---

Re: Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/ --- (Updated May 1, 2018, 7:50 p.m.) Review request for sentry. Repository:

Review Request 66888: SENTRY-2206 Refactor out sentry api from sentry-provider-db to own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66888/ --- Review request for sentry. Repository: sentry Description --- Mainly

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/ --- (Updated April 27, 2018, 4:47 p.m.) Review request for sentry. Changes

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 27, 2018, 3:47 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 26, 2018, 7:38 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 7:58 p.m., Sergio Pena wrote: > > I found out that Hive made a change on the smart-apply-patch.sh to use git > > apply instead of patch, and the patch still have some validation to check > > if the patch was generated using the --no-prefix and also the levels. > > See > >

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 25, 2018, 4:51 p.m., Colm O hEigeartaigh wrote: > > Why is the package name changed for GenericPrivilegeConverter.java + > > TSentryPrivilegeConverter.java? They've gone from > > "sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools" > > to

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 33 (original), 32 (patched) > > > > > > Will we not continue to support stdin patches? I think it can still be

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201939 --- dev-support/smart-apply-patch.sh Line 33 (original), 32

Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/ --- Review request for sentry. Repository: sentry Description --- Removed

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 24, 2018, 7:29 p.m.) Review request for sentry. Repository:

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: SENTRY-2207 Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- (Updated April 23, 2018, 8:45 p.m.) Review request for sentry. Summary

Re: Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Re: Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

> On April 23, 2018, 4:34 p.m., Colm O hEigeartaigh wrote: > > Shouldn't the location of the files be changed as well? If I apply the diff > > from this JIRA I see, for example: > > > > ./sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/ShellCommand.java > >

Review Request 66748: Refactor out Sentry CLI from sentry-provider-db into own module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66748/ --- Review request for sentry. Repository: sentry Description --- Moved the

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

> On April 19, 2018, 10:04 p.m., Na Li wrote: > > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java > > Lines 60 (patched) > > > > > > should we make this function thread-safe? It invoves two tables

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- (Updated April 20, 2018, 4:14 p.m.) Review request for sentry. Repository:

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- (Updated April 19, 2018, 9:09 p.m.) Review request for sentry. Repository:

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

> On April 16, 2018, 2:38 p.m., Xinran Tinney wrote: > > sentry-abac/src/main/java/org/apache/sentry/abac/AttributeMap.java > > Lines 117 (patched) > > > > > > targetObjects.size()=0 might because of line 111, so

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

> On April 19, 2018, 3:23 p.m., Arjun Mishra wrote: > > sentry-abac/src/main/java/org/apache/sentry/abac/Attribute.java > > Lines 19 (patched) > > > > > > Is Attribute persisted? Currently, maybe. I need to update

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- (Updated April 16, 2018, 7:51 p.m.) Review request for sentry. Repository:

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

> On April 13, 2018, 9:13 p.m., Anthony Young-Garner wrote: > > sentry-abac/notes.txt > > Lines 19 (patched) > > > > > > Lines 19 - 20 can be removed if the example-delta.json file is removed. I just deleted the

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- (Updated April 12, 2018, 8:45 p.m.) Review request for sentry. Changes

Re: Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- (Updated April 12, 2018, 8:45 p.m.) Review request for sentry. Changes

Review Request 66590: SENTRY-2201 Initial Attriubte based access control

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66590/ --- Review request for sentry. Repository: sentry Description --- This is

Re: Review Request 66480: SENTRY-2140: Static Attribute Ingestion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66480/#review200653 --- sentry-abac/notes.txt Lines 23 (patched)

Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift

> On March 29, 2018, 5:29 p.m., Steve Moist wrote: > > Tested this out with some by adding the thrift apis I wrote (new endpoints > > and objects). It generates only the necessary files and changes in most > > cases. When adding new endpoints and objects it shifts things around in > > the a

Re: Review Request 66360: SENTRY-2192: supress date value in @Generated annotation generated by thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66360/#review200202 --- Tested this out with some by adding the thrift apis I wrote (new

Re: Review Request 66336: SENTRY-2190: Have verbose debug logs in CounterWait class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66336/#review200135 --- Ship it! Ship It! - Steve Moist On March 28, 2018, 4:14

Review Request 66319: 75+ files are uneccessarily changed when generetating new Thrift files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66319/ --- Review request for sentry. Repository: sentry Description --- Changed

Re: Review Request 65639: SENTRY-1242 Enable getting all privileges on a hive object

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65639/ --- (Updated March 9, 2018, 6:40 p.m.) Review request for sentry. Repository:

Re: Review Request 65953: SENTRY-2165: NotificationProcesser process notification methods have logs wrongly flagged as ERROR

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65953/#review198898 ---

Re: Review Request 65945: SENTRY-2164: Convert uses of TransactionBlock to lambdas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65945/#review198820 --- Ship it! Ship It! - Steve Moist On March 7, 2018, 7:14

Re: Review Request 65953: SENTRY-2165: NotificationProcesser processAlterTable method has logs wrongly flagged as ERROR when they should be INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65953/#review198819 ---

Re: Review Request 65866: SENTRY-2146: Add better error handling to ResourceAuthorizationProvider and improve logging in related classes

> On March 1, 2018, 5:39 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > > Lines 140 (patched) > > > > > > I

Re: Review Request 65639: SENTRY-1242 Enable getting all privileges on a hive object

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65639/ --- (Updated March 5, 2018, 9:40 p.m.) Review request for sentry. Repository:

Re: Review Request 65867: SENTRY-2147 - Fix Javadoc for SentryHiveAuthorizerFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65867/#review198650 --- Ship it! Ship It! - Steve Moist On March 5, 2018, 5:25

Re: Review Request 65816: SENTRY-2145 - Some misc code cleanups

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65816/#review198354 ---

Re: Review Request 65704: SENTRY-2143: Table renames should synchronize with Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65704/#review198135 ---

Re: Review Request 65642: SENTRY-2141: Sentry Privilege TimeStamp is not converted to grantTime in HivePrivilegeInfo correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65642/#review197679 --- Ship it! Ship It! - Steve Moist On Feb. 14, 2018, 12:51

Re: Review Request 65641: SENTRY-853 Handle show grant on failure correctly

> On Feb. 13, 2018, 10:51 p.m., Sergio Pena wrote: > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java > > Line 363 (original), 363 (patched) > >

Review Request 65641: SENTRY-853 Handle show grant on failure correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65641/ --- Review request for sentry. Repository: sentry Description --- Improved

Review Request 65639: SENTRY-1242 Enable getting all privileges on a hive object

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65639/ --- Review request for sentry. Repository: sentry Description --- Enabled

Re: Review Request 65268: SENTRY-1904: TransactionManager should limit the max time spent by transaction retry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65268/#review196463 ---

Re: Review Request 65388: SENTRY-2124 LeaderStatusMonitor.toString() throws IllegalFormatConversionException with AtomicLong

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65388/#review196460 --- Ship it! Ship It! - Steve Moist On Jan. 29, 2018, 4:51

Re: Review Request 65046: SENTRY-1819 HMSFollower and friends do not belong in sentry.service.thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65046/#review195043 --- sentry-dist/src/license/THIRD-PARTY.properties Line 1

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

> On Jan. 4, 2018, 9:37 p.m., Arjun Mishra wrote: > > I don't think you meant to commit > > "sentry-dist/src/license/THIRD-PARTY.properties". Am I right? It is being > > generated because of another issue. I am not sure if you intentionally > > created it I have also seen this on another

Re: Review Request 64949: SENTRY-641 Add binding for lily hbase indexer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64949/#review194783 ---

Re: Review Request 64317: SENTRY-2085: Keep sentry exceptions contained within Sentry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64317/#review194718 ---

Re: Review Request 64890: SENTRY-1165 add clover plugin to maven to get code coverage report

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64890/#review194640 --- pom.xml Lines 117 (patched)

Re: Review Request 64452: SENTRY-2091: User-based Privilege is broken by SENTRY-769

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64452/#review194184 ---

Re: Review Request 64661: SENTRY-1944: Optimize DelegateSentryStore.getGroupsByRoles()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194180 ---

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote: > > The subject of the review board must match the JIRA subject. You could > > either change the JIRA or the Review subject to match the correct fix. > > > > The getUniqueMSentryPrivilege() is still confusing. Any idea of the > > difference in

Re: Review Request 64259: SENTRY-1572 SentryMain() shouldn't dynamically load tool class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64259/#review192785 --- This project has a lot of command line tools, maybe rename to

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote: > > The subject of the review board must match the JIRA subject. You could > > either change the JIRA or the Review subject to match the correct fix. > > > > The getUniqueMSentryPrivilege() is still confusing. Any idea of the > > difference in

Re: Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/ --- (Updated Nov. 27, 2017, 9:36 p.m.) Review request for sentry. Bugs:

Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63964/ --- Review request for sentry. Bugs: SENTRY-2049

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63775/ --- (Updated Nov. 15, 2017, 9:47 p.m.) Review request for sentry. Summary

Review Request 63775: SENTRY-1543 Rename methods to be clearer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63775/ --- Review request for sentry. Bugs: SENTRY-1543

Re: Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/ --- (Updated Nov. 9, 2017, 7:32 p.m.) Review request for sentry. Bugs:

Review Request 63704: SENTRY-1662 Constants java uses mutable collection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63704/ --- Review request for sentry. Bugs: SENTRY-1662