Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review202072 --- Ship it! Thanks, the change looks better. FYI, keeping the

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/ --- (Updated April 27, 2018, 4:47 p.m.) Review request for sentry. Changes

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 7:58 p.m., Sergio Pena wrote: > > I found out that Hive made a change on the smart-apply-patch.sh to use git > > apply instead of patch, and the patch still have some validation to check > > if the patch was generated using the --no-prefix and also the levels. > > See > >

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201957 --- I found out that Hive made a change on the smart-apply-patch.sh

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 44 (original) > > > > > > Do we not still want to detect this situation (only new files) and try > > applying

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

> On April 25, 2018, 4:07 p.m., Anthony Young-Garner wrote: > > dev-support/smart-apply-patch.sh > > Line 33 (original), 32 (patched) > > > > > > Will we not continue to support stdin patches? I think it can still be

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201939 --- dev-support/smart-apply-patch.sh Line 33 (original), 32

Re: Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/#review201928 --- dev-support/smart-apply-patch.sh Line 33 (original), 32

Review Request 66787: SENTRY-2212 smart-apply-patch.sh isn't so smart, won't apply changes when files have been moved or renamed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66787/ --- Review request for sentry. Repository: sentry Description --- Removed