Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-26 Thread Arjun Mishra via Review Board
> On Sept. 21, 2018, 2:11 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > Can you use an example to explain the optimization this chnage is going to > > make? > > Arjun Mishra wrote: > Kalyan, will give you an example. ReadEntity has an attribute called > accessedColumns. Say a

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-26 Thread Arjun Mishra via Review Board
> On Sept. 21, 2018, 2:11 p.m., kalyan kumar kalvagadda wrote: > > Arjun, > > > > Can you use an example to explain the optimization this chnage is going to > > make? Kalyan, will give you an example. ReadEntity has an attribute called accessedColumns. Say a table has 10 partitions and 7

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-25 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/ --- (Updated Sept. 26, 2018, 5:11 a.m.) Review request for sentry, kalyan kumar

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-21 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/ --- (Updated Sept. 21, 2018, 5:05 p.m.) Review request for sentry, kalyan kumar

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-21 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/#review208857 --- Arjun, Can you use an example to explain the optimization this

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-20 Thread Arjun Mishra via Review Board
> On Sept. 20, 2018, 9:44 p.m., Na Li wrote: > > can you add unit test? I thought the existing end to end tests should cover it. Let me try - Arjun --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-20 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/#review208815 --- can you add unit test? - Na Li On Sept. 20, 2018, 7:32 p.m.,

Review Request 68787: SENTRY-2406: Make sure inputHierarchy and outputHierarchy have unique values

2018-09-20 Thread Arjun Mishra via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68787/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.