[GitHub] asifdxtreme opened a new pull request #59: Add the Release guide for ServiceComb

[GitBox]

asifdxtreme opened a new pull request #59: Add the Release guide for ServiceComb
URL: https://github.com/apache/incubator-servicecomb-website/pull/59
 
 
   Preview :  
https://asifdxtreme.github.io/incubator-servicecomb-website/developers/release-guide/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism

[GitBox]

wujimin commented on a change in pull request #639: [SCB-422] prometheus switch 
to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r179985745
 
 

 ##
 File path: 
metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/PrometheusPublisher.java
 ##
 @@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.prometheus;
+
+import java.net.InetSocketAddress;
+import java.util.ArrayList;
+import java.util.List;
+
+import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.apache.servicecomb.foundation.metrics.MetricsInitializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.config.DynamicPropertyFactory;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Measurement;
+import com.netflix.spectator.api.Tag;
+
+import io.prometheus.client.Collector;
+import io.prometheus.client.Collector.MetricFamilySamples.Sample;
+import io.prometheus.client.CollectorRegistry;
+import io.prometheus.client.exporter.HTTPServer;
+
+public class PrometheusPublisher extends Collector implements 
Collector.Describable, MetricsInitializer {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(PrometheusPublisher.class);
+
+  static final String METRICS_PROMETHEUS_ADDRESS = 
"servicecomb.metrics.prometheus.address";
+
+  private HTTPServer httpServer;
+
+  private CompositeRegistry globalRegistry;
+
+  @Override
+  public void init(CompositeRegistry globalRegistry, EventBus eventBus, 
MetricsBootstrapConfig config) {
+this.globalRegistry = globalRegistry;
+
+//prometheus default port allocation is here : 
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
+String address =
+
DynamicPropertyFactory.getInstance().getStringProperty(METRICS_PROMETHEUS_ADDRESS,
 "0.0.0.0:9696").get();
+
+try {
+  InetSocketAddress socketAddress = getSocketAddress(address);
+  register();
+  this.httpServer = new HTTPServer(socketAddress, 
CollectorRegistry.defaultRegistry, true);
 
 Review comment:
   By MetricsRestPublisher in previous PR, we already support metrics endpoint: 
/metrics
   
   and created a issue for contribute: 
https://issues.apache.org/jira/browse/SCB-466


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

[GitBox]

acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r179983363
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/ExceptionToResponseConverter.java
 ##
 @@ -22,5 +22,9 @@
 public interface ExceptionToResponseConverter {
   Class getExceptionClass();
 
+  default int getOrder() {
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to input configuration from a Map

[GitBox]

liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to 
input configuration from a Map
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/632#discussion_r179982498
 
 

 ##
 File path: 
foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
 ##
 @@ -80,6 +81,16 @@ public static void tearDown() throws Exception {
 ArchaiusUtils.resetConfig();
   }
 
+  @Test
+  public void testAddConfig() {
+Map config = new HashMap();
+config.put("APPLICATION_ID", "app");
+ConfigUtil.setConfigs(config);
+ConcurrentCompositeConfiguration configuration = 
ConfigUtil.createLocalConfig();
+Assert.assertEquals(configuration.getString("APPLICATION_ID"), "app");
 
 Review comment:
   Can you provide a test case for dynamic property change is work? (callback)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism

[GitBox]

liubao68 commented on a change in pull request #639: [SCB-422] prometheus 
switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r179981976
 
 

 ##
 File path: 
metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/PrometheusPublisher.java
 ##
 @@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.prometheus;
+
+import java.net.InetSocketAddress;
+import java.util.ArrayList;
+import java.util.List;
+
+import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.apache.servicecomb.foundation.metrics.MetricsInitializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.config.DynamicPropertyFactory;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Measurement;
+import com.netflix.spectator.api.Tag;
+
+import io.prometheus.client.Collector;
+import io.prometheus.client.Collector.MetricFamilySamples.Sample;
+import io.prometheus.client.CollectorRegistry;
+import io.prometheus.client.exporter.HTTPServer;
+
+public class PrometheusPublisher extends Collector implements 
Collector.Describable, MetricsInitializer {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(PrometheusPublisher.class);
+
+  static final String METRICS_PROMETHEUS_ADDRESS = 
"servicecomb.metrics.prometheus.address";
+
+  private HTTPServer httpServer;
+
+  private CompositeRegistry globalRegistry;
+
+  @Override
+  public void init(CompositeRegistry globalRegistry, EventBus eventBus, 
MetricsBootstrapConfig config) {
+this.globalRegistry = globalRegistry;
+
+//prometheus default port allocation is here : 
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
+String address =
+
DynamicPropertyFactory.getInstance().getStringProperty(METRICS_PROMETHEUS_ADDRESS,
 "0.0.0.0:9696").get();
+
+try {
+  InetSocketAddress socketAddress = getSocketAddress(address);
+  register();
+  this.httpServer = new HTTPServer(socketAddress, 
CollectorRegistry.defaultRegistry, true);
 
 Review comment:
   For future customization, I think we 'd provide way to export to servicecomb 
rest framework. And contribute the code to 
https://github.com/prometheus/client_java. If we can create a task to tracking 
this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism

[GitBox]

liubao68 commented on a change in pull request #639: [SCB-422] prometheus 
switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r179981976
 
 

 ##
 File path: 
metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/PrometheusPublisher.java
 ##
 @@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.prometheus;
+
+import java.net.InetSocketAddress;
+import java.util.ArrayList;
+import java.util.List;
+
+import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.apache.servicecomb.foundation.metrics.MetricsInitializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.config.DynamicPropertyFactory;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Measurement;
+import com.netflix.spectator.api.Tag;
+
+import io.prometheus.client.Collector;
+import io.prometheus.client.Collector.MetricFamilySamples.Sample;
+import io.prometheus.client.CollectorRegistry;
+import io.prometheus.client.exporter.HTTPServer;
+
+public class PrometheusPublisher extends Collector implements 
Collector.Describable, MetricsInitializer {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(PrometheusPublisher.class);
+
+  static final String METRICS_PROMETHEUS_ADDRESS = 
"servicecomb.metrics.prometheus.address";
+
+  private HTTPServer httpServer;
+
+  private CompositeRegistry globalRegistry;
+
+  @Override
+  public void init(CompositeRegistry globalRegistry, EventBus eventBus, 
MetricsBootstrapConfig config) {
+this.globalRegistry = globalRegistry;
+
+//prometheus default port allocation is here : 
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
+String address =
+
DynamicPropertyFactory.getInstance().getStringProperty(METRICS_PROMETHEUS_ADDRESS,
 "0.0.0.0:9696").get();
+
+try {
+  InetSocketAddress socketAddress = getSocketAddress(address);
+  register();
+  this.httpServer = new HTTPServer(socketAddress, 
CollectorRegistry.defaultRegistry, true);
 
 Review comment:
   For future customization, I think we 'd provide way to export to servicecomb 
rest framework. And contribute the code to 
https://github.com/prometheus/client_java


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

?????? [VOTE] Holding Apache ServiceComb (incubating) Meetup Hosted byHuawei Cloud as a Co-located Event in LC3 2018 Aisa

[bismy]

+1 ??Binding??




--  --
??: "willem.jiang";
: 2018??4??8??(??) 10:13
??: "dev";

: Re: [VOTE] Holding Apache ServiceComb (incubating) Meetup Hosted byHuawei 
Cloud as a Co-located Event in LC3 2018 Aisa



+1 ??Binding??


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: willem

On Sun, Apr 8, 2018 at 3:40 PM, Zen Lin  wrote:

> Hi All,
> This is a call for Vote to hold Apache ServiceComb (incubating) Meetup
> Hosted by Huawei Cloud as a Co-located Event in LC3 2018 Aisa.
>
> As discussed in the meetup propersal[1], we have plan to hold Apache
> ServiceComb (incubating) Mini Meetup, details are listed bellow,
>
>
>- What is the topic focus of the event?
>
> Topics are focused on user-pratices/technologies/ecosystem of Apache
> ServiceComb (incubating)
>
>- Who is organising the event?
>
> PMCs of ServiceComb (incubating) are the organizer
>
>- When is the event?
>
>  one day Between Jun 25, 2018 and Jun 27, 2018, maybe in Jun 26, 2018
>
>- How many attendees are expected?
>
> 60~100
>
>- How much PMC involvement is there already?
>
> 5
>
>- Which marks are requested?
>
> Two marks are requested,
> 1. Name of "Apache ServiceComb Incubating Meetup Hosted by Huawei Cloud"
> 2. "Powered By" Apache Incubator logo of Apache ServiceComb (incubating)
>
>- Is this for profit or non-profit? (See "Event Profits And Donations")?
>
> non-profit.
>
>
>
> [1]  https://www.mail-archive.com/dev@servicecomb.apache.org/msg03298.html
>

Re: [Discussion]Provider a project fully show all features ofServiceComb(also can use as a scaffold)

[wjm wjm]

we already have some projects like this(houseApp or something else).
so my question is: design some new projects or make the exists better.

2018-04-09 11:02 GMT+08:00 bismy :

> This is a good idea, and the features is good too.
> Here are some works done that you can refer to
>https://java.huaweicse.com/featured-topics/develope-
> microservice-using-ces.html
> including microservice design and the working code is also included.
>
>
> If you want to demonstrate transactions processing, this is a project you
> can refer to https://github.com/huawei-microservice-demo/HouseApp
>
>
> -- 原始邮件 --
> 发件人: "郑扬勇";
> 发送时间: 2018年4月9日(星期一) 上午9:58
> 收件人: "dev";
>
> 主题: 回复： [Discussion]Provider a project fully show all features
> ofServiceComb(also can use as a scaffold)
>
>
>
> Ok,I will try.
>
>  Yangyong Zheng
> Best Regards !
>
>   -- 原始邮件 --
>   发件人: "willem.jiang";
>  发送时间: 2018年4月8日(星期天) 晚上10:29
>  收件人: "dev";
>
>  主题: Re: [Discussion]Provider a project fully show all features
> ofServiceComb(also can use as a scaffold)
>
>
>
> I just went through the documents, it looks good.
> Here are some comments for the edge service part.
> For the canary test, we need to make sure the new version of service is
> available to some kind of user, not the normal round robin one.
> Is better to show the user to do AB test by applying different routing rule
> on the edge service.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Apr 4, 2018 at 10:06 AM, 郑扬勇  wrote:
>
> > Hi everyone:
> > In order to fully show features of ServiceComb, I think we can use it
> > to construct a classic micro-service style project step by step (also can
> > called hand by hand) :
> >  1. Use ServiceCenter to support services register and discover;
> > 2. Includes edge service, user service with authentication and some other
> > business services develped by Java Chassis;
> > 3. Use Apollo to support dynamic config;
> > 4. Include a composite service to do complex business logic;
> > 5. In composite service we will use Saga to show eventually data
> > consistency solution;
> > 6. Show logs, metrics, tracing etc in operation phase.
> >
> >  Each small step of the construction will check a branch and write a
> > wiki to let user known what we had done, like:
> > 0.0.1 -> 1. Implement user service
> > 0.0.2 -> 2. Add authentication in user service
> > 0.0.3 -> 3. Implement edge service
> > ...
> >
> >  Then user can learn how to develop with ServiceComb faster, and can
> > use this project as a scaffold.
> >
> >  I had complete a small part of this program here :
> > https://github.com/zhengyangyong/scaffold/wiki (English version is
> coming
> > soon).
> >
> >  Any other ideas or suggestions are welcome !
> >
> >  Yangyong Zheng
> >  Best Regards !
>

?????? [Discussion]Provider a project fully show all features ofServiceComb(also can use as a scaffold)

[bismy]

This is a good idea, and the features is good too. 
Here are some works done that you can refer to 
   
https://java.huaweicse.com/featured-topics/develope-microservice-using-ces.html
including microservice design and the working code is also included.


If you want to demonstrate transactions processing, this is a project you can 
refer to https://github.com/huawei-microservice-demo/HouseApp


--  --
??: "??";
: 2018??4??9??(??) 9:58
??: "dev";

: ?? [Discussion]Provider a project fully show all features 
ofServiceComb(also can use as a scaffold)



Ok,I will try.
  
 Yangyong Zheng
Best Regards !

  --  --
  ??: "willem.jiang";
 : 2018??4??8??(??) 10:29
 ??: "dev";
 
 : Re: [Discussion]Provider a project fully show all features 
ofServiceComb(also can use as a scaffold)

 

I just went through the documents, it looks good.
Here are some comments for the edge service part.
For the canary test, we need to make sure the new version of service is
available to some kind of user, not the normal round robin one.
Is better to show the user to do AB test by applying different routing rule
on the edge service.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: willem

On Wed, Apr 4, 2018 at 10:06 AM, ??  wrote:

> Hi everyone:
> In order to fully show features of ServiceComb, I think we can use it
> to construct a classic micro-service style project step by step (also can
> called hand by hand) :
>  1. Use ServiceCenter to support services register and discover;
> 2. Includes edge service, user service with authentication and some other
> business services develped by Java Chassis;
> 3. Use Apollo to support dynamic config;
> 4. Include a composite service to do complex business logic;
> 5. In composite service we will use Saga to show eventually data
> consistency solution;
> 6. Show logs, metrics, tracing etc in operation phase.
>
>  Each small step of the construction will check a branch and write a
> wiki to let user known what we had done, like:
> 0.0.1 -> 1. Implement user service
> 0.0.2 -> 2. Add authentication in user service
> 0.0.3 -> 3. Implement edge service
> ...
>
>  Then user can learn how to develop with ServiceComb faster, and can
> use this project as a scaffold.
>
>  I had complete a small part of this program here :
> https://github.com/zhengyangyong/scaffold/wiki (English version is coming
> soon).
>
>  Any other ideas or suggestions are welcome !
>
>  Yangyong Zheng
>  Best Regards !

[GitHub] liubao68 closed pull request #637: [SCB-459]Update netty's version to 4.1.19 and vertx's version to 3.5.1

[GitBox]

liubao68 closed pull request #637: [SCB-459]Update netty's version to 4.1.19 
and vertx's version to 3.5.1
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/637
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
 
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
index a7a351a4c..a2536964a 100644
--- 
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
+++ 
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxTLSBuilder.java
@@ -18,6 +18,8 @@
 package org.apache.servicecomb.foundation.vertx;
 
 import java.io.File;
+import java.util.Arrays;
+import java.util.HashSet;
 
 import org.apache.servicecomb.foundation.ssl.SSLCustom;
 import org.apache.servicecomb.foundation.ssl.SSLManager;
@@ -126,10 +128,8 @@ private static TCPSSLOptions buildTCPSSLOptions(SSLOption 
sslOption, SSLCustom s
 throw new IllegalArgumentException("invalid trust store type.");
   }
 }
-
-for (String protocol : sslOption.getProtocols().split(",")) {
-  tcpClientOptions.addEnabledSecureTransportProtocol(protocol);
-}
+HashSet protocols = new 
HashSet<>(Arrays.asList(sslOption.getProtocols().split(",")));
+tcpClientOptions.setEnabledSecureTransportProtocols(protocols);
 for (String cipher : SSLManager.getEnalbedCiphers(sslOption.getCiphers())) 
{
   tcpClientOptions.addEnabledCipherSuite(cipher);
 }
diff --git 
a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestSimpleBodyHandler.java
 
b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestSimpleBodyHandler.java
index c36e75e0e..7c4cee493 100644
--- 
a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestSimpleBodyHandler.java
+++ 
b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestSimpleBodyHandler.java
@@ -25,6 +25,7 @@
 import org.junit.Test;
 import org.mockito.Mockito;
 
+import io.vertx.core.MultiMap;
 import io.vertx.core.http.HttpServerRequest;
 import io.vertx.core.http.HttpServerResponse;
 import io.vertx.ext.web.RoutingContext;
@@ -40,6 +41,8 @@ public void setUp() throws Exception {
 context = Mockito.mock(RoutingContext.class);
 HttpServerRequest request = Mockito.mock(HttpServerRequest.class);
 Mockito.when(context.request()).thenReturn(request);
+MultiMap multiMap = Mockito.mock(MultiMap.class);
+Mockito.when(request.headers()).thenReturn(multiMap);
 HttpServerResponse response = Mockito.mock(HttpServerResponse.class);
 
Mockito.when(response.setStatusCode(Status.UNSUPPORTED_MEDIA_TYPE.getStatusCode())).thenReturn(response);
 Mockito.when(context.response()).thenReturn(response);
diff --git 
a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
 
b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
index 33ef44538..3f14f0862 100644
--- 
a/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
+++ 
b/foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
@@ -63,7 +63,7 @@ public void testbuildHttpClientOptions_sslKey_noFactory() {
   public static class SSLOptionFactoryForTest implements SSLOptionFactory {
 static SSLOption sslOption = new SSLOption();
 static {
-  sslOption.setEngine("openssl");  
+  sslOption.setEngine("openssl");
   sslOption.setProtocols("");
   sslOption.setCiphers(SSLOption.DEFAUL_CIPHERS);
   sslOption.setCheckCNHost(true);
diff --git a/java-chassis-dependencies/pom.xml 
b/java-chassis-dependencies/pom.xml
index b7b622785..b9ab059a5 100644
--- a/java-chassis-dependencies/pom.xml
+++ b/java-chassis-dependencies/pom.xml
@@ -32,7 +32,7 @@
 
   
 2.9.4
-3.5.0
+3.5.1
 0.8
 4.3.5.RELEASE
 1.7.7
@@ -45,7 +45,7 @@
 4.5.2
 1.5.2
 1.5.12
-4.1.17.Final
+4.1.19.Final
 2.0.7.Final
 ${basedir}/../..
 5.3.2.Final
diff --git a/java-chassis-distribution/src/release/LICENSE 
b/java-chassis-distribution/src/release/LICENSE
index 8243952fa..eac3a4243 100644
--- a/java-chassis-distribution/src/release/LICENSE
+++ b/java-chassis-distribution/src/release/LICENSE
@@ -358,19 +358,19 @@ Jackson-dataformat-XML 
(http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding
 Jackson-dataformat-YAML 
(https://github.com/FasterXML/jackson-dataformats-text) 

Re: [Discussion]Provider a project fully show all features of ServiceComb(also can use as a scaffold)

[wjm wjm]

AB test supported by DarkLaunchFilter in CSE not ServiceComb

2018-04-08 22:29 GMT+08:00 Willem Jiang :

> I just went through the documents, it looks good.
> Here are some comments for the edge service part.
> For the canary test, we need to make sure the new version of service is
> available to some kind of user, not the normal round robin one.
> Is better to show the user to do AB test by applying different routing rule
> on the edge service.
>
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
>   http://jnn.iteye.com  (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Apr 4, 2018 at 10:06 AM, 郑扬勇  wrote:
>
> > Hi everyone:
> > In order to fully show features of ServiceComb, I think we can use it
> > to construct a classic micro-service style project step by step (also can
> > called hand by hand) :
> >  1. Use ServiceCenter to support services register and discover;
> > 2. Includes edge service, user service with authentication and some other
> > business services develped by Java Chassis;
> > 3. Use Apollo to support dynamic config;
> > 4. Include a composite service to do complex business logic;
> > 5. In composite service we will use Saga to show eventually data
> > consistency solution;
> > 6. Show logs, metrics, tracing etc in operation phase.
> >
> >  Each small step of the construction will check a branch and write a
> > wiki to let user known what we had done, like:
> > 0.0.1 -> 1. Implement user service
> > 0.0.2 -> 2. Add authentication in user service
> > 0.0.3 -> 3. Implement edge service
> > ...
> >
> >  Then user can learn how to develop with ServiceComb faster, and can
> > use this project as a scaffold.
> >
> >  I had complete a small part of this program here :
> > https://github.com/zhengyangyong/scaffold/wiki (English version is
> coming
> > soon).
> >
> >  Any other ideas or suggestions are welcome !
> >
> >  Yangyong Zheng
> >  Best Regards !
>

[GitHub] wujimin closed pull request #635: [SCB-462] cloud eye publisher switch to new mechanism

[GitBox]

wujimin closed pull request #635: [SCB-462] cloud eye publisher switch to new 
mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/635
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml 
b/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml
deleted file mode 100644
index 806d3b4e1..0
--- 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/pom.xml
+++ /dev/null
@@ -1,88 +0,0 @@
-
-
-
-http://maven.apache.org/POM/4.0.0;
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
-  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
-  
-metrics-write-file-sample
-org.apache.servicecomb.samples
-1.0.0-m2-SNAPSHOT
-  
-  4.0.0
-
-  metrics-write-file-log4j-springboot
-
-  
-  
-  
-
-  org.springframework.boot
-  spring-boot-starter
-  
-
-  org.slf4j
-  log4j-over-slf4j
-
-  
-
-
-
-  org.apache.servicecomb
-  spring-boot-starter-provider
-
-
-
-  org.apache.servicecomb
-  handler-flowcontrol-qps
-
-
-  org.apache.servicecomb
-  handler-bizkeeper
-
-
-  org.apache.servicecomb
-  handler-tracing-zipkin
-
-
-  org.hibernate
-  hibernate-validator
-
-
-
-  log4j
-  log4j
-
-
-  org.apache.servicecomb.samples
-  metrics-write-file
-
-  
-
-  
-
-  
-org.springframework.boot
-spring-boot-maven-plugin
-  
-
-  
-
-
\ No newline at end of file
diff --git 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
 
b/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
deleted file mode 100644
index cbe417dd4..0
--- 
a/samples/metrics-write-file-sample/metrics-write-file-log4j-springboot/src/main/java/org/apache/servicecomb/samples/mwf/Log4JMetricsFileWriter.java
+++ /dev/null
@@ -1,78 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.servicecomb.samples.mwf;
-
-import java.nio.file.Paths;
-import java.util.Map;
-
-import org.apache.log4j.Level;
-import org.apache.log4j.Logger;
-import org.apache.log4j.PatternLayout;
-import org.apache.log4j.RollingFileAppender;
-import org.apache.log4j.spi.LoggingEvent;
-import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
-import org.springframework.stereotype.Component;
-
-import com.netflix.config.DynamicPropertyFactory;
-
-@Component
-public class Log4JMetricsFileWriter implements MetricsFileWriter {
-  private static final String METRICS_FILE_ROLLING_MAX_FILE_COUNT = 
"servicecomb.metrics.file.rolling.max_file_count";
-
-  private static final String METRICS_FILE_ROLLING_MAX_FILE_SIZE = 
"servicecomb.metrics.file.rolling.max_file_size";
-
-  private static final String METRICS_FILE_ROOT_PATH = 
"servicecomb.metrics.file.root_path";
-
-
-  private final Map fileAppenders = new 
ConcurrentHashMapEx<>();
-
-  private final int maxFileCount;
-
-  private final String maxFileSize;
-
-  private final String rootPath;
-
-  public Log4JMetricsFileWriter() {
-maxFileCount = 
DynamicPropertyFactory.getInstance().getIntProperty(METRICS_FILE_ROLLING_MAX_FILE_COUNT,
 10).get();
-maxFileSize = DynamicPropertyFactory.getInstance()
-.getStringProperty(METRICS_FILE_ROLLING_MAX_FILE_SIZE, "10MB")
-.get();
-rootPath = 
DynamicPropertyFactory.getInstance().getStringProperty(METRICS_FILE_ROOT_PATH, 
"target").get();
-  }
-
-  @Override
-  public void write(String loggerName, String filePrefix, String content) {
-RollingFileAppender logger = fileAppenders.computeIfAbsent(loggerName, f 
-> 

[GitHub] coveralls commented on issue #639: [SCB-422] prometheus switch to new mechanism

[GitBox]

coveralls commented on issue #639: [SCB-422] prometheus switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#issuecomment-379563648
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16406707/badge)](https://coveralls.io/builds/16406707)
   
   Coverage increased (+0.07%) to 87.827% when pulling 
**702e18d6fa7a8bcad97b44b5ab07f708797726be on wujimin:metrics-prometheus** into 
**f65a9b3e21bbe7ac5dfaa90523b5bcc48a3d129d on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #635: [SCB-462] cloud eye publisher switch to new mechanism

[GitBox]

coveralls commented on issue #635: [SCB-462] cloud eye publisher switch to new 
mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#issuecomment-379478939
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16406396/badge)](https://coveralls.io/builds/16406396)
   
   Coverage decreased (-0.01%) to 87.597% when pulling 
**aab76a4510436fe08724287ab3b7dc8fcbd0d79f on wujimin:cloudeye-publisher** into 
**49d8249b90c5b303725def283b10b29cdb452f59 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #639: [SCB-422] prometheus switch to new mechanism

[GitBox]

wujimin opened a new pull request #639: [SCB-422] prometheus switch to new 
mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/639
 
 
   
![image](https://user-images.githubusercontent.com/16874843/38469195-56cbd4b0-3b83-11e8-90d9-8ed1cc627144.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin closed pull request #633: [SCB-422] Threadpool metrics

[GitBox]

wujimin closed pull request #633: [SCB-422] Threadpool metrics
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/633
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core/src/main/java/org/apache/servicecomb/core/BootListener.java 
b/core/src/main/java/org/apache/servicecomb/core/BootListener.java
index f6e50cc03..b3b875543 100644
--- a/core/src/main/java/org/apache/servicecomb/core/BootListener.java
+++ b/core/src/main/java/org/apache/servicecomb/core/BootListener.java
@@ -28,7 +28,9 @@
 BEFORE_TRANSPORT,
 AFTER_TRANSPORT,
 BEFORE_REGISTRY,
-AFTER_REGISTRY
+AFTER_REGISTRY,
+BEFORE_CLOSE,
+AFTER_CLOSE
   }
 
   class BootEvent {
diff --git 
a/core/src/main/java/org/apache/servicecomb/core/CseApplicationListener.java 
b/core/src/main/java/org/apache/servicecomb/core/CseApplicationListener.java
index 5cff9ca5e..4952f35f3 100644
--- a/core/src/main/java/org/apache/servicecomb/core/CseApplicationListener.java
+++ b/core/src/main/java/org/apache/servicecomb/core/CseApplicationListener.java
@@ -147,7 +147,9 @@ public void onApplicationEvent(ApplicationEvent event) {
   }
 } else if (event instanceof ContextClosedEvent) {
   LOGGER.warn("cse is closing now...");
+  triggerEvent(EventType.BEFORE_CLOSE);
   RegistryUtils.destroy();
+  triggerEvent(EventType.AFTER_CLOSE);
   isInit = false;
 }
   }
diff --git 
a/core/src/main/java/org/apache/servicecomb/core/executor/FixedThreadExecutor.java
 
b/core/src/main/java/org/apache/servicecomb/core/executor/FixedThreadExecutor.java
index e70cc1bd0..2600ebb53 100644
--- 
a/core/src/main/java/org/apache/servicecomb/core/executor/FixedThreadExecutor.java
+++ 
b/core/src/main/java/org/apache/servicecomb/core/executor/FixedThreadExecutor.java
@@ -58,6 +58,10 @@ public FixedThreadExecutor() {
 }
   }
 
+  public List getExecutorList() {
+return executorList;
+  }
+
   @Override
   public void execute(Runnable command) {
 long threadId = Thread.currentThread().getId();
diff --git 
a/core/src/test/java/org/apache/servicecomb/core/TestCseApplicationListener.java
 
b/core/src/test/java/org/apache/servicecomb/core/TestCseApplicationListener.java
index fb473b751..e5eaec84a 100644
--- 
a/core/src/test/java/org/apache/servicecomb/core/TestCseApplicationListener.java
+++ 
b/core/src/test/java/org/apache/servicecomb/core/TestCseApplicationListener.java
@@ -22,11 +22,17 @@
 import static org.mockito.Mockito.verify;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 
+import javax.xml.ws.Holder;
+
+import org.apache.commons.lang3.reflect.FieldUtils;
 import org.apache.servicecomb.core.BootListener.BootEvent;
+import org.apache.servicecomb.core.BootListener.EventType;
 import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
 import org.apache.servicecomb.core.endpoint.AbstractEndpointsCache;
 import org.apache.servicecomb.core.provider.consumer.ConsumerProviderManager;
@@ -39,6 +45,7 @@
 import org.apache.servicecomb.serviceregistry.RegistryUtils;
 import 
org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
 import 
org.apache.servicecomb.serviceregistry.task.MicroserviceInstanceRegisterTask;
+import org.hamcrest.Matchers;
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Assert;
@@ -53,6 +60,8 @@
 import mockit.Deencapsulation;
 import mockit.Expectations;
 import mockit.Injectable;
+import mockit.Mock;
+import mockit.MockUp;
 import mockit.Mocked;
 
 public class TestCseApplicationListener {
@@ -147,15 +156,26 @@ public void 
testCseApplicationListenerParentNotnull(@Injectable ContextRefreshed
   }
 
   @Test
-  public void testCseApplicationListenerShutdown(@Injectable 
ContextClosedEvent event,
-  @Mocked RegistryUtils ru) {
-new Expectations() {
-  {
-RegistryUtils.destroy();
+  public void testCseApplicationListenerShutdown(@Mocked ApplicationContext 
context) throws IllegalAccessException {
+Holder destroyHolder = new Holder<>();
+new MockUp() {
+  @Mock
+  void destroy() {
+destroyHolder.value = true;
   }
 };
 CseApplicationListener cal = new CseApplicationListener();
+ContextClosedEvent event = new ContextClosedEvent(context);
+
+List eventTypes = new ArrayList<>();
+BootListener bootListener = e -> {
+  eventTypes.add(e.getEventType());
+};
+FieldUtils.writeField(cal, "bootListenerList", 
Arrays.asList(bootListener), true);
 cal.onApplicationEvent(event);
+
+Assert.assertTrue(destroyHolder.value);
+Assert.assertThat(eventTypes, Matchers.contains(EventType.BEFORE_CLOSE, 

[GitHub] wujimin commented on a change in pull request #635: [SCB-462] cloud eye publisher switch to new mechanism

[GitBox]

wujimin commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179950917
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   stupid mistake
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [Discussion]Provider a project fully show all features of ServiceComb(also can use as a scaffold)

[Willem Jiang]

I just went through the documents, it looks good.
Here are some comments for the edge service part.
For the canary test, we need to make sure the new version of service is
available to some kind of user, not the normal round robin one.
Is better to show the user to do AB test by applying different routing rule
on the edge service.


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Apr 4, 2018 at 10:06 AM, 郑扬勇  wrote:

> Hi everyone:
> In order to fully show features of ServiceComb, I think we can use it
> to construct a classic micro-service style project step by step (also can
> called hand by hand) :
>  1. Use ServiceCenter to support services register and discover;
> 2. Includes edge service, user service with authentication and some other
> business services develped by Java Chassis;
> 3. Use Apollo to support dynamic config;
> 4. Include a composite service to do complex business logic;
> 5. In composite service we will use Saga to show eventually data
> consistency solution;
> 6. Show logs, metrics, tracing etc in operation phase.
>
>  Each small step of the construction will check a branch and write a
> wiki to let user known what we had done, like:
> 0.0.1 -> 1. Implement user service
> 0.0.2 -> 2. Add authentication in user service
> 0.0.3 -> 3. Implement edge service
> ...
>
>  Then user can learn how to develop with ServiceComb faster, and can
> use this project as a scaffold.
>
>  I had complete a small part of this program here :
> https://github.com/zhengyangyong/scaffold/wiki (English version is coming
> soon).
>
>  Any other ideas or suggestions are welcome !
>
>  Yangyong Zheng
>  Best Regards !

Re: [VOTE] Holding Apache ServiceComb (incubating) Meetup Hosted by Huawei Cloud as a Co-located Event in LC3 2018 Aisa

[Willem Jiang]

+1 （Binding）


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
  http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Sun, Apr 8, 2018 at 3:40 PM, Zen Lin  wrote:

> Hi All,
> This is a call for Vote to hold Apache ServiceComb (incubating) Meetup
> Hosted by Huawei Cloud as a Co-located Event in LC3 2018 Aisa.
>
> As discussed in the meetup propersal[1], we have plan to hold Apache
> ServiceComb (incubating) Mini Meetup, details are listed bellow,
>
>
>- What is the topic focus of the event?
>
> Topics are focused on user-pratices/technologies/ecosystem of Apache
> ServiceComb (incubating)
>
>- Who is organising the event?
>
> PMCs of ServiceComb (incubating) are the organizer
>
>- When is the event?
>
>  one day Between Jun 25, 2018 and Jun 27, 2018, maybe in Jun 26, 2018
>
>- How many attendees are expected?
>
> 60~100
>
>- How much PMC involvement is there already?
>
> 5
>
>- Which marks are requested?
>
> Two marks are requested,
> 1. Name of "Apache ServiceComb Incubating Meetup Hosted by Huawei Cloud"
> 2. "Powered By" Apache Incubator logo of Apache ServiceComb (incubating)
>
>- Is this for profit or non-profit? (See "Event Profits And Donations")?
>
> non-profit.
>
>
>
> [1]  https://www.mail-archive.com/dev@servicecomb.apache.org/msg03298.html
>

Re: Request the permissions of using name and logo of ServiceComb in the Meetup

[Kevin A. McGrail]

Happy to help.

On Sun, Apr 8, 2018, 02:50 Zen Lin  wrote:

> Hi Sally, Kevin,
>
> I am going to have a fromal vote email to get approval of PMCs, and then to
> get permissions from VP and Brand Management.
>
> Thanks for your help.
>
> 2018-04-04 18:17 GMT+08:00 Sally Khudairi :
>
> > Thank you, Zen. The logo is fine. You are good to go.
> >
> > --Sally
> >
> > [from the mobile; kindly forgive typos, brevity]
> >
> > On Wed, Apr 4, 2018 at 0:43, Sally Khudairi
> >  wrote:
> > Thank you, Zen. Yes, I will be happy to check the images when I am back
> in
> > the office later today.
> >
> > Kind regards,
> > Sally
> >
> > [from the mobile; kindly forgive typos, brevity]
> >
> > On Wed, Apr 4, 2018 at 0:29, Zen Lin
> >  wrote:
> > Hi Sally, thanks, it is so nice of you to give the instructions.
> >
> > The "Powered By" image is just have been designed yesterday after I gone
> > through the  doc of press-kit[1].
> > We still have not updated to the Servicecomb website[2] because it has
> not
> > been checked by ASF Marketing & Publicity.
> >
> > I just shared the images google drive through your email, could you help
> > to do a check about wheather the image is specific to the Apache
> Incubator
> > press-kit[1]?
> >
> >
> >
> >
> > [1] https://incubator.apache.org/ guides/press-kit.html
> > 
> > [2]  http://servicecomb.incubator.apache.org/
> >
> >
> > Zen Lin
> >
> > 2018-04-03 19:31 GMT+08:00 Sally Khudairi :
> >
> > Thank you, Zen. I appreciate your reaching out.
> >
> > Overall, this looks fine. We will also need signoff from ASF Brand
> > Management (tradema...@apache.org). I've copied them here for
> > their review.
> > Also, please ensure that the "Powered By" images are specific to the
> > Apache Incubator https://incubator.apache.org/ guides/press-kit.html
> >  :-)
> > Please let me know once you have signoff and I'll be happy to add the
> > event to the "Community Notices" section of the Apache Weekly News Round-
> > ups https://blogs.apache.org/ foundation/entry/the-apache-
> news-round-up64
> > 
> > Warm regards,
> > Sally
> >
> > - - -
> > Vice President Marketing & Publicity
> > The Apache Software Foundation
> >
> > Tel +1 617 921 8656
> > Skype sallykhudairi
> >
> >
> > On Tue, Apr 3, 2018, at 01:16, Zen Lin wrote:
> > > Hi ASF Marketing & Publicity,
> > >
> > > In order to promote ServiceComb and its community, ServiceComb are
> > > planning to hold a mini meetup as a Co-located Event in LC3 2018 Asia.>
> > > The Proposal for holding the mini meetup have been approved with the
> > > PMCs of ServiceComb [1] .>
> > > I have gone through the docs of  Approval of small Apache-related
> > > events[2] and   Apache branding rules[3], this mail is to describe
> > > some details of the planning event and ask for using the name logo of
> > > Apache ServiceComb(incubating) in the event. Further advices are
> > > welcomed.>
> > > Some details of the idea/plan,
> > > 1. Name of the event: Apache ServiceComb(incubating) Meetup
> > >Hosted/Presented by Huawei  PaaS> 2. Event organizer: PMCs of
> > ServiceComb project
> > > 3. Estimated attendees: 60~100
> > > 4. Where/When/How: As a Co-located Event in LC3 Asia, June 25-27,
> > >2018, China National Convention Center, Beijing, China> 5. Possible
> > topics: user pratices/technologies/ ecosystem sharing
> > >
> > > We are requsting two permissions,
> > > 1. Use the name of "Apache ServiceComb Incubating Meetup
> > >Hosted/Supported by Huawei PaaS"> 2. Use the "Powered By" Apache
> > Incubator logo of ServiceComb.
> > >
> > >
> > > [1] https://www.mail-archive.com/ dev@servicecomb.apache.org/
> > msg03298.html
> > >
> > [2] http://community.apache.org/ events/small-events.html
> > 
> > > [3] http://www.apache.org/ foundation/marks/events.html
> > 
> > >
> > >
> > >
> > > Thanks very much,
> > >
> > > Zen Lin
> >
> >
> >
>

[GitHub] liubao68 commented on a change in pull request #635: [SCB-462] cloud eye publisher switch to new mechanism

[GitBox]

liubao68 commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179944492
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   I think this test case can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #635: [SCB-462] cloud eye publisher switch to new mechanism

[GitBox]

liubao68 commented on a change in pull request #635: [SCB-462] cloud eye 
publisher switch to new mechanism
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/635#discussion_r179944492
 
 

 ##
 File path: 
samples/metrics-write-file-sample/metrics-write-file/src/main/java/org/apache/servicecomb/samples/mwf/CloudEyeMetricModel.java
 ##
 @@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.samples.mwf;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.foundation.common.utils.JsonUtils;
+
+import com.fasterxml.jackson.annotation.JsonAnyGetter;
+import com.fasterxml.jackson.annotation.JsonAnySetter;
+
+public class CloudEyeMetricModel {
+  private String node;
+
+  private String scope_name;
+
+  private long timestamp;
+
+  private String inface_name;
+
+  @JsonAnySetter
+  private Map dynamicValue = new HashMap<>();
+
+  public String getNode() {
+return node;
+  }
+
+  public void setNode(String node) {
+this.node = node;
+  }
+
+  public String getScope_name() {
+return scope_name;
+  }
+
+  public void setScope_name(String scope_name) {
+this.scope_name = scope_name;
+  }
+
+  public long getTimestamp() {
+return timestamp;
+  }
+
+  public void setTimestamp(long timestamp) {
+this.timestamp = timestamp;
+  }
+
+  public String getInface_name() {
+return inface_name;
+  }
+
+  public void setInface_name(String inface_name) {
+this.inface_name = inface_name;
+  }
+
+  @JsonAnyGetter
+  public Map getDynamicValue() {
+return dynamicValue;
+  }
+
+  public void setDynamicValue(Map dynamicValue) {
+this.dynamicValue = dynamicValue;
+  }
+
+  public static void main(String[] args) throws IOException {
 
 Review comment:
   I think this main class can be removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 opened a new issue #324: sc front end service name is not correct

[GitBox]

liubao68 opened a new issue #324: sc front end service name is not correct
URL: https://github.com/apache/incubator-servicecomb-service-center/issues/324
 
 
   service name is case sensitive, but sc front end will rename the first 
letter to upper case. this is quit confusing. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics

[GitBox]

wujimin commented on a change in pull request #633: [SCB-422] Threadpool metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179941587
 
 

 ##
 File path: 
metrics/metrics-core/src/main/java/com/netflix/spectator/api/patterns/ThreadPoolMonitorPublishModelFactory.java
 ##
 @@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.netflix.spectator.api.patterns;
 
 Review comment:
   yes
   ThreadPoolMonitor.TASK_COUNT and so on, is package visible


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #629: fix typo change swagger to hystrix

[GitBox]

liubao68 commented on issue #629: fix typo change swagger to hystrix
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/629#issuecomment-379535277
 
 
   Close as merged in 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/638


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 closed pull request #629: fix typo change swagger to hystrix

[GitBox]

liubao68 closed pull request #629: fix typo change swagger to hystrix
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/629
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/LICENSE b/LICENSE
index 5a4a4f2a4..435198809 100644
--- a/LICENSE
+++ b/LICENSE
@@ -220,11 +220,11 @@ For details, see https://github.com/vert-x3/vertx-web
 
 For 
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/extend/property/AbstractBaseIntegerProperty.java
 
-This product bundles files from swagger which is licensed under the Apache 
License v2.
+This product bundles files from hystrix which is licensed under the Apache 
License v2.
 For details, see https://github.com/swagger-api/swagger-core
 
 
 For 
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java
 
 This product bundles files from swagger which is licensed under the Apache 
License v2.
-For details, see  https://github.com/Netflix/Hystrix
\ No newline at end of file
+For details, see  https://github.com/Netflix/Hystrix


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 closed pull request #630: [SCB-444]try to optimize autoDiscovery function

[GitBox]

liubao68 closed pull request #630: [SCB-444]try to optimize autoDiscovery 
function
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/630
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
index b3bb4617d..0d5db0a6b 100644
--- 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
+++ 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
@@ -50,6 +50,12 @@
 
   private boolean autoDiscoveryInited = false;
 
+  private int maxRetryTimes;
+
+  public int getMaxRetryTimes() {
+return maxRetryTimes;
+  }
+
   public IpPortManager(ServiceRegistryConfig serviceRegistryConfig, 
InstanceCacheManager instanceCacheManager) {
 this.serviceRegistryConfig = serviceRegistryConfig;
 this.instanceCacheManager = instanceCacheManager;
@@ -61,6 +67,7 @@ public IpPortManager(ServiceRegistryConfig 
serviceRegistryConfig, InstanceCacheM
 }
 int initialIndex = new Random().nextInt(defaultIpPort.size());
 currentAvailableIndex = new AtomicInteger(initialIndex);
+maxRetryTimes = defaultIpPort.size();
   }
 
   // we have to do this operation after the first time setup has already done
@@ -98,6 +105,7 @@ private IpPort getAvailableAddress(int index) {
   currentAvailableIndex.set(0);
   return defaultIpPort.get(0);
 }
+maxRetryTimes = defaultIpPort.size() + endpoints.size();
 CacheEndpoint nextEndpoint = endpoints.get(index - defaultIpPort.size());
 return new URIEndpointObject(nextEndpoint.getEndpoint());
   }
diff --git 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RequestContext.java
 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RequestContext.java
index dbc5e5581..91c858da6 100644
--- 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RequestContext.java
+++ 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/RequestContext.java
@@ -33,8 +33,7 @@
 
   private RequestParam params;
 
-  // we can set max retry policies, now only try it twice
-  private boolean retry;
+  private int retryTimes = 0;
 
   public IpPort getIpPort() {
 return ipPort;
@@ -68,11 +67,12 @@ public void setParams(RequestParam params) {
 this.params = params;
   }
 
-  public boolean isRetry() {
-return retry;
+
+  public int getRetryTimes() {
+return retryTimes;
   }
 
-  public void setRetry(boolean retry) {
-this.retry = retry;
+  public void incrementRetryTimes() {
+++this.retryTimes;
   }
 }
diff --git 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
index ab7f59751..6173a1725 100644
--- 
a/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
+++ 
b/service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
@@ -85,7 +85,7 @@ public void init() {
   private void retry(RequestContext requestContext, Handler 
responseHandler) {
 LOGGER.warn("invoke service [{}] failed, retry.", requestContext.getUri());
 
requestContext.setIpPort(ipPortManager.getNextAvailableAddress(requestContext.getIpPort()));
-requestContext.setRetry(true);
+requestContext.incrementRetryTimes();
 RestUtils.httpDo(requestContext, responseHandler);
   }
 
@@ -98,7 +98,7 @@ private void retry(RequestContext requestContext, 
Handler response
   HttpClientResponse response = restResponse.getResponse();
   if (response == null) {
 // 请求失败，触发请求SC的其他实例
-if (!requestContext.isRetry()) {
+if (requestContext.getRetryTimes() <= 
ipPortManager.getMaxRetryTimes()) {
   retry(requestContext, syncHandler(countDownLatch, cls, holder));
 } else {
   countDownLatch.countDown();
@@ -150,7 +150,7 @@ private void retry(RequestContext requestContext, 
Handler response
   HttpClientResponse response = restResponse.getResponse();
   if (response == null) {
 // 请求失败，触发请求SC的其他实例
-if (!requestContext.isRetry()) {
+if (requestContext.getRetryTimes() <= 
ipPortManager.getMaxRetryTimes()) {
   retry(requestContext, syncHandlerEx(countDownLatch, holder));
 } else {
   countDownLatch.countDown();
@@ -176,7 +176,7 @@ private void 

[GitHub] liubao68 closed pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

liubao68 closed pull request #636: SCB-189 fix CI problems and warnings for 
feature support async restTe…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/636
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/archetypes/business-service-jaxrs/src/main/java/org/apache/servicecomb/archetypes/HelloConsumer.java
 
b/archetypes/business-service-jaxrs/src/main/java/org/apache/servicecomb/archetypes/HelloConsumer.java
index 7007c1188..e1113838e 100644
--- 
a/archetypes/business-service-jaxrs/src/main/java/org/apache/servicecomb/archetypes/HelloConsumer.java
+++ 
b/archetypes/business-service-jaxrs/src/main/java/org/apache/servicecomb/archetypes/HelloConsumer.java
@@ -24,7 +24,7 @@
   private final RestTemplate restTemplate = RestTemplateBuilder.create();
 
   public void invokeHello(){
-String result = restTemplate.getForObject("cse://business-service/hello", 
String.class);
+restTemplate.getForObject("cse://business-service/hello", String.class);
   }
 
 }
diff --git 
a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
 
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
index 1be86dc88..d66a0c639 100644
--- 
a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
+++ 
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequest.java
@@ -50,12 +50,11 @@ public OutputStream getBody() {
 return null;
   }
 
-  @SuppressWarnings("unchecked")
   private ListenableFuture invoke(Object[] args) {
 Invocation invocation = prepareInvocation(args);
 invocation.getHandlerContext().put(RestConst.CONSUMER_HEADER, 
this.getHeaders());
 CompletableFuture clientHttpResponseCompletableFuture 
= doAsyncInvoke(invocation);
-return new 
CompletableToListenableFutureAdapter(clientHttpResponseCompletableFuture);
+return new 
CompletableToListenableFutureAdapter(clientHttpResponseCompletableFuture);
   }
 
   protected CompletableFuture doAsyncInvoke(Invocation 
invocation) {
diff --git 
a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
 
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
index 6f16f997e..4bf1ba50d 100644
--- 
a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
+++ 
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRestTemplate.java
@@ -34,14 +34,12 @@ public CseAsyncRestTemplate() {
   }
 
   @Override
-  @SuppressWarnings("unchecked")
   protected  AsyncRequestCallback httpEntityCallback(HttpEntity 
requestBody) {
-return new CseAsyncRequestCallback(requestBody);
+return new CseAsyncRequestCallback(requestBody);
   }
 
   @Override
-  @SuppressWarnings("unchecked")
   protected  AsyncRequestCallback httpEntityCallback(HttpEntity 
requestBody, Type responseType) {
-return new CseAsyncRequestCallback(requestBody);
+return new CseAsyncRequestCallback(requestBody);
   }
 }
\ No newline at end of file
diff --git 
a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
 
b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
index 4ae2bc703..35388cc7a 100644
--- 
a/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
+++ 
b/providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
@@ -59,10 +59,10 @@ public void teardown() {
 ReferenceConfigUtils.setReady(false);
   }
 
-  @RequestMapping(path = "SpringmvcImpl")
-  static class SpringmvcImpl {
-@RequestMapping(path = "/bytes", method = RequestMethod.POST)
-public byte[] bytes(@RequestBody byte[] input) {
+  @RequestMapping(path = "CseAsyncClientHttpRequestTestSchema")
+  static class CseAsyncClientHttpRequestTestSchema {
+@RequestMapping(path = "/testbytes", method = RequestMethod.POST)
+public byte[] testbytes(@RequestBody byte[] input) {
   input[0] = (byte) (input[0] + 1);
   return input;
 }
@@ -89,17 +89,18 @@ public void testNormal() {
 serviceRegistry.init();
 

[GitHub] liubao68 closed pull request #638: [SCB-449] Fix typo in LICENSE files

[GitBox]

liubao68 closed pull request #638: [SCB-449] Fix typo in LICENSE files
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/638
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/LICENSE b/LICENSE
index 5a4a4f2a4..c75dbb5b5 100644
--- a/LICENSE
+++ b/LICENSE
@@ -226,5 +226,5 @@ For details, see https://github.com/swagger-api/swagger-core
 
 For 
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java
 
-This product bundles files from swagger which is licensed under the Apache 
License v2.
-For details, see  https://github.com/Netflix/Hystrix
\ No newline at end of file
+This product bundles files from Hystrix which is licensed under the Apache 
License v2.
+For details, see  https://github.com/Netflix/Hystrix
diff --git a/java-chassis-distribution/src/release/LICENSE 
b/java-chassis-distribution/src/release/LICENSE
index 8243952fa..39470791b 100644
--- a/java-chassis-distribution/src/release/LICENSE
+++ b/java-chassis-distribution/src/release/LICENSE
@@ -212,7 +212,7 @@ following licenses.
 
 For Stax2 API org.codehaus.woodstox:stax2-api:bundle:3.1.4
 
-This product bundles files from swagger which is licensed under the
+This product bundles files from stax2 which is licensed under the
 2-Clause BSD license.
 For details, see http://wiki.fasterxml.com/WoodstoxStax2
 You can find a copy of the License at licenses/LICENSE-woodstox-stax2-api
@@ -319,7 +319,7 @@ For details, see https://github.com/swagger-api/swagger-core
 
 For 
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/HystrixCommandPropertiesExt.java
 
-This product bundles files from swagger which is licensed under the Apache 
License v2.
+This product bundles files from Hystrix which is licensed under the Apache 
License v2.
 For details, see https://github.com/Netflix/Hystrix
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #633: [SCB-422] Threadpool metrics

[GitBox]

liubao68 commented on a change in pull request #633: [SCB-422] Threadpool 
metrics
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179940415
 
 

 ##
 File path: 
metrics/metrics-core/src/main/java/com/netflix/spectator/api/patterns/ThreadPoolMonitorPublishModelFactory.java
 ##
 @@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.netflix.spectator.api.patterns;
 
 Review comment:
   Why add this package? Access package visible variables ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems 
and warnings for feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179939355
 
 

 ##
 File path: 
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
 ##
 @@ -61,8 +61,8 @@ public void teardown() {
 
   @RequestMapping(path = "SpringmvcImpl")
   static class SpringmvcImpl {
 
 Review comment:
   Agree, change class name would be easier.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

lijasonvip commented on a change in pull request #636: SCB-189 fix CI problems 
and warnings for feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179939180
 
 

 ##
 File path: 
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRequestCallbackTest.java
 ##
 @@ -28,27 +28,24 @@
   @Test
   public void testNormal() {
 CseAsyncClientHttpRequest request = new CseAsyncClientHttpRequest();
-@SuppressWarnings("unchecked")
-CseAsyncRequestCallback cb = new CseAsyncRequestCallback(null);
+CseAsyncRequestCallback cb = new 
CseAsyncRequestCallback(null);
 
 Review comment:
   As HttpEntity is still a raw type here, this could cause a warning again.
   how about `CseAsyncRequestCallback cb = new 
CseAsyncRequestCallback<>(null);`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor opened a new pull request #638: [SCB-449] Fix typo in LICENSE files

[GitBox]

yangbor opened a new pull request #638: [SCB-449] Fix typo in LICENSE files
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/638
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

coveralls commented on issue #636: SCB-189 fix CI problems and warnings for 
feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#issuecomment-379521919
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16403898/badge)](https://coveralls.io/builds/16403898)
   
   Coverage decreased (-0.006%) to 87.6% when pulling 
**cb5689963c1f9ceea533771230d4d7f9d98a9af9 on lijasonvip:scb-189** into 
**8a77e34365e786462b74826c724d10f0e735d5fe on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

wujimin commented on a change in pull request #636: SCB-189 fix CI problems and 
warnings for feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179938700
 
 

 ##
 File path: 
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncClientHttpRequestTest.java
 ##
 @@ -61,8 +61,8 @@ public void teardown() {
 
   @RequestMapping(path = "SpringmvcImpl")
   static class SpringmvcImpl {
 
 Review comment:
   why not just change "SpringmvcImpl" to "CseAsyncClientHttpRequestTestSchema"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[VOTE] Holding Apache ServiceComb (incubating) Meetup Hosted by Huawei Cloud as a Co-located Event in LC3 2018 Aisa

[Zen Lin]

Hi All,
This is a call for Vote to hold Apache ServiceComb (incubating) Meetup
Hosted by Huawei Cloud as a Co-located Event in LC3 2018 Aisa.

As discussed in the meetup propersal[1], we have plan to hold Apache
ServiceComb (incubating) Mini Meetup, details are listed bellow,


   - What is the topic focus of the event?

Topics are focused on user-pratices/technologies/ecosystem of Apache
ServiceComb (incubating)

   - Who is organising the event?

PMCs of ServiceComb (incubating) are the organizer

   - When is the event?

 one day Between Jun 25, 2018 and Jun 27, 2018, maybe in Jun 26, 2018

   - How many attendees are expected?

60~100

   - How much PMC involvement is there already?

5

   - Which marks are requested?

Two marks are requested,
1. Name of "Apache ServiceComb Incubating Meetup Hosted by Huawei Cloud"
2. "Powered By" Apache Incubator logo of Apache ServiceComb (incubating)

   - Is this for profit or non-profit? (See "Event Profits And Donations")?

non-profit.



[1]  https://www.mail-archive.com/dev@servicecomb.apache.org/msg03298.html

[GitHub] wujimin commented on a change in pull request #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

wujimin commented on a change in pull request #636: SCB-189 fix CI problems and 
warnings for feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#discussion_r179938611
 
 

 ##
 File path: 
providers/provider-springmvc/src/test/java/org/apache/servicecomb/provider/springmvc/reference/async/CseAsyncRequestCallbackTest.java
 ##
 @@ -28,27 +28,24 @@
   @Test
   public void testNormal() {
 CseAsyncClientHttpRequest request = new CseAsyncClientHttpRequest();
-@SuppressWarnings("unchecked")
-CseAsyncRequestCallback cb = new CseAsyncRequestCallback(null);
+CseAsyncRequestCallback cb = new 
CseAsyncRequestCallback(null);
 
 Review comment:
   CseAsyncRequestCallback cb = new 
CseAsyncRequestCallback<>(null);


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lijasonvip commented on issue #636: SCB-189 fix CI problems and warnings for feature support async restTe…

[GitBox]

lijasonvip commented on issue #636: SCB-189 fix CI problems and warnings for 
feature support async restTe…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/636#issuecomment-379526718
 
 
   ![no 
problems](https://user-images.githubusercontent.com/11032245/38464353-1f871c60-3b3f-11e8-92d4-f79f1d4c52c8.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services