Re: [Discuss] sharding-orchestration module reconstruction

2019-12-12 Thread guangyuan wang
Yes. We could discuss step 2 at this email. And I think after we remove the old modules, errors will happen in callers. I could fix the errors by using new modules. sunbufu 于2019年12月12日周四 下午6:30写道: > I misunderstood the meaning of yuan in last email. But after communicating > with yuan on

Re: [Discuss] sharding-orchestration module reconstruction

2019-12-12 Thread sunbufu
I misunderstood the meaning of yuan in last email. But after communicating with yuan on WeChat, we get a tentative agreement want to discuss with you . We need 2 main steps to do in reconstruct orchestration module. # 1 Replace old orchestration module with new orchestration module. ## 1.1

Re: [Discuss] sharding-orchestration module reconstruction

2019-12-11 Thread Juan Pan
Take it easy. And FYI, maybe we could modify the internal of orchestration without changing API of orchestration. When the refactoring of orchestration finishes, API changes and behavior changes of callers comes. Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On

Re: [Discuss] sharding-orchestration module reconstruction

2019-12-11 Thread sunbufu
I think this maybe not so hard, we can do this like follow. 1. Remove the old modules. 2. Rename the new modules. 3. Modify references we can easy find. 4.Follow the error lead. — Haisheng Sun (sunbufu) Apache ShardingSphere On 12/11/2019 16:14,guangyuan wang wrote: The modifications

Re: [Discuss] sharding-orchestration module reconstruction

2019-12-11 Thread guangyuan wang
The modifications in sharding-orchestration are: 1. The RegistryCenter is changed to split into 3 interfaces: ConfigCenter, Registry Center, DistributedLockManagement. 2. The related implementation class is changed and initialization is changed. These changes mean the sharding-orchestration module

Re:[Discuss] sharding-orchestration module reconstruction

2019-12-11 Thread Juan Pan
Hi Yuan, I’d like to join in discussion, however i have no idea about what is going now, could you draft a workflow or schedule to give us a basic understanding about it. Based on that, maybe others could give some great suggestion or idea. Juan Pan panj...@apache.org Juan Pan(Trista),

[Discuss] sharding-orchestration module reconstruction

2019-12-10 Thread guangyuan wang
Hello everyone I'd like to reconstruct the sharding-orchestration module. So far as, we have develop a new sharding-orchestration-center module and sharding-orchestration-core-new module. I'd like to use them to replace the old ones. But It's really huge engineering. So I'd like to discuss the