Thanks,
I'm quite interested in this, but not only for entering and exiting but
eventually for other logging as well. However, I wouldn't want it in
all classes. I'd prefer to see additional configuration to define which
classes should be instrumented.
Also, once the logging is injected
Author: ceki
Date: Thu Oct 2 17:08:15 2008
New Revision: 1158
Modified:
slf4j/trunk/slf4j-api/src/main/java/org/slf4j/spi/LocationAwareLogger.java
Log:
- minor javadoc fix
Modified:
slf4j/trunk/slf4j-api/src/main/java/org/slf4j/spi/LocationAwareLogger.java
Author: ceki
Date: Thu Oct 2 17:10:19 2008
New Revision: 1159
Modified:
slf4j/trunk/jcl-over-slf4j/src/main/java/org/apache/commons/logging/Log.java
Log:
- minor javadoc fix
- noting that jcl-over-slf4j is compatible with JCL 1.1.1
Modified:
Author: ceki
Date: Thu Oct 2 17:11:58 2008
New Revision: 1161
Modified:
slf4j/trunk/slf4j-api/pom.xml
Log:
- clirr compatibility report should be with respect to 1.5.3
Modified: slf4j/trunk/slf4j-api/pom.xml
==
---
Author: ceki
Date: Thu Oct 2 17:38:39 2008
New Revision: 1163
Added:
slf4j/trunk/slf4j-ext/src/test/java/org/slf4j/ext/ListAppender.java
Modified:
slf4j/trunk/slf4j-ext/src/test/java/org/slf4j/ext/XLoggerTest.java
Log:
- adding test cases as requested by Raph Goers in bug 104
This is an
Author: ceki
Date: Thu Oct 2 18:09:45 2008
New Revision: 1164
Added:
slf4j/trunk/slf4j-ext/src/test/java/org/slf4j/dummyExt/
- copied from r1157, /slf4j/trunk/slf4j-ext/src/test/java/org/slf4j/ext/
slf4j/trunk/slf4j-ext/src/test/java/org/slf4j/dummyExt/ListAppender.java
-
http://bugzilla.slf4j.org/show_bug.cgi?id=104
--- Comment #8 from Ceki Gulcu [EMAIL PROTECTED] 2008-10-02 18:15:35 ---
Added appropriate test cases which were useful enough to catch a bug.
On a related note, Ralph, have you noticed that the dump() method is not part
of XLogger?
--
Hello Ralph,
As you are the driving force behind XLogger would you mind adding a
documentation about XLogger? The extensions.html page would be a good place.
BTW, since you have filed an ICLA, should we create a user for you in SVN?
Cheers,
Ralph Goers wrote:
I'm posting this to the dev
Author: ceki
Date: Thu Oct 2 20:14:25 2008
New Revision: 1165
Added:
slf4j/trunk/binderVersion.pl
Modified:
slf4j/trunk/goVersion.sh
slf4j/trunk/version.pl
Log:
- a perl script to edit the version number of StaticLoggerBinder.java files
This is used for version checking done by
Author: ceki
Date: Thu Oct 2 20:44:12 2008
New Revision: 1167
Modified:
slf4j/trunk/goVersion.sh
slf4j/trunk/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java
slf4j/trunk/slf4j-ext/pom.xml
Log:
- Adding version check support in each slf4j-binding
Each copy of
Thorbjørn Ravn Andersen wrote:
I'm trying to get unit tests up and running in Maven for the agent, but
I am unfamiliar with the Maven way of doing things, so I'd appreciate
some comments.
I've figured out how to use the argLine tag to get -javaagent:foobar
put in the right place of
Author: ravn
Date: Thu Oct 2 21:11:01 2008
New Revision: 1168
Modified:
slf4j/trunk/slf4j-ext/pom.xml
Log:
cannot test the resulting jar yet.
Modified: slf4j/trunk/slf4j-ext/pom.xml
==
---
Thorbjørn Ravn Andersen wrote:
Ralph Goers skrev:
Thanks,
I'm quite interested in this, but not only for entering and exiting but
eventually for other logging as well. However, I wouldn't want it in
all classes. I'd prefer to see additional configuration to define which
classes
[EMAIL PROTECTED] skrev:
Author: ceki
Date: Thu Oct 2 20:14:25 2008
New Revision: 1165
Added:
slf4j/trunk/binderVersion.pl
Modified:
slf4j/trunk/goVersion.sh
slf4j/trunk/version.pl
Log:
- a perl script to edit the version number of StaticLoggerBinder.java files
This is
Thorbjørn Ravn Andersen wrote:
I read up a bit on this. It appears that maven-surefire-plugin cannot
both do unit tests and integration tests in the same life cycle (as far
as I understood).
Oh the joy of other peoples tools :)
Maven is far from perfect.
On a related note, the
Thorbjørn Ravn Andersen wrote:
Any particular reason you wrote a Perl script instead of using the Ant
Replace task?
Here is the rationale. As the release manager, I am the only one who runs the
script. The Ant equivalent of the script would not gain much except the
dependency on Perl
Ceki Gulcu skrev:
Thorbjørn Ravn Andersen wrote:
Any particular reason you wrote a Perl script instead of using the Ant
Replace task?
Here is the rationale. As the release manager, I am the only one who runs the
script. The Ant equivalent of the script would not
Thorbjørn Ravn Andersen wrote:
Ceki Gulcu skrev:
Does _log field refers to a logger named after the containing class? If so,
you
could enable/disable logging for each java class separately using the
configuration mechanism provided in log4j/jul/logback. In other words,
additional
Ceki Gulcu skrev:
Thorbjørn Ravn Andersen wrote:
I read up a bit on this. It appears that maven-surefire-plugin cannot
both do unit tests and integration tests in the same life cycle (as far
as I understood).
Oh the joy of other peoples tools :)
Maven is far from perfect.
Ceki Gulcu skrev:
Actually in the article I used the INFO level as it is the lowest level
printed out by j.u.l without a configuration file. I think it would be
a valid default level to keep the entry barrier as low as possible, and
then have a level keyword to the agent to override this.
Thorbjørn Ravn Andersen wrote:
Frankly I just want to know to know when I was (one of the) responsible
for the build breaking and when it was ok again.
If the problem persists we'll tackle it.
Also it confused me a bit in the beginning to see stack traces in the
maven output, but
Author: ceki
Date: Thu Oct 2 23:05:01 2008
New Revision: 1169
Modified:
slf4j/trunk/slf4j-jdk14/src/test/java/org/slf4j/InvocationTest.java
Log:
keep JDK logging quite during tests...
Modified: slf4j/trunk/slf4j-jdk14/src/test/java/org/slf4j/InvocationTest.java
Author: ceki
Date: Thu Oct 2 23:08:48 2008
New Revision: 1170
Modified:
slf4j/trunk/jcl-over-slf4j/pom.xml
slf4j/trunk/jcl-over-slf4j/src/test/java/org/apache/commons/logging/InvokeJCLTest.java
Log:
keep tests silent...
Modified: slf4j/trunk/jcl-over-slf4j/pom.xml
Author: ceki
Date: Thu Oct 2 23:15:06 2008
New Revision: 1171
Modified:
slf4j/trunk/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java
Log:
- keep tests quiet
- fixed bug in version check code
Modified: slf4j/trunk/slf4j-api/src/main/java/org/slf4j/LoggerFactory.java
Author: ceki
Date: Thu Oct 2 23:15:07 2008
New Revision: 1172
Modified:
slf4j/trunk/slf4j-jcl/src/test/java/org/slf4j/InvocationTest.java
Log:
- keep tests quiet
- fixed bug in version check code
Modified: slf4j/trunk/slf4j-jcl/src/test/java/org/slf4j/InvocationTest.java
Author: ceki
Date: Thu Oct 2 23:31:23 2008
New Revision: 1173
Added:
slf4j/trunk/slf4j-simple/src/test/java/org/slf4j/SilentPrintStream.java
Modified:
slf4j/trunk/slf4j-simple/src/test/java/org/slf4j/InvocationTest.java
Log:
keep slfj-simple tests silent as well...
Modified:
Hello all,
Thorbjørn has observed that slf4j test spewed a lot of garbage on the console.
I
just modified the various tests so that the unit test are silent. This has been
done by
- In slf4j-jdk14, setting the level of the root logger to OFF
- In jcl-over-slf4j, replacing slf4j-simple by
I assume that would give me rights to commit? That would be great.
I'd be happy to write some documentation on XLogger.
Ceki Gulcu wrote:
Hello Ralph,
As you are the driving force behind XLogger would you mind adding a
documentation about XLogger? The extensions.html page would be a good
Thorbjørn Ravn Andersen wrote:
I read up a bit on this. It appears that maven-surefire-plugin cannot
both do unit tests and integration tests in the same life cycle (as far
as I understood).
Actually you can. I've done it. I'll dig around and find an example of
how to do it.
Ralph
Ceki Gulcu wrote:
logging for the entire class. Had you used markers, one could enable/disable
entry/exit logging without necessarily affecting logging in the rest of the
containing class. By the way, XLogger.enter() and exit() methods use the
appropriate markers.
I mentioned this as
http://bugzilla.slf4j.org/show_bug.cgi?id=104
--- Comment #9 from Ralph Goers [EMAIL PROTECTED] 2008-10-03 07:55:18 ---
Yes, I noticed that dump wasn't added when you created it. I assumed you had a
good reason for not adding it. Although it isn't as critical to me as the other
methods it is
31 matches
Mail list logo