Any comments ... which approach to take?
Chetan Mehrotra
On Sat, Jan 25, 2014 at 12:59 PM, Chetan Mehrotra
chetan.mehro...@gmail.com wrote:
Yes such a situation might occur. Some approaches I can think of are
1. Special case Log bundles when installing bundle in
BootstrapInstaller. So in the
[
https://issues.apache.org/jira/browse/SLING-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885143#comment-13885143
]
Chetan Mehrotra commented on SLING-3344:
While we are at it ... should we export
Hi,
Is it possible, in code running in a bundle, to detect if the OSGi
container has a classloader that is being pinned and should have been
garbage collected.
I have recently found code (in bundle A) that registered a
implementation class with a service outside its own bundle (bundle B)
but
Hi
Am 29.01.2014 um 09:53 schrieb Ian Boston i...@tfd.co.uk:
Hi,
Is it possible, in code running in a bundle, to detect if the OSGi
container has a classloader that is being pinned and should have been
garbage collected.
Well, that bundle would have to analyze class loaders and memory
[
https://issues.apache.org/jira/browse/SLING-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885169#comment-13885169
]
Bertrand Delacretaz commented on SLING-3037:
As per
I would prefer 3 if feasible/doable in a short time frame.
The other option I see would be to enhance our launchpad support and allow
for different start levels for both, the bootstrap installer and the osgi
installer. For now, all bundles in the boot level get the same start
level. Unfortunately
So an ugly option would be to have:
startLevel level=boot
log bundles
/startlevel
startLevel level=boot:2
everything else
/startLevel
Carsten
2014-01-29 Carsten Ziegeler cziege...@apache.org
I would prefer 3 if feasible/doable in a short time frame.
The other option I see would be to
On Wed, Jan 29, 2014 at 3:24 PM, Carsten Ziegeler cziege...@apache.org wrote:
I would prefer 3 if feasible/doable in a short time frame.
Seeing the slow release cycle of Slf4j API it might take some time to
push for such change and get a release done. I would start a
discussion on there DL.
For
Hi all mates,
I am using the new FeatureFlags APIs to implement my own Flags rules but I
noticed that Features are never evaluated, I mean that I cannot track
any Feature#isEnabled(ExecutionContext) method invocation.
It is enough for a resource having a sling:features property with a valid
Hi,
On 29 January 2014 09:16, Felix Meschberger fmesc...@adobe.com wrote:
Hi
Am 29.01.2014 um 09:53 schrieb Ian Boston i...@tfd.co.uk:
Hi,
Is it possible, in code running in a bundle, to detect if the OSGi
container has a classloader that is being pinned and should have been
garbage
On Wed, Jan 29, 2014 at 10:58 AM, Chetan Mehrotra
chetan.mehro...@gmail.com wrote:
...So can we go for #2?...
Which is adding custom bundle header 'x-sling-startup-order' that our
bootstrap installer takes into account?
But how is that handled? Set the bundle's OSGi start level to a
different
Right, there is no well defined start order for bundles in the same start
level - so this doesn't help us. If we need an order, we have to use
different start levels
Adjusting the start level for an update should be easy (the OSGi installer
does so already) and hopefully a simple fix in the
Hi Simo,
On Wed, Jan 29, 2014 at 11:03 AM, Simone Tripodi
simonetrip...@apache.org wrote:
...How can I provide you a valid IT to demonstrate it?...
If you need a fairly complete Sling instance including a JCR
repository, the simplest might be to use the freshly released
sling-pax-utils module
On Wed, Jan 29, 2014 at 11:21 AM, Carsten Ziegeler cziege...@apache.org wrote:
...all this adds a lot of cruft to fix a single simple problem in a
logging implementation. I see the point that slf4j releases might take some
time, but I think that's the right place to fix it and avoids adding
Thanks a lot Bertrand,
I am checking the doc fill the issue right now!
A bientôt!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Wed, Jan 29, 2014 at 11:24 AM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
Hi Simo,
On Wed, Jan 29, 2014 at 11:03
Simone Tripodi created SLING-3346:
-
Summary: Feature#isEnabled(ExecutionContext) method not evaluated
Key: SLING-3346
URL: https://issues.apache.org/jira/browse/SLING-3346
Project: Sling
Hi all mates,
can someone, with enough karma, create the featureflag component on JIRA?
I just created SLING-3346 and it needs to be classified...
TIA and all the best!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
on the next startup the bundles will again start in an
unpredictable order, if they have the same start level.
Aah .. I misread the code. I thought Sling starts the bundle always
though that code path. Missed the facts that such a flow is only used
for new bundles.
Chetan, do you see a
[
https://issues.apache.org/jira/browse/SLING-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger reassigned SLING-3346:
Assignee: Felix Meschberger
Feature#isEnabled(ExecutionContext) method not
[
https://issues.apache.org/jira/browse/SLING-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-3346:
---
Component/s: (was: ResourceResolver)
Feature Flags
[
https://issues.apache.org/jira/browse/SLING-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-3346:
-
Component/s: ResourceResolver
Feature#isEnabled(ExecutionContext) method not evaluated
Hi Simo,
About SLING-3346, would the following test scenario match what you expect?
1. Create a Resource R with sling:features=F
2. Verify that R is not visible, as there's no F feature yet
3. Add OSGi service for Feature F, enabled, verify that R is visible
4. Set F to disabled, verify that R
On Wed, Jan 29, 2014 at 11:45 AM, Simone Tripodi
simonetrip...@apache.org wrote:
can someone, with enough karma, create the featureflag component on JIRA?
I just created SLING-3346 and it needs to be classified...
done
-Bertrand
Funnily we had a discussion about the start order of bundles in the same
start level last week during our OSGi CPEG meeting and leaving out all the
nice details, never ever rely on that.
And for B we would need changes at least in the launchpad - for A we just
fix slf4j
Carsten
2014-01-29
Why ?
Feature Flags bundle is part of the extensions component and Resource Resolver
has its own ResourceResolver component.
Regards
Felix
Am 29.01.2014 um 12:07 schrieb Bertrand Delacretaz bdelacre...@apache.org:
On Wed, Jan 29, 2014 at 11:45 AM, Simone Tripodi
simonetrip...@apache.org
We should rather add a version for the feature flags bundle
Carsten
2014-01-29 Felix Meschberger fmesc...@adobe.com
Why ?
Feature Flags bundle is part of the extensions component and Resource
Resolver has its own ResourceResolver component.
Regards
Felix
Am 29.01.2014 um 12:07 schrieb
On Wed, Jan 29, 2014 at 4:39 PM, Carsten Ziegeler cziege...@apache.org wrote:
never ever rely on that.
Agreed. But ...
And for B we would need changes at least in the launchpad - for A we just
fix slf4j
Change in our code is in our control and easy to do without incurring
any penalty. Fix in
[
https://issues.apache.org/jira/browse/SLING-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simone Tripodi updated SLING-3346:
--
Component/s: (was: Feature Flags)
ResourceResolver
On Wed, Jan 29, 2014 at 12:09 PM, Felix Meschberger fmesc...@adobe.com wrote:
...Feature Flags bundle is part of the extensions component...
But what's the problem with making that more specific?
We have 45 modules under either bundles/extensions or
contrib/extensions, being a bit specific
[
https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-3148.
--
Resolution: Fixed
Fix Version/s: Feature Flags 1.0.0
Initial implementation
[
https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-3148:
-
Component/s: (was: General)
Extensions
Implement support for
[
https://issues.apache.org/jira/browse/SLING-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-3346:
-
Fix Version/s: Feature Flags 1.0.0
Feature#isEnabled(ExecutionContext) method not
Hi
Thanks for reporting. This is actually a consequence of me removing the global
ClientContext filter yesterday. I have fixed it now in trunk (as well as
another bug causing negative features to not be evaluated correctly).
Why is the global filter needed ? Because the initial resource
The Buildbot has detected a new failure on builder sling-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/191
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: scheduler
Build Source
Felix Meschberger created SLING-3347:
Summary: Improve handling of features service reference
Key: SLING-3347
URL: https://issues.apache.org/jira/browse/SLING-3347
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-3347.
--
Resolution: Fixed
Assignee: Felix Meschberger
Fixed in Rev. 1562422
Improve
Sounds good to me.
The bundle will need to be there all the time, but its going to be
tiny and its only 1 more thread.
Best Regards
Ian
On 29 January 2014 11:21, Chetan Mehrotra chetan.mehro...@gmail.com wrote:
One possible approach can be that
1. Have a custom bundle listener. This would
Hi
We have implemented Feature Flag support in the featureflags project in
contrib/extensions. As such we consider this to be a contributed bundle and we
don't include it in the default Sling launchpad.
Still we added support for these feature flags into one of our core bundles,
even though
The Buildbot has detected a restored build on builder sling-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/192
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: scheduler
Build Source
Hi
Agreed, this sounds like an interesting approach to follow.
Regards
Felix
Am 29.01.2014 um 12:21 schrieb Chetan Mehrotra chetan.mehro...@gmail.com:
One possible approach can be that
1. Have a custom bundle listener. This would maintain some structure
around bundle
2. Use Java Phantom
+1 to move to bundles
Yes, we could omit it from launchpad - but I think it's such an important
feature and deserves to be in the launchpad.
Carsten
2014-01-29 Felix Meschberger fmesc...@adobe.com
Hi
We have implemented Feature Flag support in the featureflags project in
I think we should avoid the double evaluation - especially as this might
result in interesting situations, a feature is enabled in the global filter
by disabled in the per request filter.
Apart from enabling a feature based on request information, features might
be enabled based on user
I just realized that this doesn't help us - we need to set the resource
resolver to the ExecutionContext before the features are evaluated and even
with a lazy check for enabled features, the resource resolver would not be
available for the initial resource lookup as this is still done before the
What about just having the global filter and using the same mechanism as
the Sling Main Servlet does?
// get ResourceResolver (set by AuthenticationSupport)
Object resolverObject =
request.getAttribute(AuthenticationSupport.REQUEST_ATTRIBUTE_RESOLVER);
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-2986:
---
Assignee: Carsten Ziegeler
Merged Resource Provider
On Wed, Jan 29, 2014 at 12:27 PM, Felix Meschberger fmesc...@adobe.com wrote:
...we currently don't do it to not create a ton of components.
We can certainly discuss doing this (though I would prefer not to)
I think it's fine to have a general extensions component in jira
while at the same
[
https://issues.apache.org/jira/browse/SLING-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885311#comment-13885311
]
Justin Edelson commented on SLING-3344:
---
I'm not 100% sure what the expectation is
[
https://issues.apache.org/jira/browse/SLING-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reopened SLING-3344:
---
log bundle is too conservative in exporting logback
Stefan Egli created SLING-3348:
--
Summary: fix sortable table headers in /system/console/topology
Key: SLING-3348
URL: https://issues.apache.org/jira/browse/SLING-3348
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-2986:
Component/s: (was: ResourceResolver)
Extensions
Merged Resource
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-2986:
Fix Version/s: Resource Merger 1.0.0
Merged Resource Provider
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2986.
-
Resolution: Fixed
Many thanks for your contribution, Gilles.
I've applied it to the
Hi Felix!
thanks a lot for following up - unfortunately, once updated my local copy
of Sling, reinstalled everything and re-set up my environment, I noticed
that even if I hardcode a Feature to return `true`, the Resource would be
hidden anyway...
I guess that Feature#isEnabled(ExecutionContext)
Hi
I think we have an API problem ;-)
One reason for eager resolution would probably be to have a
ClientContext.getEnabledFeatures() method. I somehow fail to understand why we
have this method in the first place.
So if we remove getEnabledFeatures() from ClientContext we are left with
Hi Simo
Are you sure you updated to the latest trunk build of the ResourceResolver
bundle ?
When debugging you should see the (new) ResourceResolverContext.applyFeatures
method be called from ProviderHandler.getReadableResource. If that is not the
case you ResourceResolver bundle is outdated.
This doesn't solve the problem - see previous mails as the resource
resolver is not available when it should be.
I like the ClientContext approach as this gives you context information,
especially which features are enabled - which e.g. might be interesting for
debugging etc.
Carsten
2014-01-29
Carsten Ziegeler created SLING-3349:
---
Summary: Guard servlet resolver against no resource type
Key: SLING-3349
URL: https://issues.apache.org/jira/browse/SLING-3349
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-3349.
-
Resolution: Fixed
Added special null and length check
Guard servlet resolver against
[
https://issues.apache.org/jira/browse/SLING-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-3349:
Description:
If the resource returns null or the empt string for the resource type, this
Hi
Am 29.01.2014 um 14:38 schrieb Carsten Ziegeler cziege...@apache.org:
This doesn't solve the problem - see previous mails as the resource
resolver is not available when it should be.
If we drop the eager evaluation requirement, it helps.
While at the same time, application use easier:
Hi all,
I completely dropped the local chache of mvn artifacts
(~/.m2/repository/org/apache/sling/) and checked out sling trunk r1562439,
while reinstalling the build I stumbled on the error below.
Do I need to checkout other modules from a different location?
TIA, all the best!
-Simo
[ERROR]
Ok, so you want to use the ClientContext (or a thread local) internally in
Features.isEnabled(String), right?
I'm fine with that.
Now, it still does not solve the problem at hand, or I'm misunderstanding
something :)
Let's have a look at the flow
a) a request comes in
b) global filter sets the
Hi Simo,
TL;DR - manually change that dependency to 1.0.1-SNAPSHOT
Longer:
This always happens when we are mid-release of a new module. Trunk
points to the next snapshot, but other modules point to the last
snapshot. We can't update the dependencies to the release version as
the release isn't
Hi,
Quick question - I can't 100% tell based on the discussion in
SLING-2944: is getServiceID() supposed to be part of the API or not?
It's documented at
http://sling.apache.org/documentation/the-sling-engine/service-authentication.html
and SLING-2944 makes it look like there was an open
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reopened SLING-2986:
-
Reopening this as it does not properly work atm
Merged Resource Provider
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885384#comment-13885384
]
Carsten Ziegeler commented on SLING-2986:
-
I've fixed some path handling within
Hi Justin!
thanks, that helped on fixing the problem, very appreciated!
In other (non) ASF projects, I followed the rule to not have SNAPSHOT
dependencies - or, at least, the current SNAPSHOT... not sure if that would
help on having that issue fixed, I should spend some time on
investigation...
Hi
Am 29.01.2014 um 15:07 schrieb Carsten Ziegeler cziege...@apache.org:
Ok, so you want to use the ClientContext (or a thread local) internally in
Features.isEnabled(String), right?
I'm fine with that.
Actually, that is not even required any more since all it takes is the
ExecutionCOntext
Hi all,
I just noticed that in r1562439 there is the update on Feature interface,
now extending Adaptable.
Is there a specific adapted type the resources resolver expects?
TIA, all the best!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
2014-01-29 Felix Meschberger fmesc...@adobe.com
Hi
The problem really is that the initial resolution does not have the
ResourceResolver available in the context yet, because only the
SlingMainServlet knows about it so far.
Yepp
So that leaves us with a two options:
* keep the global
OK.
+1 for me.
Could you removing the reference to this method in the documentation
when you do the site updates for the release?
On Wed, Jan 29, 2014 at 9:57 AM, Carsten Ziegeler cziege...@apache.org wrote:
It's not part of the API, Felix agreed to this (maybe this was an offline
discussion)
Hi
Am 29.01.2014 um 15:53 schrieb Carsten Ziegeler cziege...@apache.org:
2014-01-29 Felix Meschberger fmesc...@adobe.com
Hi
The problem really is that the initial resolution does not have the
ResourceResolver available in the context yet, because only the
SlingMainServlet knows about it
Hi Felix!
Good news, thanks! :)
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Wed, Jan 29, 2014 at 3:59 PM, Felix Meschberger fmesc...@adobe.comwrote:
Hi Simone
I fear there is something wrong in your checkout: Feature is not an
Adaptable any longer.
Hi Simone
I fear there is something wrong in your checkout: Feature is not an Adaptable
any longer.
Regards
Felix
Am 29.01.2014 um 15:36 schrieb Simone Tripodi simonetrip...@apache.org:
Hi all,
I just noticed that in r1562439 there is the update on Feature interface,
now extending
+1
2014-01-29 Carsten Ziegeler cziege...@apache.org
Sure, thanks for mentioning
Carsten
2014-01-29 Justin Edelson jus...@justinedelson.com
OK.
+1 for me.
Could you removing the reference to this method in the documentation
when you do the site updates for the release?
On Wed, Jan
Sure, thanks for mentioning
Carsten
2014-01-29 Justin Edelson jus...@justinedelson.com
OK.
+1 for me.
Could you removing the reference to this method in the documentation
when you do the site updates for the release?
On Wed, Jan 29, 2014 at 9:57 AM, Carsten Ziegeler
Hi Simo,
We try :) but in some cases it isn't possible because new APIs are
being introduced. That's the case here.
Justin
On Wed, Jan 29, 2014 at 9:29 AM, Simone Tripodi
simonetrip...@apache.org wrote:
Hi Justin!
thanks, that helped on fixing the problem, very appreciated!
In other (non)
Perfect :)
Carsten
2014-01-29 Felix Meschberger fmesc...@adobe.com
Hi
Am 29.01.2014 um 15:53 schrieb Carsten Ziegeler cziege...@apache.org:
2014-01-29 Felix Meschberger fmesc...@adobe.com
Hi
The problem really is that the initial resolution does not have the
ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885431#comment-13885431
]
Carsten Ziegeler commented on SLING-2986:
-
I've also changed/improved the value
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885468#comment-13885468
]
Carsten Ziegeler commented on SLING-2986:
-
I think there is a problem wrt hiding
Hi all mates,
I just checked out r1562484 and I would like to give you the feedback that
everything looks working as designed :)
Thanks a lot for your effort!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Wed, Jan 29, 2014 at 4:33 PM, Carsten Ziegeler
The Buildbot has detected a new failure on builder sling-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/202
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: scheduler
Build Source
The Buildbot has detected a restored build on builder sling-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/204
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: scheduler
Build Source
[
https://issues.apache.org/jira/browse/SLING-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885585#comment-13885585
]
Carsten Ziegeler commented on SLING-3344:
-
Yes, I fear we have to go this route -
[
https://issues.apache.org/jira/browse/SLING-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-3344.
---
Resolution: Fixed
added all packages in r 1562601
log bundle is too conservative in
[
https://issues.apache.org/jira/browse/SLING-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885880#comment-13885880
]
Carsten Ziegeler commented on SLING-2986:
-
I've just committed a potential fix for
Felix Meschberger created SLING-3350:
Summary: Simplify Feature Flags API
Key: SLING-3350
URL: https://issues.apache.org/jira/browse/SLING-3350
Project: Sling
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SLING-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger reassigned SLING-3350:
Assignee: Felix Meschberger
Simplify Feature Flags API
[
https://issues.apache.org/jira/browse/SLING-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-3350:
-
Attachment: SLING-3350.patch
Proposed patch.
As for point (e) of the issue description:
Alexei Krainiouk created SLING-3351:
---
Summary: org.apache.sling.jcr.resource.JcrResourceUtil.setProperty
method doesn't handle primitive arrays
Key: SLING-3351
URL:
[
https://issues.apache.org/jira/browse/SLING-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexei Krainiouk updated SLING-3351:
Description:
org.apache.sling.jcr.resource.JcrResourceUtil.setProperty(Node, String,
[
https://issues.apache.org/jira/browse/SLING-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886336#comment-13886336
]
Carsten Ziegeler commented on SLING-3350:
-
+1
Simplify Feature Flags API
Looks good to me, especially removing the context handling from the api is
good as this might be something we need but differently in the future. So
not having it there in the first place makes things easier.
Carsten
2014-01-29 Felix Meschberger fmesc...@adobe.com:
Hi
Ok, I drastically cut
[
https://issues.apache.org/jira/browse/SLING-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-3351:
---
Assignee: Carsten Ziegeler
[
https://issues.apache.org/jira/browse/SLING-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-3351:
Affects Version/s: JCR Resource 2.2.8
[
https://issues.apache.org/jira/browse/SLING-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886342#comment-13886342
]
Carsten Ziegeler commented on SLING-3351:
-
Thanks for the patch, Alexei. It's
96 matches
Mail list logo
