[jira] [Updated] (SLING-10674) Publish/Unpubilsh button not working

2021-07-27 Thread James Raynor (Jira)
[ https://issues.apache.org/jira/browse/SLING-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Raynor updated SLING-10674: - Description: Steps to reproduce: 1.Run SlingCMS, visit the page [http://localhost:8080/apache/

[jira] [Updated] (SLING-10674) Publish/Unpubilsh button not working

2021-07-27 Thread James Raynor (Jira)
[ https://issues.apache.org/jira/browse/SLING-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Raynor updated SLING-10674: - Attachment: 1.png > Publish/Unpubilsh button not working >

[jira] [Updated] (SLING-10674) Publish/Unpubilsh button not working

2021-07-27 Thread James Raynor (Jira)
[ https://issues.apache.org/jira/browse/SLING-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Raynor updated SLING-10674: - Description: Steps to reproduce: 1.Run SlingCMS, visit the page [http://localhost:8080/apache/

[jira] [Comment Edited] (SLING-10678) enhance ObjectModel#resolveProperty to handle target that is an enum class

2021-07-27 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388352#comment-17388352 ] Eric Norman edited comment on SLING-10678 at 7/28/21, 12:13 AM: --

[jira] [Commented] (SLING-10677) add support for using an enum class via the Java Use-API

2021-07-27 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388360#comment-17388360 ] Eric Norman commented on SLING-10677: - PR #13 contains the proposed changes for revi

[GitHub] [sling-org-apache-sling-scripting-sightly] sonarcloud[bot] commented on pull request #13: SLING-10677 add support for using an enum class via the Java Use-API

2021-07-27 Thread GitBox
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/13#issuecomment-887901008 SonarCloud Quality Gate failed.    ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Quality

[GitHub] [sling-org-apache-sling-scripting-sightly] enapps-enorman opened a new pull request #13: SLING-10677 add support for using an enum class via the Java Use-API

2021-07-27 Thread GitBox
enapps-enorman opened a new pull request #13: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/13 For a use case where you need access to an enum value in your ui script for some reason, it would be nice to be able to "data-sly-use" your enum class with somethin

[jira] [Commented] (SLING-10678) enhance ObjectModel#resolveProperty to handle target that is an enum class

2021-07-27 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388352#comment-17388352 ] Eric Norman commented on SLING-10678: - PR #8 created with the proposed changes > en

[jira] [Created] (SLING-10678) enhance ObjectModel#resolveProperty to handle target that is an enum class

2021-07-27 Thread Eric Norman (Jira)
Eric Norman created SLING-10678: --- Summary: enhance ObjectModel#resolveProperty to handle target that is an enum class Key: SLING-10678 URL: https://issues.apache.org/jira/browse/SLING-10678 Project: Sli

[jira] [Created] (SLING-10677) add support for using an enum class via the Java Use-API

2021-07-27 Thread Eric Norman (Jira)
Eric Norman created SLING-10677: --- Summary: add support for using an enum class via the Java Use-API Key: SLING-10677 URL: https://issues.apache.org/jira/browse/SLING-10677 Project: Sling Issue

[VOTE] Promote org.apache.sling.thumbnails to its own Sling Module

2021-07-27 Thread Daniel Klco
Hi, This is a vote to promote the org.apache.sling.thumbnails[1] to its own Sling Module. This module contains everything needed to create thumbnails of file resources in Sling based applications: - a servlet to serve cached thumbnails based on CA configured generation pipelines - a servlet for g

[jira] [Commented] (SLING-5825) Add support for implicit conversion of Enum to String

2021-07-27 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388310#comment-17388310 ] Eric Norman commented on SLING-5825: [~kwin] [~radu] Do you recall if there was there

[GitHub] [sling-site] raducotescu commented on a change in pull request #63: SLING-10652 add table for HTL type conversions

2021-07-27 Thread GitBox
raducotescu commented on a change in pull request #63: URL: https://github.com/apache/sling-site/pull/63#discussion_r677695118 ## File path: src/main/jbake/content/documentation/bundles/scripting/scripting-htl.md ## @@ -56,6 +56,31 @@ The [HTML Template Language Specification

[jira] [Commented] (SLING-10676) Add a SECURITY.MD file to all our Git repositories

2021-07-27 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388185#comment-17388185 ] Bertrand Delacretaz commented on SLING-10676: - I have created https://githu

[jira] [Updated] (SLING-10676) Add a SECURITY.MD file to all our Git repositories

2021-07-27 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-10676: Description: We should add [https://github.com/apache/.github/blob/main/.github/SE

[jira] [Created] (SLING-10676) Add a SECURITY.MD file to all our Git repositories

2021-07-27 Thread Bertrand Delacretaz (Jira)
Bertrand Delacretaz created SLING-10676: --- Summary: Add a SECURITY.MD file to all our Git repositories Key: SLING-10676 URL: https://issues.apache.org/jira/browse/SLING-10676 Project: Sling

[GitHub] [sling-org-apache-sling-scripting-sightly] Buuhuu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
Buuhuu commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887581315 The library is big. Besides a lot of JDK drop-in implementations, it also contains the cldr records, timezone data etc. (> 10mb). I will try to come

[GitHub] [sling-org-apache-sling-scripting-sightly] raducotescu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
raducotescu commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-88747 Since only `com.ibm.icu.text.MessageFormat` is used, if we want to go the embed route, then maybe we could conditionally embed only what's used.

[GitHub] [sling-org-apache-sling-scripting-sightly] bdelacretaz commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
bdelacretaz commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887539132 >... icu4j doesn't version the exported packages, which could lead to runtime errors in the future... If the library is small enough or i

[GitHub] [sling-org-apache-sling-scripting-sightly] Buuhuu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
Buuhuu commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887451545 I created https://unicode-org.atlassian.net/browse/ICU-21691 and will try to come up with a PR for it. -- This is an automated message from the A

[GitHub] [sling-org-apache-sling-scripting-sightly] Buuhuu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
Buuhuu commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887443088 > There's one thing which I don't like that much, namely that icu4j doesn't version the exported packages, which could lead to runtime errors in the

[jira] [Commented] (SLING-10675) Parent POMs contain wrong scm tag

2021-07-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387964#comment-17387964 ] Konrad Windszus commented on SLING-10675: - The tag is only evaluated in during r

[jira] [Commented] (SLING-10673) Derive source for javadoc from property sling.java.version

2021-07-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387963#comment-17387963 ] Konrad Windszus commented on SLING-10673: - I improved the handling in https://g

[GitHub] [sling-parent] kwin merged pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
kwin merged pull request #18: URL: https://github.com/apache/sling-parent/pull/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [sling-site] kwin commented on a change in pull request #63: SLING-10652 add table for HTL type conversions

2021-07-27 Thread GitBox
kwin commented on a change in pull request #63: URL: https://github.com/apache/sling-site/pull/63#discussion_r677318669 ## File path: src/main/jbake/content/documentation/bundles/scripting/scripting-htl.md ## @@ -56,6 +56,31 @@ The [HTML Template Language Specification](https

[GitHub] [sling-org-apache-sling-scripting-sightly] raducotescu commented on pull request #10: SLING-4443 - Whitespace removal for Sightly HTML output

2021-07-27 Thread GitBox
raducotescu commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/10#issuecomment-887377463 Sorry for stumbling on this PR so late! Your PR doesn't actually accomplish what's requested in https://issues.apache.org/jira/browse/SLI

[GitHub] [sling-org-apache-sling-scripting-sightly] raducotescu closed pull request #10: SLING-4443 - Whitespace removal for Sightly HTML output

2021-07-27 Thread GitBox
raducotescu closed pull request #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [sling-org-apache-sling-scripting-sightly] raducotescu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

2021-07-27 Thread GitBox
raducotescu commented on pull request #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887375141 There's one thing which I don't like that much, namely that `icu4j` doesn't version the exported packages, which could lead to runtime errors in

[GitHub] [sling-site] raducotescu commented on pull request #63: SLING-10652 add table for HTL type conversions

2021-07-27 Thread GitBox
raducotescu commented on pull request #63: URL: https://github.com/apache/sling-site/pull/63#issuecomment-887349975 @kwin, I've expanded a bit the table and mentioned how `Optional` is handled. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (SLING-10652) Add a type coercion table to the HTL Engine documentation

2021-07-27 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-10652: - Summary: Add a type coercion table to the HTL Engine documentation (was: Extend HTL Engine docu

[jira] [Commented] (SLING-10675) Parent POMs contain wrong scm tag

2021-07-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387890#comment-17387890 ] Oliver Lietz commented on SLING-10675: -- [~kwin], Can you have a look? > Parent POM

[jira] [Created] (SLING-10675) Parent POMs contain wrong scm tag

2021-07-27 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-10675: Summary: Parent POMs contain wrong scm tag Key: SLING-10675 URL: https://issues.apache.org/jira/browse/SLING-10675 Project: Sling Issue Type: Bug

[RESULT] [VOTE] Release Apache Sling JCR Base 3.1.10

2021-07-27 Thread Stefan Egli
Hi, The vote has passed with the following result: +1 (binding): Carsten Ziegeler, Eric Norman, Radu Cotescu, Daniel Klco +1 (non-binding): Marcel Reutegger I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, Stefan On 19.07.

[GitHub] [sling-parent] oliverlietz commented on pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
oliverlietz commented on pull request #18: URL: https://github.com/apache/sling-parent/pull/18#issuecomment-887314865 Works with Commons Messaging Mail and Java 11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-parent] sonarcloud[bot] commented on pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-parent/pull/18#issuecomment-887300052 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.

[GitHub] [sling-parent] sonarcloud[bot] removed a comment on pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #18: URL: https://github.com/apache/sling-parent/pull/18#issuecomment-887253006 Kudos, SonarCloud Quality Gate passed!    ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/pass

[GitHub] [sling-parent] kwin commented on pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
kwin commented on pull request #18: URL: https://github.com/apache/sling-parent/pull/18#issuecomment-887299120 That was a typo, fixed in https://github.com/apache/sling-parent/pull/18/commits/4bafd743a9637ed82420a1eecb4f6cb1d6a6fe7e. -- This is an automated message from the Apache Git Se

[jira] [Assigned] (SLING-10654) HTL optionally support ICU4j MessageFormat for string formatting

2021-07-27 Thread Dirk Rudolph (Jira)
[ https://issues.apache.org/jira/browse/SLING-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph reassigned SLING-10654: Assignee: Dirk Rudolph > HTL optionally support ICU4j MessageFormat for string formatting

[GitHub] [sling-parent] oliverlietz commented on pull request #18: SLING-10673 set property maven.compiler.source or maven.compiler.release

2021-07-27 Thread GitBox
oliverlietz commented on pull request #18: URL: https://github.com/apache/sling-parent/pull/18#issuecomment-887293494 Where is `java.target.version` coming from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SLING-10672) Document required settings for reproducible builds

2021-07-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387854#comment-17387854 ] Konrad Windszus commented on SLING-10672: - If we set the project.build.outputTim

[jira] [Commented] (SLING-10673) Derive source for javadoc from property sling.java.version

2021-07-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387852#comment-17387852 ] Konrad Windszus commented on SLING-10673: - Both fall back to using the same prop

[jira] [Commented] (SLING-10672) Document required settings for reproducible builds

2021-07-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387840#comment-17387840 ] Oliver Lietz commented on SLING-10672: -- "Meanigful": Picking the timestamp from pre

[jira] [Created] (SLING-10674) Publish/Unpubilsh button not working

2021-07-27 Thread James Raynor (Jira)
James Raynor created SLING-10674: Summary: Publish/Unpubilsh button not working Key: SLING-10674 URL: https://issues.apache.org/jira/browse/SLING-10674 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-10673) Derive source for javadoc from property sling.java.version

2021-07-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387827#comment-17387827 ] Oliver Lietz commented on SLING-10673: -- Setting {{source}} on {{maven-compiler-plug