[
https://issues.apache.org/jira/browse/SLING-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435165#comment-17435165
]
Konrad Windszus commented on SLING-10888:
-
The question is which input parameters should be
[
https://issues.apache.org/jira/browse/SLING-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10888:
Description:
As not all resource providers necessarily support all CRUD operations it
[
https://issues.apache.org/jira/browse/SLING-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-9850.
Resolution: Fixed
> Clarify null return values for ResourceResolver.map(...)
>
[
https://issues.apache.org/jira/browse/SLING-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-5773.
Resolution: Won't Fix
Agree, let's close as Won't Fix.
> NonExistingResource.getParent()
sonarcloud[bot] removed a comment on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-953163038
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-953504443
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435156#comment-17435156
]
Carsten Ziegeler commented on SLING-2723:
-
[~fvisser] Another long open issue, should we do
[
https://issues.apache.org/jira/browse/SLING-5773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435154#comment-17435154
]
Carsten Ziegeler commented on SLING-5773:
-
[~kwin] It seems we didn't really come to a
[
https://issues.apache.org/jira/browse/SLING-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435152#comment-17435152
]
Carsten Ziegeler commented on SLING-6636:
-
[~fvisser] / [~radu] This is an older open issue - is
[
https://issues.apache.org/jira/browse/SLING-7800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-7800.
-
Resolution: Won't Fix
Clients can easily use the converter with the value map. So there
[
https://issues.apache.org/jira/browse/SLING-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-9850:
Fix Version/s: API 2.24.0
> Clarify null return values for ResourceResolver.map(...)
>
[
https://issues.apache.org/jira/browse/SLING-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-9850:
---
Assignee: Konrad Windszus
> Clarify null return values for
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-10871.
--
Resolution: Fixed
> Add builder API for request/resource objects
>
[
https://issues.apache.org/jira/browse/SLING-10894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-10894.
--
Resolution: Fixed
Carsten Ziegeler created SLING-10894:
Summary: Allow null for SlingUriBuilder.setSelectors
Key: SLING-10894
URL: https://issues.apache.org/jira/browse/SLING-10894
Project: Sling
Issue
sonarcloud[bot] commented on pull request #6:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/6#issuecomment-953325451
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #6:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/6#issuecomment-952989930
SonarCloud Quality Gate failed. ![Quality Gate
Oliver Lietz created SLING-10893:
Summary: Enable code checks with SpotBugs
Key: SLING-10893
URL: https://issues.apache.org/jira/browse/SLING-10893
Project: Sling
Issue Type: Task
Oliver Lietz created SLING-10892:
Summary: Enable code checks with PMD
Key: SLING-10892
URL: https://issues.apache.org/jira/browse/SLING-10892
Project: Sling
Issue Type: Task
Oliver Lietz created SLING-10891:
Summary: Enable code checks with Checkstyle
Key: SLING-10891
URL: https://issues.apache.org/jira/browse/SLING-10891
Project: Sling
Issue Type: Task
sonarcloud[bot] commented on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-953163038
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-953109201
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
kwin merged pull request #38:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-7975:
---
Fix Version/s: API 2.24.0
> Add a Java API for ordering resources
>
sonarcloud[bot] commented on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-953109201
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
raducotescu opened a new pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26
* refactored code to switch to the o.a.s.api.request.builder API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SLING-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-10890.
--
Resolution: Fixed
Updated dependencies in [commit
sonarcloud[bot] commented on pull request #38:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/38#issuecomment-953063662
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-10890:
-
Description: SLING-8742 increased the API version for {{o.a.s.api.request}}
to 2.5.0. Since the
[
https://issues.apache.org/jira/browse/SLING-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-10890:
-
Component/s: (was: Servlets)
JCR
> Make the Jackrabbit User Manager
Radu Cotescu created SLING-10890:
Summary: Make the Jackrabbit User Manager compatible with API
2.24.0
Key: SLING-10890
URL: https://issues.apache.org/jira/browse/SLING-10890
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-10890:
-
Fix Version/s: (was: Servlets Resolver 2.8.4)
JCR Jackrabbit User Manager
[
https://issues.apache.org/jira/browse/SLING-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-10889.
--
Resolution: Fixed
Updated to the latest snapshot dependency which provides the API change in
[
https://issues.apache.org/jira/browse/SLING-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-10889:
-
Summary: Make the Servlets Resolver compatible with API 2.24.0 (was:
Update the o.a.s.api
Radu Cotescu created SLING-10889:
Summary: Update the o.a.s.api dependency in o.a.s.servlets.resolver
Key: SLING-10889
URL: https://issues.apache.org/jira/browse/SLING-10889
Project: Sling
kwin opened a new pull request #38:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/38
improve javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434904#comment-17434904
]
Konrad Windszus commented on SLING-10871:
-
It is always good for consumers to know with which
cziegeler commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-953020744
works for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SLING-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10888:
Description:
As not all resource providers necessarily support all CRUD operations it
kwin commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-953019806
> True, but it is probably more common that a RP supports create/delete, but
not reordering
We can easily add such a capability check API later on. This
Konrad Windszus created SLING-10888:
---
Summary: Add CRUD operation capability API
Key: SLING-10888
URL: https://issues.apache.org/jira/browse/SLING-10888
Project: Sling
Issue Type: New
cziegeler commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-953015171
True, but it is probably more common that a RP supports create/delete, but
not reordering
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434717#comment-17434717
]
Konrad Windszus edited comment on SLING-7975 at 10/27/21, 2:57 PM:
---
I
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434717#comment-17434717
]
Konrad Windszus edited comment on SLING-7975 at 10/27/21, 2:57 PM:
---
I
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434717#comment-17434717
]
Konrad Windszus edited comment on SLING-7975 at 10/27/21, 2:45 PM:
---
I
kwin commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737425332
##
File path: src/main/java/org/apache/sling/api/resource/ResourceResolver.java
##
@@ -691,6 +691,24 @@ void delete(@NotNull Resource
kwin edited a comment on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952998147
> How can a client figure out if reordering is support? Right now the only
way seems to try it and then get an UnsupportedOperationException
Right now
kwin commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952998147
> How can a client figure out if reordering is support? Right now the only
way seems to try it and then get an UnsupportedOperationException
Right now there
kwin commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737535295
##
File path:
src/main/java/org/apache/sling/spi/resource/provider/ResourceProvider.java
##
@@ -509,6 +509,28 @@ public boolean
kwin commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737535295
##
File path:
src/main/java/org/apache/sling/spi/resource/provider/ResourceProvider.java
##
@@ -509,6 +509,28 @@ public boolean
cziegeler commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952992453
How can a client figure out if reordering is support? Right now the only way
seems to try it and then get an UnsupportedOperationException
--
This is an
cziegeler commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737533620
##
File path:
src/main/java/org/apache/sling/spi/resource/provider/ResourceProvider.java
##
@@ -509,6 +509,28 @@ public boolean
karlpauls commented on pull request #6:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/6#issuecomment-952990048
@cziegeler, @raducotescu - work in progress but feedback welcome. The idea
is to enable something like:
```
org.apache.sling
sonarcloud[bot] commented on pull request #6:
URL:
https://github.com/apache/sling-jspc-maven-plugin/pull/6#issuecomment-952989930
SonarCloud Quality Gate failed. ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-7975:
--
Assignee: Konrad Windszus
> Add a Java API for ordering resources
>
[
https://issues.apache.org/jira/browse/SLING-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434717#comment-17434717
]
Konrad Windszus edited comment on SLING-7975 at 10/27/21, 2:27 PM:
---
I
Karl Pauls created SLING-10887:
--
Summary: Optionally allow osgi dependencies provided by a feature
Key: SLING-10887
URL: https://issues.apache.org/jira/browse/SLING-10887
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434869#comment-17434869
]
Carsten Ziegeler commented on SLING-10871:
--
I switched to the SlingUriBuilder in
[
https://issues.apache.org/jira/browse/SLING-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-10886.
--
Resolution: Done
> Update to Sling Bundle Parent 46
>
>
>
[
https://issues.apache.org/jira/browse/SLING-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz resolved SLING-10879.
--
Resolution: Done
> Support all JCR property types
> --
>
>
Oliver Lietz created SLING-10886:
Summary: Update to Sling Bundle Parent 46
Key: SLING-10886
URL: https://issues.apache.org/jira/browse/SLING-10886
Project: Sling
Issue Type: Task
On 2021/10/26 12:07:55, Nicola Cisternino wrote:
> Hi all
> I've an html resource (e.g. "pagecontent.html" stored in "apps" JCR structure
> and mapped as sling:resourceType in a "content" node (e.g.
> /content/test/page1).
> So, using a browser, a request of:
kwin opened a new pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resourcesecurity/pull/1
Depends on
https://github.com/apache/sling-org-apache-sling-resourceaccesssecurity/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the
raducotescu merged pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] edited a comment on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] edited a comment on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952912429
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952861095
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952731564
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952900826
SonarCloud Quality Gate failed. ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434849#comment-17434849
]
Carsten Ziegeler commented on SLING-10871:
--
[~henzlerg] Good catch, yes I think using SlingUri
kwin commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737426026
##
File path:
src/main/java/org/apache/sling/api/security/ResourceAccessSecurity.java
##
@@ -98,6 +98,16 @@
*/
boolean
Hi Nicola,
On Tue, 2021-10-26 at 12:07 +, Nicola Cisternino wrote:
> Hi all
> I've an html resource (e.g. "pagecontent.html" stored in "apps" JCR
> structure and mapped as sling:resourceType in a "content" node (e.g.
> /content/test/page1).
> So, using a browser, a request of:
>
kwin commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737425332
##
File path: src/main/java/org/apache/sling/api/resource/ResourceResolver.java
##
@@ -691,6 +691,24 @@ void delete(@NotNull Resource
raducotescu commented on a change in pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#discussion_r737418157
##
File path:
src/main/java/org/apache/sling/api/security/ResourceAccessSecurity.java
##
@@ -98,6 +98,16 @@
*/
boolean
[
https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434834#comment-17434834
]
Georg Henzler commented on SLING-9662:
--
[~cziegeler] yes this part is still missing (while the first
cziegeler commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952867023
@raducotescu no worries, thats fine; I just didn't want to block this PR by
fine tuning javadocs, but if this is done now even better
--
This is an
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434828#comment-17434828
]
Georg Henzler commented on SLING-10871:
---
[~cziegeler] Just came across
raducotescu commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952863953
Sorry, Carsten! I didn't see your comment before pushing my latest changes.
The JavaDocs have been slightly reworded too. Let me know if I should revert
sonarcloud[bot] commented on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952861095
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #36:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/36#issuecomment-952642755
SonarCloud Quality Gate failed. ![Quality Gate
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/723/
for details.
No further emails will be sent until the status of the build is changed.
arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavende703ced/maven-spy-20211027-111721-6864573913197203139846.log.tmp
...
[INFO] Scanning for projects...
[INFO]
[INFO] < org.ap
cziegeler commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952789131
PR looks good in general, we can fine tune javadoc etc. separately if
required. Using Nullable makes sense
--
This is an automated message from the Apache
raducotescu commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737327781
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -94,9 +101,8 @@
*
kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737289970
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
@NotNull
raducotescu commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737289086
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
sonarcloud[bot] commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952731564
SonarCloud Quality Gate failed. ![Quality Gate
sonarcloud[bot] removed a comment on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952710646
SonarCloud Quality Gate failed. ![Quality Gate
kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737288078
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
@NotNull
kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737288078
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
@NotNull
raducotescu commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737286707
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737286238
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -94,9 +101,8 @@
* Add the
kwin commented on a change in pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#discussion_r737285005
##
File path:
src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java
##
@@ -65,13 +65,20 @@
@NotNull
kwin opened a new pull request #18:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/18
This depends upon
https://github.com/apache/sling-org-apache-sling-api/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kwin opened a new pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/51
This depends upon
https://github.com/apache/sling-org-apache-sling-api/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SLING-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434752#comment-17434752
]
Robert Munteanu commented on SLING-8593:
[~himanshu.singhal] - apologies, this went unnoticed for
sonarcloud[bot] commented on pull request #37:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/37#issuecomment-952710646
SonarCloud Quality Gate failed. ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17434745#comment-17434745
]
Radu Cotescu commented on SLING-10871:
--
New PR available for review:
raducotescu opened a new pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-api/pull/37
* allow passing nulls to methods accepting only one parameter so that
clients can still use fluid calls without doing null checks
* adjusted tests to reflect the new behaviour
1 - 100 of 109 matches
Mail list logo
