[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797135#comment-17797135 ] Roy Teeuwen commented on SLING-12026: - OK, we were on 2023.10 ;) that explains, thanks! > Ch

[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797130#comment-17797130 ] Roy Teeuwen commented on SLING-12026: - [~kwin]  I do have a dependency on the aem-sdk-api

[jira] [Commented] (SLING-12026) Check for implementation/extension of provider types

2023-12-15 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797099#comment-17797099 ] Roy Teeuwen commented on SLING-12026: - [~kwin]  I tried implementing it in our codebase

Re: Please welcome Roy Teeuwen as new Sling committer

2023-10-20 Thread Roy Teeuwen
ing community, > > Based on his ongoing and valuable contributions to the project, the > Sling PMC has elected Roy Teeuwen as a Sling committer, and he > has accepted the invitation. > > Please join me in welcoming Roy! > > Roy - if you want to honor the old tradition

Re: [git] New repository - sling-org-apache-sling-commons-metrics-prometheus

2023-08-30 Thread Roy Teeuwen
Hey Robert, I am also looking into using sling metrics and expose it as prometheus endpoint, but what strikes me is that DropWizard Metrics is totally abandoned as project. There are no more maintainers, it's even explicitely mentioned on the github project Are there any plans into migrating

[jira] [Created] (SLING-11991) Allow other import post processors / invalidation processors

2023-08-03 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11991: --- Summary: Allow other import post processors / invalidation processors Key: SLING-11991 URL: https://issues.apache.org/jira/browse/SLING-11991 Project: Sling

[jira] [Commented] (SLING-10384) Execute actions before sending "o/a/s/d/i/package/imported" event

2023-07-28 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748701#comment-17748701 ] Roy Teeuwen commented on SLING-10384: - [~marett] [~joerghoh]  I'm working for one of those customers

Re: Rewriter: resource structure forcing a dependency on OSGI services

2023-07-15 Thread Roy Teeuwen
Hey, What is the reasoning around making this a JCR node in the first place? Why not make it an OSGi configuration instead? I often had the same issue where the specific parser was not live yet as OSGi service, but the configuration already exists in the repo so I get the message that you

[jira] [Commented] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-06 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720213#comment-17720213 ] Roy Teeuwen commented on SLING-11856: - Wouldn’t it make more sense to recalculate the active jobs

[jira] [Commented] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-06 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720204#comment-17720204 ] Roy Teeuwen commented on SLING-11856: - [~cziegeler] the PR is because we are running against

[jira] [Commented] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-05 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719701#comment-17719701 ] Roy Teeuwen commented on SLING-11856: - [~cziegeler]  could you have a look at this? You did

[jira] [Created] (SLING-11857) OsgiInstallationListener is not throwing DynamicClassLoader exceptions

2023-05-02 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11857: --- Summary: OsgiInstallationListener is not throwing DynamicClassLoader exceptions Key: SLING-11857 URL: https://issues.apache.org/jira/browse/SLING-11857 Project: Sling

[jira] [Created] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-02 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11856: --- Summary: Statistics for Sling Event Queue do not reset correctly Key: SLING-11856 URL: https://issues.apache.org/jira/browse/SLING-11856 Project: Sling Issue

[jira] [Updated] (SLING-11856) Statistics for Sling Event Queue do not reset correctly

2023-05-02 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-11856: Component/s: Event > Statistics for Sling Event Queue do not reset correc

[jira] [Commented] (SLING-11771) Upgrade Sling Starter to Groovy 4.x

2023-03-31 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707157#comment-17707157 ] Roy Teeuwen commented on SLING-11771: - [~olli] could you have a look at this? > Upgrade Sl

[jira] [Commented] (SLING-11771) Upgrade Sling Starter to Groovy 4.x

2023-03-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704617#comment-17704617 ] Roy Teeuwen commented on SLING-11771: - Created a PR > Upgrade Sling Starter to Groovy

[jira] [Commented] (SLING-11771) Upgrade Sling Starter to Groovy 4.x

2023-03-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704563#comment-17704563 ] Roy Teeuwen commented on SLING-11771: - Composum has been released with groovy 4.x support > Upgr

Re: Unable to solve "No OSGi SCR metadata found for class"

2023-03-06 Thread Roy Teeuwen
@Stefan, is there any way that it is feasible for Intellij IDE to run the sling mock unit tests without first doing a compile with maven (and thus triggering the bnd-maven-plugin to create the OSG-INF files)? It would be handy if SlingContext could compile them "at runtime" of the junit test if

[jira] [Commented] (SLING-11780) Cache non-existing resources

2023-02-20 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691105#comment-17691105 ] Roy Teeuwen commented on SLING-11780: - [~joerghoh] are you proposing to fix this on ResourceResolver

[jira] [Created] (SLING-11771) Upgrade Sling Starter to Groovy 4.x

2023-02-11 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11771: --- Summary: Upgrade Sling Starter to Groovy 4.x Key: SLING-11771 URL: https://issues.apache.org/jira/browse/SLING-11771 Project: Sling Issue Type: Improvement

[jira] [Commented] (SLING-11407) Upgrade to Groovy 4

2023-02-09 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686573#comment-17686573 ] Roy Teeuwen commented on SLING-11407: - Super, thanks! I will make a PR to also update the sling

[jira] [Commented] (SLING-11407) Upgrade to Groovy 4

2023-01-25 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680481#comment-17680481 ] Roy Teeuwen commented on SLING-11407: - [~olli] thanks. I will follow up the groovy-json fix

[jira] [Commented] (SLING-11407) Upgrade to Groovy 4

2023-01-23 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679740#comment-17679740 ] Roy Teeuwen commented on SLING-11407: - [~olli] I have tried installing Groovy 4.x on a Sling

[jira] [Comment Edited] (SLING-11407) Upgrade to Groovy 4

2023-01-23 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679740#comment-17679740 ] Roy Teeuwen edited comment on SLING-11407 at 1/23/23 9:52 AM: -- [~olli] I

[jira] [Created] (SLING-11706) Enable provider for the basename for I18nRuntimeExtension

2022-11-29 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11706: --- Summary: Enable provider for the basename for I18nRuntimeExtension Key: SLING-11706 URL: https://issues.apache.org/jira/browse/SLING-11706 Project: Sling

[jira] [Commented] (SLING-11455) ResourceResolver Mock: ResourceProvider implementation

2022-08-19 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581805#comment-17581805 ] Roy Teeuwen commented on SLING-11455: - [~sseifert]  another unwanted effect

[jira] [Commented] (SLING-11079) models-caconfig: Lower log level to debug for message "Injection only supported using @ContextAwareConfiguration annotation"

2022-07-22 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569857#comment-17569857 ] Roy Teeuwen commented on SLING-11079: - [~sseifert]  care to make a release for this ticket

[jira] [Commented] (SLING-10831) o.a.s.commons.thread fails setting up ThreadLocal cleaner on Java 17

2022-02-15 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492529#comment-17492529 ] Roy Teeuwen commented on SLING-10831: - Indeed, I can definitely vouch for that ThreadLocal's

[jira] [Commented] (SLING-11121) Avoid registering service in activate method

2022-02-06 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487660#comment-17487660 ] Roy Teeuwen commented on SLING-11121: - [~cziegeler]  why is it an anti pattern to register other

Re: Problem with vault validation

2022-01-25 Thread Roy Teeuwen
Hey Christian, I have the same annoying issue, it seems that when you format the xml file in for example Intellij IDEA, it will delete the cq namespace because there is no property in the xml that starts with cq:, but on the other hand it also seems the validator expects the namespace cq to be

[jira] [Commented] (SLING-11068) Split up api regions exportsimports analyser task

2022-01-17 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477398#comment-17477398 ] Roy Teeuwen commented on SLING-11068: - Created PR: https://github.com/apache/sling-org-apache-sling

[jira] [Created] (SLING-11068) Split up api regions exportsimports analyser task

2022-01-17 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-11068: --- Summary: Split up api regions exportsimports analyser task Key: SLING-11068 URL: https://issues.apache.org/jira/browse/SLING-11068 Project: Sling Issue Type

Re: Introducing Lombok to Sling?

2021-12-24 Thread Roy Teeuwen
+1 also not a fan of Lombok, have already Delomboked a few projects because it just adds extra complexity / less debuggability > On 24 Dec 2021, at 10:20, Konrad Windszus wrote: > > Hi, > to be honest I am rather opposed to that idea as Lombok has the following > disadvantages from my PoV: >

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-17 Thread Roy Teeuwen
Hey Carsten, Could you clarify why you need to clean up the threadlocal when it is bound to the thread of a request? Don't the threads of a request get garbage collected, and by that way also the ThreadLocal's bound to it Greets, Roy > On 17 Oct 2021, at 09:57, Carsten Ziegeler wrote: > >

[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces

2021-09-29 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422151#comment-17422151 ] Roy Teeuwen commented on SLING-10840: - I indeed have the same requirement as [~empire29], having

[jira] [Commented] (SLING-10840) Sling Servlet Helpers implements @ProviderType interfaces

2021-09-27 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420967#comment-17420967 ] Roy Teeuwen commented on SLING-10840: - But still it is a very common use-case in real world

[jira] [Commented] (SLING-10356) MockResourceResolver does not correctly resolve resources

2021-06-28 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370451#comment-17370451 ] Roy Teeuwen commented on SLING-10356: - Thats always a possibility of course, but that adds an extra

[jira] [Updated] (SLING-10356) MockResourceResolver does not correctly resolve resources

2021-05-06 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-10356: Description: The mock resource resolver does not do the complete cycle of the resolving

[jira] [Created] (SLING-10356) MockResourceResolver does not correctly resolve resources

2021-05-06 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-10356: --- Summary: MockResourceResolver does not correctly resolve resources Key: SLING-10356 URL: https://issues.apache.org/jira/browse/SLING-10356 Project: Sling

[jira] [Commented] (SLING-8450) JcrPersist: Provide transparent persistence to Sling Models

2021-03-26 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309213#comment-17309213 ] Roy Teeuwen commented on SLING-8450: [~brobert] Would be nice! I don't seem to find the updated

[jira] [Created] (SLING-10245) JCR Mocks: Allow setting of primary type for MockNode

2021-03-20 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-10245: --- Summary: JCR Mocks: Allow setting of primary type for MockNode Key: SLING-10245 URL: https://issues.apache.org/jira/browse/SLING-10245 Project: Sling Issue

[jira] [Commented] (SLING-10124) OSGi Mock - Service reference order is not correct for Collection field injection

2021-03-08 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297316#comment-17297316 ] Roy Teeuwen commented on SLING-10124: - Super, thanks for the further digging into the actual OSGi

[jira] [Commented] (SLING-10124) OSGi Mock - Service reference order is not correct

2021-03-01 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293409#comment-17293409 ] Roy Teeuwen commented on SLING-10124: - Anyone has any time to verify what I did is correct

Re: No OSGi SCR metadata in Unit Tests

2021-02-25 Thread Roy Teeuwen
Interesting that you mention Intellij Stefan? Because If i wouldn't do a mvn install first before executing the unit tests from the Intellij junit run configuration, it will fail with the exact reason stated. Is there an easy way in intellij to get those OSGi SCR xmls in a junit run

[jira] [Commented] (SLING-10124) OSGi Mock - Service reference order is not correct

2021-02-05 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279624#comment-17279624 ] Roy Teeuwen commented on SLING-10124: - [~sseifert] I made a test case to show my use case https

[jira] [Updated] (SLING-10124) OSGi Mock - Service reference order is not correct

2021-02-03 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-10124: Component/s: Testing > OSGi Mock - Service reference order is not corr

[jira] [Commented] (SLING-10124) OSGi Mock - Service reference order is not correct

2021-02-03 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278216#comment-17278216 ] Roy Teeuwen commented on SLING-10124: - [~sseifert] I see you committed the code for the ordering

[jira] [Created] (SLING-10124) OSGi Mock - Service reference order is not correct

2021-02-03 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-10124: --- Summary: OSGi Mock - Service reference order is not correct Key: SLING-10124 URL: https://issues.apache.org/jira/browse/SLING-10124 Project: Sling Issue Type

[jira] [Commented] (SLING-10093) Add Mock Node Definition in jcr-mock

2021-01-26 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272121#comment-17272121 ] Roy Teeuwen commented on SLING-10093: - Added a pull request to add a mock node definition: https

[jira] [Created] (SLING-10093) Add Mock Node Definition in jcr-mock

2021-01-26 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-10093: --- Summary: Add Mock Node Definition in jcr-mock Key: SLING-10093 URL: https://issues.apache.org/jira/browse/SLING-10093 Project: Sling Issue Type: Improvement

[jira] [Commented] (SLING-10003) Allow to mock findResources in MockResourceResolver

2021-01-13 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264198#comment-17264198 ] Roy Teeuwen commented on SLING-10003: - Et voila: https://issues.apache.org/jira/browse/SLING-10062

[jira] [Created] (SLING-10062) Provide a way to allow mocking of findResources or query manager for resource resolvers / sessions obtained inside production code

2021-01-13 Thread Roy Teeuwen (Jira)
Roy Teeuwen created SLING-10062: --- Summary: Provide a way to allow mocking of findResources or query manager for resource resolvers / sessions obtained inside production code Key: SLING-10062 URL: https

[jira] [Commented] (SLING-10003) Allow to mock findResources in MockResourceResolver

2021-01-13 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264073#comment-17264073 ] Roy Teeuwen commented on SLING-10003: - Yes but what if you have the following code:     {code:java

[jira] [Comment Edited] (SLING-10003) Allow to mock findResources in MockResourceResolver

2021-01-13 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264073#comment-17264073 ] Roy Teeuwen edited comment on SLING-10003 at 1/13/21, 11:03 AM: Yes

[jira] [Commented] (SLING-10003) Allow to mock findResources in MockResourceResolver

2021-01-13 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264050#comment-17264050 ] Roy Teeuwen commented on SLING-10003: - [~sseifert] I have tried the jcr-mock way, but it has a big

[jira] [Commented] (SLING-8450) JcrPersist: Provide transparent persistence to Sling Models

2020-12-17 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251288#comment-17251288 ] Roy Teeuwen commented on SLING-8450: [~brobert] [~cziegeler] what ever happened with this PR

Precompiled JSP's / HTLs

2020-11-17 Thread Roy Teeuwen
Hey devs, I saw the talk about precompiled JSP’s and HTL’s on adaptTo (also the last years) and when I saw the performance impact I was really amazed! I have some questions about it. We are running an existing on-premise application. Would it be possible to somehow extract the jsp's / htl's

[jira] [Commented] (SLING-8742) Allow overriding the extension when using the RequestDispatcher

2020-10-05 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208117#comment-17208117 ] Roy Teeuwen commented on SLING-8742: [~rombert] [~bdelacretaz] any update on this ticket

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144257#comment-17144257 ] Roy Teeuwen commented on SLING-7768: [~rombert] ok perfect because I also had to build a workaround

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144104#comment-17144104 ] Roy Teeuwen commented on SLING-7768: any ETA on a release date for this? > Add String Interpolat

[jira] [Commented] (SLING-8570) Extract a generic Content Parser API from org.apache.sling.jcr.contentparser with pluggable implementations

2019-10-29 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961827#comment-16961827 ] Roy Teeuwen commented on SLING-8570: Hey [~radu], can you tell me where the implementation

[jira] [Commented] (SLING-8742) Allow overriding the extension when using the RequestDispatcher

2019-09-27 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939186#comment-16939186 ] Roy Teeuwen commented on SLING-8742: +1. I think you would make a lot of people happy with this one

Re: Why get rid of the rewriter?

2019-09-10 Thread Roy Teeuwen
I also used rewriting for various use cases ( for example creating disclaimer links at the bottom of the page based on whats on the page) To be honest, its just a nice wrapper around a filter, if you would take it away, people would just create a filter on page level that captures the response

Re: [RT] Support OSGi R7 Logging

2019-08-15 Thread Roy Teeuwen
Hey Carsten, What is the benefit of using this log service instead of just keep using SLF4J which seems to have almost the exact same interface / way of using? Greets, Roy > On 14 Aug 2019, at 08:17, Carsten Ziegeler wrote: > > Hi, > > the OSGi R7 specification has an update to the Log

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-26 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893412#comment-16893412 ] Roy Teeuwen commented on SLING-7768: Any update on ever getting this in? Would simplify the setup

[jira] [Commented] (SLING-8548) Allow specifying negative runmode match

2019-07-01 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876149#comment-16876149 ] Roy Teeuwen commented on SLING-8548: you can use install.author and override

Re: Resource resolver - mapping entry

2019-04-15 Thread Roy Teeuwen
tps://github.com/apache/sling-org-apache-sling-resourceresolver/blob/8ee602cd722938a46f0b8f95aaa3dfbda923f98e/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java#L1198> Going to see if there are any cases where this is not used Thanks, Roy > On 15 Apr 2019, at 15:40, Roy Teeuw

Re: Resource resolver - mapping entry

2019-04-15 Thread Roy Teeuwen
Not only talking about that line by the way, also the following: https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/34f301b18227cbca24a8f5e636c405fc844077da/src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntry.java#L212 > On 15 Apr 2019, at 15:40, Roy Teeu

Resource resolver - mapping entry

2019-04-15 Thread Roy Teeuwen
Hey dev's, Currently the mapping entries for the resource resolver always cause a 302, I was wondering if there is anything against making this configurable to be either a 301 or a 302?

Re: [RTC] Rename error.log to success.log

2019-04-01 Thread Roy Teeuwen
Hey Robert, Why not call it sling.log? or status.log? Because it will still log errors / exceptions in the success.log this way Greets, Roy > On 1 Apr 2019, at 09:19, Robert Munteanu wrote: > > Hi, > > I think for some time we have overlooked the operational aspects of > Apache Sling and

ValueMapDecorator using impl class in api

2019-01-22 Thread Roy Teeuwen
Hey dev's, Since the use of the ObjectConverter, the ValueMapDecorator class which is in the api package bundle, uses an impl class. Is this good practice? See https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/wrappers/ValueMapDecorator.java

Sling Teleporter

2019-01-03 Thread Roy Teeuwen
Hey dev's, I was wondering if anyone has made any effort yet into making the sling teleporter also usable for junit 5? Currently there is the TeleporterRule, which is the old way of doing it with an @Rule in junit4 instead of @ExtendWith in junit5 Greets, Roy

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-12-15 Thread Roy Teeuwen
Hey guys, Seeing as you are all talking about deprecating or even removing the entire Sling Job API in the future, what would you propose as alternative / migration path? We have a lot JobConsumers in our projects, what would be a reason to stop using them? Greets, Roy > On 30 Oct 2018, at

Re: [RT] Simple File System Resource Provider

2018-11-11 Thread Roy Teeuwen
Seeing as the current filesystem resource provider does need an update to java 8 api, it would be nice to refactor / start over with that one and make it more generic / extensible? It has some caveats (like the start up scanning etc.) that would be nice to have fixed in a more elegant way. Roy

Re: SLING-7613 - un-deprecating loginAdministrative

2018-07-17 Thread Roy Teeuwen
Hey Justin, How would this be any different from using the getServiceResourceResolver though? This also needs additional work to actually create the service user and make a service mapping config for it. Not that I am disagreeing with what you are saying because I think the service user is

Re: Initial prototype of Sling Feature model API Region support

2018-07-13 Thread Roy Teeuwen
What made it that we don't use the actual spec and implement that one properly? Is the spec too difficult in practice? > On 13 Jul 2018, at 17:25, Karl Pauls wrote: > > On Friday, July 13, 2018, Roy Teeuwen <mailto:r...@teeuwen.be>> wrote: > >> Hey David, >&g

Re: Initial prototype of Sling Feature model API Region support

2018-07-13 Thread Roy Teeuwen
Hey David, Am I correct to understand that we are actually trying to make a lightweight OSGi Subsystem implementation with this? Greets, Roy > On 13 Jul 2018, at 10:47, David Bosschaert wrote: > > Hi all, > > I started working on a prototype for the API Region support for the Sling >

Re: [proposal][osgi][scripting] redesigned scripts deployment and resolution

2018-04-27 Thread Roy Teeuwen
> I *do not* love the idea of having to build a bundle every time a script > changes (if the above is true). This is a non-starter for front-end > developers... the primary people writing HTL files. Completely agree with that Chris, we just got to a stage that we can get the frontend developers

[jira] [Commented] (SLING-7363) Dictionary is not always invalidated for resource bundles using sling:basename

2018-01-08 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316208#comment-16316208 ] Roy Teeuwen commented on SLING-7363: I have created a fix using a github pr: https://github.com

[jira] [Created] (SLING-7363) Dictionary is not always invalidated for resource bundles using sling:basename

2018-01-08 Thread Roy Teeuwen (JIRA)
Roy Teeuwen created SLING-7363: -- Summary: Dictionary is not always invalidated for resource bundles using sling:basename Key: SLING-7363 URL: https://issues.apache.org/jira/browse/SLING-7363 Project

Re: [ANN] New Apache Sling PMC Chair: Robert Munteanu

2017-11-16 Thread Roy Teeuwen
Congratulations Robert! Greets, Roy > On 16 Nov 2017, at 15:25, Carsten Ziegeler wrote: > > Hi, > > it's my pleasure to announce that Robert took up the role as our new PMC > chair. > > Congrats Robert! > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research

[jira] [Updated] (SLING-7130) ResourceChangeListener does not work correctly when using ADDED on a glob path

2017-09-17 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-7130: --- Description: When adding a resource change listener to a glob pattern, where only the "ADDED&qu

[jira] [Created] (SLING-7130) ResourceChangeListener does not work correctly when using ADDED on a glob path

2017-09-17 Thread Roy Teeuwen (JIRA)
Roy Teeuwen created SLING-7130: -- Summary: ResourceChangeListener does not work correctly when using ADDED on a glob path Key: SLING-7130 URL: https://issues.apache.org/jira/browse/SLING-7130 Project

Re: SlingClient is removing double / triple slashes from the URL

2017-06-23 Thread Roy Teeuwen
Hey Andreas, I wouldn't go relying on double and triple slashes too much, I already have written a few classes that did at the beginning also to use it in suffixes, but I had to change it because it wasn't workable (in AEM for example the Link checker kept removing the slashes in the rendered

Re: Sling Test Environment Setup with Maven and Content Packages

2017-06-23 Thread Roy Teeuwen
Hey Andreas, It is definitely possible, I have the following provisioning model (its already half a year old thats why its still using the snapshot version), I think that Sling even has its own OSGi package installer: [feature name=:boot] [artifacts]

Re: Rewriting CSS files (delivered using Output Stream) using rewriter pipeline

2017-05-26 Thread Roy Teeuwen
Hey Amrit, Have you looked at the rewriterpipeline example of acs commons? It rewrites css urls too: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java

[jira] [Commented] (SLING-6778) [Sling Models] Support Delegate Pattern for Models adapted from interfaces

2017-04-12 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965489#comment-15965489 ] Roy Teeuwen commented on SLING-6778: Hey [~justinedelson], Please change your annotation name from

[jira] [Commented] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything

2017-03-24 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940614#comment-15940614 ] Roy Teeuwen commented on SLING-6708: Indeed, this is more of a problem related to the AEM dispatcher

[jira] [Commented] (SLING-6666) Make Sling shiny

2017-03-20 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932547#comment-15932547 ] Roy Teeuwen commented on SLING-: Last year when I contacted the devs of composum they also

Re: Usage of "Apache Sling Installer Content Package Support"

2016-12-26 Thread Roy Teeuwen
Hey Suren, The content package maven plugin should normally/hopefully (one day) be donated by Adobe as stated in this nabble: http://apache-sling.73963.n3.nabble.com/content-package-maven-plugin-and-tooling-around-it-td4028573.html

[jira] [Commented] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

2016-12-26 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779043#comment-15779043 ] Roy Teeuwen commented on SLING-6344: Seems hard to get a response on this, would love to see this too

Git broken?

2016-12-14 Thread Roy Teeuwen
Hey all, The last commit on git Apache Sling was 3 days ago, but the SVN had a lot of updates, is this something that should be or has been reported to infra? Greets, Roy

[jira] [Commented] (SLING-6396) Set project final name as default model archive name

2016-12-14 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15747876#comment-15747876 ] Roy Teeuwen commented on SLING-6396: Hey [~cziegeler], You're welcome! For the future, is making

Re: Support for model archives

2016-12-12 Thread Roy Teeuwen
> On 12 Dec 2016, at 09:25, Carsten Ziegeler <cziege...@apache.org> wrote: > > Roy Teeuwen wrote >> Hey Carsten, >> >> I had a look at the slingshot example that you set up with this. I see that >> a file slingstart.mar gets created, containing all the jars

Re: Support for model archives

2016-12-04 Thread Roy Teeuwen
Hey Carsten, I had a look at the slingshot example that you set up with this. I see that a file slingstart.mar gets created, containing all the jars and model files that are necessary. Is there a reason that the name is always slingstart.mar, and not for example artifactId-version.mar? Or

[jira] [Commented] (SLING-6249) Move ServletResolverConstants to an exported package

2016-11-26 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15698248#comment-15698248 ] Roy Teeuwen commented on SLING-6249: Hey Konrad, Maybe the docs examples should be updated completely

[jira] [Commented] (SLING-6219) Allow to create users with repoinit

2016-11-25 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695374#comment-15695374 ] Roy Teeuwen commented on SLING-6219: Thanks, must have missed that :) > Allow to create us

Re: What repository explorer should we ship with Launchpad 9?

2016-11-21 Thread Roy Teeuwen
+1 The only reason I have my custom sling launchpad jar (without including project related bundles) is to include Composum in the launchpad at the moment :) Greets Roy > On 21 Nov 2016, at 11:12, Robert Munteanu wrote: > > Hi, > > With the default Sling launchpad we're

[jira] [Commented] (SLING-6219) Allow to create users with repoinit

2016-11-12 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660002#comment-15660002 ] Roy Teeuwen commented on SLING-6219: [~cziegeler] related to the question that I asked about service

[jira] [Updated] (SLING-6223) Impossible to create HTL resource type that starts with a number inside the foldername

2016-11-01 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen updated SLING-6223: --- Affects Version/s: Scripting Sightly Engine 1.0.2 > Impossible to create HTL resource t

  1   2   >