[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-12-09 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r539457672 ## File path: bnd.bnd ## @@ -3,6 +3,7 @@ Export-Package: !org.junit.platform.*, \

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-12-02 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r534469447 ## File path: src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java ## @@ -54,19 +60,23 @@ protected

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-12-02 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r534469447 ## File path: src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java ## @@ -54,19 +60,23 @@ protected

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-12-02 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r534469447 ## File path: src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java ## @@ -54,19 +60,23 @@ protected

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-11-30 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r532946310 ## File path: src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java ## @@ -56,4 +57,16 @@ protected

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-11-23 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529057232 ## File path: src/main/java/org/apache/sling/junit/tests/TestReferenceJTest.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-11-23 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529033933 ## File path: src/main/java/org/apache/sling/junit/impl/AnnotationsProcessor.java ## @@ -64,25 +67,32 @@ private void

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-11-23 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529025065 ## File path: src/main/java/org/apache/sling/junit/annotations/TestReference.java ## @@ -39,6 +38,12 @@ */ String

[GitHub] [sling-org-apache-sling-junit-core] cmrockwell commented on a change in pull request #5: Sling 9915 support for sling annotations test runner

2020-11-23 Thread GitBox
cmrockwell commented on a change in pull request #5: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528773456 ## File path: src/main/java/org/apache/sling/junit/ServiceGetter.java ## @@ -15,7 +15,7 @@ * limitations under the License.