Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-14 Thread Oliver Lietz
On Tuesday 13 March 2018 21:09:59 Carsten Ziegeler wrote: > Hmm interesting, I can't remember to change it, but apparently it got > changed by my commit. That's a mistake. > > I guess the best would be to revert that change and do another release > > WDYT? I've fixed the bundle version in

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Carsten Ziegeler
Hmm interesting, I can't remember to change it, but apparently it got changed by my commit. That's a mistake. I guess the best would be to revert that change and do another release WDYT? Carsten Oliver Lietz wrote > On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: >> Hi Oli >> >> I

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Oliver Lietz
On Tuesday 13 March 2018 15:46:44 Julian Sedding wrote: > Hi Oli > > I think it's ok, because ResourceResolver#getSearchPath() also returns > String[]. So I think for consistency's sake we should leave it as-is. > While I agree with you in principle, there are other examples where > the singular

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Julian Sedding
Hi Oli I think it's ok, because ResourceResolver#getSearchPath() also returns String[]. So I think for consistency's sake we should leave it as-is. While I agree with you in principle, there are other examples where the singular term is used to refer to a list of paths, e.g. the java classpath.

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Oliver Lietz
On Tuesday 13 March 2018 08:36:14 Carsten Ziegeler wrote: > Hi, Hi, > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 SLING-7537: The method name should be getSearchPaths() instead of getSearchPath() as it returns a list of strings

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Robert Munteanu
On Tue, 2018-03-13 at 08:36 +0100, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Daniel Klco
+1 On Tue, Mar 13, 2018 at 6:58 AM, Radu Cotescu wrote: > +1 > > On Tue, 13 Mar 2018 at 08:36 Carsten Ziegeler > wrote: > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release,

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Radu Cotescu
+1 On Tue, 13 Mar 2018 at 08:36 Carsten Ziegeler wrote: > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- >

RE: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Stefan Seifert
+1

[VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Carsten Ziegeler
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12342301 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1884 You can use this UNIX script to download the release and verify the signatures:

Re: [VOTE] Release Apache Sling API 2.17.0

2018-03-13 Thread Carsten Ziegeler
+1 Carsten Ziegeler wrote > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12342301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1884 > > You can use this UNIX script to download the