Re: Sling Resource Editor :: first patch

2014-11-15 Thread Sandro Boehme
Hi Robert, I got it wrong. Or course a simple split would work. Even though initial commits may overlap which leads to the new add-node dialog changes to be hidden in the patch for the restructuring of the folders. But for reviewing it's probably easier. I splitted the patch up into smaller

Sling Resource Editor :: first patch

2014-11-12 Thread Sandro Boehme
Hello, does somebody have the time to commit my first patch [1] for my Sling Resource Editor contribution [2]? [1] - https://issues.apache.org/jira/browse/SLING-4141 [2] - https://issues.apache.org/jira/browse/SLING-4001 Best Sandro BTW: I god nice issue numbers, right? ;-)

Re: Sling Resource Editor :: first patch

2014-11-12 Thread Robert Munteanu
Hi Sandro, On Wed, 2014-11-12 at 13:39 +0100, Sandro Boehme wrote: Hello, does somebody have the time to commit my first patch [1] for my Sling Resource Editor contribution [2]? I planned to look at it at some point - no promise that I will find the time to do that :-) - but since you

Re: Sling Resource Editor :: first patch

2014-11-12 Thread Sandro Boehme
Hi Robert, thanks for thinking about committing the patch. The patch is not self contained because AFAIK the SVN patch format does not have information about deleted files. Only about deleted file content. I would appreciate it if somebody has a workaround for that. I don't see a way to