Re: [VOTE] Release Apache Sling Tooling Support Install 1.0.2
+1 Robert On Thu, Feb 19, 2015 at 10:55 AM, Robert Munteanu romb...@apache.org wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING-4405 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1187/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1187 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Tooling Support Install 1.0.2
+1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[VOTE] Release Apache Sling Tooling Support Install 1.0.2
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING-4405 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1187/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1187 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Created] (SLING-4441) The JavaUseProvider should return a failure for any exception encountered during Use object retrieval
Radu Cotescu created SLING-4441:
---
Summary: The JavaUseProvider should return a failure for any
exception encountered during Use object retrieval
Key: SLING-4441
URL: https://issues.apache.org/jira/browse/SLING-4441
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The {{JavaUseProvider}} should return a failure for any exception encountered
during Use object retrieval, not only for {{CompilerException}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4437) MockJcrResourceResolverFactory should allow to register services dynamically.
[
https://issues.apache.org/jira/browse/SLING-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-4437.
---
Resolution: Fixed
Completed: At revision: 1660995
i've implemented a slightly different apporach re-using the bundle context
already available or that can be passed to the resource resolver factory (that
makes more sense anyway).
so you can register additional classes before creating the resource resolver
e.g. in the bundle context of the SlingContext rule and it should work.
please give it a try.
MockJcrResourceResolverFactory should allow to register services dynamically.
-
Key: SLING-4437
URL: https://issues.apache.org/jira/browse/SLING-4437
Project: Sling
Issue Type: Improvement
Components: Testing
Affects Versions: Testing Sling Mock 1.1.2
Reporter: Tomek Rękawek
Assignee: Stefan Seifert
Labels: mocks
Fix For: Testing Sling Mock 1.2.0
Attachments: SLING-4437.patch
The {{MockJcrResourceResolverFactory}} class creates it's own mocked OSGi
BundleContext and uses it to create a ResourceResolverFactory. Part of the
OSGi environment initialization performed in the class is registering OSGi
services to be available by the mocked resolver. By default there is only one
service - SlingRepository.
However, the more recent versions of ResourceProvider implementations
requires other services, eg. PathMapper. Right now there is no way to inject
this service into the mocked OSGi container. The
{{MockJcrResourceResolverFactory}} should allow to register custom services,
so it'll be compatible with the future versions of ResourceResolvers and
Providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #767
See https://builds.apache.org/job/sling-trunk-1.8/changes
Re: [VOTE] Release Apache Sling API version 2.9.0
Hello all, On Thu, Feb 19, 2015 at 4:26 PM, Antonio Sanso asa...@adobe.com wrote: hi Tomek, it looks like you did not go through the key creation steps… It's my fault after all. I have a few keys in my GPG keyring and the release process took the first one rather than the one associated with the Apache account. I'll drop the staging repository and create it once more, properly signed this time. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Commented] (SLING-4437) MockJcrResourceResolverFactory should allow to register services dynamically.
[
https://issues.apache.org/jira/browse/SLING-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328085#comment-14328085
]
Tomek Rękawek commented on SLING-4437:
--
Works perfect, thanks.
MockJcrResourceResolverFactory should allow to register services dynamically.
-
Key: SLING-4437
URL: https://issues.apache.org/jira/browse/SLING-4437
Project: Sling
Issue Type: Improvement
Components: Testing
Affects Versions: Testing Sling Mock 1.1.2
Reporter: Tomek Rękawek
Assignee: Stefan Seifert
Labels: mocks
Fix For: Testing Sling Mock 1.2.0
Attachments: SLING-4437.patch
The {{MockJcrResourceResolverFactory}} class creates it's own mocked OSGi
BundleContext and uses it to create a ResourceResolverFactory. Part of the
OSGi environment initialization performed in the class is registering OSGi
services to be available by the mocked resolver. By default there is only one
service - SlingRepository.
However, the more recent versions of ResourceProvider implementations
requires other services, eg. PathMapper. Right now there is no way to inject
this service into the mocked OSGi container. The
{{MockJcrResourceResolverFactory}} should allow to register custom services,
so it'll be compatible with the future versions of ResourceResolvers and
Providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.6 #3080
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Resolved] (SLING-4435) OSGi Mock: Cache reading of OSGi SCR Metadata files
[ https://issues.apache.org/jira/browse/SLING-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-4435. --- Resolution: Fixed Completed: At revision: 1660841 OSGi Mock: Cache reading of OSGi SCR Metadata files --- Key: SLING-4435 URL: https://issues.apache.org/jira/browse/SLING-4435 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing OSGi Mock 1.1.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Priority: Minor Labels: mocks Fix For: Testing OSGi Mock 1.1.2 currently the OSGi SCR metadata XML files are parsed multiple times for each SCR component during the unit tests. the metadata in classpath can be considered static during the whole unit test, so it should be safe to cache it in a static cache. on the way we should refactor the code to parse this metadata a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (SLING-4435) OSGi Mock: Cache reading of OSGi SCR Metadata files
Stefan Seifert created SLING-4435: - Summary: OSGi Mock: Cache reading of OSGi SCR Metadata files Key: SLING-4435 URL: https://issues.apache.org/jira/browse/SLING-4435 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing OSGi Mock 1.1.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Priority: Minor Fix For: Testing OSGi Mock 1.1.2 currently the OSGi SCR metadata XML files are parsed multiple times for each SCR component during the unit tests. the metadata in classpath can be considered static during the whole unit test, so it should be safe to cache it in a static cache. on the way we should refactor the code to parse this metadata a bit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #760
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327187#comment-14327187
]
Marius Petria commented on SLING-4312:
--
I did the change to only register what is changed, I still need to test a bit
more but I think this is close to finish.
[1]
https://github.com/mpetria/sling/compare/mpetria:e62a0e94005709357e9a42a2ba526985d4b588a4...dev-SLING-4312
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327198#comment-14327198
]
Carsten Ziegeler commented on SLING-4312:
-
[~mpetria] Looks ok to me, except :) that I think you should also implement
FindHook - while EventListenerHook works with the current DS implementation,
those two hooks should be implemented in pairs usually. For example if someone
uses directly the framework API to find a service this needs to be filtered.
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 #1469
See https://builds.apache.org/job/sling-trunk-1.7/changes
Support getting versioned resources by using uri path parameters
hi *, SLING-848 [0] introduces the versioned resources by using uri path parameters” concept. This is nice :) I wonder though, since this affect quite few bundles if this stuff is ready to be released. I wasn’t too much involved in it, hence my question…. How far we are to release the affected bundles ? regards antonio [0] https://issues.apache.org/jira/browse/SLING-848
[jira] [Created] (SLING-4436) org.apache.sling.scripting.sightly does not compile
Konrad Windszus created SLING-4436:
--
Summary: org.apache.sling.scripting.sightly does not compile
Key: SLING-4436
URL: https://issues.apache.org/jira/browse/SLING-4436
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Konrad Windszus
The current 1.0.0-SNAPSHOT version of the
{{org.apache.sling.scripting.sightly}} Maven module doesn't compile, as it
can't find the {{org.eclipse.core:resources:jar:3.4.0}} transitive dependency
included in {{org.apache.sling.commons.compiler:2.0.0}}.
In order to reproduce, clean your local Maven repository and try to compile the
aforementioned module.
The fix would be to increase that dependency to
{{org.apache.sling.commons.compiler:2.2.0}}. Compare with SLING-4379.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling HC Core 1.2.0 and Webconsole 1.1.2
+1 Robert On Wed, Feb 18, 2015 at 3:31 PM, Carsten Ziegeler cziege...@apache.org wrote: Hi, We solved 2 issues https://issues.apache.org/jira/browse/SLING/fixforversion/12329465 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1186/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1186 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build is still unstable: sling-trunk-1.6 #3081
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Commented] (SLING-848) Support getting versioned resources by using uri path parameters
[ https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327250#comment-14327250 ] Tomek Rękawek commented on SLING-848: - Hello Stefan, I'm sorry that I did these changes in the \*mock modules without consulting you. Please find my reasons below: # This SLING-848 issue changes a few important modules: Sling API, Resource resolver and JCR resource provider. # I created an integration test it-resource-versioning # In this test I wanted to use sling-mock (as I need to mock the resource resolver) # I updated the Sling API, Resource resolver and JCR resource bundles in the sling-mock as I needed to have the new features from SLING-848 enabled in the mocked resolver. # I added the empty getThreadResourceResolver() as it was required by the new Sling API (it wasn't my change, but simply a thing that happened between Sling API 2.4.0 and 2.8.1-SNAPSHOT) # I needed the PathMapper for the similar reason - JcrResourceProviderFactory started referencing it in version 2.4.2 Now I see that I can solve point 4 and 5 without a need to modify the sling-mock, simply overriding versions of appropriate bundles in my it-resource-versioning/pom.xml, which I did in rev. 1660831. I still need the PathMapper to have the new JcrResourceProviderFactory working. I made a workaround in rev. 1660831, copying the MockJcrResourceResolverFactory to my testing module and adding PathMapper there. I think it's the only solution without updating jcr resource dependency in sling-mock to 2.4.2. Support getting versioned resources by using uri path parameters Key: SLING-848 URL: https://issues.apache.org/jira/browse/SLING-848 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.0.2 Reporter: Carsten Ziegeler Assignee: Tomek Rękawek Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0 Attachments: SLING-848-metadata.patch Getting versioned content should be support thorough uri path parameters, like /something/hello;v=1.1 For jcr based resources the value of the version should either point to a version name or label. In order to not change our existing apis, we introduce a new utility method which removes all uri path parameters and returns a map of these. Every resource provider could use this utility method and then decide to act on these parameters. If a requested version does not exists, a 404 is returned. If the requested node does not directly point to a versionable node, the algorithm checks the parent hierarchy until a versionable node is found, and tries to get the version of this node and then goes down the path again. If the versionable node does not have the requested version or the child, a 404 is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #759
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is back to stable : sling-trunk-1.7 #1470
See https://builds.apache.org/job/sling-trunk-1.7/1470/changes
[jira] [Resolved] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso resolved SLING-3854.
--
Resolution: Fixed
Fix Version/s: JCR Resource 2.5.0
Service User Mapper 1.1.0
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327341#comment-14327341
]
Antonio Sanso edited comment on SLING-3854 at 2/19/15 12:26 PM:
committed jcr resource part in r1660869
for the record. In order to leave the jcr api low enough the {{isSystemUser}}
has been implemented using reflection
was (Author: asanso):
committed jcr resource part in r1660869
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Oak + Sling
Hello, On Tue, Feb 17, 2015 at 10:58 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: (...) Tomasz just published https://github.com/trekawek/Sling-S3 with interesting setups for running Sling on Oak + Mongo. That stuff is not officially part of Sling but now that he's a committer, having more users might convince him to bring this here as a contrib ;-) After such call I have no other choice but to move Sling-S3 to the Sling contrib :) I'll do it in a few days. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[RESULT][VOTE] Release Apache Sling Engine Implementation 2.4.0
This vote passed with 4 binding +1 votes Thanks Antonio
[jira] [Updated] (SLING-4437) MockJcrResourceResolverFactory should allow to register services dynamically.
[
https://issues.apache.org/jira/browse/SLING-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek updated SLING-4437:
-
Attachment: SLING-4437.patch
MockJcrResourceResolverFactory should allow to register services dynamically.
-
Key: SLING-4437
URL: https://issues.apache.org/jira/browse/SLING-4437
Project: Sling
Issue Type: Improvement
Reporter: Tomek Rękawek
Fix For: Testing Sling Mock 1.1.4
Attachments: SLING-4437.patch
The {{MockJcrResourceResolverFactory}} class creates it's own mocked OSGi
BundleContext and uses it to create a ResourceResolverFactory. Part of the
OSGi environment initialization performed in the class is registering OSGi
services to be available by the mocked resolver. By default there is only one
service - SlingRepository.
However, the more recent versions of ResourceProvider implementations
requires other services, eg. PathMapper. Right now there is no way to inject
this service into the mocked OSGi container. The
{{MockJcrResourceResolverFactory}} should allow to register custom services,
so it'll be compatible with the future versions of ResourceResolvers and
Providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.7 #1471
See https://builds.apache.org/job/sling-trunk-1.7/1471/changes
Jenkins build is still unstable: sling-trunk-1.8 #762
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.6 #3082
See https://builds.apache.org/job/sling-trunk-1.6/changes
Re: Support getting versioned resources by using uri path parameters
Hello Antonio, On Thu, Feb 19, 2015 at 11:49 AM, Antonio Sanso asa...@adobe.com wrote: SLING-848 [0] introduces the versioned resources by using uri path parameters” concept. (...) How far we are to release the affected bundles ? I'm glad you like the SLING-848 :) There are integration tests for all changes which comes with this feature and I think we won't be more ready to do the release than we already are. However, I'd like to know the opinion of other Sling folks involved in the subject (Bertrand? Carsten?). The release plan would be as follows: First we need to release the org.apache.sling.api 2.8.2, to support new parameters in the API. Then we can release org.apache.sling.resourceresolver 1.1.16, so the resource resolver is aware of the parameters in URI and knows how to parse them. The last bundle to release is org.apache.sling.jcr.resource 2.4.6, so the JcrResourceResolver gets the parsed parameters and returns appropriate version of the node. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Closed] (SLING-4204) Better abstraction of internal Filter handling and add filter processing timing
[ https://issues.apache.org/jira/browse/SLING-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso closed SLING-4204. Better abstraction of internal Filter handling and add filter processing timing --- Key: SLING-4204 URL: https://issues.apache.org/jira/browse/SLING-4204 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.3.10 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: Engine 2.4.0 The Sling Engine web console configuration printer currently exposes all the Filter services that are used by the Sling engine. It would be great if we cold expose usage and timing information about those filters as well to see which filters attribute the most to request processing. At the same time internal filter handling can be improved to better abstract holding Filter services and leverage usage functionality such as said timing and tracking but also future requirements such as providing capabilities to not call filters unless some condition is met (e.g. only call a filter on certain resource types or paths) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4339) NullPointerException at org.apache.sling.engine.impl.parameters.RequestParameterSupportConfigurer.getFileLocation(RequestParameterSupportConfigurer.java:132)
[ https://issues.apache.org/jira/browse/SLING-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso closed SLING-4339. NullPointerException at org.apache.sling.engine.impl.parameters.RequestParameterSupportConfigurer.getFileLocation(RequestParameterSupportConfigurer.java:132) - Key: SLING-4339 URL: https://issues.apache.org/jira/browse/SLING-4339 Project: Sling Issue Type: Bug Components: Engine Reporter: Ronald Plöger Assignee: Carsten Ziegeler Fix For: Engine 2.4.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4421) Remove duplicate API method bodys
[ https://issues.apache.org/jira/browse/SLING-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso closed SLING-4421. Remove duplicate API method bodys - Key: SLING-4421 URL: https://issues.apache.org/jira/browse/SLING-4421 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.3.10 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.4.0 The engine API deprecates RequestUtil and ResponseUtil in favour of the variants from the Sling API. Instead of duplication the code from the Sling API, we should simply call the Sling API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4294) Servlet Filter Support adding sling.filter.pattern support
[ https://issues.apache.org/jira/browse/SLING-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso closed SLING-4294. Servlet Filter Support adding sling.filter.pattern support -- Key: SLING-4294 URL: https://issues.apache.org/jira/browse/SLING-4294 Project: Sling Issue Type: Improvement Components: Engine Reporter: Antonio Sanso Assignee: Antonio Sanso Fix For: Engine 2.4.0 Attachments: SLING-4294-patch.txt the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit like what currently can be done for Apache Felix filters. mailing list discussion in [1] [0] http://sling.apache.org/documentation/the-sling-engine/filters.html [1] http://markmail.org/message/lzp7qcienk3blwpk -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4420) Escape quotes and double quotes when escaping for XML
[ https://issues.apache.org/jira/browse/SLING-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso closed SLING-4420. Escape quotes and double quotes when escaping for XML - Key: SLING-4420 URL: https://issues.apache.org/jira/browse/SLING-4420 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.3.10 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.4.0 Currently only , and are escaped in the ResponseUtil, we should extend this to and ' in order to use the same functionality for writing out attributes as well as text. This has already been done in the Sling API version of this class (see SLING-3276), but although this class is deprecated we should apply the same encoding -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4437) MockJcrResourceResolverFactory should allow to register services dynamically.
[
https://issues.apache.org/jira/browse/SLING-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek updated SLING-4437:
-
Attachment: SLING-4437.patch
Patch proposal attached.
MockJcrResourceResolverFactory should allow to register services dynamically.
-
Key: SLING-4437
URL: https://issues.apache.org/jira/browse/SLING-4437
Project: Sling
Issue Type: Improvement
Reporter: Tomek Rękawek
Fix For: Testing Sling Mock 1.1.4
Attachments: SLING-4437.patch
The {{MockJcrResourceResolverFactory}} class creates it's own mocked OSGi
BundleContext and uses it to create a ResourceResolverFactory. Part of the
OSGi environment initialization performed in the class is registering OSGi
services to be available by the mocked resolver. By default there is only one
service - SlingRepository.
However, the more recent versions of ResourceProvider implementations
requires other services, eg. PathMapper. Right now there is no way to inject
this service into the mocked OSGi container. The
{{MockJcrResourceResolverFactory}} should allow to register custom services,
so it'll be compatible with the future versions of ResourceResolvers and
Providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Support getting versioned resources by using uri path parameters
Am 19.02.15 um 13:51 schrieb Tomek Rękawek: I'm glad you like the SLING-848 :) There are integration tests for all changes which comes with this feature and I think we won't be more ready to do the release than we already are. However, I'd like to know the opinion of other Sling folks involved in the subject (Bertrand? Carsten?). I'm fine with the changes :) The release plan would be as follows: First we need to release the org.apache.sling.api 2.8.2, to support new parameters in the API. This would be api 2.9.0 as it contains a new feature/api Then we can release org.apache.sling.resourceresolver 1.1.16, so the resource resolver is aware of the parameters in URI and knows how to parse them. Similar this is 1.2.0 The last bundle to release is org.apache.sling.jcr.resource 2.4.6, so the JcrResourceResolver gets the parsed parameters and returns appropriate version of the node. ...and...2.5.0 :) We could do the releases in one shot to safe some time, or one after the other Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build is back to stable : sling-trunk-1.6 #3083
See https://builds.apache.org/job/sling-trunk-1.6/3083/changes
Sightly Integration Test execution fails for me
I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
Jenkins build is still unstable: sling-trunk-1.8 #761
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Commented] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327341#comment-14327341
]
Antonio Sanso commented on SLING-3854:
--
committed jcr resource part in r1660869
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-848) Support getting versioned resources by using uri path parameters
[ https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327365#comment-14327365 ] Tomek Rękawek commented on SLING-848: - I created SLING-4437. Support getting versioned resources by using uri path parameters Key: SLING-848 URL: https://issues.apache.org/jira/browse/SLING-848 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.0.2 Reporter: Carsten Ziegeler Assignee: Tomek Rękawek Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0 Attachments: SLING-848-metadata.patch Getting versioned content should be support thorough uri path parameters, like /something/hello;v=1.1 For jcr based resources the value of the version should either point to a version name or label. In order to not change our existing apis, we introduce a new utility method which removes all uri path parameters and returns a map of these. Every resource provider could use this utility method and then decide to act on these parameters. If a requested version does not exists, a 404 is returned. If the requested node does not directly point to a versionable node, the algorithm checks the parent hierarchy until a versionable node is found, and tries to get the version of this node and then goes down the path again. If the versionable node does not have the requested version or the child, a 404 is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4437) MockJcrResourceResolverFactory should allow to register services dynamically.
[
https://issues.apache.org/jira/browse/SLING-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek updated SLING-4437:
-
Attachment: (was: SLING-4437.patch)
MockJcrResourceResolverFactory should allow to register services dynamically.
-
Key: SLING-4437
URL: https://issues.apache.org/jira/browse/SLING-4437
Project: Sling
Issue Type: Improvement
Reporter: Tomek Rękawek
Fix For: Testing Sling Mock 1.1.4
Attachments: SLING-4437.patch
The {{MockJcrResourceResolverFactory}} class creates it's own mocked OSGi
BundleContext and uses it to create a ResourceResolverFactory. Part of the
OSGi environment initialization performed in the class is registering OSGi
services to be available by the mocked resolver. By default there is only one
service - SlingRepository.
However, the more recent versions of ResourceProvider implementations
requires other services, eg. PathMapper. Right now there is no way to inject
this service into the mocked OSGi container. The
{{MockJcrResourceResolverFactory}} should allow to register custom services,
so it'll be compatible with the future versions of ResourceResolvers and
Providers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.7 #1472
See https://builds.apache.org/job/sling-trunk-1.7/1472/changes
Re: Support getting versioned resources by using uri path parameters
Hi, On Thu, Feb 19, 2015 at 2:13 PM, Carsten Ziegeler cziege...@apache.org wrote: First we need to release the org.apache.sling.api 2.8.2, to support new (...) This would be api 2.9.0 as it contains a new feature/api Then we can release org.apache.sling.resourceresolver 1.1.16, so the (...) Similar this is 1.2.0 The last bundle to release is org.apache.sling.jcr.resource 2.4.6 (...) ...and...2.5.0 :) Of course :) We could do the releases in one shot to safe some time, or one after the other I'd do them in one shot. Am I entitled - as a committer - to propose a vote for a release or should it be done by the PMC member? Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Commented] (SLING-3781) Fix unstable Eclipse-based tests
[ https://issues.apache.org/jira/browse/SLING-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327415#comment-14327415 ] Robert Munteanu commented on SLING-3781: Ensure that when a deleted resource is turned into an update ( see SLING-3741 ) the parents are created if needed - https://svn.apache.org/viewvc?view=revisionrevision=1660881 Fix unstable Eclipse-based tests Key: SLING-3781 URL: https://issues.apache.org/jira/browse/SLING-3781 Project: Sling Issue Type: Test Components: IDE, Testing Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 The eclipse-based tests from the eclipse-test project don't always pass. These are likely timing issues, but they result in lower confidence in their ability to catch regression tests. Here's what I have so far: * importFilesAndFoldersRespectsVltFilters(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * importFilesWithExtraNodesUnderJcrContent(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * deploySlingOrderedFolderWithJcrContentNode(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root * deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test/hello.esp * deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected status call for http://localhost:40325/test/hello.txt * deployNodeWithContentXmlInParentFolder_reverse(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root/mapping/jcr:content/par/folder * changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test * importFullCoverageNode(org.apache.sling.ide.test.impl.ContentImportTest): Unexpected events captured during import : -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-848) Support getting versioned resources by using uri path parameters
[ https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek resolved SLING-848. - Resolution: Fixed Support getting versioned resources by using uri path parameters Key: SLING-848 URL: https://issues.apache.org/jira/browse/SLING-848 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.0.2 Reporter: Carsten Ziegeler Assignee: Tomek Rękawek Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0 Attachments: SLING-848-metadata.patch Getting versioned content should be support thorough uri path parameters, like /something/hello;v=1.1 For jcr based resources the value of the version should either point to a version name or label. In order to not change our existing apis, we introduce a new utility method which removes all uri path parameters and returns a map of these. Every resource provider could use this utility method and then decide to act on these parameters. If a requested version does not exists, a 404 is returned. If the requested node does not directly point to a versionable node, the algorithm checks the parent hierarchy until a versionable node is found, and tries to get the version of this node and then goes down the path again. If the versionable node does not have the requested version or the child, a 404 is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-848) Support getting versioned resources by using uri path parameters
[ https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327351#comment-14327351 ] Stefan Seifert commented on SLING-848: -- no problem, it was just not obvious to me that this ticket related the sling mock as well. please create a new sling ticket concerning sling mock to think about a better solution for point 6 without the code duplication, and reference it with this ticket. i will have to think about it. perhaps we can make MockJcrResourceResolverFactory ab bit more pluggable for this. i fear this is not the last time we will face such issues as the referenced/mocked bundles itself are further developed. Support getting versioned resources by using uri path parameters Key: SLING-848 URL: https://issues.apache.org/jira/browse/SLING-848 Project: Sling Issue Type: New Feature Components: JCR Affects Versions: JCR Resource 2.0.2 Reporter: Carsten Ziegeler Assignee: Tomek Rękawek Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0 Attachments: SLING-848-metadata.patch Getting versioned content should be support thorough uri path parameters, like /something/hello;v=1.1 For jcr based resources the value of the version should either point to a version name or label. In order to not change our existing apis, we introduce a new utility method which removes all uri path parameters and returns a map of these. Every resource provider could use this utility method and then decide to act on these parameters. If a requested version does not exists, a 404 is returned. If the requested node does not directly point to a versionable node, the algorithm checks the parent hierarchy until a versionable node is found, and tries to get the version of this node and then goes down the path again. If the versionable node does not have the requested version or the child, a 404 is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Support getting versioned resources by using uri path parameters
Am 19.02.15 um 14:43 schrieb Tomek Rękawek: I'd do them in one shot. Am I entitled - as a committer - to propose a vote for a release or should it be done by the PMC member? You are allowed and encouraged :) to do the release. Only one step of the whole process (copying the release artifacts to the dist directory) requires a PMC member and if you simply write a mail to this list once that step is reached, someone will happily pick up that task. Afaik, before we do the release there is some open work on the jcr.resource module by Antonio. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-3781) Fix unstable Eclipse-based tests
[ https://issues.apache.org/jira/browse/SLING-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327443#comment-14327443 ] Robert Munteanu commented on SLING-3781: Increased event settle timeout in https://svn.apache.org/viewvc?view=revisionrevision=r1660887 Fix unstable Eclipse-based tests Key: SLING-3781 URL: https://issues.apache.org/jira/browse/SLING-3781 Project: Sling Issue Type: Test Components: IDE, Testing Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 The eclipse-based tests from the eclipse-test project don't always pass. These are likely timing issues, but they result in lower confidence in their ability to catch regression tests. Here's what I have so far: * importFilesAndFoldersRespectsVltFilters(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * importFilesWithExtraNodesUnderJcrContent(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * deploySlingOrderedFolderWithJcrContentNode(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root * deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test/hello.esp * deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected status call for http://localhost:40325/test/hello.txt * deployNodeWithContentXmlInParentFolder_reverse(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root/mapping/jcr:content/par/folder * changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test * importFullCoverageNode(org.apache.sling.ide.test.impl.ContentImportTest): Unexpected events captured during import : -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Support getting versioned resources by using uri path parameters
Hi, On Thu, Feb 19, 2015 at 2:53 PM, Carsten Ziegeler cziege...@apache.org wrote: You are allowed and encouraged :) to do the release. (...) I feel the thrill ;) I started with the API, as the resolver and JCR resource modules will need API 2.9.0 in their dependencies. Best regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Created] (SLING-4439) OSGi Mock: Handle dynamic service references updates
Stefan Seifert created SLING-4439: - Summary: OSGi Mock: Handle dynamic service references updates Key: SLING-4439 URL: https://issues.apache.org/jira/browse/SLING-4439 Project: Sling Issue Type: New Feature Components: Testing Affects Versions: Testing OSGi Mock 1.1.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing OSGi Mock 1.1.2 currently service references are only injected when registering the services. updates after this e.g. when a another service is referenced matching an optional or multiple references this is currently ignored. we should handle this in the mock context as well at least in a basic way to support unit tests. this is required e.g. to resolve SLING-4434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Apache Sling API version 2.9.0
hi Tomek, it looks like you did not go through the key creation steps… /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/2.9.0/org.apache.sling.api-2.9.0-javadoc.jar gpg: BAD md5 : GOOD (6c2d1cf78e3b17d673f2602f6df140fe) sha1 : GOOD (826f7ef7667b4cae30b174ac1e1dc9ebe54deb53) /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/2.9.0/org.apache.sling.api-2.9.0-source-release.zip gpg: BAD md5 : GOOD (cc9cffc562de7f774d24d632807f52d0) sha1 : GOOD (f7878651ff9c252cbf1b829cc769bd45f961daab) /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/2.9.0/org.apache.sling.api-2.9.0-sources.jar gpg: BAD md5 : GOOD (f5a60ff7991ff7a1626cf9752fca72bf) sha1 : GOOD (da808a792782bb2b371ef4d95cc9187fd12b75d8) /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/2.9.0/org.apache.sling.api-2.9.0.jar gpg: BAD md5 : GOOD (b42fa3966c466c771d19a4ad7cfadf97) sha1 : GOOD (cfcd8f2fa9e359e9cc92755fa1db995afd899e6d) /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/2.9.0/org.apache.sling.api-2.9.0.pom gpg: BAD md5 : GOOD (a6c0e0af961233303184cef20878826b) sha1 : GOOD (de99d6a3c6834baf7236af1ea4d9c640271de4c7) /tmp/sling-staging/1188/org/apache/sling/org.apache.sling.api/maven-metadata.xml gpg: md5 : GOOD (06ec750e8b858a1926c6f3f060b12229) sha1 : GOOD (687993172a83276b61a9bdb57d2d54e3613616d3) or might be just me but I can’t find you here gpg: key 9E4DCC6B: Bertrand Delacretaz (CODE SIGNING KEY) bdelacre...@apache.orgmailto:bdelacre...@apache.org not changed gpg: key F2F27A06: Carsten Ziegeler (CODE SIGNING KEY) cziege...@apache.orgmailto:cziege...@apache.org not changed 100 174k 100 174k0 0 109k 0 0:00:01 0:00:01 --:--:-- 109k gpg: key E41EDC7E: Carsten Ziegeler cziege...@apache.orgmailto:cziege...@apache.org not changed gpg: key F79B7715: Felix Meschberger fmesc...@apache.orgmailto:fmesc...@apache.org not changed gpg: key 40E47E14: Ian Boston i...@apache.orgmailto:i...@apache.org not changed gpg: key 134B145C: Justin Edelson (CODE SIGNING KEY) jus...@apache.orgmailto:jus...@apache.org not changed gpg: key F79F6478: Mike Mueller (CODE SIGNING KEY) my...@apache.orgmailto:my...@apache.org not changed gpg: key 8DB0F512: Antonio Sanso (CODE SIGNING KEY) asa...@apache.orgmailto:asa...@apache.org not changed gpg: key 4C6E4124: Dan Klco (CODE SIGNING KEY) dk...@apache.orgmailto:dk...@apache.org not changed gpg: key 1E60C54E: Stefan Egli (CODE SIGNING KEY) stefane...@apache.orgmailto:stefane...@apache.org not changed gpg: key 4F63EC54: Robert Munteanu romb...@apache.orgmailto:romb...@apache.org not changed gpg: key 7120565E: Amit Gupta (CODE SIGNING KEY) amitg...@apache.orgmailto:amitg...@apache.org not changed gpg: key 0E4B0826: Oliver Lietz o...@apache.orgmailto:o...@apache.org not changed gpg: key 88E59E02: Chetan Mehrotra (CODE SIGNING KEY) chet...@apache.orgmailto:chet...@apache.org not changed gpg: key 3C1E73F8: Tommaso Teofili tomm...@apache.orgmailto:tomm...@apache.org not changed gpg: key 75D78E92: Stefan Seifert sseif...@apache.orgmailto:sseif...@apache.org not changed gpg: key 964478D3: Radu Cotescu (CODE SIGNING KEY) r...@apache.orgmailto:r...@apache.org not changed regards antonio On Feb 19, 2015, at 4:01 PM, Tomek Rękawek tomasz.reka...@cognifide.commailto:tomasz.reka...@cognifide.com wrote: Hi, We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327958 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/component/12311944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1188/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1188 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Updated] (SLING-4438) Don't execute duplicate or out-of-order commands
[ https://issues.apache.org/jira/browse/SLING-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4438: --- Description: Content sync operations work through commands created on demand by SlingLaunchpadBehaviour. Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples: - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed - Deleting a path attempts to delete the parent _and_ all children nodes We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 . The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue. A nice side-effect is that we can rely on the number of events generated, and can use that for wait for events to settle in tests, instead of hard-coding wait times. was: Content sync operations work through commands created on demand by SlingLaunchpadBehaviour. Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples: - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed - Deleting a path attempts to delete the parent _and_ all children nodes We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 . The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue. Don't execute duplicate or out-of-order commands Key: SLING-4438 URL: https://issues.apache.org/jira/browse/SLING-4438 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Critical Fix For: Sling Eclipse IDE 1.1.0 Content sync operations work through commands created on demand by SlingLaunchpadBehaviour. Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples: - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed - Deleting a path attempts to delete the parent _and_ all children nodes We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 . The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue. A nice side-effect is that we can rely on the number of events generated, and can use that for wait for events to settle in tests, instead of hard-coding wait times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-848) Support getting versioned resources by using uri path parameters
[ https://issues.apache.org/jira/browse/SLING-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated SLING-848: Component/s: ResourceResolver API Support getting versioned resources by using uri path parameters Key: SLING-848 URL: https://issues.apache.org/jira/browse/SLING-848 Project: Sling Issue Type: New Feature Components: API, JCR, ResourceResolver Affects Versions: JCR Resource 2.0.2 Reporter: Carsten Ziegeler Assignee: Tomek Rękawek Fix For: JCR Resource 2.5.0, API 2.9.0, Resource Resolver 1.2.0 Attachments: SLING-848-metadata.patch Getting versioned content should be support thorough uri path parameters, like /something/hello;v=1.1 For jcr based resources the value of the version should either point to a version name or label. In order to not change our existing apis, we introduce a new utility method which removes all uri path parameters and returns a map of these. Every resource provider could use this utility method and then decide to act on these parameters. If a requested version does not exists, a 404 is returned. If the requested node does not directly point to a versionable node, the algorithm checks the parent hierarchy until a versionable node is found, and tries to get the version of this node and then goes down the path again. If the versionable node does not have the requested version or the child, a 404 is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.8 #763
See https://builds.apache.org/job/sling-trunk-1.8/763/changes
Jenkins build became unstable: sling-trunk-1.6 #3087
See https://builds.apache.org/job/sling-trunk-1.6/3087/changes
Jenkins build is back to stable : sling-trunk-1.8 #768
See https://builds.apache.org/job/sling-trunk-1.8/768/changes
[jira] [Resolved] (SLING-4441) The JavaUseProvider should return a failure for any exception encountered during Use object retrieval
[
https://issues.apache.org/jira/browse/SLING-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4441.
-
Resolution: Fixed
Fixed in
[r1661012|https://svn.apache.org/viewvc?view=revisionrevision=1661012].
The JavaUseProvider should return a failure for any exception encountered
during Use object retrieval
-
Key: SLING-4441
URL: https://issues.apache.org/jira/browse/SLING-4441
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
The {{JavaUseProvider}} should return a failure for any exception encountered
during Use object retrieval, not only for {{CompilerException}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.6 #3089
See https://builds.apache.org/job/sling-trunk-1.6/3089/changes
[jira] [Resolved] (SLING-3781) Fix unstable Eclipse-based tests
[ https://issues.apache.org/jira/browse/SLING-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3781. Resolution: Fixed Fix unstable Eclipse-based tests Key: SLING-3781 URL: https://issues.apache.org/jira/browse/SLING-3781 Project: Sling Issue Type: Test Components: IDE, Testing Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 The eclipse-based tests from the eclipse-test project don't always pass. These are likely timing issues, but they result in lower confidence in their ability to catch regression tests. Here's what I have so far: * importFilesAndFoldersRespectsVltFilters(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * importFilesWithExtraNodesUnderJcrContent(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * deploySlingOrderedFolderWithJcrContentNode(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root * deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test/hello.esp * deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected status call for http://localhost:40325/test/hello.txt * deployNodeWithContentXmlInParentFolder_reverse(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root/mapping/jcr:content/par/folder * changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test * importFullCoverageNode(org.apache.sling.ide.test.impl.ContentImportTest): Unexpected events captured during import : -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-3781) Fix unstable Eclipse-based tests
[ https://issues.apache.org/jira/browse/SLING-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328234#comment-14328234 ] Robert Munteanu commented on SLING-3781: * https://svn.apache.org/viewvc?view=revisionrevision=r1661018 - Added PathUtil.getParent * https://svn.apache.org/viewvc?view=revisionrevision=r1661019 - Added JcrCommand.dumpNode to aid with debugging * https://svn.apache.org/viewvc?view=revisionrevision=r1661020 - Remove existing workardound, it was broken * https://svn.apache.org/viewvc?view=revisionrevision=r1661021 - Also consider regular files when mapping resource deletions to updates * https://svn.apache.org/viewvc?view=revisionrevision=r1661022 - Add a Thread.sleep inside the last failing test Fix unstable Eclipse-based tests Key: SLING-3781 URL: https://issues.apache.org/jira/browse/SLING-3781 Project: Sling Issue Type: Test Components: IDE, Testing Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 The eclipse-based tests from the eclipse-test project don't always pass. These are likely timing issues, but they result in lower confidence in their ability to catch regression tests. Here's what I have so far: * importFilesAndFoldersRespectsVltFilters(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * importFilesWithExtraNodesUnderJcrContent(org.apache.sling.ide.test.impl.ContentImportTest): Unable to update a stale item: item.save() * deploySlingOrderedFolderWithJcrContentNode(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root * deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test/hello.esp * deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected status call for http://localhost:40325/test/hello.txt * deployNodeWithContentXmlInParentFolder_reverse(org.apache.sling.ide.test.impl.JcrPartialCoverageAggregatesDeploymentTest): javax.jcr.PathNotFoundException: /content/test-root/mapping/jcr:content/par/folder * changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest): javax.jcr.PathNotFoundException: /test * importFullCoverageNode(org.apache.sling.ide.test.impl.ContentImportTest): Unexpected events captured during import : -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4100) Improve selection and ordering when choosing an archetype
[ https://issues.apache.org/jira/browse/SLING-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4100: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Improve selection and ordering when choosing an archetype - Key: SLING-4100 URL: https://issues.apache.org/jira/browse/SLING-4100 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 The archetype selection page from the bundle creation wizard should - order the archetypes by version descending ( we don't have multiple group+artifact combinations yet ) - preselect the latest version -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4032) Prevent the same resource from being published twice
[ https://issues.apache.org/jira/browse/SLING-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4032: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Prevent the same resource from being published twice Key: SLING-4032 URL: https://issues.apache.org/jira/browse/SLING-4032 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 When publishing resource changes, it can happen that two workspace resources refer to the same repository resource, e.g. /content/page and /content/page/.content.xml, where /content/page is a sling:Folder To make publish operations faster, we should only run the AddOrUpdate and ReorderChildNode commands once for each repository resource in one publish operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-3591) Unable to delete all nodes of a full coverage aggregate
[ https://issues.apache.org/jira/browse/SLING-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3591: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Unable to delete all nodes of a full coverage aggregate --- Key: SLING-3591 URL: https://issues.apache.org/jira/browse/SLING-3591 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 With the fix for SLING-3590 it is no longer possible to delete all nodes of a full coverage aggregate. Pushing to 1.0.2 since - it is not an usual scenario - it requires some changes to the Sling IDE Resource API, which I'd like to defer for now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4071) Remove manual interactions related to the tooling support bundle
[ https://issues.apache.org/jira/browse/SLING-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4071: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Remove manual interactions related to the tooling support bundle Key: SLING-4071 URL: https://issues.apache.org/jira/browse/SLING-4071 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 We currently have a UI for installing/reinstalling the tooling support bundle, but we install it automatically when connecting it to the server anyway. I believe that we should rather catch all situations where we don't automatically install the bundle and then remove all traces of manual control from the UI. One scenario that I'm aware of is - Create a new server instance - Start a launchpad - Uninstall the tooling support bundle - Add a bundle module to the server instance -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-3784) Convert majority of eclipse-based tests to test vlt commands or the ResourceChangeCommandFactory
[
https://issues.apache.org/jira/browse/SLING-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3784:
---
Fix Version/s: (was: Sling Eclipse IDE 1.0.6)
Sling Eclipse IDE 1.0.8
Convert majority of eclipse-based tests to test vlt commands or the
ResourceChangeCommandFactory
Key: SLING-3784
URL: https://issues.apache.org/jira/browse/SLING-3784
Project: Sling
Issue Type: Test
Components: IDE, Testing
Affects Versions: Sling Eclipse IDE 1.0.2
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.8
The current mechanism for content sync is
* for reach resource change/build event/manual publish
* {{SlingContentModuleFactory}} generates lists of module resources
* Eclipse change detection mechanism generates a diff
* {{SlingLaunchpadBehaviour}} invokes the {{ResourceChangeCommandFactory}}
to build vlt commands
* vlt commands are executed
The current eclipse-based tests, while useful, exercise the whole process and
are therefore more brittle and more difficult to write that the alternatives
testing a smaller part of the stack
We now have tests in place for each of the steps ( excluding of course
Eclipse diff generation, but that's out of scope ). Moving the tests to
simpler fixtures will make the tests more stable, faster and easier to write.
We should still keep some end-to-end tests, but we will not aim to test all
scenarios end-to-end.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4031) Missing MANIFEST.MF should be a validation error
[
https://issues.apache.org/jira/browse/SLING-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4031:
---
Fix Version/s: (was: Sling Eclipse IDE 1.0.6)
Sling Eclipse IDE 1.0.8
Missing MANIFEST.MF should be a validation error
Key: SLING-4031
URL: https://issues.apache.org/jira/browse/SLING-4031
Project: Sling
Issue Type: Test
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.2
Reporter: Robert Munteanu
Priority: Minor
Fix For: Sling Eclipse IDE 1.0.8
I just noticed a warning on the Sling console when a bundle was rebuilt
{quote}[October 11, 2014 2:09:53 AM EEST] InstallBundle -
/home/ADOBENET/rmuntean/Downloads/import/myproject/components/target/classes
: Project P/myproject.components does not have a META-INF/MANIFEST.MF (yet) -
not publishing this time (0 ms)
{quote}
This should be a validation error and block publishing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4076) Add more file type options to New... menu
[ https://issues.apache.org/jira/browse/SLING-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4076: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Add more file type options to New... menu - Key: SLING-4076 URL: https://issues.apache.org/jira/browse/SLING-4076 Project: Sling Issue Type: Improvement Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Justin Edelson Fix For: Sling Eclipse IDE 1.0.8 Opening the New context menu on a JCR node currently shows these options: * Project... * Example... * Other... * Node... This list should have File and Folder added to it and, ideally, JSP File, HTML File, JS File, CSS File, and Text File. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-3607) Resource deletion can delete too much
[ https://issues.apache.org/jira/browse/SLING-3607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3607: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Resource deletion can delete too much - Key: SLING-3607 URL: https://issues.apache.org/jira/browse/SLING-3607 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 There are two issue with the deletion code: * it deletes .content.xml files * it deletes everything under a subtree, even though it would be enough to just delete the subtree root -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4036) Changing the jcr primary type does not work if mandatory properties are added
[ https://issues.apache.org/jira/browse/SLING-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4036: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Changing the jcr primary type does not work if mandatory properties are added - Key: SLING-4036 URL: https://issues.apache.org/jira/browse/SLING-4036 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 Similar to SLING-4035, but this time use a node type which has at least one mandatory property. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4037) AddOrUpdateNodeCommandTest should connect to the repository via WebDAV remoting
[ https://issues.apache.org/jira/browse/SLING-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4037: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 AddOrUpdateNodeCommandTest should connect to the repository via WebDAV remoting --- Key: SLING-4037 URL: https://issues.apache.org/jira/browse/SLING-4037 Project: Sling Issue Type: Test Components: IDE, Testing Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 I've seen some minor differences in behaviour between accessing the repository directly and accesing via WebDAV remoting, especially related to node type changes. To make sure our tests exercise the same code paths, they should use the same access mechanism. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4438) Don't execute duplicate or out-of-order commands
[ https://issues.apache.org/jira/browse/SLING-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4438: --- Fix Version/s: (was: Sling Eclipse IDE 1.1.0) Sling Eclipse IDE 1.0.8 Don't execute duplicate or out-of-order commands Key: SLING-4438 URL: https://issues.apache.org/jira/browse/SLING-4438 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Critical Fix For: Sling Eclipse IDE 1.0.8 Content sync operations work through commands created on demand by SlingLaunchpadBehaviour. Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples: - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed - Deleting a path attempts to delete the parent _and_ all children nodes We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 . The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue. A nice side-effect is that we can rely on the number of events generated, and can use that for wait for events to settle in tests, instead of hard-coding wait times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4030) Create test for creating resources with missing parents while server is stopped
[ https://issues.apache.org/jira/browse/SLING-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4030: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Create test for creating resources with missing parents while server is stopped --- Key: SLING-4030 URL: https://issues.apache.org/jira/browse/SLING-4030 Project: Sling Issue Type: Test Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 The scenario covered in SLING-3586 and detailed in https://issues.apache.org/jira/browse/SLING-3586?focusedCommentId=14166984page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14166984 should be covered by a regression test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4070) Validation errors are not cleared
[ https://issues.apache.org/jira/browse/SLING-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4070: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Validation errors are not cleared - Key: SLING-4070 URL: https://issues.apache.org/jira/browse/SLING-4070 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 Our validators don't clean the previous validation messages when the root cause is fixed, so error messages will pile up until a full build is triggered. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-3775) Review allowed-children node type check
[ https://issues.apache.org/jira/browse/SLING-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3775: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Review allowed-children node type check --- Key: SLING-3775 URL: https://issues.apache.org/jira/browse/SLING-3775 Project: Sling Issue Type: Bug Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.8 SLING-3774 describes a case where a cq:ClientLibraryFolder did not accept a sling:Folder as a child - hence preventing a node type change to the latter. This needs to be reviewed, as to why ntManager.isAllowedPrimaryChildNodeType(cq:ClientLibraryFolder, sling:Folder) would return false.. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4427) Inneficient JcrNode.hashCode and equals
[
https://issues.apache.org/jira/browse/SLING-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4427:
---
Fix Version/s: (was: Sling Eclipse IDE 1.0.6)
Sling Eclipse IDE 1.0.8
Inneficient JcrNode.hashCode and equals
---
Key: SLING-4427
URL: https://issues.apache.org/jira/browse/SLING-4427
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.8
On certain paths, JcrNode equals and hashcode perform copies of the their
domElement, manipulate them and use them for equals/hashCode computations,
e.g.
{code:java} Element domElementCopy = domElement.copy();
domElementCopy.clearChildren();
Element otherDomElementCopy = other.domElement.copy();
otherDomElementCopy.clearChildren();
return
domElementCopy.toString().equals(otherDomElementCopy.toString());{code}
This has the potential to be quite expensive and should be corrected
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4043) The JCR properties view does not display escaped properties with escaped values correctly
[
https://issues.apache.org/jira/browse/SLING-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4043:
---
Fix Version/s: (was: Sling Eclipse IDE 1.0.6)
Sling Eclipse IDE 1.0.8
The JCR properties view does not display escaped properties with escaped
values correctly
-
Key: SLING-4043
URL: https://issues.apache.org/jira/browse/SLING-4043
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.2
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.8
Consider a property serialized as
{noformat}org.apache.sling.commons.log.pattern=\{0,date,-MM-dd
HH:mm:ss.SSS} {4} [{3}] {5}{noformat}
The value displayed by the JCR properties view is {noformat}{4} [{3}]
{5}{noformat}, while the value displayed when editing is
{noformat}\{0,date,-MM-dd HH:mm:ss.SSS} {4} [{3}] {5}{noformat}
In fact, both the display and edit modes should work with the unescaped value
{noformat}{0,date,-MM-dd HH:mm:ss.SSS} {4} [{3}] {5}{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4003) Investigate compatibility with m2eclipse-tycho 0.7.0 or newer
[ https://issues.apache.org/jira/browse/SLING-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4003: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 Investigate compatibility with m2eclipse-tycho 0.7.0 or newer - Key: SLING-4003 URL: https://issues.apache.org/jira/browse/SLING-4003 Project: Sling Issue Type: Task Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 With commit [85cd048f|https://github.com/tesla/m2eclipse-tycho/commit/85cd048ffcd47020992bdec2cd44f1a4945173bf] m2eclipse-tycho will no longer regenerate the bundle's manifest on each change. This will result in improved performance. However, it might also mean that when a new SCR component is added the manifest's Service-Component will not get updated with the location of the newly generated descriptor files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4045) Lack of support for multi-facet (content and bundle) projects
[
https://issues.apache.org/jira/browse/SLING-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4045:
---
Fix Version/s: (was: Sling Eclipse IDE 1.1.0)
Sling Eclipse IDE 1.0.8
Lack of support for multi-facet (content and bundle) projects
-
Key: SLING-4045
URL: https://issues.apache.org/jira/browse/SLING-4045
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.2
Reporter: Kamil Ciecierski
Fix For: Sling Eclipse IDE 1.0.8
Attachments: aemtools.zip
I am working on the project which is +not based+ on
com.adobe.granite.archetype: sample-project-archetype. My project also
contains multiple module projects, but some of them contain both java and jsp
files under paths:
* java files: _module-name/src/main/java/groupName/..._
* jsp files: _module-name/src/main/aem/jcr_root/apps or
etc/app-name..._
Basically it looks like merged _core_ module and _ui.apps_ module from _AEM
Sample Multi-Module Project_/
When I configure my module as Content Project the *jsp* files are uploaded
to the server automatically, but the plugin does not respond on *java* files
changes.
When I configure my module as Bundle Project the *java* files are uploaded
to the server automatically, but the plugin does not respond on *jsp* files
changes.
I've also tested converting project to Faceted Form by doing:
* Right click on module project and choosing _Configure/Convert to Faceted
Form_
* Choosing _Content module_ and _Bundle module_ from _Project facet list_
* Clicking Apply and OK.
After this _org.eclipse.wst.common.project.facet.core.xml_ is generated under
the path: _module-name/.settings_ which looks like this:
{code}
?xml version=1.0 encoding=UTF-8?
faceted-project
installed facet=sling.bundle version=1.0/
installed facet=sling.content version=1.0/
/faceted-project
{code}
After this if I start editing *jsp* files at first then the content files are
uploaded to server but *java* uploading isn't working - I see _ JcrResult[
success:true]_ in Sling logs.
If I start editing *java* files at first then the java files are uploaded to
server, but *jsp* uploading isn't working - I see logs that _target\classes_
is uploaded_.
I conclusion, I can't make plugin to work correctly with the modules
containing both jsp and java files. I also don't know if you planned the
support for this kind of projects or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-3862) Publish operation fails if the bundle to be updated is starting or stopping
[ https://issues.apache.org/jira/browse/SLING-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3862: --- Fix Version/s: (was: Sling Eclipse IDE 1.1.0) Sling Eclipse IDE 1.0.8 Publish operation fails if the bundle to be updated is starting or stopping --- Key: SLING-3862 URL: https://issues.apache.org/jira/browse/SLING-3862 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.8 If the bundle that is to be updated is slow to start and is deployed multiple times in a short interval, the subsequent operations will fail, with a message similar to Failed installing bundle : Unable to install/update bundle from dir /location/target/classes : Bundle some.bundle [377] cannot be update, since it is either starting or stopping. Unable to install/update bundle from dir /location/target/classes : Bundle some.bundle [377] cannot be update, since it is either starting or stopping. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4091) Non-Java content is not deployed if the connection is made in debug mode
[ https://issues.apache.org/jira/browse/SLING-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4091: --- Fix Version/s: (was: Sling Eclipse IDE 1.1.0) Sling Eclipse IDE 1.0.8 Non-Java content is not deployed if the connection is made in debug mode Key: SLING-4091 URL: https://issues.apache.org/jira/browse/SLING-4091 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 If we connect to the server in debug mode we rely on the debug connection to update changes to Java files. This means that changes to non-java files, e.g. content files deployed with the JCR content loader will not be published. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4034) ListTreeCommand should not use the EventAdmin directly
[ https://issues.apache.org/jira/browse/SLING-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4034: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.6) Sling Eclipse IDE 1.0.8 ListTreeCommand should not use the EventAdmin directly -- Key: SLING-4034 URL: https://issues.apache.org/jira/browse/SLING-4034 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.2 Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.8 The ListTreeCommand uses the EventAdmin directly for logging, but it should be wrapped by a TracingCommand instead. That would bring the benefit of not logging a lot of command executions when connecting to the server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328635#comment-14328635
]
Carsten Ziegeler commented on SLING-4312:
-
bq. One more question: The ServiceUserMapping exposes only serviceName and
subServiceName. I did not expose also the serviceUserId as this seems to be
something that should not be known to a consumer. Is it OK?
Yes. I think that makes sense
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Sightly Integration Test execution fails for me
Hi Radu, I use UTF-8 as default encoding as well. The issue only occurs when using it with JDK 1.7.0_55. Using JDK 1.7.0_60 or later solves the issue. So it is probably related to one issue being fixed in 1.7.0_60: http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html Konrad On 20 Feb 2015, at 02:33, Radu Cotescu r...@cotescu.com wrote: Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
[jira] [Commented] (SLING-4436) org.apache.sling.scripting.sightly does not compile
[
https://issues.apache.org/jira/browse/SLING-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328655#comment-14328655
]
Konrad Windszus commented on SLING-4436:
{{org.eclipse.core:resource:3.4.0}} is not available from Maven Central:
http://search.maven.org/#search|gav|1|g%3A%22org.eclipse.core%22%20AND%20a%3A%22resources%22.
Probably you are using another maven repository which has that artifact. Just
remove your settings.xml to reproduce the issue.
org.apache.sling.scripting.sightly does not compile
---
Key: SLING-4436
URL: https://issues.apache.org/jira/browse/SLING-4436
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Konrad Windszus
The current 1.0.0-SNAPSHOT version of the
{{org.apache.sling.scripting.sightly}} Maven module doesn't compile, as it
can't find the {{org.eclipse.core:resources:jar:3.4.0}} transitive dependency
included in {{org.apache.sling.commons.compiler:2.0.0}}.
In order to reproduce, clean your local Maven repository and try to compile
the aforementioned module.
The fix would be to increase that dependency to
{{org.apache.sling.commons.compiler:2.2.0}}. Compare with SLING-4379.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Sightly Integration Test execution fails for me
Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
[jira] [Created] (SLING-4440) Don't remove autoCreated properties
Robert Munteanu created SLING-4440:
--
Summary: Don't remove autoCreated properties
Key: SLING-4440
URL: https://issues.apache.org/jira/browse/SLING-4440
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The content sync tries to remove auto-created properties when they no longer
exist:
{noformat}
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt : Removed
property jcr:created from node at
/content/test-root/mapping/jcr:content/par/folder
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt : Removed
property jcr:createdBy from node at
/content/test-root/mapping/jcr:content/par/folder
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.8 #764
See https://builds.apache.org/job/sling-trunk-1.8/764/changes
Jenkins build became unstable: sling-trunk-1.6 #3085
See https://builds.apache.org/job/sling-trunk-1.6/3085/changes
Jenkins build is still unstable: sling-trunk-1.8 #765
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Resolved] (SLING-4439) OSGi Mock: Handle dynamic service references updates
[ https://issues.apache.org/jira/browse/SLING-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-4439. --- Resolution: Fixed Completed: At revision: 1660943 OSGi Mock: Handle dynamic service references updates Key: SLING-4439 URL: https://issues.apache.org/jira/browse/SLING-4439 Project: Sling Issue Type: New Feature Components: Testing Affects Versions: Testing OSGi Mock 1.1.0 Reporter: Stefan Seifert Assignee: Stefan Seifert Labels: mocks Fix For: Testing OSGi Mock 1.1.2 currently service references are only injected when registering the services. updates after this e.g. when a another service is referenced matching an optional or multiple references this is currently ignored. we should handle this in the mock context as well at least in a basic way to support unit tests. this is required e.g. to resolve SLING-4434 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Support getting versioned resources by using uri path parameters
On Feb 19, 2015, at 2:53 PM, Carsten Ziegeler cziege...@apache.org wrote: Am 19.02.15 um 14:43 schrieb Tomek Rękawek: I'd do them in one shot. Am I entitled - as a committer - to propose a vote for a release or should it be done by the PMC member? You are allowed and encouraged :) to do the release. Only one step of the whole process (copying the release artifacts to the dist directory) requires a PMC member and if you simply write a mail to this list once that step is reached, someone will happily pick up that task. Afaik, before we do the release there is some open work on the jcr.resource module by Antonio. already committed , so green light from me :) regards antonio Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Created] (SLING-4438) Don't execute duplicate or out-of-order commands
Robert Munteanu created SLING-4438: -- Summary: Don't execute duplicate or out-of-order commands Key: SLING-4438 URL: https://issues.apache.org/jira/browse/SLING-4438 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Priority: Critical Fix For: Sling Eclipse IDE 1.1.0 Content sync operations work through commands created on demand by SlingLaunchpadBehaviour. Right now the order is ad-hoc and there is no guarantee that duplicate or redundant commands are not executed. Some examples: - Trying to add an sling:Folder resource twice since it seems both the directory and the .content.xml file as changed - Deleting a path attempts to delete the parent _and_ all children nodes We also have some akwardness to make sure that SLING-3741 works as expected, see https://svn.apache.org/r1660881 . The fix would be to have generate the commands, pass them to a provider-specific command queue, which insures that the above cases are handled as expected and then execute the commands in the order returned by the queue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327589#comment-14327589
]
Marius Petria commented on SLING-4312:
--
Implemented also the FindHook.
One more question: The ServiceUserMapping exposes only serviceName and
subServiceName. I did not expose also the serviceUserId as this seems to be
something that should not be known to a consumer. Is it OK?
[1] https://github.com/mpetria/sling/compare/mpetria:trunk...dev-SLING-4312
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling API version 2.9.0
+1 Tomek On Thu, Feb 19, 2015 at 4:01 PM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hi, We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327958 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/component/12311944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1188/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1188 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[VOTE] Release Apache Sling API version 2.9.0
Hi, We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327958 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/component/12311944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1188/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1188 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
Jenkins build is back to stable : sling-trunk-1.6 #3086
See https://builds.apache.org/job/sling-trunk-1.6/3086/changes
[jira] [Resolved] (SLING-4434) Sling Mock: MockModelAdapterFactory not compatible with latest Sling Models Impl
[ https://issues.apache.org/jira/browse/SLING-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-4434. --- Resolution: Fixed Completed: At revision: 1660951 MockModelAdapterFactory subclass is removed and instead the ModelAdapterFactory is used directly using the new osgi-mock dynamic service referencing feature (SLING-4439). this also simplifies the code and makes it more robust for future updates. Sling Mock: MockModelAdapterFactory not compatible with latest Sling Models Impl Key: SLING-4434 URL: https://issues.apache.org/jira/browse/SLING-4434 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing Sling Mock 1.1.2 Reporter: Stefan Seifert Assignee: Stefan Seifert Priority: Minor Labels: mocks Fix For: Testing Sling Mock 1.2.0 the current sling mock MockModelAdapterFactory implementation is not compatible with the latest sling models implementation because it does not support InjectAnnotationProcessorFactory2 and StaticInjectAnnotationProcessorFactory interfaces. a better solution than the current hard-wired mock wiring of injectors would be to enhance the osgi mock and bind/unbind them dynamically, then the new interfaces would be supported as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
