[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436930253 I got it, thanks @cziegeler for the feedback - I get back to work

Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4

2018-11-08 Thread Robert Munteanu
On Wed, 2018-11-07 at 17:00 +0100, Karl Pauls wrote: > Please vote to approve these releases: +1 Robert

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436951654 sounds good to me

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436965172 Ah yes, you're right of course. the validation is too late. So we

[GitHub] DominikSuess opened a new pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev…

2018-11-08 Thread GitBox
DominikSuess opened a new pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3 …en when being null

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436972355 OK, so validation is turned _on_ by default?

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436978949 Yes, an invalid json can't be read anyway

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Robert Munteanu
On Thu, 2018-11-08 at 14:37 +0100, Bertrand Delacretaz wrote: > Hi, > > On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu > wrote: > > ... > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > > ... > > I think it's a great idea to have

[GitHub] bosschaert commented on issue #3: SLING-8077 - adding testcoverage and processing of source & target ev…

2018-11-08 Thread GitBox
bosschaert commented on issue #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3#issuecomment-436984676 Thanks for the additional tests @DominikSuess ! It's merged.

[GitHub] bosschaert closed pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev…

2018-11-08 Thread GitBox
bosschaert closed pull request #3: SLING-8077 - adding testcoverage and processing of source & target ev… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Robert Munteanu
Hi Valentin, On Wed, 2018-11-07 at 21:05 +0100, Valentin Olteanu wrote: > I just wanted to drop [1] which can give you some guidelines on where > to > put the tests. It shows the drawbacks of having the tests in > src/test/ and > it states that the preferred way is to create a separate project. >

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Bertrand Delacretaz
Hi, On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu wrote: > ... > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test > ... I think it's a great idea to have tests closer to their code, while also running a large test suite against a

Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4

2018-11-08 Thread Radu Cotescu
+1 > On 7 Nov 2018, at 17:00, Karl Pauls wrote: > > Please vote to approve these releases: > > [ ] +1 Approve the releases > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436944950 Currently, the Schema definition is in the

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436948124 awesome - would it be OK to have it under `META-INF/feature` or

Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4

2018-11-08 Thread Carsten Ziegeler
+1 Am 07.11.2018 um 17:00 schrieb Karl Pauls: I would like to call a vote on the following release, Apache Sling Service User Mapper 1.4.4 We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12344048 Staging repository:

[GitHub] cziegeler closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11 This is an automated

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436945663 I think the schema should be part of the feature-io module as this is

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436962821 @cziegeler there is one problem on accessing to Feature files via

[GitHub] simonetripodi opened a new pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi opened a new pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/11 schema definition moved from sling-org-apache-sling-feature to

[GitHub] ghenzler opened a new pull request #1: SLING-8083 avoid ClassNotFoundExceptions, take infoProvider.getInstallationState().getInstalledResources() into account

2018-11-08 Thread GitBox
ghenzler opened a new pull request #1: SLING-8083 avoid ClassNotFoundExceptions, take infoProvider.getInstallationState().getInstalledResources() into account URL: https://github.com/apache/sling-org-apache-sling-installer-provider-installhook/pull/1

[GitHub] DominikSuess opened a new pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer…

2018-11-08 Thread GitBox
DominikSuess opened a new pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/4 …ing flow as implemented in JCRVLT-319 (based on SNAPSHOT for now) / adding

[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680336#comment-16680336 ] Stefan Seifert commented on SLING-8084: --- i stumbled about this 8 years ago... SLING-1899 a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680037#comment-16680037 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on a change in pull request #17:

[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679650#comment-16679650 ] ASF GitHub Bot commented on SLING-8077: --- DominikSuess opened a new pull request #3: SLING-8077 -

[jira] [Closed] (SLING-7863) Models API: Add missing Nullability annotations to ModelFactory interface

2018-11-08 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-7863. - > Models API: Add missing Nullability annotations to ModelFactory interface >

[jira] [Assigned] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-8084: -- Assignee: Konrad Windszus > Clarify javadoc for ResourceResolver.map(...) >

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679942#comment-16679942 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi edited a comment on issue #11: SLING-8032 -

[jira] [Created] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-8084: -- Summary: Clarify javadoc for ResourceResolver.map(...) Key: SLING-8084 URL: https://issues.apache.org/jira/browse/SLING-8084 Project: Sling Issue Type:

[RESULT] [VOTE] Release Apache Sling Models API 1.3.8

2018-11-08 Thread Stefan Seifert
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Daniel Klco, Robert Munteanu, Karl Pauls, Radu Cotescu, Georg Henzler I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679638#comment-16679638 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-08 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679780#comment-16679780 ] Robert Munteanu commented on SLING-8080: Thanks [~cziegeler] . I am using pom dependencies for a

[jira] [Created] (SLING-8081) NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR

2018-11-08 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8081: --- Summary: NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR Key: SLING-8081 URL: https://issues.apache.org/jira/browse/SLING-8081

[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679850#comment-16679850 ] Konrad Windszus commented on SLING-8084: PR with proposed change:

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679571#comment-16679571 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679960#comment-16679960 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Created] (SLING-8085) Incorporate layering optimizations for cross layer dependencies

2018-11-08 Thread JIRA
Dominik Süß created SLING-8085: -- Summary: Incorporate layering optimizations for cross layer dependencies Key: SLING-8085 URL: https://issues.apache.org/jira/browse/SLING-8085 Project: Sling

[jira] [Created] (SLING-8082) Correct target filter for service user

2018-11-08 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8082: --- Summary: Correct target filter for service user Key: SLING-8082 URL: https://issues.apache.org/jira/browse/SLING-8082 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679497#comment-16679497 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679332#comment-16679332 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

[jira] [Commented] (SLING-8085) Incorporate layering optimizations for cross layer dependencies

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679818#comment-16679818 ] ASF GitHub Bot commented on SLING-8085: --- DominikSuess opened a new pull request #4: SLING-8085 -

[jira] [Resolved] (SLING-8082) Correct target filter for service user

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8082. - Resolution: Fixed Fixed in rev 5ac9e3b > Correct target filter for service user >

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679931#comment-16679931 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

[jira] [Updated] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8084: --- Affects Version/s: (was: API 2.18.6) API 2.18.4 > Clarify javadoc

Re: Capabilities

2018-11-08 Thread Oliver Lietz
On Monday 05 November 2018 11:05:19 Bertrand Delacretaz wrote: > Hi, Hi Bertrand, > On Sun, Nov 4, 2018 at 9:45 PM Oliver Lietz wrote: > > > > ...wouldn't it make sense to exploit OSGi Capabilities instead of > > > > building our own API and implementation for capabilities?... > > The goal of

[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679715#comment-16679715 ] ASF GitHub Bot commented on SLING-8077: --- bosschaert closed pull request #3: SLING-8077 - adding

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679610#comment-16679610 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler closed pull request #11: SLING-8032 - Add a MOJO

[jira] [Assigned] (SLING-7936) Execute module integration tests in the launchpad-testing module

2018-11-08 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-7936: -- Assignee: Robert Munteanu > Execute module integration tests in the launchpad-testing

Re: [VOTE] Release Apache Sling Service User Mapper 1.4.4

2018-11-08 Thread David Bosschaert
+1 David On Wed, 7 Nov 2018 at 16:00, Karl Pauls wrote: > I would like to call a vote on the following release, > > Apache Sling Service User Mapper 1.4.4 > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12344048 > > Staging repository: >

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679968#comment-16679968 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on a change in pull request #17:

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679582#comment-16679582 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-08 Thread Oliver Lietz
On Wednesday 07 November 2018 17:29:01 Robert Munteanu wrote: > Hi, Hi Robert, > We discussed a couple of time that it would be desireable to move tests > closer to the code they're testing. > > I wrote a proposal about how this could look like in terms of results > >

[jira] [Commented] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679525#comment-16679525 ] ASF GitHub Bot commented on SLING-8083: --- ghenzler opened a new pull request #1: SLING-8083 avoid

[jira] [Created] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-08 Thread Georg Henzler (JIRA)
Georg Henzler created SLING-8083: Summary: Installer Hook: Installer events are not in all cases received Key: SLING-8083 URL: https://issues.apache.org/jira/browse/SLING-8083 Project: Sling

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679959#comment-16679959 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi opened a new pull request #17: SLING-8032 -

[jira] [Updated] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-08 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-8083: - Issue Type: Bug (was: Task) > Installer Hook: Installer events are not in all cases received >

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679695#comment-16679695 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679563#comment-16679563 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on issue #11: SLING-8032 - Add a MOJO

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679626#comment-16679626 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679660#comment-16679660 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Updated] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8084: --- Fix Version/s: API 2.18.6 > Clarify javadoc for ResourceResolver.map(...) >

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679602#comment-16679602 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi opened a new pull request #11: SLING-8032 -

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679969#comment-16679969 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on a change in pull request #17:

[jira] [Commented] (SLING-8077) Transform ContentOrderMergeProcessor into MergeHandler

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679716#comment-16679716 ] ASF GitHub Bot commented on SLING-8077: --- bosschaert commented on issue #3: SLING-8077 - adding

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679941#comment-16679941 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679561#comment-16679561 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679961#comment-16679961 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi closed pull request #11: SLING-8032 - Add a

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679926#comment-16679926 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLING-8032 - Add a

[jira] [Commented] (SLING-7936) Execute module integration tests in the launchpad-testing module

2018-11-08 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680440#comment-16680440 ] Robert Munteanu commented on SLING-7936: Started a POC with *

[jira] [Updated] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin

2018-11-08 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-7999: Fix Version/s: Scripting HTL Java Compiler 1.1.0-1.4.0 > Add a `length` property to the

[jira] [Assigned] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin

2018-11-08 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-7999: --- Assignee: Radu Cotescu > Add a `length` property to the AbstractRepeatPlugin >

[jira] [Commented] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin

2018-11-08 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680748#comment-16680748 ] Dan Klco commented on SLING-7999: - Hey [~radu.cotescu], [~tml] reached out to me on this, it seems like a

[jira] [Resolved] (SLING-8081) NoClassDefFoundError: javax/jcr/RepositoryException when using without JCR

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8081. - Resolution: Fixed Fixed in rev 31bd3c6 > NoClassDefFoundError:

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680023#comment-16680023 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler commented on a change in pull request #17:

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680055#comment-16680055 ] ASF GitHub Bot commented on SLING-8032: --- cziegeler closed pull request #17: SLING-8032 - Add a MOJO

[jira] [Resolved] (SLING-435) IE7 error when displaying SlingPostServlet result page

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-435. Resolution: Fixed Fix Version/s: Servlets Post 2.1.0 This seems to be fixed > IE7

[jira] [Resolved] (SLING-5004) Improve servlet tracking by using filter

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5004. - Resolution: Duplicate This has already been implemented > Improve servlet tracking by

[jira] [Commented] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680989#comment-16680989 ] Carsten Ziegeler commented on SLING-7436: - [~asanso] I'm trying to figure out what the problem is

[jira] [Resolved] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-8084. Resolution: Fixed Fixed with

[jira] [Resolved] (SLING-5277) Performance: per thread script resolver (admin session) is always created even if cache is hit

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5277. - Resolution: Won't Fix As the code has changed in the meantime, I'm resolving this as

[jira] [Resolved] (SLING-77) Provide an easy-to-use Javascript API for JCR

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-77. --- Resolution: Won't Fix > Provide an easy-to-use Javascript API for JCR >

[jira] [Commented] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680971#comment-16680971 ] Carsten Ziegeler commented on SLING-8011: - [~jebailey] It seems this has been fixed, can we

[jira] [Commented] (SLING-8084) Clarify javadoc for ResourceResolver.map(...)

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680934#comment-16680934 ] Carsten Ziegeler commented on SLING-8084: - Lgtm, thanks > Clarify javadoc for

[jira] [Resolved] (SLING-1916) Json renderer servlet should use a new RecursionTooDeepException.getLevel() instead of parsing the message

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-1916. - Resolution: Won't Fix > Json renderer servlet should use a new

[jira] [Closed] (SLING-435) IE7 error when displaying SlingPostServlet result page

2018-11-08 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-435. -- > IE7 error when displaying SlingPostServlet result page >

[GitHub] simonetripodi edited a comment on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi edited a comment on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507 Sure, just give me few minutes, I'll fill a new PR from a

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437049507 Sure, just give me few minutes!

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437055060 @cziegeler please refer to

[GitHub] simonetripodi closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi closed pull request #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11 This is an automated

[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231961797 ## File path:

[GitHub] simonetripodi opened a new pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi opened a new pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17 This is an

[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959205 ## File path:

[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231982937 ## File path:

[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231987768 ## File path:

[GitHub] cziegeler closed pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler closed pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17 This is an automated

[GitHub] cziegeler commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#issuecomment-437086598 Thanks for the all the work @simonetripodi

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437044956 Hi @cziegeler please check the updated branch, validation is now

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-437047260 Hi @simonetripodi Could you please rebase your branch against master?

[GitHub] cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
cziegeler commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231959908 ## File path:

[GitHub] simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-08 Thread GitBox
simonetripodi commented on a change in pull request #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#discussion_r231964057 ## File path:

  1   2   >