[GitHub] hasinidilanka commented on issue #14: First commit for oidc handler.

hasinidilanka commented on issue #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-391844968 @rombert Thank you for the comments, they were very helpful for me. I resolved some of the comments.

[GitHub] DominikSuess commented on issue #7: SLING-7544 - fixing potential race between intialization and addition…

DominikSuess commented on issue #7: SLING-7544 - fixing potential race between intialization and addition… URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7#issuecomment-391835091 @rombert initialization of aliasmap(esp. iteration over resultset) might race aga

[GitHub] hasinidilanka commented on a change in pull request #14: First commit for oidc handler.

hasinidilanka commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190706351 ## File path: oidc-handler/pom.xml ## @@ -1,11 +1,35 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="

[jira] [Assigned] (SLING-7678) create gogo command provider for running & building pipe

[ https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7678: -- Assignee: Nicolas Peltier > create gogo command provider for running & building pipe >

[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

[ https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7678: --- Affects Version/s: (was: pipes 3.0.0) pipes 2.0.2 > create gogo com

[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

[ https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7678: --- Fix Version/s: pipes 3.0.0 > create gogo command provider for running & building pipe > --

[jira] [Resolved] (SLING-7632) Pipe Execution Result should show an error list

[ https://issues.apache.org/jira/browse/SLING-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7632. Resolution: Fixed Fix Version/s: pipes 3.0.0 > Pipe Execution Result should show an e

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

Seems sensible to me. Is there a list of the deprecated / contrib repositories? I just pushed in the change, but haven't updated the site since there are new releases which may not have propagated. On Thu, May 24, 2018 at 4:20 AM, Bertrand Delacretaz wrote: > On Wed, May 23, 2018 at 5:56 PM, Dan

[jira] [Resolved] (SLING-7555) Remove ghost packages from distribution agent queue

[ https://issues.apache.org/jira/browse/SLING-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria resolved SLING-7555. -- Resolution: Fixed Assignee: Marius Petria Fixed in https://github.com/apache/sling-org-ap

[jira] [Commented] (SLING-7357) Send Content-Type header along with the DistributionPackage's content in forward distribution

[ https://issues.apache.org/jira/browse/SLING-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489089#comment-16489089 ] Marius Petria commented on SLING-7357: -- This issue introduced a breaking change in {{

[jira] [Commented] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

[ https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488975#comment-16488975 ] Konrad Windszus commented on SLING-7549: I think at least all elements listed in

[jira] [Commented] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

[ https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488923#comment-16488923 ] Radu Cotescu commented on SLING-7549: - The HTL specification doesn't mention any HTML

[GitHub] mpetria closed pull request #8: SLING-7555: option to drop ghost packages from and agent exporter

mpetria closed pull request #8: SLING-7555: option to drop ghost packages from and agent exporter URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] mpetria opened a new pull request #8: SLING-7555: option to drop ghost packages from and agent exporter

mpetria opened a new pull request #8: SLING-7555: option to drop ghost packages from and agent exporter URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/8 This is an automated message from the Ap

[jira] [Assigned] (SLING-7549) tag is not being treated as "self closing" when used in conjunction with HTL block statements

[ https://issues.apache.org/jira/browse/SLING-7549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-7549: --- Assignee: Radu Cotescu > tag is not being treated as "self closing" when used in conjunction

[jira] [Updated] (SLING-7679) slingstart-maven-plugin: Clarify in-pom vs. external model declaration

[ https://issues.apache.org/jira/browse/SLING-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7679: --- Description: Currently there are three different ways on how a model can be given to the {{sl

[jira] [Commented] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

[ https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1641#comment-1641 ] Konrad Windszus commented on SLING-7662: Yes, makes sense. I created https://issue

[jira] [Updated] (SLING-7679) slingstart-maven-plugin: Clarify in-pom vs. external model declaration

[ https://issues.apache.org/jira/browse/SLING-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7679: --- Summary: slingstart-maven-plugin: Clarify in-pom vs. external model declaration (was: Clarify

[jira] [Created] (SLING-7679) Clarify in-pom vs. external model declaration

Konrad Windszus created SLING-7679: -- Summary: Clarify in-pom vs. external model declaration Key: SLING-7679 URL: https://issues.apache.org/jira/browse/SLING-7679 Project: Sling Issue Type: I

[jira] [Commented] (SLING-7552) SlingPostServlet error handling still insufficient

[ https://issues.apache.org/jira/browse/SLING-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488820#comment-16488820 ] Antonio Sanso commented on SLING-7552: -- [~joerghoh] maybe a less invasive solution wo

[jira] [Comment Edited] (SLING-7552) SlingPostServlet error handling still insufficient

[ https://issues.apache.org/jira/browse/SLING-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488820#comment-16488820 ] Antonio Sanso edited comment on SLING-7552 at 5/24/18 11:30 AM:

[RESULT] [VOTE] Release Apache Sling Commons Log 5.1.8

Hi all, The vote has passed with the following result: +1 (binding): Daniel Klco, Chetan Mehrotra, Stefan Seifert +1 (non binding): Julian Sedding Thanks for voting. I will promote the artifacts to the central Maven repository and update the news page. @any PMC member: please copy this release

[GitHub] rombert commented on issue #7: SLING-7544 - fixing potential race between intialization and addition…

rombert commented on issue #7: SLING-7544 - fixing potential race between intialization and addition… URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7#issuecomment-391658979 Thanks for following-up @DominikSuess . Can you please explain what the race conditio

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524060 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/nodetypes/nodetypes.cnd ## @@ -0,0 +1,32 @@ +// Rev

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518251 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520984 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518177 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522920 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521434 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522526 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521558 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520623 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518810 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518767 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520244 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518465 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518373 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522352 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523934 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/content/my-first-node.xml ## @@ -0,0 +1,42 @@ + Re

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518625 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521759 ## File path: oidc-handler/core/src/main/java/org/apache/sling/oidchandler/core/SimpleDSComponent.java ## @@ -0,

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520925 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521501 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522141 ## File path: oidc-handler/pom.xml ## @@ -1,11 +1,35 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http:/

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523010 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522800 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190517700 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518098 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518013 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190523798 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/content/login/login.html ## @@ -0,0 +1,56 @@ + Rev

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190524124 ## File path: oidc-handler/ui/src/main/resources/SLING-INF/scripts/html.esp ## @@ -0,0 +1,37 @@ + Review comme

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520946 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522269 ## File path: oidc-handler/pom.xml ## @@ -1,11 +1,35 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http:/

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190517370 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190518736 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522720 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521339 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r19053 ## File path: oidc-handler/pom.xml ## @@ -1,11 +1,35 @@ +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http:/

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190522618 ## File path: oidc-handler/ui/pom.xml ## @@ -0,0 +1,191 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="htt

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190520558 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on a change in pull request #14: First commit for oidc handler.

rombert commented on a change in pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#discussion_r190521457 ## File path: oidc-handler/core/pom.xml ## @@ -0,0 +1,283 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] rombert commented on issue #14: First commit for oidc handler.

rombert commented on issue #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-391646435 Thanks for the pull request @hasinidilanka , great to see this advancing! I will add some inline comments soon.

[jira] [Commented] (SLING-2463) Sling Script Console Plugin

[ https://issues.apache.org/jira/browse/SLING-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488665#comment-16488665 ] Bertrand Delacretaz commented on SLING-2463: Thanks Chetan, I forgot about tha

[GitHub] hasinidilanka opened a new pull request #14: First commit for oidc handler.

hasinidilanka opened a new pull request #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-7677. - Resolution: Fixed Fix Version/s: Feature Model IO 0.1.2 Thanks for your fix and uni

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488647#comment-16488647 ] ASF GitHub Bot commented on SLING-7677: --- bosschaert closed pull request #1: SLING-76

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488648#comment-16488648 ] ASF GitHub Bot commented on SLING-7677: --- bosschaert commented on issue #1: SLING-767

[GitHub] bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

bosschaert commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391633367 Thanks for your contribution, JIRA and tests @andreituicu ! I've applied your changes. ---

[GitHub] bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

bosschaert closed pull request #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below f

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

On Wed, May 23, 2018 at 5:56 PM, Daniel Klco wrote: > ...Shields.io seems to be a pretty common standard for GitHub projects so what > if we just use these rather than self-hosting?... Thinking about it, I suggest using both self-hosted and dynamic badges, for different purposes: a) Self-hosted