https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Sidney Markowitz changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Giovanni Bechis changed:
What|Removed |Added
CC||giova...@paclan.it
--- Comment
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #37 from Henrik Krohns ---
+1 for v4, let's get it over with. :-)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #36 from Sidney Markowitz ---
Henrik, is patch v4 ready for voting again?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #35 from RvdH ---
I just ran a test, i like it
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #34 from Sidney Markowitz ---
(In reply to RvdH from comment #33)
> If adding require Win32; would slow things down massively,
No slowdown at all, in fact as demonstrated by my tests working before I was
reminded to add the
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #33 from RvdH ---
If adding require Win32; would slow things down massively, what about simply
using the environment variable that Windows sets itself?
File::Spec->catdir($ENV{'ALLUSERSPROFILE'}, ".spamassassin");
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Sidney Markowitz changed:
What|Removed |Added
Attachment #5830|0 |1
is obsolete|
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #31 from Henrik Krohns ---
(In reply to Sidney Markowitz from comment #30)
> (In reply to Henrik Krohns from comment #28)
> > It certainly does require "use Win32" here, just like mentioned in
> > https://perldoc.perl.org/Win32
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #30 from Sidney Markowitz ---
(In reply to Henrik Krohns from comment #28)
> It certainly does require "use Win32" here, just like mentioned in
> https://perldoc.perl.org/Win32
>
>
> STRAWBERRY
>
> C:\Strawberry>perl\bin\perl
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #29 from Henrik Krohns ---
(In reply to Henrik Krohns from comment #28)
> So probably something like this works.
> { require Win32; $home =
> Win32::GetFolderPath(Win32::CSIDL_COMMON_APPDATA()); }
I meant eval { require.. }
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #28 from Henrik Krohns ---
It certainly does require "use Win32" here, just like mentioned in
https://perldoc.perl.org/Win32
STRAWBERRY
C:\Strawberry>perl\bin\perl -e "print
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Sidney Markowitz changed:
What|Removed |Added
Attachment #5828|0 |1
is obsolete|
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #26 from RvdH ---
Yes, that is the perfect location for user independent data as mentioned above,
eg: that is exactly what it's ment for :)
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #25 from Sidney Markowitz ---
(In reply to RvdH from comment #24)
> That is also C:\ProgramData, not?
That's what it is on my Windows 10 VM
Does that seem like a sensible place to you? I'm not a real Windows user.
--
You are
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #24 from RvdH ---
That is also C:\ProgramData, not?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #23 from Sidney Markowitz ---
It looks like for Windows the correct location to use in a Windows-version
portable and future-proof way is
Win32::GetFolderPath(Win32::CSIDL_COMMON_APPDATA)
And then create a .spamassassin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #22 from RvdH ---
Still not tested, but to give you an idea what i mean
sub set_global_state_dir {
my ($self) = @_;
# try home_dir_for_helpers
my $helper_dir = $self->{home_dir_for_helpers} || '';
if ($helper_dir) {
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #21 from RvdH ---
1. it was ONLY a issue when running spamassassin from command line (example:
spamassassin --debug --lint)
> It seems Util::portable_getpwuid sets "/" as user home on Windows. Not sure
> if this is the best
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #20 from Sidney Markowitz ---
(In reply to Sidney Markowitz from comment #19)
> So, should this code be ending up with .spamassassin in the C:\Users\USER\
> directory after all?
Or, this sub is called set_global_state_dir so
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #19 from Sidney Markowitz ---
(In reply to RvdH from comment #18)
> So why not for temporary files for Dns::enter_helper_run_mode stuff?
Maybe because I was up later than I should have been while still looking at
this? :)
This
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #18 from RvdH ---
I mean, the --helper-home-dir param is used to define a path for temporary
files created by razor, pyzor... etc
So why not for temporary files for Dns::enter_helper_run_mode stuff?
--
You are receiving this
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #17 from RvdH ---
Still kinda curious why the --helper-home-dir only is ignored on windows
if (!am_running_on_windows()) {
}
When --helper-home-dir on windows is used on Windows it works OK, i was only
this part that did not
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #16 from Sidney Markowitz ---
+1 on the new patch
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #15 from RvdH ---
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #14 from Sidney Markowitz ---
(In reply to RvdH from comment #13)
> So now it always uses LOCAL_STATE_DIR on windows?
> Even with when the --helpers-home-dir parameter is passed to spamd?
The --helpers-home-dir is still used
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #13 from RvdH ---
So now it always uses LOCAL_STATE_DIR on windows?
Even with when the --helpers-home-dir parameter is passed to spamd?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #12 from Henrik Krohns ---
(In reply to Henrik Krohns from comment #11)
> spamd implies that -H alone with any argument
... meant of course _without_
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Henrik Krohns changed:
What|Removed |Added
Attachment #5825|0 |1
is obsolete|
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #10 from Sidney Markowitz ---
(In reply to Henrik Krohns from comment #8)
> It does what the comment implies ("skip if checked already"). Skips a
> redundant test_global_state_dir() call that's already been done for that
>
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #9 from Henrik Krohns ---
(In reply to Sidney Markowitz from comment #7)
>
> If home_dir_for_helper is set in the configs then this patch will still
> create a .spamassassin directory there and use it.
Is this a problem
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #8 from Henrik Krohns ---
(In reply to Sidney Markowitz from comment #5)
> Henrik, this isn't the change you did, but how is this existing code correct
> in the line "if ($home && $home ne $prev)"?
It does what the comment
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #7 from Sidney Markowitz ---
Ok, I looked over the patch now, not just the apparent bug in the existing code
I got distracted by.
If home_dir_for_helper is set in the configs then this patch will still create
a .spamassassin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #6 from Sidney Markowitz ---
(In reply to Sidney Markowitz from comment #5)
Or even simpler, change just the first part to something like
my $prev = $self->{home_dir_for_helpers};
if ($prev) {
my $dir =
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Sidney Markowitz changed:
What|Removed |Added
CC||sid...@sidney.com
--- Comment
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Bill Cole changed:
What|Removed |Added
CC||billc...@apache.org
--- Comment #4
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
--- Comment #3 from RvdH ---
Comment on attachment 5826
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5826
debug.log
Looks good, running command:
spamassassin --debug --lint --nocreate-prefs --ipv4 > debug.log 2>&1
see
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
RvdH changed:
What|Removed |Added
CC||ruud.vd.h...@gmail.com
--- Comment #2 from
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Henrik Krohns changed:
What|Removed |Added
Summary|Fix global_state_dir on |[REVIEW] Fix
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8050
Henrik Krohns changed:
What|Removed |Added
Target Milestone|Undefined |4.0.0
--
You are receiving this
40 matches
Mail list logo
