[jira] [Commented] (SQOOP-2443) Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693006#comment-14693006 ] Sqoop QA bot commented on SQOOP-2443: - Testing file [SQOOP-2443.patch|https://issues.

Re: Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Dian Fu
> On Aug. 12, 2015, 5:05 a.m., Dian Fu wrote: > > Overall the patch LGTM. Just one minor issue. +1 if the following issue is fixed. - Dian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/373

Re: Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37380/#review95055 --- connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/con

Re: Review Request 37015: SQOOP-2450 Sqoop2: Precommit: Introduce findbugs checks

2015-08-11 Thread Abraham Elmahrek
> On Aug. 11, 2015, 1:05 a.m., Abraham Elmahrek wrote: > > dev-support/test-patch.py, line 422 > > > > > > A note on python style: > >if not summary: > > ... > > > > Would also work!

[jira] [Commented] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692860#comment-14692860 ] Sqoop QA bot commented on SQOOP-2474: - Testing file [SQOOP-2474.001.patch|https://iss

Re: Review Request 35591: Sqoop-1853: Kafka connector supporting FROM direction

2015-08-11 Thread richard zhou
On Aug. 11, 2015, 2:09 p.m., richard zhou wrote: > > Thanks for submitting a patch for this! I know my review has a lot of > > comments, but I wanted to put all of my thoughts out there. Feel free to > > discuss any of them. Hey, Grant Henke, I real appreciate that you have left so many commen

[jira] [Updated] (SQOOP-2443) Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-2443: -- Attachment: SQOOP-2443.patch > Sqoop2: Generic JDBC: Properly detect compound primary ke

Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37380/ --- Review request for Sqoop. Bugs: SQOOP-2443 https://issues.apache.org/jira/b

[jira] [Commented] (SQOOP-2443) Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-11 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692792#comment-14692792 ] Jarek Jarcec Cecho commented on SQOOP-2443: --- While working on this patch, I've n

[jira] [Assigned] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma reassigned SQOOP-2474: --- Assignee: Colin Ma > Fix the problem in the integration test case Derby1_99_4UpgradeTest > --

[jira] [Assigned] (SQOOP-2460) Refactor repository-common to make sqoop2 easy to use external DB as repository

2015-08-11 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma reassigned SQOOP-2460: --- Assignee: Colin Ma > Refactor repository-common to make sqoop2 easy to use external DB as > reposito

[jira] [Assigned] (SQOOP-2461) Add sqoop-repository-mysql to support MySql for the metadata repository

2015-08-11 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma reassigned SQOOP-2461: --- Assignee: Colin Ma > Add sqoop-repository-mysql to support MySql for the metadata repository > --

[jira] [Commented] (SQOOP-2442) Sqoop2: Generic JDBC: Drop tests for specifying schema name and custom SQL at the same time

2015-08-11 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692296#comment-14692296 ] Sqoop QA bot commented on SQOOP-2442: - Testing file [SQOOP-2442.patch|https://issues.

[jira] [Comment Edited] (SQOOP-1369) Avro export ignores --columns option

2015-08-11 Thread Paul Mazak (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682353#comment-14682353 ] Paul Mazak edited comment on SQOOP-1369 at 8/11/15 7:38 PM: Ad

[jira] [Updated] (SQOOP-1369) Avro export ignores --columns option

2015-08-11 Thread Paul Mazak (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Mazak updated SQOOP-1369: -- Attachment: SQOOP-1369_5.patch Addressed code review comments. > Avro export ignores --columns option >

Re: Review Request 34104: Fix for SQOOP-1369 Avro export ignores --columns option

2015-08-11 Thread Paul Mazak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34104/ --- (Updated Aug. 11, 2015, 7:36 p.m.) Review request for Sqoop and Yibing Shi. C

Re: Review Request 34104: Fix for SQOOP-1369 Avro export ignores --columns option

2015-08-11 Thread Paul Mazak
> On Aug. 8, 2015, 6:47 p.m., Jarek Cecho wrote: > > src/test/org/apache/sqoop/mapreduce/JdbcExportJobTest.java, line 55 > > > > > > Let's again avoid the string comparison here? For these, do you mind if I use ass

Re: Review Request 34104: Fix for SQOOP-1369 Avro export ignores --columns option

2015-08-11 Thread Paul Mazak
> On July 22, 2015, 9:57 p.m., Jarek Cecho wrote: > > I have few more comments: > > > > 1) The JIRA specifies that the user visible problem is that export from > > Avro won't work correctly. Can we add test for that, so that we know that > > the problem that we're trying to address is actually

[jira] [Updated] (SQOOP-2442) Sqoop2: Generic JDBC: Drop tests for specifying schema name and custom SQL at the same time

2015-08-11 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-2442: -- Attachment: SQOOP-2442.patch Attaching simple patch, so skipping review board. > Sqoop2

[jira] [Commented] (SQOOP-1853) Sqoop2: Kafka connector supporting FROM direction

2015-08-11 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681852#comment-14681852 ] Grant Henke commented on SQOOP-1853: In reviews on the review board I mentioned that I

Re: Review Request 35591: Sqoop-1853: Kafka connector supporting FROM direction

2015-08-11 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35591/#review94911 --- Can you add documentation to the existing Kafka Connector documentat

[jira] [Updated] (SQOOP-2331) Snappy Compression Support in Sqoop-HCatalog

2015-08-11 Thread Shashank (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank updated SQOOP-2331: Attachment: SQOOP-2331_0.patch Upload a pact to fix. When a user will try to use --compress, then it will u

Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-08-11 Thread Shashank Tandon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37353/ --- Review request for Sqoop and Venkat Ranganathan. Repository: sqoop-trunk Desc

[jira] [Updated] (SQOOP-2328) Sqoop import does not recognize Primary Key of a IBM DB2 table

2015-08-11 Thread Shashank (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank updated SQOOP-2328: Attachment: SQOOP-2328_0.patch Created patch and uploaded.It will fix Sqoop import query recognize the PK of

[jira] [Assigned] (SQOOP-2328) Sqoop import does not recognize Primary Key of a IBM DB2 table

2015-08-11 Thread Shashank (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank reassigned SQOOP-2328: --- Assignee: Shashank (was: Atul Gupta) > Sqoop import does not recognize Primary Key of a IBM DB2 tabl

Re: Review Request 37348: Fix Bug: Sqoop import query does not recognize the PK of IBM DB2 table.The Jira number is SQOOP-2328

2015-08-11 Thread Shashank Tandon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37348/ --- (Updated Aug. 11, 2015, 9:09 a.m.) Review request for Sqoop and Venkat Ranganat

Review Request 37348: Fix Bug: Sqoop import query does not recognize the PK of IBM DB2 table.The Jira number is SQOOP-2328

2015-08-11 Thread Shashank Tandon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37348/ --- Review request for Sqoop and Venkat Ranganathan. Repository: sqoop-trunk Desc

[jira] [Commented] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681430#comment-14681430 ] Sqoop QA bot commented on SQOOP-2474: - Testing file [SQOOP-2474.001.patch|https://iss

[jira] [Updated] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma updated SQOOP-2474: Attachment: SQOOP-2474.001.patch > Fix the problem in the integration test case Derby1_99_4UpgradeTest > ---

[jira] [Updated] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma updated SQOOP-2474: Description: When do the integration test Derby1_99_4UpgradeTest, there will be the error message like the

[jira] [Created] (SQOOP-2474) Fix the problem in the integration test case Derby1_99_4UpgradeTest

2015-08-11 Thread Colin Ma (JIRA)
Colin Ma created SQOOP-2474: --- Summary: Fix the problem in the integration test case Derby1_99_4UpgradeTest Key: SQOOP-2474 URL: https://issues.apache.org/jira/browse/SQOOP-2474 Project: Sqoop Issu