Re: [VOTE] Release Sqoop version 1.4.7

2017-12-21 Thread Szabolcs Vasas
he same state as RC1 and do a totally new > > RC1 build and vote? (I did not see rules for this) > > > > The proper link for the keys file: > > http://www.apache.org/dist/sqoop/KEYS > > > > Cheers, > > Attila > > > > On Thu, Dec 21, 2017 at 3:2

Re: [VOTE] Release Sqoop version 1.4.7

2017-12-21 Thread Szabolcs Vasas
Hi Attila, I did not have time to run the full testing yet but it seems that the scripts in the bin directory have Microsoft-style line endings so I am not able to start them. Also http://www.apache.org/dist/incubator/sqoop/KEYS seems to be broken, can you please update the link? Thanks and

[jira] [Commented] (SQOOP-3267) Incremental import to HBase deletes only last version of column

2017-12-15 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292487#comment-16292487 ] Szabolcs Vasas commented on SQOOP-3267: --- Hi [~dvoros], Thank you for reporting this bug

[jira] [Commented] (SQOOP-3153) Sqoop export with --as- error message could be more verbose

2017-12-15 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292195#comment-16292195 ] Szabolcs Vasas commented on SQOOP-3153: --- Hi [~fero], Your patch is committed, thank you for your

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

2017-12-15 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64417/#review193890 --- Ship it! Ship It! - Szabolcs Vasas On Dec. 14, 2017, 1:45

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

2017-12-14 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64251/#review193783 --- Ship it! Ship It! - Szabolcs Vasas On Dec. 13, 2017, 10:59

Re: Review Request 64251: SQOOP-3266: Update 3rd party and manual test running related info in COMPILING.txt

2017-12-13 Thread Szabolcs Vasas
atched) <https://reviews.apache.org/r/64251/#comment272244> I think the correct parameter name here is ms.sqlserver.password, can you please double check? - Szabolcs Vasas On Dec. 7, 2017, 4:46 p.m., Boglarka

Re: Review Request 64417: SQOOP-3153 Sqoop export with --as- error message could be more verbose

2017-12-13 Thread Szabolcs Vasas
troducing a method like org.apache.commons.cli.Util#stripLeadingHyphens. - Szabolcs Vasas On Dec. 8, 2017, 3:55 p.m., Fero Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 63920: Sqoop ignores metastore properties defined in sqoop-site.xml

2017-12-12 Thread Szabolcs Vasas
/63920/diff/2-3/ Testing --- Executed unit and third party test suite, created new test cases. Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3255) Sqoop ignores metastore properties defined in sqoop-site.xml

2017-12-08 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3255: -- Attachment: SQOOP-3255.patch > Sqoop ignores metastore properties defined in sqoop-site.

Re: Review Request 63920: Sqoop ignores metastore properties defined in sqoop-site.xml

2017-12-08 Thread Szabolcs Vasas
://reviews.apache.org/r/63920/diff/2/ Changes: https://reviews.apache.org/r/63920/diff/1-2/ Testing --- Executed unit and third party test suite, created new test cases. Thanks, Szabolcs Vasas

Re: Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

2017-12-08 Thread Szabolcs Vasas
and third party tests successfully so everything looks good. - Szabolcs Vasas On Dec. 7, 2017, 5:23 p.m., Fero Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 64371: SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

2017-12-07 Thread Szabolcs Vasas
e code duplication as well. src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java Lines 413 (patched) <https://reviews.apache.org/r/64371/#comment271640> nit: I know this was not originally your code, but can we rename the one letter variable? - Szabolcs Vasas On Dec

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2017-12-01 Thread Szabolcs Vasas
> On Nov. 10, 2017, 4:05 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java > > Lines 24 (patched) > > <https://reviews.apache.org/r/62492/diff/4/?file=1868652#file1868652line24> > > > > Can

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2017-12-01 Thread Szabolcs Vasas
od, can you please fix it? src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java Lines 1 (patched) <https://reviews.apache.org/r/62492/#comment270643> Can you please add license information to this new file? - Szabolcs Vasas

[jira] [Resolved] (SQOOP-3260) Make sure PublishJobData.publishJobData does not log sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas resolved SQOOP-3260. --- Resolution: Duplicate This is implemented in the parent JIRA: https://issues.apache.org/jira

[jira] [Resolved] (SQOOP-3259) Make sure JobTool.showJob does not print sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas resolved SQOOP-3259. --- Resolution: Duplicate This is implemented in the parent JIRA: https://issues.apache.org/jira

[jira] [Resolved] (SQOOP-3258) Make sure GenericJobStorage.setV0Property does not log sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas resolved SQOOP-3258. --- Resolution: Duplicate This is implemented in the parent JIRA: https://issues.apache.org/jira

[jira] [Assigned] (SQOOP-3258) Make sure GenericJobStorage.setV0Property does not log sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3258: - Assignee: Szabolcs Vasas > Make sure GenericJobStorage.setV0Property does not

[jira] [Assigned] (SQOOP-3260) Make sure PublishJobData.publishJobData does not log sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3260: - Assignee: Szabolcs Vasas > Make sure PublishJobData.publishJobData does not

[jira] [Assigned] (SQOOP-3259) Make sure JobTool.showJob does not print sensitive data

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3259: - Assignee: Szabolcs Vasas > Make sure JobTool.showJob does not print sensitive d

[jira] [Updated] (SQOOP-3257) Sqoop must not log database passwords

2017-11-29 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3257: -- Attachment: SQOOP-3257.patch > Sqoop must not log database passwo

Re: Review Request 64034: Sqoop must not log database passwords

2017-11-27 Thread Szabolcs Vasas
://reviews.apache.org/r/64034/diff/2/ Changes: https://reviews.apache.org/r/64034/diff/1-2/ Testing --- Unit tests and third party tests are executed. Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3257) Sqoop must not log database passwords

2017-11-22 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3257: -- Attachment: SQOOP-3257.patch > Sqoop must not log database passwo

Review Request 64034: Sqoop must not log database passwords

2017-11-22 Thread Szabolcs Vasas
/apache/sqoop/metastore/PasswordRedactorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/64034/diff/1/ Testing --- Unit tests and third party tests are executed. Thanks, Szabolcs Vasas

[jira] [Assigned] (SQOOP-3257) Sqoop must not log database passwords

2017-11-22 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3257: - Assignee: Szabolcs Vasas > Sqoop must not log database passwo

[jira] [Updated] (SQOOP-3257) Sqoop must not log database passwords

2017-11-22 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3257: -- Description: If sqoop.metastore.client.record.password property is set to true then Sqoop

[jira] [Updated] (SQOOP-3257) Sqoop must not log database passwords

2017-11-22 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3257: -- Summary: Sqoop must not log database passwords (was: Implement sensitive data redaction

[jira] [Updated] (SQOOP-3260) Make sure PublishJobData.publishJobData does not log sensitive data

2017-11-21 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3260: -- Issue Type: Sub-task (was: Improvement) Parent: SQOOP-3257 > Make s

[jira] [Updated] (SQOOP-3258) Make sure GenericJobStorage.setV0Property does not log sensitive data

2017-11-21 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3258: -- Issue Type: Sub-task (was: Improvement) Parent: SQOOP-3257 > Make s

[jira] [Created] (SQOOP-3259) Make sure JobTool.showJob does not print sensitive data

2017-11-21 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3259: - Summary: Make sure JobTool.showJob does not print sensitive data Key: SQOOP-3259 URL: https://issues.apache.org/jira/browse/SQOOP-3259 Project: Sqoop

[jira] [Updated] (SQOOP-3259) Make sure JobTool.showJob does not print sensitive data

2017-11-21 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3259: -- Issue Type: Sub-task (was: Improvement) Parent: SQOOP-3257 > Make sure JobTool.show

[jira] [Created] (SQOOP-3258) Make sure GenericJobStorage.setV0Property does not log sensitive data

2017-11-21 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3258: - Summary: Make sure GenericJobStorage.setV0Property does not log sensitive data Key: SQOOP-3258 URL: https://issues.apache.org/jira/browse/SQOOP-3258 Project: Sqoop

[jira] [Created] (SQOOP-3257) Implement sensitive data redaction in Sqoop logging

2017-11-21 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3257: - Summary: Implement sensitive data redaction in Sqoop logging Key: SQOOP-3257 URL: https://issues.apache.org/jira/browse/SQOOP-3257 Project: Sqoop Issue

[jira] [Updated] (SQOOP-3255) Sqoop ignores metastore properties defined in sqoop-site.xml

2017-11-17 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3255: -- Attachment: SQOOP-3255.patch > Sqoop ignores metastore properties defined in sqoop-site.

Review Request 63920: Sqoop ignores metastore properties defined in sqoop-site.xml

2017-11-17 Thread Szabolcs Vasas
. Thanks, Szabolcs Vasas

[jira] [Assigned] (SQOOP-3255) Sqoop ignores metastore properties defined in sqoop-site.xml

2017-11-17 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3255: - Assignee: Szabolcs Vasas > Sqoop ignores metastore properties defined in sqoop-site.

[jira] [Created] (SQOOP-3255) Sqoop ignores metastore properties defined in sqoop-site.xml

2017-11-17 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3255: - Summary: Sqoop ignores metastore properties defined in sqoop-site.xml Key: SQOOP-3255 URL: https://issues.apache.org/jira/browse/SQOOP-3255 Project: Sqoop

Re: Review Request 61882: SQOOP-3215 : sqoop import to hive table as formats(avro, parquet)

2017-11-16 Thread Szabolcs Vasas
#importTable never gets invoked if we import into Parquet files. See: org/apache/sqoop/tool/ImportTool.java:539 * The other thing is the Avro support for Hive tables. I think this part still needs more testing with possibly all the supported data types and codecs. Regards, Szabolcs - Szabolcs

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

2017-11-10 Thread Szabolcs Vasas
use org.junit.rules.ExpectedException here. src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java Lines 387 (patched) <https://reviews.apache.org/r/62492/#comment268330> Please use a method of org.junit.Assert here. - Szabolcs Vasas On Oct. 25, 2017, 10:25 a.m., Chris Teoh wrote: > &

Re: Review Request 63576: SQOOP-3243: Importing BLOB data causes "Stream closed" error on encrypted HDFS

2017-11-06 Thread Szabolcs Vasas
to me now. - Szabolcs Vasas On Nov. 6, 2017, 4:28 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63576: SQOOP-3243: Importing BLOB data causes "Stream closed" error on encrypted HDFS

2017-11-06 Thread Szabolcs Vasas
ou did in the createCryptoOutputStream method you can avoid the library upgrade. - Szabolcs Vasas On Nov. 6, 2017, 12:58 p.m., Boglarka Egyed wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-23 Thread Szabolcs Vasas
> On Oct. 23, 2017, 9:19 p.m., Szabolcs Vasas wrote: > > Ship It! Hi Chris, Thank you for the improvements, I have reran all the tests, everything is green. Szabolcs - Szabolcs --- This is an automatically generated e-mail.

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-23 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review188983 --- Ship it! Ship It! - Szabolcs Vasas On Oct. 19, 2017, 10:25

[jira] [Updated] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-10-06 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3229: -- Attachment: SQOOP-3229-5.patch > Document how to run third party tests manually with databa

Re: Review Request 62574: Document how to run third party tests manually with databases running in docker

2017-10-06 Thread Szabolcs Vasas
-CREATION Diff: https://reviews.apache.org/r/62574/diff/5/ Changes: https://reviews.apache.org/r/62574/diff/4-5/ Testing --- Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-10-04 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3229: -- Attachment: SQOOP-3229-4.patch > Document how to run third party tests manually with databa

Re: Review Request 62574: Document how to run third party tests manually with databases running in docker

2017-10-04 Thread Szabolcs Vasas
/scripts/thirdpartytest/stop-thirdpartytest-db-containers.sh PRE-CREATION Diff: https://reviews.apache.org/r/62574/diff/4/ Changes: https://reviews.apache.org/r/62574/diff/3-4/ Testing --- Thanks, Szabolcs Vasas

Re: Review Request 61882: SQOOP-3215 : sqoop import to hive table as formats(avro, parquet)

2017-10-04 Thread Szabolcs Vasas
> On Sept. 26, 2017, 1:35 p.m., Szabolcs Vasas wrote: > > Hi Sandish, > > > > Thank you for your patch! Please find my findings below: > > > > - Sqoop uses Kite for importing in Parquet format so I think your patch > > should also utilize the Kite l

[jira] [Commented] (SQOOP-3216) Expanded Metastore support for MySql, Oracle, Postgresql, MSSql, and DB2

2017-10-04 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190940#comment-16190940 ] Szabolcs Vasas commented on SQOOP-3216: --- Hi [~sanysand...@gmail.com], This property is not removed

[jira] [Updated] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-10-04 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3229: -- Attachment: SQOOP-3229-3.patch > Document how to run third party tests manually with databa

Re: Review Request 62574: Document how to run third party tests manually with databases running in docker

2017-10-04 Thread Szabolcs Vasas
/thirdpartytest/stop-thirdpartytest-db-containers.sh PRE-CREATION Diff: https://reviews.apache.org/r/62574/diff/3/ Changes: https://reviews.apache.org/r/62574/diff/2-3/ Testing --- Thanks, Szabolcs Vasas

Re: Review Request 62574: Document how to run third party tests manually with databases running in docker

2017-10-03 Thread Szabolcs Vasas
-CREATION Diff: https://reviews.apache.org/r/62574/diff/2/ Changes: https://reviews.apache.org/r/62574/diff/1-2/ Testing --- Thanks, Szabolcs Vasas

[jira] [Created] (SQOOP-3241) ImportAllTablesTool uses the same SqoopOptions object for every table import

2017-09-29 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3241: - Summary: ImportAllTablesTool uses the same SqoopOptions object for every table import Key: SQOOP-3241 URL: https://issues.apache.org/jira/browse/SQOOP-3241 Project

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-29 Thread Szabolcs Vasas
y works if the -ea parameter is specified for the JVM. You can add the verify line here as well: verify(mockFTPClient).listFiles(); - Szabolcs Vasas On Sept. 28, 2017, 9:34 p.m., Chris Teoh wrote: > > --- > This is a

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Szabolcs Vasas
tioned datasets we use the default FTP list parsing. - Szabolcs Vasas On Sept. 28, 2017, 9:28 a.m., Chris Teoh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[jira] [Updated] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-09-26 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3229: -- Attachment: SQOOP-3229.patch > Document how to run third party tests manually with databa

[jira] [Assigned] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-09-26 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3229: - Assignee: Szabolcs Vasas > Document how to run third party tests manually with databa

Review Request 62574: Document how to run third party tests manually with databases running in docker

2017-09-26 Thread Szabolcs Vasas
/thirdpartytest/start-thirdpartytest-db-containers.sh PRE-CREATION scripts/thirdpartytest/stop-thirdpartytest-db-containers.sh PRE-CREATION Diff: https://reviews.apache.org/r/62574/diff/1/ Testing --- Thanks, Szabolcs Vasas

Re: Review Request 61882: SQOOP-3215 : sqoop import to hive table as formats(avro, parquet)

2017-09-26 Thread Szabolcs Vasas
u need to add this change? As far as I understand your Parquet changes should only be effective if the --create-hive-table option is specified. - Szabolcs Vasas On Aug. 24, 2017, 9:51 a.m., Sandish Kumar HN wrote: > > --- > This is a

Re: Review Request 62057: SQOOP-3014 Sqoop with HCatalog import loose precision for large numbers that does not fit into double

2017-09-12 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62057/#review185166 --- Ship it! Ship It! - Szabolcs Vasas On Sept. 12, 2017, 12:19

Re: Review Request 61372: Expanded Metastore support for MySql, Oracle, Postgresql, MSSql, and DB2

2017-09-12 Thread Szabolcs Vasas
have reviewed it, ran the unit and third party test suite, executed some manual testing too and everything seems to be fine. Regards, Szabolcs - Szabolcs Vasas On Aug. 25, 2017, 11:53 a.m., Zach Berkowitz wrote

Re: Review Request 62057: SQOOP-3014 Sqoop with HCatalog import loose precision for large numbers that does not fit into double

2017-09-11 Thread Szabolcs Vasas
oop/mapreduce/hcat/TestSqoopHCatImportHelper.java Lines 31 (patched) <https://reviews.apache.org/r/62057/#comment261298> Nit: please remove these extra 2 lines here. - Szabolcs Vasas On Sept. 5, 2017, 3:32 p.m., Zoltán Tóth wrote: > > --- > Thi

[jira] [Updated] (SQOOP-3232) Remove Sqoop dependency on deprecated HBase APIs

2017-09-11 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3232: -- Attachment: SQOOP-3232-2.patch > Remove Sqoop dependency on deprecated HBase A

Re: Review Request 62028: Remove Sqoop dependency on deprecated HBase APIs

2017-09-11 Thread Szabolcs Vasas
://reviews.apache.org/r/62028/diff/2/ Changes: https://reviews.apache.org/r/62028/diff/1-2/ Testing --- Added a new test case for the small refactoring I did. Ran all unit and third party tests successfully. Thanks, Szabolcs Vasas

Re: Review Request 62028: Remove Sqoop dependency on deprecated HBase APIs

2017-09-11 Thread Szabolcs Vasas
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62028/#review184973 --- On Sept. 11, 2017, 9:58 a.m., Szabolcs Vasas wrote: > > ---

[jira] [Updated] (SQOOP-3232) Remove Sqoop dependency on deprecated HBase APIs

2017-09-01 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3232: -- Attachment: SQOOP-3232.patch > Remove Sqoop dependency on deprecated HBase A

[jira] [Assigned] (SQOOP-3232) Remove Sqoop dependency on deprecated HBase APIs

2017-09-01 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas reassigned SQOOP-3232: - Assignee: Szabolcs Vasas > Remove Sqoop dependency on deprecated HBase A

Review Request 62028: Remove Sqoop dependency on deprecated HBase APIs

2017-09-01 Thread Szabolcs Vasas
a new test case for the small refactoring I did. Ran all unit and third party tests successfully. Thanks, Szabolcs Vasas

[jira] [Created] (SQOOP-3232) Remove Sqoop dependency on deprecated HBase APIs

2017-09-01 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3232: - Summary: Remove Sqoop dependency on deprecated HBase APIs Key: SQOOP-3232 URL: https://issues.apache.org/jira/browse/SQOOP-3232 Project: Sqoop Issue Type

Re: Add docker support to Sqoop test infrastructure to run third party tests automatically

2017-08-31 Thread Szabolcs Vasas
p-dev/201704. > mbox/%3CC12DC713-E74F-4D39-A29B-CE8EA4A93515%40apache.org%3E>. > What do you think? > > Thanks, > Bogi > > On Wed, Aug 30, 2017 at 3:06 PM, Szabolcs Vasas <va...@cloudera.com> > wrote: > > > Hi Anna, > > > > Thank you for your feedback

Re: Add docker support to Sqoop test infrastructure to run third party tests automatically

2017-08-30 Thread Szabolcs Vasas
gt; thanks for driving this! > > Thanks, > Anna > > On Wed, Aug 30, 2017 at 11:40 AM, Szabolcs Vasas <va...@cloudera.com> > wrote: > > > Hi All, > > > > I have been working on making the third party test execution easier > during > > the last couple

Add docker support to Sqoop test infrastructure to run third party tests automatically

2017-08-30 Thread Szabolcs Vasas
Hi All, I have been working on making the third party test execution easier during the last couple of months and I would like to share my results/plans and ask for feedback. Executing the Sqoop third party test cases is way too painful and we have already discussed it in another chain that a

[jira] [Updated] (SQOOP-3231) Execute Sqoop third party tests in the CI system

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3231: -- Issue Type: Sub-task (was: Task) Parent: SQOOP-3228 > Execute Sqoop third party te

[jira] [Created] (SQOOP-3231) Execute Sqoop third party tests in the CI system

2017-08-30 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3231: - Summary: Execute Sqoop third party tests in the CI system Key: SQOOP-3231 URL: https://issues.apache.org/jira/browse/SQOOP-3231 Project: Sqoop Issue Type

[jira] [Updated] (SQOOP-3222) Test HBase kerberized connectivity

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3222: -- Attachment: SQOOP-3222-3.patch > Test HBase kerberized connectiv

Re: Review Request 61669: Test HBase kerberized connectivity

2017-08-30 Thread Szabolcs Vasas
src/test/org/apache/sqoop/infrastructure/kerberos/MiniKdcInfrastructureRule.java PRE-CREATION Diff: https://reviews.apache.org/r/61669/diff/5/ Changes: https://reviews.apache.org/r/61669/diff/4-5/ Testing --- Ran unit tests and third party tests. Thanks, Szabolcs Vasas

[jira] [Created] (SQOOP-3230) Add a build step which starts RDBMS docker containers before the third party tests are executed

2017-08-30 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3230: - Summary: Add a build step which starts RDBMS docker containers before the third party tests are executed Key: SQOOP-3230 URL: https://issues.apache.org/jira/browse/SQOOP-3230

[jira] [Commented] (SQOOP-3104) Create test categories instead of test suites and naming conventions

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146845#comment-16146845 ] Szabolcs Vasas commented on SQOOP-3104: --- I converted this JIRA to a subtask of SQOOP-3228 since we

[jira] [Updated] (SQOOP-3104) Create test categories instead of test suites and naming conventions

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3104: -- Issue Type: Sub-task (was: Improvement) Parent: SQOOP-3228 > Create test categor

[jira] [Updated] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3229: -- Issue Type: Sub-task (was: Task) Parent: SQOOP-3228 > Document how to run third pa

[jira] [Created] (SQOOP-3229) Document how to run third party tests manually with databases running in docker

2017-08-30 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3229: - Summary: Document how to run third party tests manually with databases running in docker Key: SQOOP-3229 URL: https://issues.apache.org/jira/browse/SQOOP-3229

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Issue Type: Sub-task (was: Test) Parent: SQOOP-3228 > ImportTest, ExportT

[jira] [Updated] (SQOOP-3196) Modify MySQLAuthTest to use configurable test database parameters

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3196: -- Issue Type: Sub-task (was: Test) Parent: SQOOP-3228 > Modify MySQLAuthTest to

[jira] [Updated] (SQOOP-3195) SQLServerDatatypeImportDelimitedFileTest can fail in some environments

2017-08-30 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3195: -- Issue Type: Sub-task (was: Test) Parent: SQOOP-3228

[jira] [Created] (SQOOP-3228) Add docker support to Sqoop test infrastructure to run third party tests automatically

2017-08-30 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3228: - Summary: Add docker support to Sqoop test infrastructure to run third party tests automatically Key: SQOOP-3228 URL: https://issues.apache.org/jira/browse/SQOOP-3228

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Attachment: SQOOP-3226-2.patch > ImportTest, ExportTest and TimestampDataTest fail beca

Re: Review Request 61933: ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas
/61933/diff/2/ Changes: https://reviews.apache.org/r/61933/diff/1-2/ Testing --- Executed unit and third party tests. Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Attachment: SQOOP-3226-1.patch > ImportTest, ExportTest and TimestampDataTest fail beca

Review Request 61933: ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas
631e4f96fc7edc501faedde014d829d6190e58e5 src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 1babf6cc7ff3e9a2bb616de9926e7c502b27b3a3 Diff: https://reviews.apache.org/r/61933/diff/1/ Testing --- Executed unit and third party tests. Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Description: It seems there were some changes in the escaping logic in the Oracle escaping

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Description: It seems there were some changes in the escaping logic in the Oracle escaping

[jira] [Updated] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3226: -- Fix Version/s: (was: 1.4.7) > ImportTest, ExportTest and TimestampDataTest fail beca

[jira] [Created] (SQOOP-3226) ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems

2017-08-28 Thread Szabolcs Vasas (JIRA)
Szabolcs Vasas created SQOOP-3226: - Summary: ImportTest, ExportTest and TimestampDataTest fail because of column escaping problems Key: SQOOP-3226 URL: https://issues.apache.org/jira/browse/SQOOP-3226

Re: Review Request 61669: Test HBase kerberized connectivity

2017-08-25 Thread Szabolcs Vasas
/kerberos/MiniKdcInfrastructureRule.java PRE-CREATION Diff: https://reviews.apache.org/r/61669/diff/4/ Changes: https://reviews.apache.org/r/61669/diff/3-4/ Testing --- Ran unit tests and third party tests. Thanks, Szabolcs Vasas

[jira] [Updated] (SQOOP-3222) Test HBase kerberized connectivity

2017-08-25 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3222: -- Attachment: SQOOP-3222.patch > Test HBase kerberized connectiv

Re: Review Request 61669: Test HBase kerberized connectivity

2017-08-25 Thread Szabolcs Vasas
/kerberos/MiniKdcInfrastructureRule.java PRE-CREATION Diff: https://reviews.apache.org/r/61669/diff/3/ Changes: https://reviews.apache.org/r/61669/diff/2-3/ Testing --- Ran unit tests and third party tests. Thanks, Szabolcs Vasas

Re: Review Request 61669: Test HBase kerberized connectivity

2017-08-21 Thread Szabolcs Vasas
/kerberos/MiniKdcInfrastructureRule.java PRE-CREATION Diff: https://reviews.apache.org/r/61669/diff/2/ Changes: https://reviews.apache.org/r/61669/diff/1-2/ Testing --- Ran unit tests and third party tests. Thanks, Szabolcs Vasas

Re: Review Request 61777: sqoop tries to re execute select query during import in case of a connection reset error and this is causing lots of duplicate records from source

2017-08-21 Thread Szabolcs Vasas
g/r/61777/#comment259356> Nit: can we use SPLIT_BY_COLUMN.toUpperCase() here? - Szabolcs Vasas On Aug. 21, 2017, 9:16 a.m., Zoltán Tóth wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

[jira] [Updated] (SQOOP-3222) Test HBase kerberized connectivity

2017-08-18 Thread Szabolcs Vasas (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Vasas updated SQOOP-3222: -- Attachment: SQOOP-3222.patch > Test HBase kerberized connectiv

<    1   2   3   4   5   6   7   8   >