Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-24 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review189039 --- Ship it! Tests passed, thanks for the corrections! - Boglarka

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-23 Thread Szabolcs Vasas
> On Oct. 23, 2017, 9:19 p.m., Szabolcs Vasas wrote: > > Ship It! Hi Chris, Thank you for the improvements, I have reran all the tests, everything is green. Szabolcs - Szabolcs --- This is an automatically generated e-mail. To reply,

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-23 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review188983 --- Ship it! Ship It! - Szabolcs Vasas On Oct. 19, 2017, 10:25

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-19 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Oct. 19, 2017, 10:25 a.m.) Review request for Sqoop. Changes

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-19 Thread Chris Teoh
> On Oct. 19, 2017, 9:10 a.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java > > Line 86 (original), 91 (patched) > > > > > > This is an example of "shown as changed" because

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-19 Thread Chris Teoh
> On Sept. 29, 2017, 9:41 a.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for improving the patch and the description of the datasets! > > I have left few more comments and I can see that there are still some > > whitespace changes (they are shown by ReviewBoard as well) can you

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-19 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review188652 --- Hi Chris, Thanks for addressing review findinds in your new

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-10-02 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Oct. 2, 2017, 11:12 p.m.) Review request for Sqoop. Changes ---

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-29 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review186658 --- Hi Chris, Thanks for your patch! I ran unit tests with your

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-29 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review186652 --- Hi Chris, Thank you for improving the patch and the description

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Chris Teoh
> On Sept. 28, 2017, 6:16 p.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for your patch! > > Generally it looks good to me however I am not that familiar with the > > mainframe world, can you please give us a bit more context about the > > datasets? As far as I understand from

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Sept. 28, 2017, 9:34 p.m.) Review request for Sqoop. Changes

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Szabolcs Vasas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review186571 --- Hi Chris, Thank you for your patch! Generally it looks good to

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Sept. 28, 2017, 9:28 a.m.) Review request for Sqoop. Changes

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-28 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Sept. 28, 2017, 7:34 a.m.) Review request for Sqoop. Changes

Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

2017-09-27 Thread Chris Teoh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- Review request for Sqoop. Bugs: SQOOP-3225