Re: Review Request 68278: Add LOG message for git hash

2018-08-10 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207067
---


Ship it!




Very good idea to include these in the logs! :)

Thanks,
Bogi

- Boglarka Egyed


On Aug. 9, 2018, 8 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 8 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

(Updated Aug. 9, 2018, 8 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs (updated)
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/3/

Changes: https://reviews.apache.org/r/68278/diff/2-3/


Testing
---


Thanks,

Nguyen Truong

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong 


> On Aug. 9, 2018, 2:02 p.m., Szabolcs Vasas wrote:
> > src/java/org/apache/sqoop/Sqoop.java
> > Lines 95 (patched)
> > 
> >
> > I have just realized that VERSION and GIT_HASH are static final members 
> > of SqoopVersion so the best practice is to access them via class reference:
> > SqoopVersion.VERSION
> > SqoopVersion.GIT_HASH

Hi Szabolcs,

Yes, you're right. I will fix it. Thank you for the suggestion.

Best,
Nguyen


- Nguyen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207030
---


On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207030
---



Hi Nguyen,

Thank you for submitting this patch, it is a nice little improvement for 
debugging.
I have left a minor comment, please take a look.

Szabolcs


src/java/org/apache/sqoop/Sqoop.java
Lines 95 (patched)


I have just realized that VERSION and GIT_HASH are static final members of 
SqoopVersion so the best practice is to access them via class reference:
SqoopVersion.VERSION
SqoopVersion.GIT_HASH


- Szabolcs Vasas


On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

(Updated Aug. 9, 2018, 1:53 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs (updated)
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/2/

Changes: https://reviews.apache.org/r/68278/diff/1-2/


Testing
---


Thanks,

Nguyen Truong

Re: Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207025
---




src/java/org/apache/sqoop/Sqoop.java
Lines 95 (patched)


You could extract SqoopVersion into a local variable and reuse it.


- Fero Szabo


On Aug. 9, 2018, 1:32 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Review Request 68278: Add LOG message for git hash

2018-08-09 Thread Nguyen Truong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/1/


Testing
---


Thanks,

Nguyen Truong