[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715370#comment-14715370 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on the pull

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r38021285 --- Diff: conf/defaults.yaml --- @@ -140,6 +140,14 @@ task.heartbeat.frequency.secs: 3 task.refresh.poll.secs: 10 task.credentials.poll.secs: 30

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715365#comment-14715365 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r38023281 --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj --- @@ -114,12 +114,34 @@ (fast-list-iter [[task tuple :as pair] tuple-batch]

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r38021586 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -602,7 +607,15 @@ (log-message Activating spout component-id :

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715347#comment-14715347 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715354#comment-14715354 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714180#comment-14714180 ] ASF GitHub Bot commented on STORM-1010: --- Github user Renkai commented on the pull

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714431#comment-14714431 ] ASF GitHub Bot commented on STORM-886: -- GitHub user zhuoliu opened a pull request:

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714448#comment-14714448 ] Zhuo Liu commented on STORM-886: Our ABP scheme implements a light-weight yet efficient

[jira] [Comment Edited] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714448#comment-14714448 ] Zhuo Liu edited comment on STORM-886 at 8/26/15 4:27 PM: - Our ABP

[jira] [Updated] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Description: This new feature is aimed for automatic flow control through the topology DAG since different

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715368#comment-14715368 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715400#comment-14715400 ] ASF GitHub Bot commented on STORM-1010: --- Github user revans2 commented on the pull

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715339#comment-14715339 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715351#comment-14715351 ] ASF GitHub Bot commented on STORM-886: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/700#discussion_r38023405 --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj --- @@ -510,15 +554,21 @@ )) ) credentials

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-135145296 This looks very interesting. I would really like to see some unit tests, especially around the disruptor queue to show that the callback is working. Perhaps we can

[jira] [Created] (STORM-1008) Isolate the code for metric collection and retrieval from the DisruptorQueue

2015-08-26 Thread Li Wang (JIRA)
Li Wang created STORM-1008: -- Summary: Isolate the code for metric collection and retrieval from the DisruptorQueue Key: STORM-1008 URL: https://issues.apache.org/jira/browse/STORM-1008 Project: Apache Storm

[GitHub] storm pull request: [STORM-1007] Isolate the code for metric colle...

2015-08-26 Thread wangli1426
GitHub user wangli1426 opened a pull request: https://github.com/apache/storm/pull/698 [STORM-1007] Isolate the code for metric collection and retrieval from DisruptorQueue I created an inner class QueueMetrics for DisruptorQueue. The QueueMetrics class handles metric collection

[jira] [Created] (STORM-1009) link on http://storm.apache.org/documentation/Command-line-client.html is wrong

2015-08-26 Thread Golda Velez (JIRA)
Golda Velez created STORM-1009: -- Summary: link on http://storm.apache.org/documentation/Command-line-client.html is wrong Key: STORM-1009 URL: https://issues.apache.org/jira/browse/STORM-1009 Project:

[jira] [Updated] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: an simple example for backpressure.png Automatic Back Pressure ---

[jira] [Updated] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: backpressure.png Automatic Back Pressure --- Key:

[jira] [Comment Edited] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714448#comment-14714448 ] Zhuo Liu edited comment on STORM-886 at 8/26/15 4:41 PM: - Our ABP

[jira] [Comment Edited] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714448#comment-14714448 ] Zhuo Liu edited comment on STORM-886 at 8/26/15 4:28 PM: - Our ABP

[jira] [Updated] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: backpressure.png Automatic Back Pressure --- Key:

[jira] [Updated] (STORM-886) Automatic Back Pressure

2015-08-26 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-886: --- Attachment: (was: backpressure.png) Automatic Back Pressure ---

[jira] [Commented] (STORM-855) Add tuple batching

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14714441#comment-14714441 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in

[GitHub] storm pull request: [STORM-855] Add tuple batching

2015-08-26 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/694#discussion_r38002218 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -18,23 +18,23 @@ (:import [backtype.storm.generated Grouping]

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135165221 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135173459 I am fine with the current approach but we need to standardize one way configuring the bolts as each connector follows its own pattern right now and which can be

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715537#comment-14715537 ] ASF GitHub Bot commented on STORM-1010: --- Github user harshach commented on the pull

[jira] [Commented] (STORM-855) Add tuple batching

2015-08-26 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715568#comment-14715568 ] Sriharsha Chintalapani commented on STORM-855: -- [~mjsax] curious why we are

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715478#comment-14715478 ] ASF GitHub Bot commented on STORM-1010: --- Github user Parth-Brahmbhatt commented on

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135165749 @revans2 @Renkai makes sense. Instead of using constructor can we should with Options like other bolts are using. probably withProducerProperties method and remove the

[jira] [Comment Edited] (STORM-855) Add tuple batching

2015-08-26 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715568#comment-14715568 ] Sriharsha Chintalapani edited comment on STORM-855 at 8/26/15 9:39 PM:

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread Renkai
GitHub user Renkai opened a pull request: https://github.com/apache/storm/pull/699 [STORM-1010] each KafkaBolt have its own properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/Renkai/storm dev Alternatively you can

[GitHub] storm pull request: [STORM-954] Topology event inspector

2015-08-26 Thread arunmahadevan
Github user arunmahadevan commented on the pull request: https://github.com/apache/storm/pull/673#issuecomment-134900295 @harshach @Parth-Brahmbhatt added changes for supporting sampling pct. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712860#comment-14712860 ] ASF GitHub Bot commented on STORM-1010: --- GitHub user Renkai opened a pull request:

[jira] [Created] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread Renkai Ge (JIRA)
Renkai Ge created STORM-1010: Summary: Each KafkaBolt could have a specified properties. Key: STORM-1010 URL: https://issues.apache.org/jira/browse/STORM-1010 Project: Apache Storm Issue Type:

[jira] [Commented] (STORM-954) Toplogy Event Inspector

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712713#comment-14712713 ] ASF GitHub Bot commented on STORM-954: -- Github user arunmahadevan commented on the

[jira] [Commented] (STORM-994) Connection leak between nimbus and supervisors

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713498#comment-14713498 ] ASF GitHub Bot commented on STORM-994: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-954] Topology event inspector

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/673#issuecomment-135050549 @arunmahadevan you need to upmerge this branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713608#comment-14713608 ] ASF GitHub Bot commented on STORM-1010: --- Github user harshach commented on the pull

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135050335 @Renkai whats the need for this? why can't you add multiple bolts with its own parallelism. IMO this goes against the storm api. --- If your project is set up for it,

[jira] [Commented] (STORM-954) Toplogy Event Inspector

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14713612#comment-14713612 ] ASF GitHub Bot commented on STORM-954: -- Github user harshach commented on the pull

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715483#comment-14715483 ] ASF GitHub Bot commented on STORM-1010: --- Github user harshach commented on the pull

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread Renkai
Github user Renkai commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135233931 Travis CI shows test fails in with jdk8,but I think it's not problems with my commits,tests all passed on my Mac. --- If your project is set up for it, you can reply to

[jira] [Created] (STORM-1011) HBaseBolt default mapper should handle null values

2015-08-26 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-1011: --- Summary: HBaseBolt default mapper should handle null values Key: STORM-1011 URL: https://issues.apache.org/jira/browse/STORM-1011 Project: Apache Storm

[jira] [Commented] (STORM-1011) HBaseBolt default mapper should handle null values

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715747#comment-14715747 ] ASF GitHub Bot commented on STORM-1011: --- GitHub user Parth-Brahmbhatt opened a pull

[GitHub] storm pull request: STORM-1011: Hbase default mapper should handle...

2015-08-26 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/701 STORM-1011: Hbase default mapper should handle null values. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread Renkai
Github user Renkai commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135222309 @harshach I will push another merge requests,make it harmonic with current code. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715838#comment-14715838 ] ASF GitHub Bot commented on STORM-1010: --- Github user Renkai commented on the pull

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715875#comment-14715875 ] ASF GitHub Bot commented on STORM-1010: --- Github user Renkai commented on the pull

[jira] [Created] (STORM-1012) Shade Jackson dependency

2015-08-26 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-1012: --- Summary: Shade Jackson dependency Key: STORM-1012 URL: https://issues.apache.org/jira/browse/STORM-1012 Project: Apache Storm Issue Type: Bug

[GitHub] storm pull request: STORM-1012: Shading jackson.

2015-08-26 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/702 STORM-1012: Shading jackson. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM-1012 Alternatively

[jira] [Commented] (STORM-1012) Shade Jackson dependency

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715751#comment-14715751 ] ASF GitHub Bot commented on STORM-1012: --- GitHub user Parth-Brahmbhatt opened a pull

[GitHub] storm pull request: Added new option to allow Kafka spout to save ...

2015-08-26 Thread hsun-cnnxty
GitHub user hsun-cnnxty opened a pull request: https://github.com/apache/storm/pull/703 Added new option to allow Kafka spout to save offset and other state using Kafka's offset management api Current Kafka spout stores the offsets (and some other states) inside ZK with its

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread Renkai
Github user Renkai commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135067844 @harshach Different KafkaBolts may need to send topic to different kafka clusters,use different serializers,and have different params for performance tunning.

[jira] [Commented] (STORM-886) Automatic Back Pressure

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715934#comment-14715934 ] ASF GitHub Bot commented on STORM-886: -- Github user vesense commented on the pull

[GitHub] storm pull request: [STORM-886] Automatic Back Pressure (ABP)

2015-08-26 Thread vesense
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/700#issuecomment-135248186 +1 Looks very exciting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1010] each KafkaBolt have its own prope...

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/699#issuecomment-135286772 @Renkai those failed tests are intermittent test failures in storm-core not related to the patch. --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request: STORM-1012: Shading jackson.

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/702#issuecomment-135286951 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-974) [storm-elasticsearch] Introduces Tuple - ES document mapper to get rid of constant field mapping (source, index, type)

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716086#comment-14716086 ] ASF GitHub Bot commented on STORM-974: -- Github user harshach commented on the pull

[jira] [Commented] (STORM-1012) Shade Jackson dependency

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716074#comment-14716074 ] ASF GitHub Bot commented on STORM-1012: --- Github user harshach commented on the pull

[jira] [Commented] (STORM-1011) HBaseBolt default mapper should handle null values

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716075#comment-14716075 ] ASF GitHub Bot commented on STORM-1011: --- Github user harshach commented on the pull

[jira] [Commented] (STORM-1010) Each KafkaBolt could have a specified properties.

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716073#comment-14716073 ] ASF GitHub Bot commented on STORM-1010: --- Github user harshach commented on the pull

[GitHub] storm pull request: STORM-978: Implemented EsLookupBolt

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/693#issuecomment-135289205 overall looks good to me I am +1. Just a minor question on client.transport.sniff, true --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: STORM-978: Implemented EsLookupBolt

2015-08-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/693#discussion_r38061653 --- Diff: external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/ElasticSearchClient.java --- @@ -0,0 +1,57 @@ +/** + *

[jira] [Commented] (STORM-978) [storm-elasticsearch] Introduces Lookup(or Query)Bolt which emits matched documents from ES

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716083#comment-14716083 ] ASF GitHub Bot commented on STORM-978: -- Github user harshach commented on a diff in

[jira] [Commented] (STORM-978) [storm-elasticsearch] Introduces Lookup(or Query)Bolt which emits matched documents from ES

2015-08-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716085#comment-14716085 ] ASF GitHub Bot commented on STORM-978: -- Github user harshach commented on the pull

[GitHub] storm pull request: STORM-974 Introduces Tuple - ES document mapp...

2015-08-26 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/679#issuecomment-135289297 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled