[GitHub] storm pull request #1696: STORM-2104: More graceful handling of acked/failed...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1696#discussion_r79973663 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -145,6 +154,10 @@ private void initialize(Collection

Re: [GitHub] storm issue #1697: STORM-2018: Supervisor V2

Can you please let me know how to unsubscribe I have followed instructions without success On Sep 21, 2016 11:08 AM, "revans2" wrote: > Github user revans2 commented on the issue: > > https://github.com/apache/storm/pull/1697 > > I ran the same set of manual tests

Re: [DISCUSS] Plan for merge SQE and Storm SQL

Thank you for the analysis Jungtaek. I particularly appreciate your admitted bias as a big contributor to storm-SQL. It will take time for us to sort out how the merge will happen. Similar to what we are discussing with Kafka and ES, we could support two versions of SQL, and eventually

Fwd: [IP CLEARANCE] JWPlayer SQE (Streaming Query Engine)

Meant to cc dev@ but missed it. -Taylor Begin forwarded message: > From: "P. Taylor Goetz" > Date: September 21, 2016 at 2:41:21 PM EDT > To: Incubator > Subject: [IP CLEARANCE] JWPlayer SQE (Streaming Query Engine) > > Apache Storm has

Re: [DISCUSS] Plan for merge SQE and Storm SQL

My apologies. I meant to cc dev@, but didn't. Will forward in a bit... The vote (lazy consensus) is underway on general@incubator, and will close in less than 72 hours. After that the code can be merged. -Taylor > On Sep 21, 2016, at 7:02 PM, Jungtaek Lim wrote: > > Hi

[GitHub] storm pull request #1702: Update Eventhub-Client jar dependency to 1.0.1

GitHub user raviperi opened a pull request: https://github.com/apache/storm/pull/1702 Update Eventhub-Client jar dependency to 1.0.1 Eventhub client library has few key fixes that need to be included in storm-eventhub jar. Fixes: 1. Fix for EventHubSender may throw

[GitHub] storm issue #1679: STORM-2087: storm-kafka-client - tuples not always being ...

Github user jfenc91 commented on the issue: https://github.com/apache/storm/pull/1679 @srdo Alright I think everything has been addressed here. I have actually been running this merged with your other PR for the last 12 hours processing 100M tuples and its looked pretty good. Only

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79956690 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user jfenc91 commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79956580 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[DISCUSS] Plan for merge SQE and Storm SQL

Hi dev, While code contribution of SQE is in progress, I would like to continue discussion how to merge SQE and Storm SQL. I did an analysis of merging SQE and Storm SQL in both side, integrating SQE to Storm SQL and vice versa.

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1691 @raghavgautam Thanks. It looks great to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1691: STORM-2090: Add integration test for storm windowing

Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/1691 @HeartSaVioR I have fixed the rat issue and I have put fast fail. Yes, we will be contributing more tests to apache storm going forward. --- If your project is set up for it, you can

[GitHub] storm pull request #1701: Emit to _spoutConfig.outputStreamId

GitHub user aichow opened a pull request: https://github.com/apache/storm/pull/1701 Emit to _spoutConfig.outputStreamId Even though KafkaSpout.declareOutputFields declaresStream using outputStreamId (if present), the message gets emitted to a stream matching the Kafka topic it was

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79898972 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79898829 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79897811 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79897599 --- Diff: bin/storm.py --- @@ -572,6 +572,22 @@ def kill_workers(*args): jvmtype="-client", extrajars=[USER_CONF_DIR,

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79897541 --- Diff: bin/storm.py --- @@ -572,6 +572,22 @@ def kill_workers(*args): jvmtype="-client", extrajars=[USER_CONF_DIR,

[GitHub] storm pull request #1677: STORM-1985: Admin Commands

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1677#discussion_r79898747 --- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java --- @@ -0,0 +1,133 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79893753 --- Diff: integration-test/src/test/resources/storm-conf/storm.yaml --- @@ -0,0 +1,17 @@ + +storm.zookeeper.servers: +- "node1" +

[GitHub] storm pull request #1691: STORM-2090: Add integration test for storm windowi...

Github user raghavgautam commented on a diff in the pull request: https://github.com/apache/storm/pull/1691#discussion_r79893438 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/window/TumblingTimeCorrectness.java --- @@ -0,0 +1,164 @@ +/* + *

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 We also found #1700 so once that goes in I'll pull it in here too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1700: STORM-2110: strip out empty String in worker opts

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1700 STORM-2110: strip out empty String in worker opts You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2110

Re: [DISCUSS] Provision for dead-letter topic in storm

Thank you Aaron. We use Kafka and JMS spouts and several bolts - Elastic-Search, Solr, Cassandra, Couchbase and HDFS in different scenarios and need to have the dead letter functionality for almost all these scenarios. Locally we have this functionality almost ready for writing dead-letters to

[GitHub] storm issue #1698: Storm 2105 cluster supervisor total and avail resources

Github user abellina commented on the issue: https://github.com/apache/storm/pull/1698  Note the "Cluster Resources" table, and the

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 I ran the same set of manual tests as before, but I now want to wait on #1699 to go into master, and then I will pull it in here. We are in the process of rolling essentially what is this same

[GitHub] storm issue #1699: STORM-2109: Treat Supervisor CPU/MEMORY Configs as Number...

Github user abellina commented on the issue: https://github.com/apache/storm/pull/1699 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1699: STORM-2109: Treat Supervisor CPU/MEMORY Configs as...

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1699 STORM-2109: Treat Supervisor CPU/MEMORY Configs as Numbers You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2109

[GitHub] storm pull request #1698: Storm 2105 cluster supervisor total and avail reso...

GitHub user abellina opened a pull request: https://github.com/apache/storm/pull/1698 Storm 2105 cluster supervisor total and avail resources Most of the work performed by @jerrypeng. I added a few changes for consistency and issues with the tooltips in the index page You

[GitHub] storm issue #1677: STORM-1985: Admin Commands

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1677 Looks good to me. I have a few tests that I want to run, but in general it looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1209: STORM-956: When the execute() or nextTuple() hang on exte...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1209 I think this feature is too fiddly for the user, and it doesn't really seem like there's any demand for it. Closing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request #1209: STORM-956: When the execute() or nextTuple() hang ...

Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1260: Fix wait-for-desired-code-replication always choosing dis...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1260 Nevermind this, the right mode is set when using the local cluster from testing4j, so this is probably fine. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #1260: Fix wait-for-desired-code-replication always choos...

Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79809326 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -266,26 +266,32 @@ private void

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79795823 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -277,7 +277,9 @@ private void emit() {

[GitHub] storm pull request #1679: STORM-2087: storm-kafka-client - tuples not always...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1679#discussion_r79794331 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -479,16 +482,17 @@ public OffsetAndMetadata

[GitHub] storm issue #1696: STORM-2104: More graceful handling of acked/failed tuples...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1696 The test failure is due to maven failing to download dependencies on storm-core. !storm-core passed. --- If your project is set up for it, you can reply to this email and have your reply appear on