Setting heap size parameters by workers.childopts and supervisor.childopts

i'm using 0.10.2 version . i tried to write in the code conf.put(Config.WORKER_CHILDOPTS, "-Xmx4g"); conf.put(Config.SUPERVISOR_CHILDOPTS, "-Xmx4g"); but i didn't touch any affect . Did i write the right configurations ? Does this value is the largest ?

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479775 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479281 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -488,84 +476,55 @@ public void registerCallbacks() {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479705 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479713 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479790 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129478344 --- Diff: storm-client/pom.xml --- @@ -257,7 +258,7 @@ **/generated/** -

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129478664 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/GrouperFactory.java --- @@ -137,7 +137,7 @@ public void prepare(WorkerTopologyContext context,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129479581 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -488,84 +476,55 @@ public void registerCallbacks() {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129478169 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize:

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129466805 --- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java --- @@ -21,101 +21,100 @@ import java.util.HashMap; import

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129466554 --- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java --- @@ -21,101 +21,100 @@ import java.util.HashMap; import

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

> On Jul 25, 2017, at 6:36 PM, Jungtaek Lim wrote: > > I believe I ported back complete set of bugfixes to the 1.1.x-branch when I > created 1.1.x-branch. > > 1.x-branch has some new features after 1.1.0, even also has backward > incompatible change: Redis state changed to

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 @avermeer As @roshannaik stated, we addressed many parts of performance bottleneck on Storm 1.0.0. The paper about Heron and blog post on SuperChief referred old version of Storm so it

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2241 Let's not be too hard on the Heron community. Yes, in the past they've not been exactly friendly in terms of marketing and technical claims, but now that Heron is incubating as an Apache project

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 @roshannaik First of all, great work! The numbers are impressive. Before going into this deeply, I would like to see the comparison between current master branch vs this patch (say,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129449347 --- Diff: storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java --- @@ -17,72 +17,92 @@ */ package org.apache.storm.executor;

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129449095 --- Diff: storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java --- @@ -105,19 +107,21 @@ public void expire(Long key, TupleInfo

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129448851 --- Diff: storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java --- @@ -105,19 +107,21 @@ public void expire(Long key, TupleInfo

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129447855 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -246,4 +291,26 @@ private void addTaskHooks() { } }

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129447781 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -122,28 +130,33 @@ public Task(Executor executor, Integer taskId) throws

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129447347 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/GrouperFactory.java --- @@ -137,7 +137,7 @@ public void prepare(WorkerTopologyContext context,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129447002 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -488,84 +476,55 @@ public void registerCallbacks() {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129446349 --- Diff: storm-client/src/jvm/org/apache/storm/task/IOutputCollector.java --- @@ -30,4 +31,5 @@ void ack(Tuple input); void fail(Tuple

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129445991 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129445734 --- Diff: conf/defaults.yaml --- @@ -146,7 +149,7 @@ supervisor.run.worker.as.user: false #how long supervisor will wait to ensure that a worker

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129445604 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java --- @@ -24,50 +24,56 @@ import org.apache.storm.task.GeneralTopologyContext;

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

I believe I ported back complete set of bugfixes to the 1.1.x-branch when I created 1.1.x-branch. 1.x-branch has some new features after 1.1.0, even also has backward incompatible change: Redis state changed to binary. I included migration script on it but still don't think it is bugfix. Taylor,

[GitHub] storm issue #2200: STORM-2616: Documentation for built in metrics

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2200 Thanks, it looks great. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2113: STORM-2497: Let Supervisor enforce memory and add in supp...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2113 +1, though I'll admit to just skimming it this time. It would be easier to tell what changed if the non-merge-conflict-resolution changes were in separate commits. It might make sense to drop

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2241 @avermeer Looks like SuperChief blog is relaying the same basic claims that Heron has marketed. Since you ask, i will share my opinions wrt Heron's claims. - Heron has never been a

[GitHub] storm issue #2200: STORM-2616: Documentation for built in metrics

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2200 @srdo I think I have addressed all of your concerns. Great suggestions by the way. Please have another look. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #2113: STORM-2497: Let Supervisor enforce memory and add in supp...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2113 @srdo @kishorvpatil @jerrypeng I just rebased this on the latest master and added in a few caches in some of the internal data structures to help with performance issues we had seen in

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

I ran into https://issues.apache.org/jira/browse/STORM-2659, which is a regression compared to 1.0.x, but not compared to 1.1.0. I think it would be nice to get fixed. 2017-07-25 20:59 GMT+02:00 Bobby Evans : > We could do a 1.1.2 release sooner if needed.

[GitHub] storm pull request #2244: STORM-2659: Add daemon.name variable to storm.cmd ...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2244 STORM-2659: Add daemon.name variable to storm.cmd to fix log4j logging See https://issues.apache.org/jira/browse/STORM-2659 You can merge this pull request into a Git repository by running: $ git

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

We could do a 1.1.2 release sooner if needed.  Technically any committer can call for a release at any point in time.  If there is a reason to do a release (like an important fix for a critical component) then we can do it. - Bobby On Tuesday, July 25, 2017, 1:48:07 PM CDT, Alexandre

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Hi, I guess 1.1.2 is going to be a few months away from now, so we'll have to go with our own basic Kafka 0.10 Spout in the meantime... You can discard my previous vote, we'd need to at least download 1.1.1 rc and give it a try to make an objective vote. Regards, Alexandre Vermeerbergen

[GitHub] storm pull request #2243: STORM-2658: Extract storm-kafka-client examples to...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2243 STORM-2658: Extract storm-kafka-client examples to storm-kafka-client… …-examples, make storm-kafka-client-examples generate a jar with all dependencies. See

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Hi Alexandre, STORM-2648 couldn’t be included because there is no patch available for it yet. Once there is a patch available, it can go into the next release, so it’s certainly possible for it to be available in 1.1.2. -Taylor > On Jul 25, 2017, at 1:12 PM, Alexandre Vermeerbergen >

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Tested source code by running unit tests and installed binaries to run example topologies. +1. -Harsha On Tue, Jul 25, 2017, at 10:08 AM, Bobby Evans wrote: > I built from source (v1.1.1 88f0b8a45553ea960164fab18c736a5cdbae8e58) ran > all of the unit tests and ran some manual tests. > I am +1 on

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

I built from source (v1.1.1 88f0b8a45553ea960164fab18c736a5cdbae8e58) ran all of the unit tests and ran some manual tests. I am +1 on the release. - Bobby On Tuesday, July 25, 2017, 11:14:14 AM CDT, Kishorkumar Patil wrote: I built and ran some manual tests.

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Hello, -1 (non binding) Maybe it's a bit selfish, but I really count on https://issues.apache.org/jira/browse/STORM-2648 being part of Storm 1.1.1, because we have a requirement to use Kafka 0.10 consumer in topologies requiring at most once behavior. We understood that we could use

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Yes. There were a number of important patches present in 1.x-branch that were not in 1.1.x-branch. When I tried to merge 1.x-branch to 1.1.x-branch, I ran into unexpected conflicts. I thought about deleting 1.1.x-branch and recreating it, but decided against it, not wanting lose changes there

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

I built and ran some manual tests. +1 to release this package. -Kishor On Tuesday, July 25, 2017, 12:08:32 PM EDT, Stig Rohde Døssing wrote: Is it on purpose that this is cut from 1.x-branch and not 1.1.x-branch? 2017-07-25 17:09 GMT+02:00 P. Taylor Goetz

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR That's great. I filed a PR addressing this bug. https://github.com/apache/storm/pull/2239 Could you please review it if you get a chance? Thanks. --- If your project is set up for it,

Re: [VOTE] Release Apache Storm 1.0.4 (rc1)

I built and I ran manual tests. It looks good to me. I am +1 on the release. -Kishor On Tuesday, July 25, 2017, 11:19:46 AM EDT, Bobby Evans wrote: I built from source (v1.0.4 a5e1c154b5b2ae74fd78bf10d4c130afb1ad4513), ran all of the unit tests, and ran a few

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Is it on purpose that this is cut from 1.x-branch and not 1.1.x-branch? 2017-07-25 17:09 GMT+02:00 P. Taylor Goetz : > This is a call to vote on releasing Apache Storm 1.1.1 (rc1) > > Full list of changes in this release: > >

Re: problem with the size of the result after submitting

up .. will appreciate any help On Tue, Jul 25, 2017 at 2:23 PM, sam mohel wrote: > Can someone help , please? > > On Tuesday, July 25, 2017, sam mohel wrote: > > i attached log files for worker and supervisor files , Can someone help > ? > > On Tue,

[GitHub] storm issue #2242: [STORM-1347] display topology version on UI

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2242  --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #2242: [STORM-1347] display topology version on UI

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2242 [STORM-1347] display topology version on UI Display topology version on UI. see: https://issues.apache.org/jira/browse/STORM-1347 You can merge this pull request into a Git repository by

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129344288 --- Diff: storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java --- @@ -0,0 +1,182 @@ +/** + * Licensed to the

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on the issue: https://github.com/apache/storm/pull/2241 @roshannaik Did you run any topologies with trident topologies in distributed mode with these changes? --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [VOTE] Release Apache Storm 1.0.4 (rc1)

I built from source (v1.0.4 a5e1c154b5b2ae74fd78bf10d4c130afb1ad4513), ran all of the unit tests, and ran a few manual tests on my laptop. I am +1 on the release. - Bobby On Tuesday, July 25, 2017, 6:27:18 AM CDT, Stig Rohde Døssing wrote: The linked changelog

[VOTE] Release Apache Storm 1.1.1 (rc1)

This is a call to vote on releasing Apache Storm 1.1.1 (rc1) Full list of changes in this release: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=88f0b8a45553ea960164fab18c736a5cdbae8e58 The tag/commit to be voted upon is v1.1.1:

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm Great news for me to figure it out. I just added pair of `username` & `username@domain` while testing so didn't recognize the issue. --- If your project is set up for it, you can reply

Writing orc files with storm via java API

Is there any implementation of storm bolt which can write files to HDFS in ORC format, without using Hive Streaming API? I've found java API for writing ORC files and I'm guessing is there any existing Hive bolts that uses it or any plans to create such?

Re: problem with the size of the result after submitting

Can someone help , please? On Tuesday, July 25, 2017, sam mohel wrote: > i attached log files for worker and supervisor files , Can someone help ? > On Tue, Jul 25, 2017 at 7:57 AM, sam mohel wrote: >> >> in supervisor.log got >> 2017-07-25 07:35:20.137

Re: [VOTE] Release Apache Storm 1.0.4 (rc1)

The linked changelog (https://git-wip-us.apache.org/repos/asf?p=storm.git;a= blob_plain;f=CHANGELOG.md;h=50878fab679973a1230466920006dc0746ffddd5;hb= eac433b0beb3798c4723deb39b3c4fad446378f4) seems to contain only changes up to 1.0.3. It's just a problem with the link, the changelog in the src tar

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user avermeer commented on the issue: https://github.com/apache/storm/pull/2241 Hello Roshan, Thank you very much for your huge work for improving Storm performances! Regarding "competitive perf evaluation", would you say that now the reasons why SuperCheif

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129208678 --- Diff: conf/defaults.yaml --- @@ -304,6 +303,7 @@ storm.cgroup.resources: storm.cgroup.hierarchy.name: "storm" storm.supervisor.cgroup.rootdir:

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129217706 --- Diff: storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java --- @@ -105,19 +107,21 @@ public void expire(Long key, TupleInfo

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129212155 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -488,84 +476,55 @@ public void registerCallbacks() {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129209017 --- Diff: storm-client/src/jvm/org/apache/storm/task/IOutputCollector.java --- @@ -30,4 +31,5 @@ void ack(Tuple input); void fail(Tuple

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129208440 --- Diff: conf/defaults.yaml --- @@ -146,7 +149,7 @@ supervisor.run.worker.as.user: false #how long supervisor will wait to ensure that a worker process

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129215798 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -246,4 +291,26 @@ private void addTaskHooks() { } } +

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129208570 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129222974 --- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java --- @@ -21,101 +21,100 @@ import java.util.HashMap; import

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129217748 --- Diff: storm-client/src/jvm/org/apache/storm/executor/spout/SpoutExecutor.java --- @@ -105,19 +107,21 @@ public void expire(Long key, TupleInfo

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129214432 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Acker.java --- @@ -66,6 +67,7 @@ public void prepare(Map topoConf, TopologyContext

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129219489 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java --- @@ -26,38 +26,25 @@ import java.util.ArrayList; import

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129216374 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -122,28 +130,33 @@ public Task(Executor executor, Integer taskId) throws IOException

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129218102 --- Diff: storm-client/src/jvm/org/apache/storm/executor/ExecutorShutdown.java --- @@ -34,17 +34,19 @@ import org.slf4j.Logger; import

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129218772 --- Diff: storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java --- @@ -17,72 +17,92 @@ */ package org.apache.storm.executor;

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129214771 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/GrouperFactory.java --- @@ -137,7 +137,7 @@ public void prepare(WorkerTopologyContext context,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129220412 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java --- @@ -24,50 +24,56 @@ import org.apache.storm.task.GeneralTopologyContext;

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129223991 --- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java --- @@ -21,101 +21,100 @@ import java.util.HashMap; import