[GitHub] storm issue #1082: STORM-1492 With nimbus.seeds set to default, a nimbus for...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1082 @revans2 Thanks for reviewing. Just got rebased against current master. ---

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2309 @srdo Addressed review comments. ---

[GitHub] storm pull request #2304: STORM-2445 Topology log search refers supervisor I...

2017-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2304 ---

[GitHub] storm issue #2310: STORM-2724 Shutdown ExecutorService in WaterMarkEventGene...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2310 @srdo Addressed review comments. ---

[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2309#discussion_r137663649 --- Diff: storm-core/test/jvm/org/apache/storm/windowing/WaterMarkEventGeneratorTest.java --- @@ -56,6 +57,13 @@ public void add(Event event) {

[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2309#discussion_r137663770 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java --- @@ -126,4 +135,20 @@ private void checkFailures() {

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2309 @srdo Unfortunately we should always have two PRs for fixing storm-client or storm-server or storm-core because master and 1.x version lines are diverged. ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2289 sure thanks. ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @roshannaik I merged this into master, but if you want any changes to it please just ask and I'll see what I can do. ---

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

2017-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2289 ---

[GitHub] storm pull request #2312: YSTORM-2725: Generic Resource Scheduling - initial...

2017-09-07 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2312 YSTORM-2725: Generic Resource Scheduling - initial config changes and… … TopologyBuilder API You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] Release Apache Storm 1.0.5 (rc1)

2017-09-07 Thread Stig Rohde Døssing
* Extracted binary zip and built storm-starter using the included example code and the Nexus staging repo. * After working around https://issues.apache.org/jira/browse/STORM-2451 (I forgot to pull it into 1.0.x after the 1.0.4 release, and don't want to delay this release for that issue), started

[GitHub] storm pull request #2302: STORM-2635 Deep log search doesn’t work when the...

2017-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2302 ---

[GitHub] storm pull request #2261: STORM-2678 Improve performance of LoadAwareShuffle...

2017-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2261 ---

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2289 +1 ---

[GitHub] storm issue #2310: STORM-2724 Shutdown ExecutorService in WaterMarkEventGene...

2017-09-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2310 +1, same nits as on the 1.x version ---

[GitHub] storm pull request #2311: [STORM-2729] Fix NPE in WorkerState runWorkerStart...

2017-09-07 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2311 [STORM-2729] Fix NPE in WorkerState runWorkerStartHooks and runWorkerShutdownHooks methods worker_hooks is an optional field in StormTopology struct (storm.thrift). So when we call

Re: Running topologies in LocalCluster mode leaves junk in ${user.dir}/logs

2017-09-07 Thread Alexandre Vermeerbergen
Hello Bobby, Thanks a lot for your rapid answer. At least there's hope for improvement in LocalCluster when 2.x will be available as a stable release. For 1.x, you mention that I could use Clojure APIs. But unless I'm mistaking, Clojure is just "yet another JVM compliant" language, so isn't there

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

2017-09-07 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @knusbaum do you have any other comments? ---

[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

2017-09-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2309#discussion_r137563632 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java --- @@ -126,4 +135,20 @@ private void checkFailures() { public

[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

2017-09-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2309#discussion_r137560854 --- Diff: storm-core/test/jvm/org/apache/storm/windowing/WaterMarkEventGeneratorTest.java --- @@ -56,6 +57,13 @@ public void add(Event event) {

[GitHub] storm pull request #2310: STORM-2724 Shutdown ExecutorService in WaterMarkEv...

2017-09-07 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2310 STORM-2724 Shutdown ExecutorService in WaterMarkEventGenerator in shu… …tdown phase * also names unnamed executor services in windowing package For 1.x version: #2309 You

[GitHub] storm pull request #2309: (1.x) STORM-2724 Shutdown ExecutorService in Water...

2017-09-07 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2309 (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEventGenerator in shu… …tdown phase * also names unnamed executor services in windowing package This issue affects

Re: [VOTE] Release Apache Storm 1.0.5 (rc1)

2017-09-07 Thread Alexandre Vermeerbergen
Hello, (non binding) [x] 0 No opinion => we are currently running with 1.1.0, waiting for include https://issues.apache.org/jira/browse/STORM-2648 fix was unfortunately shifted in 1.2.0 (although lack of acks for KafkaSpout when it's running in autocommit mode sounds more like a bug than a