[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2532 @satishd added comments. Commit amended because it is tiny change. ---

[GitHub] storm pull request #2533: STORM-2912 Revert optimization of sharing tick tup...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2533#discussion_r163767878 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -387,11 +387,13 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2532 @danny0405 If it's in critical path, it could bring perf. hit, not only from creating object but also from GC. We are targeting to emit millions of tuples in a second. In this case, give

[GitHub] storm pull request #2533: STORM-2912 Revert optimization of sharing tick tup...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2533#discussion_r163766870 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -387,11 +387,13 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2532 @satishd @danny0405 Sorry guys. I missed while commenting, corrected now. **I don't think it brings any perf hit.** I wrote it opposite way. ;) ---

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2532 @HeartSaVioR Create an object is very lightweight, is should not have any performance hit. ---

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/2532 @HeartSaVioR It may be helpful to have a comment on why it was changed with JIRA number so that same change is avoided later. ---

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2532 @satishd I don't know about the perf hit, and I don't think it doesn't bring actual perf hit, but anyone would think it is just weird to create same tuple every time, so easy to break it again.

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple (1.x...

Github user satishd commented on the issue: https://github.com/apache/storm/pull/2532 @HeartSaVioR Was there a reasonable perf hit because of creating tick tuple instance whenever it is executed in timer? ---

[GitHub] storm issue #2531: STORM-2898: Support for WorkerToken authentication

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2531 @HeartSaVioR BTW, worker needs to fetch assignment as a timer task to sync connections. ---

[GitHub] storm pull request #2533: STORM-2912 Revert optimization of sharing tick tup...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2533 STORM-2912 Revert optimization of sharing tick tuple * since it incurs side effect and messes metrics More detail: https://issues.apache.org/jira/browse/STORM-2912 You can merge this pu

[GitHub] storm issue #2532: STORM-2912 Revert optimization of sharing tick tuple

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2532 It is really hard to think such side effect while applying optimization like this. It is fairly easy to think that tuple is immutable, and it is true for interface `Tuple`, but no longer true for

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

Regarding storm-kafka-client, what Jungtaek is saying lines up with why I (and likely others) haven't been backporting all fixes to 1.0.x and 1.1.x. We've been trying to follow semantic versioning, so new features and deprecations have been going in 1.2.0 rather than patch releases. This has caused

[GitHub] storm pull request #2532: STORM-2912 Revert optimization of sharing tick tup...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2532 STORM-2912 Revert optimization of sharing tick tuple * since it incurs side effect and messes metrics It must be cherry-picked into 1.1.x-branch and 1.0.x-branch as well. Will a

Re: [VOTE] Release Apache Storm 1.1.2

I found blocker issue based on the contributor's report in 1.2.0 RC1, and found the cause. Filed https://issues.apache.org/jira/browse/STORM-2912. Will craft patches for branches shortly. -1 (binding) - Jungtaek Lim (HeartSaVioR) 2018년 1월 25일 (목) 오전 2:36, P. Taylor Goetz 님이 작성: > This is a cal

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

Btw, I found blocker issue based on the contributor's report in 1.2.0 RC1, and found the cause. Filed https://issues.apache.org/jira/browse/STORM-2912. Will craft patches for branches shortly. -1 (binding) - Jungtaek Lim (HeartSaVioR) 2018년 1월 25일 (목) 오후 12:43, Jungtaek Lim 님이 작성: > IMHO, I ha

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

I found the cause. Filed https://issues.apache.org/jira/browse/STORM-2912. Will craft patches for branches shortly. FYI, this issue affects all the RCs being opened now. I'll comment to other RCs as well. -Jungtaek Lim (HeartSaVioR) 2018년 1월 25일 (목) 오후 12:09, Jungtaek Lim 님이 작성: > Alexandre, >

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

IMHO, I have been wondering that it is still a good strategy to couple Storm core and connectors with one version. That has been making painful situations in storm-kafka-client, where it could be marked as beta and release often with free to break backward compatibility until it is fairly stable, b

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

Hi Erik, Thanks for bring up issue. Yes you're right that all the patches are going through 1.x-branch (1.2.0), but not 1.1.x-branch because of huge divergence. We have limited resource so I'm afraid to say folks to port back issues with much pain of conflicts. Maybe we could make somewhat crazy

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

Alexandre, As Priyank stated we're seeing odd numbers in storm-starter. I also found the odd value but it was not 1.2.0 but RC for another version. Maybe I missed to check for 1.2.0 here. I'm planning to test all the open release candidates as well and test with various topologies, but it would be

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

Release looks good overall except for complete latency and capacity. Verified the md5, sha and asc Unzipped and untared the source and binary releases. Built from source and ran daemons from storm-dist binary release after packing from the same. Submitted FastWordCount and RollingTopWords Played

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

Erik, Open and honest opinions are always welcome. Even if they may come across as harsh (and yours did not). We value your opinion, and that of the mesos community. I’d like to get these issues resolved and would ask others to help where they can. You’ve been very forthcoming with informatio

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user erikdw commented on the issue: https://github.com/apache/storm/pull/2433 @revans2 : thanks, please just loop us in and we'll carve out time to provide feedback. ---

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r163729225 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/kerberos/ServerCallbackHandler.java --- @@ -18,79 +18,86 @@ package org.apache

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r163728603 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/kerberos/KerberosSaslTransportPlugin.java --- @@ -114,22 +120,26 @@ public TTransportFact

Re: [VOTE] Release Apache Storm 1.0.6 (rc1)

Hi Taylor, I apologize that this objection is a bit long, incomplete, and late for this release vote. Also, I by no means intend this as an attack on the good folks that develop and maintain storm-kafka-client. That being said, I'm uncomfortable with the situation of storm-kafka-client in the 1.

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2433 @HeartSaVioR thanks for putting up the reference to my patch for STORM-2898. Sorry I have not been responding for the past few days. I locked myself in a room trying to get it done ASAP, and have b

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 @revans2 just posted the patch of STORM-2898: #2531. Please participate reviewing when you have free time. Thanks in advance. ---

[GitHub] storm issue #2531: STORM-2898: Support for WorkerToken authentication

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2531 I just forgot you don't think worker -> supervisor heartbeat passing via RPC is mandatory, hence there's no need to have worker -> supervisor token. Please let me know if I'm missing here. ---

[GitHub] storm issue #2531: STORM-2898: Support for WorkerToken authentication

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2531 @revans2 Thanks a lot for putting great efforts to craft a patch so quickly! I'll take a look after verification of release candidates on 1.x version lines in progress. Btw, in #2433 we

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

Hello Storm developers, One of my team member (Noureddine Chatti) found that the regression in "Assigned Memory (MB)" columns for our topologies with Storm 1.2.0rc1, where the 65 MB value is displayed regardless of our actual topologies's memory setting: We define our workers's max memory heap us

[VOTE] Release Apache Storm 1.0.6 (rc1)

This is a call to vote on releasing Apache Storm 1.0.6 (rc1) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.6-rc1/RELEASE_NOTES.html The tag/commit to be voted upon is v1.0.6: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=24a42

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

+1 (binding) - Downloaded and deployed the tar.gz and .zip binary distribution. - Verified MD5. - Built the source with JDK 1.8 - Ran a few sample topologies and observed the output. - Viewed the worker logs via log viewer and did some basic sanity on the metrics. Thanks, Arun On 1/23/18, 10

[VOTE] Release Apache Storm 1.1.2

This is a call to vote on releasing Apache Storm 1.1.2 (rc1) Full list of changes in this release: https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.1.2-rc1/RELEASE_NOTES.html The tag/commit to be voted upon is v1.1.2: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=80b88

Re: [VOTE] Release Apache Storm 1.2.0 (rc1)

Here is the correct URL for the changes in this release (Thanks Stig!): https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.0-rc1/RELEASE_NOTES.html -Taylor > On Jan 23, 2018, at 3:36 PM, P. Tayl

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2531#discussion_r163574245 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -744,19 +767,111 @@ public Credentials credentials(String stormId,

[GitHub] storm pull request #2531: STORM-2898: Support for WorkerToken authentication

GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2531 STORM-2898: Support for WorkerToken authentication This adds in support for workers to be able to authenticate with either nimbus or drpc invocation servers using WorkerTokens. A WorkerToke