[GitHub] storm pull request #2545: STORM-2933: Add a storm-perf topology that uses st...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2545 ---

[GitHub] storm issue #2548: STORM-2935 Add metric to track when TGT expires

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2548 I just noticed that Metrics V2 is not port-forwarded to master branch. I'd suggest waiting for Metrics V2 integration against master, and apply it unless it is urgent. ---

[GitHub] storm issue #2548: STORM-2935 Add metric to track when TGT expires

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2548 Looks like this patch proposes making a change to Metrics V1 interface which is deprecated. I'd like to see us having a plan to migrate Metrics V1 into Metrics V2 instead of keep using it. ---

[GitHub] storm pull request #2548: STORM-2935 Add metric to track when TGT expires

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2548#discussion_r166201854 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -20,6 +20,17 @@ import

[GitHub] storm pull request #2546: STORM-2934 - fix startup ClassNotFoundException wh...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2546#discussion_r166201614 --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java --- @@ -1035,7 +1035,10 @@ * Class implementing MetricStore.

[GitHub] storm issue #2544: [STORM-2932] the naming of topology localityaware configs...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2544 @revans2 @Ethanlm I don't think this is a deal. We didn't release Storm 2.0.0 officially, and also that's added just 4 months ago hence even early-adopter may exist, the possibility for

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

UPDATE: Submitted a pull request https://github.com/apache/storm/pull/2549 for STORM-2936 (against 1.1.x-branch) Erik, please change the status to "IN PROGRESS" if someone is working on. I would find the free time and just do it if there's no one working in progress. 2018년 2월 6일 (화) 오전 10:39,

[GitHub] storm pull request #2549: STORM-2936 Overwrite latest storm-kafka-client 1.x...

GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/2549 STORM-2936 Overwrite latest storm-kafka-client 1.x-branch into 1.1.x-… …branch * also doc and storm-kafka-client-examples as well Please check the list of changed files

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

Thanks for quick response Erik! Just filed two issues : https://issues.apache.org/jira/browse/STORM-2936 (for 1.1.x-branch) https://issues.apache.org/jira/browse/STORM-2937 (for 1.0.x-branch) We have another discussion around making storm-kafka-client be experiment of managing separately

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

Thanks for the quick response Jungtaek! Yes, my teammates and myself would like to help on this. Is there an existing JIRA for the work you've been doing on the other branches? I propose we don't make this block 1.0.6 -- we can just release 1.0.7 quickly when the backport is done, if that is

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

UPDATE: I've finished working on overwriting storm-kafka-client 1.x-branch to 1.1.x-branch. Not yet pushed to ASF git, but pushed to my fork first to trigger Travis CI to see how the build goes well. https://github.com/HeartSaVioR/storm/commit/76b8a7d3a6f91e66612e87da8589f5723f05218a

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

hey Jungtaek, Thanks for continuing to pursue this! The issue for Storm not working on Mesos is due to a fundamental change to the core scheduling logic in Storm: -

Re: [CANCELED] [VOTE] Release Apache Storm 1.2.0 (rc2)

I'm working on copying storm-kafka-client, but as I noticed to other thread [1], copying incurs change of storm-core. While 1.1.x-branch requires small change, but 1.0.x-branch requires non-trivial change and I have to track the changes related to storm-kafka-client. So I've suggested the

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

UPDATE: Looks like we changed some parts of storm-core while fixing storm-kafka-client issues (especially went in 1.1.0), hence overwriting also incurs changes of storm-core. It doesn't look like a big deal for 1.1.x-branch, but there looks like needed many changes for 1.0.x-branch. The thing is,

Re: [DISCUSS] Replace storm-kafka-client on 1.1.x-branch / 1.0.x-branch with 1.x-branch

OK. No more opinion/vote in 5 days. I'll treat consensus was made, and go ahead making change: overwrite storm-kafka-client 1.2.0 to two branches 1.1.x/1.0.x. -Jungtaek Lim (HeartSaVioR) 2018년 2월 1일 (목) 오전 10:48, Jungtaek Lim 님이 작성: > This discussion got 4 +1 (binding) and no

[GitHub] storm issue #2547: Storm 2913 2914 1.x

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2547 +1 ---

Re: [CANCELED] [VOTE] Release Apache Storm 1.2.0 (rc2)

It's been merged, thanks for the quick review. I think storm-kafka-client should be ready to be copied to the other two branches. 2018-02-05 22:00 GMT+01:00 P. Taylor Goetz : > Yes, here’s the pull request: > > https://github.com/apache/storm/pull/2547 > > Once that’s merged,

[GitHub] storm pull request #2547: Storm 2913 2914 1.x

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2547 ---

[GitHub] storm issue #2547: Storm 2913 2914 1.x

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2547 Thanks, I'm going to merge this immediately since it's a backport. ---

[GitHub] storm pull request #2548: STORM-2935 Add metric to track when TGT expires

Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2548#discussion_r166117240 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -20,6 +20,17 @@ import

[GitHub] storm pull request #2548: STORM-2935 Add metric to track when TGT expires

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2548#discussion_r166111464 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -20,6 +20,17 @@ import

[GitHub] storm issue #2547: Storm 2913 2914 1.x

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2547 +1 ---

[GitHub] storm pull request #2548: STORM-2935 Add metric to track when TGT expires

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2548 STORM-2935 Add metric to track when TGT expires You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_athens Alternatively you

Re: [CANCELED] [VOTE] Release Apache Storm 1.2.0 (rc2)

Yes, here’s the pull request: https://github.com/apache/storm/pull/2547 Once that’s merged, I can sync storm-kafka-client from 1.x-branch to 1.1.x-branch and 1.0.x-branch and cut new RCs. -Taylor > On Feb 5, 2018, at 1:27 PM, Arun Mahadevan

[GitHub] storm issue #2547: Storm 2913 2914 1.x

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2547 +1 ---

[GitHub] storm pull request #2547: Storm 2913 2914 1.x

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2547 Storm 2913 2914 1.x The backport changes are in separate commits. Let me know when I should squash and merge. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #2546: STORM-2934 - fix startup ClassNotFoundException when miss...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2546 The dependency rocksdbjni.jar is present in lib/ directory after packaging so there shouldn't be exceptions during nimbus daemon startup. But changing from `isImplementationOfClass` to `isString `

Re: [CANCELED] [VOTE] Release Apache Storm 1.2.0 (rc2)

STORM-2918 has been merged to 1.x branch. Now looks like we waiting for 1.x versions of https://github.com/apache/storm/pull/2538 and https://github.com/apache/storm/pull/2537 ? Can we get the next RC as soon as the above two are merged to 1.x ? Thanks, Arun On 2/1/18, 12:55 AM,

[GitHub] storm pull request #2546: STORM-2934 - fix startup ClassNotFoundException wh...

GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2546 STORM-2934 - fix startup ClassNotFoundException when missing RocksDB jar Currently, only Nimbus uses STORM_METRIC_STORE_CLASS. If the RocksDB jar is missing on Daemons other than Nimbus,

[GitHub] storm issue #2544: [STORM-2932] the naming of topology localityaware configs...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2544 @revans2 Yes you are right. I assumed that this can be changed since 2.x is not released. ---

[GitHub] storm issue #2544: [STORM-2932] the naming of topology localityaware configs...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2544 The changes look okay to me. I just want to be sure that you are aware that this is a breaking change and the consequences of that. Because this config went into 2.x and has not been released it