Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2582
@zodvik We may still want to apply this to 1.x version line. So if you
struggled and the patch helped your case, please submit the patch against
1.x-branch.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2433
@revans2
I'm also not familiar with newly added worker token feature, and you said
we need to apply token auth to supervisor as well.
Could you apply worker token feature to this patch
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2583
+1 again, looks great
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2583#discussion_r172011662
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1030,8 +1034,34 @@ private static Object normalizeConfValue(Object obj)
{
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2583#discussion_r172011663
--- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java ---
@@ -173,4 +176,23 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2583#discussion_r172011690
--- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java ---
@@ -173,4 +176,23 @@ public void
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2584
+1
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2433
@HeartSaVioR @revans2
I have merged in master branch and fix the conflicts, but i'm not very
familiar with the authorization thing. So could you please help to make some
contribution ?
