Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
@revans2 thanks for the explanantion
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
LGTM +1. @revans2 up to you if you want to do something more about whether
those warnings should dealt with in a more serious manner
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
@revans2 Sorry for not being more clear about what I meant in regards to
using the heap instead of stack space. Currently, the algorithm uses recursion
to backtrack which means it is going to use
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
In terms of the configs, we may want to explore splitting the Configs into
multiple pieces. Config.java has become a monolith in a sense. Configs.java in
the storm-client module should probably
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
Generally look good just some minor comments. @revans2 you can also
implement a version of the algorithm using heap space in the JVM instead of
stack stack space so you wouldn't need to tinker
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r157680068
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java
---
@@ -129,7 +129,15
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r157679506
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r157679086
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
---
@@ -0,0 +1,623
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2442#discussion_r157677523
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/multitenant/NodePool.java
---
@@ -98,7 +98,7 @@ public RoundRobinSlotScheduler
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2442
cool this got open sourced!
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2400
@revans2 yup you are right about it being more about the size of the
component. Great work! Thanks for sharing the detailed information as its a
good learning experience for me! Keep me
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2400
@revans2 thanks for the explanation! Sorry my math was wrong! I understand
the context a lot better now! Though my intuition tells me that if larger
topologies usually get scheduled first
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2400
@revans2 can you elaborate on why EvictionPolicies are no longer needed?
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2400
@revans2 interesting work! Though the formula used for the
DefaultSchedulingPriorityStrategy seems to have a bias towards smaller
topologies.
For example:
Total amount
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148923251
--- Diff: docs/Resource_Aware_Scheduler_overview.md ---
@@ -303,28 +326,33 @@ To get an idea of how much memory/CPU your topology
is actually using you
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148923218
--- Diff: docs/Resource_Aware_Scheduler_overview.md ---
@@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808
### Specifying Topology
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148923188
--- Diff: docs/Resource_Aware_Scheduler_overview.md ---
@@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808
### Specifying Topology
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2400#discussion_r148923121
--- Diff: docs/Resource_Aware_Scheduler_overview.md ---
@@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808
### Specifying Topology
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2374
+1
---
GitHub user jerrypeng reopened a pull request:
https://github.com/apache/storm/pull/2314
[STORM-2731] - Simple checks in Storm Windowing
There is also inconsistent and mixed used of Longs and Ints throughout the
windowing code. Perhaps we should just change all the numeric values
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2314
@srdo thanks for the review. Lets do the larger change in a separate PR.
---
Github user jerrypeng closed the pull request at:
https://github.com/apache/storm/pull/2314
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2331
+1 but perhaps its work while looking into using something like dropwizard
metrics:
http://metrics.dropwizard.io/3.2.3/manual/core.html
---
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2314
@srdo I totally agree with your idea. I looked into changing all time
variables to be long and renaming all variables to have a "Ms". It will
probably be a significant diff
---
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/2314
[STORM-2731] - Simple checks in Storm Windowing
There is also inconsistent and mixed used of Longs and Ints throughout the
windowing code. Perhaps we should just change all the numeric values
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2199#discussion_r135584078
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
---
@@ -42,14 +43,16 @@
private Map<Str
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2113
cool feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2143
@adityasharad Thanks for changing it back. What about the unit test that
was modified as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2100
@adityasharad is I agree with your change for the sortComponents on line
544. Thank you for correcting that, but can you change the sorting logic of
sortNeighbors to as before since I believe
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/2100
@adityasharad thanks for addressing these issues but can you tell me why
you decided to change the compare function that I commented above?
@revans2 do you believe the sorting mentioned
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/2100#discussion_r118366750
--- Diff:
storm-client/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -567,9 +567,9 @@ public
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1973
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
Thanks @revans2 +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
Thanks @revans2 +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
thanks @revans2 for taking the time to refactor some of the code! I
reviewed it once more. If there is an example of how to user the metrics in
the docs I think that would be extremely helpful
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102382536
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryUsage.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102382461
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102382308
--- Diff: storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupCpu.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r102381366
--- Diff: docs/cgroups_in_storm.md ---
@@ -43,13 +43,24 @@ group storm {
}
cpu {
}
+ memory
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1934
@revans2 this is a really cool feature and thanks for adding it. My only
question is that I see you have implemented some parsers/getters for the cgroup
metrics. There is already a set of them
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r100951683
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupCpuGuarantee.java ---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r100951524
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/cgroup/CGroupMemoryLimit.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1932
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1812
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1764
LGTM +1 @revans2 thanks for making the optimizations
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1764#discussion_r90540863
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1008,23 +1008,24 @@
(reset! (:id->worker-resources nim
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r90526318
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2177,13 +2177,37 @@
@isMapEntryType(keyType = String.class, valueType
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1804
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1733
@revans2 thanks for the reviews. I have addressed your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1733
Also re-add some RAS related tests that were accidentally deleted in the
past
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1733
[STORM-2134] - improving the current scheduling strategy for RAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2134
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1713
Did some manual testing with the UI and everything looks good
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1654
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1708
[STORM-2119] - bug in log message printing to stdout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2119
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1670
[STORM-2079] - Unneccessary readStormConfig operation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2079
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1659
[STORM-2056] - Bugs in logviewer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2056
Alternatively you can review
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1619
+1 just faced this issue. Glad you already have a fix up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1621
[STORM-1766] - A better algorithm server rack selection for RAS
Backport of #1398 to 1.x branch. I'm not sure this actually needs a PR,
but since it's been a while since #1500 was merged, I'll
Github user jerrypeng commented on the issue:
https://github.com/apache/storm/pull/1592
@HeartSaVioR
I have pushed critical bug fixes for RAS to the 1.x branch. There has been
a few algorithmic improvements on RAS that I had only put into 2.x but I desire
to get them
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1510
[STORM-1866] - Update Resource Aware Scheduler Documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1866
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1398#issuecomment-221686962
@ptgoetz oh i see, thanks for letting me know! I will remember next time to
put a comment in the jira regarding which branches i merged the corresponding
PR
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1398#issuecomment-221678273
@ptgoetz just merged it into master why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1398#issuecomment-221665618
@ptgoetz I have created a jira:
https://issues.apache.org/jira/browse/STORM-1866
---
If your project is set up for it, you can reply to this email and have your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1398#issuecomment-221314974
@redsanket thanks for the review. Do you have any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1398#discussion_r64404386
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -45,6 +47,7 @@
import
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1216#issuecomment-220783660
At yahoo, cgroups are used to limit both memory and cpu of every worker so
that topologies can have more resource isolation
On Saturday, May 21, 2016, Xin
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1398
[STORM-1766] - A better algorithm server rack selection for RAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1766
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1335#issuecomment-215831984
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1370#issuecomment-215826814
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1307#issuecomment-208946081
Non-related failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1307
[STORM-1681] - Bug in scheduling cyclic topologies when scheduling with th
RAS
There is a bug in the bfs algorithm in RAS that does not correctly account
for components already visited during
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1232#issuecomment-202514705
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57491392
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -54,6 +61,681 @@
private static
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57486697
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -54,6 +61,681 @@
private static
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57485387
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -54,6 +61,681 @@
private static
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57485480
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -54,6 +61,681 @@
private static
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57391018
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57389473
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57387622
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57387004
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57386690
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1256#discussion_r57385884
--- Diff: docs/Trident-RAS-API.md ---
@@ -0,0 +1,49 @@
+---
+title: Trident RAS API
+layout: documentation
+documentation: true
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r57228512
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -0,0 +1,632 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r57182643
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncProcessEvent.java ---
@@ -0,0 +1,428 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r57171985
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java
---
@@ -0,0 +1,632 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1211#issuecomment-197672345
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1226#issuecomment-197700574
Also needs to be pushed back into 1.x branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1224#issuecomment-197671679
Unrelated travis-ci failure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1184#issuecomment-197701084
Found another bug in supervisor:
https://github.com/apache/storm/pull/1226
just another note here to make sure we remember to get in the fix whether
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1226
[STORM-1636] - Supervisor shutdown with worker id pass in being nil
In function kill-existing-workers-with-change-in-components in
supervisor.clj:
The function tries to detect whether
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1224
[STORM-1634] - Minor Refactoring of Resource Aware Scheduler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm ras_refactor
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1184#issuecomment-197042280
I have a bug fix for cgroups that involve a couple lines of modification in
supervisor.clj.
https://github.com/apache/storm/pull/1216
If that pull
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1216
[STORM-1631] - Storm CGroup bug when launching workers as the user that
submitted the topology
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55869630
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/DefaultResourceDeclarer.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55765793
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/operation/DefaultResourceDeclarer.java
---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55765520
--- Diff:
storm-core/test/clj/integration/org/apache/storm/trident/integration_test.clj
---
@@ -281,6 +285,86 @@
(.stateQuery
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55765027
--- Diff:
storm-core/test/clj/integration/org/apache/storm/trident/integration_test.clj
---
@@ -281,6 +285,86 @@
(.stateQuery
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55764668
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -431,6 +459,52 @@ public StormTopology build
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55764689
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -431,6 +459,52 @@ public StormTopology build
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1199#discussion_r55725427
--- Diff: storm-core/src/jvm/org/apache/storm/trident/TridentTopology.java
---
@@ -409,16 +427,26 @@ public StormTopology build
1 - 100 of 619 matches
Mail list logo
