Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52124493
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystemType.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52124299
--- Diff: conf/defaults.yaml ---
@@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
pacemaker.childopts: "-Xmx1024m"
pacemaker.auth.met
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52112633
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2155,6 +2156,63 @@
@isString
public static final Object
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52112026
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1178,7 +1212,7 @@
(FileUtils/copyDirectory (File. (.getFile url
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111863
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111864
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1088,8 +1104,26 @@
(str "
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111843
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111796
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111775
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -381,7 +391,7 @@
(:storm-id assignment
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111616
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098122
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -42,7 +42,9 @@
(:require [metrics.gauges :refer [defgauge
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098115
--- Diff: conf/defaults.yaml ---
@@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
pacemaker.childopts: "-Xmx1024m"
pacemaker.auth.met
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098093
--- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj ---
@@ -335,8 +334,8 @@
mock-storm-id
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098096
--- Diff: storm-core/test/clj/org/apache/storm/supervisor_test.clj ---
@@ -362,8 +361,8 @@
mock-storm-id
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098065
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098057
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52098040
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystem.java ---
@@ -0,0 +1,78 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52097950
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java ---
@@ -0,0 +1,226 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52097932
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52084693
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupOperation.java ---
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083814
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52083786
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52082924
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52082237
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/Constants.java ---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52079760
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -301,7 +303,9 @@
(try
(rmpath (ConfigUtils
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52076438
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52075177
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52073012
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52072956
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52072773
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52072010
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -344,6 +348,12 @@
:sync-retry (atom 0)
:download-lock (Object
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52068474
--- Diff: conf/cgconfig.conf.example ---
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1054#issuecomment-180410973
@redsanket thanks for the review. I have addressed all your concerns
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-180040777
@redsanket Thanks for your review. I addressed all your comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51917653
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51917264
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51917226
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51917161
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51916863
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51916794
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51916552
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java ---
@@ -0,0 +1,225 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51916430
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,118 @@
+/**
--- End diff --
will fix
---
If your project is
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1068#issuecomment-178964694
@erikdw the jira i filed contained more detailed information
https://issues.apache.org/jira/browse/STORM-1519
---
If your project is set up for it, you can
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1068#issuecomment-178963442
If a user has a log parser that adheres to RFC5426, then how log4j2 is
configured to write to syslog is a problem.
---
If your project is set up for it, you can
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1068#issuecomment-178962569
Well this only changes that config for the syslog appender. The syslog
appender writes data to a network socket. This doesn't change the other
appenders that
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1068
[STORM-1519] - Storm syslog logging not confirming to RFC5426 3.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1519
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-178072782
@revans2 @bastiliu @vesense Thanks for the reviews! I really appreciated
it! I think I have addressed all of your comments. Does anyone have any other
concerns
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51381992
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51379125
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51298506
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51290894
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1088,8 +1104,26 @@
(str "
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51289205
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51288151
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1382,5 +1385,60 @@ public static TopologyInfo getTopologyInfo(String
name, String
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51288016
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51287904
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51287016
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51286930
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,133 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51286785
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51286731
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java ---
@@ -0,0 +1,225 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51286585
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51285551
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51284349
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-176444835
@revans2 thank you for the review. I added the apache headers to files
that were missing them and addressed all of your comments
---
If your project is set up for
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51189689
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51189494
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommonOperation.java
---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51184093
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51182829
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,94 @@
+package org.apache.storm;
--- End diff --
added
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51182783
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51182779
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2359,4 +2417,24 @@ public void setTopologyStrategy(Class clazz
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51178357
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51178274
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51177060
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51175096
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51168995
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCenter.java ---
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51168299
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2359,4 +2417,24 @@ public void setTopologyStrategy(Class clazz
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51168186
--- Diff: conf/defaults.yaml ---
@@ -281,3 +281,16 @@ pacemaker.thread.timeout: 10
pacemaker.childopts: "-Xmx1024m"
pacemaker.auth.met
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51156711
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,94 @@
+package org.apache.storm;
--- End diff --
will add
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51156699
--- Diff: storm-core/test/jvm/org/apache/storm/TestCGroup.java ---
@@ -0,0 +1,94 @@
+package org.apache.storm;
+
+import org.junit.Assert
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51154779
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1054#issuecomment-176292755
@HeartSaVioR @unsleepy22 @revans2 thanks for the review! I think I have
address all of your comments
---
If your project is set up for it, you can reply to this
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51154587
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51154424
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51139715
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51139298
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51139196
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1054#discussion_r51139132
--- Diff: documentation/cgroups_in_storm.md ---
@@ -0,0 +1,61 @@
+# CGroups in Storm
+
+CGroups are used by Storm to limit the resource usage of
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r51138787
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -541,6 +541,7 @@
(.redirectErrorStream builder true)
(doseq [[k v
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1054
Documentation for cgroup support in Storm
Related to PR:
https://github.com/apache/storm/pull/1053
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1053
[STORM-1336] - Evalute/Port JStorm cgroup support and implement cgroup
support for RAS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jerrypeng closed the pull request at:
https://github.com/apache/storm/pull/1033
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-173961349
@HeartSaVioR thanks! everything looks correct. I will close #1033
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-173821645
thanks @HeartSaVioR! I just put up a PR for the backport
https://github.com/apache/storm/pull/1033
---
If your project is set up for it, you can reply to
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1033
Backport [STORM-1450] to Storm-1.x branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-1450
Alternatively you can
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-173458467
Ya sure I can back port to the 1.x branch as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-172988575
Will add to CHANGELOG
On Tue, Jan 19, 2016 at 3:11 PM, P. Taylor Goetz
wrote:
> @jerrypeng <https://github.com/jerrypeng> Can you add th
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-172022813
@d2r thank you for your review! I think I have address all of your
comments. Do you have anymore concerns?
---
If your project is set up for it, you can reply to
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/1016#issuecomment-172022837
@d2r thank you for your review! I think I have address all of your
comments. Do you have anymore concerns?
---
If your project is set up for it, you can reply to
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49873652
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/SchedulerAssignment.java ---
@@ -55,4 +56,6 @@
public Set getExecutors
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49821516
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -121,7 +116,7 @@ public
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1016#discussion_r49821113
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/resource/RAS_Node.java ---
@@ -247,19 +253,23 @@ private void freeMemory(double amount
201 - 300 of 655 matches
Mail list logo
