Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/459
+1
---
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/459
@krichter722 I would either rename that Jira and update the description a
bit, or open a new one. Once you've done that, add the jira number into the PR
title - look at other Storm PRs for exa
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/459#discussion_r175268334
--- Diff: external/storm-kafka/pom.xml ---
@@ -57,7 +57,7 @@
maven-checkstyle-plugin
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/459
@krichter722 Yes, these maps are vestiges of the old clojure code. It would
probably be preferable to do as you suggest, but I'm not sure how much work
there is to do there. IIRC, the config ob
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/459
Yes, I'll retracting my -1. Sorry for letting this one languish.
---
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2347
integration test failure looks unrelated.
---
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/2041
---
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1817
---
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141420947
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/ListHDFS.java
---
@@ -0,0 +1,52 @@
+package
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2347
STORM-2760: Add Blobstore Migration Scripts
Add code and helper scripts for migrating active Storm clusters from a
locally-backed BlobStore to an HDFS-backed BlobStore.
You can merge this pull
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2338#discussion_r140345783
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
@@ -423,32 +424,35 @@ public void supervisorHeartbeat(String
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2330
I just added a try {...} finally {...} block. Not sure why the diff is so
ugly.
---
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2330
STORM-2742: Logviewer leaking file descriptors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2742
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2289
+1
---
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135317773
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/InputStream.java
---
@@ -0,0 +1,263 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2289
Partial review done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135084038
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -0,0 +1,468 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135073224
--- Diff: examples/storm-loadgen/README.md ---
@@ -0,0 +1,195 @@
+# Storm Load Generation Tools
+
+A set of tools to place an artificial load on
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135074782
--- Diff: examples/storm-loadgen/README.md ---
@@ -0,0 +1,195 @@
+# Storm Load Generation Tools
+
+A set of tools to place an artificial load on
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135078488
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java
---
@@ -0,0 +1,468 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135074180
--- Diff: examples/storm-loadgen/README.md ---
@@ -0,0 +1,195 @@
+# Storm Load Generation Tools
+
+A set of tools to place an artificial load on
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135085622
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/EstimateThroughput.java
---
@@ -0,0 +1,108 @@
+/**
+ * Licensed to the
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2289#discussion_r135086409
--- Diff:
examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/InputStream.java
---
@@ -0,0 +1,263 @@
+/**
+ * Licensed to the Apache
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2202
@HeartSaVioR Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2202
@HeartSaVioR @kishorvpatil Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2230
I would prefer *one* message if nothing is found. When there are hundreds
of workers, this would make users scroll through many "Result not found"
messages before getting to results
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2220
@vesense Done. I think I've cleared the checkstyle warnings on all the
lines I changed. Let me know if I've missed something.
---
If your project is set up for it, you can reply to this
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2220
@vesense Agreed. How do I run the linter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2220
STORM-2638: Add in maximum object size for Pacemaker Thrift objects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2202
STORM-2623: Add in a whitelist for scheduler strategies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2623
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2187
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2187#discussion_r125767551
--- Diff: storm-core/src/clj/org/apache/storm/daemon/logviewer.clj ---
@@ -502,6 +503,20 @@
(-> (resp/response "Page n
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/2187#discussion_r125766911
--- Diff: storm-core/src/clj/org/apache/storm/daemon/logviewer.clj ---
@@ -502,6 +503,20 @@
(-> (resp/response "Page n
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2180
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2183
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2050
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2051
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2049
+1 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2129
Thanks a lot for this. It looks really good in general.
One thing I noticed that could use some improvement is the bolt-info
dropdown.
The info can run off the window with no option to
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2130
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2078
This looks good to me, but I'm pretty sure we've frozen features on
1.0.x-branch. It would be better to put it on 1.x-branch, and needs to go into
master for 2.x as well.
---
If your
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2096
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2095
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2060
Missed the previous request. This all looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2041
STORM-2452: Storm Metric classes are not thread safe
Synchronizing metrics methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2013
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1973
STORM-2385: pacemaker_state_factory.clj does not compile on branch-1.0.x
Code cherry-picked onto this branch in PR #1953 broke this.
1.0.x-branch does not have Pacemaker-HA.
You can
GitHub user knusbaum reopened a pull request:
https://github.com/apache/storm/pull/1954
STORM-2372: Pacemaker client doesn't clean up heartbeats properly. (2.x)
See #1952
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knu
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1954
Testing done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1954
Need to test this one 1.* branches are tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1954
STORM-2372: Pacemaker client doesn't clean up heartbeats properly. (2.x)
See #1952
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knu
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1953
STORM-2372: Pacemaker client doesn't clean up heartbeats properly. (1.0.x)
See #1952
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knu
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1952
STORM-2372: Pacemaker client doesn't clean up heartbeats properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-st
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1817
I'll have a version up for 2.x as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1817
STORM-2237:Nimbus reports bad supervisor heartbeat - unknown version or
thrift exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1812
Updating Trident RAS Documentation.
Adding documentation for defaults, clarifying other parts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1804
STORM-: Repeated NPEs thrown in nimbus if rebalance fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm 1.0.x
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1803
STORM-: Repeated NPEs thrown in nimbus if rebalance fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm 1.x
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1766
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1769
STORM-2195: Clean up some of worker-launcher code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm worker-launcher
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1759
@HeartSaVioR Are you using harshach's script to merge these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1753
Closing for #1696 per request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/1752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1752
Fine by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1735
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1758
STORM-2185: Storm Supervisor doesn't delete directories properly sometimes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incu
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1759
STORM-2185: Storm Supervisor doesn't delete directories properly sometimes
- 1.x branch
You can merge this pull request into a Git repository by running:
$ git pull https://githu
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1753
STORM-2180: KafkaSpout ack() should handle re-balance - 1.x branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1752
STORM-2180: KafkaSpout ack() should handle re-balance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2180
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1603
Builds fine locally.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1728
(Nice catch, BTW)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1728
+1
Looks like mistranslation. This restores the behavior of the old Clojure
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1735
/usr/lib64 is FHS standard. /usr/lib/x86_64-linux-gnu is Debian-specific. I
think we should avoid setting distro-specific defaults.
---
If your project is set up for it, you can reply to this
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1720
Also updated the docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1720
@HeartSaVioR I've synced the java files between the branches so there are
almost no differences.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1724#discussion_r82672822
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -414,33 +414,30 @@ static int copy_file(int input, const char*
in_filename
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1724#discussion_r82672834
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -414,33 +414,30 @@ static int copy_file(int input, const char*
in_filename
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1724#discussion_r82634841
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/SupervisorUtils.java ---
@@ -104,6 +104,16 @@ public static void setupStormCodeDir(Map conf
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1724#discussion_r82634237
--- Diff: storm-core/src/native/worker-launcher/impl/worker-launcher.c ---
@@ -485,14 +482,14 @@ int setup_stormdist_dir(const char* local_dir
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1724
@kishorvpatil @revans2 @jerrypeng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1724
STORM-2131: Add blob command to worker-launcher, make stormdist directory
not writeable by topo owner
Re-opening this, as I reverted the last one to fix a typo (#1723)
You can merge this pull
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1468
-1
I am generally opposed to this. Most PRs only have a small number of
commits and aren't a problem. For PRs with a large number of commits, it's
simple enough to ask the contributor
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1396
I'm going to close this. We're not going to drop 1.x support and there's
another PR up adding support for 2.x without dropping 1.x.
---
If your project is set up for it, you ca
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1337
#1676 is a no-go. We need guava in storm-core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1154
This has been fixed elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1290
This was cherry picked. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1538
I'm going to close this PR. It hasn't been touched in a few months, it is
still missing a Jira, and we have decided to halt any non-bug work on 10.*
branches.
In addition, it l
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1316
If you want to clean up the log messages, this still looks good. We'd want
this instead to go into master and 1.x, though.
---
If your project is set up for it, you can reply to this emai
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1242
This hasn't been updated for ~7 months, and I'm -1 on the concept anyhow,
so I'm going to close it.
If you'd like to discuss, feel free to reopen.
---
If your proj
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1067
@torbiak Would you like to do work on this, or should it be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1018
+1 I'm fine with this change. If you want to upmerge, I'll get it in.
Otherwise I plan to close this in a few weeks or so.
---
If your project is set up for it, you can reply to this
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/647
Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1710
Documentation updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1723
STORM-2131: Add blob command to worker-launcher, make stormdist directory
not writeable by topo owner
You can merge this pull request into a Git repository by running:
$ git pull https
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1710
@d2r @revans2 Any additional comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1720
STORM-1546: Adding Read and Write Aggregations for Pacemaker to make it HA
compatible (1.x-branch)
1.x-branch version of Pacemaker-HA
You can merge this pull request into a Git repository by
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1710#discussion_r81219539
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -926,10 +926,10 @@
public static final String UI_HTTPS_NEED_CLIENT_AUTH
1 - 100 of 663 matches
Mail list logo
