[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

2018-02-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2538 @srdo Thanks for the great work. I'd rather not review the two PRs since @hmcl already gave a nice review. If you would like to merge twos by yourself, please replace storm-kafka-client 1.1.

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

2018-02-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2538 +1. Once squashed is good to merge as far as I am concerned. Thanks a lot @srdo. ---

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

2018-02-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2538 @hmcl Rebased. ---

[GitHub] storm issue #2538: STORM-2913: Add metadata to at-most-once and at-least-onc...

2018-01-30 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2538 @srdo there is a discrepancy between the title of this pull request and the title of the associated JIRA. What problem are you trying to solve in this patch? Add meatada, or remove warnings? If