Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2763
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r206266534
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,67 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205907405
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -89,13 +89,8 @@ public void prepare(Map conf) {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205907197
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,67 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205906955
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205515487
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,67 @@
@SuppressWarnings("unchecked")
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205516198
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -89,13 +89,8 @@ public void prepare(Map conf) {
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r205500685
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r204137988
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203863810
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203772574
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203770940
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203769516
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203769152
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203764174
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203763172
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203762570
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203761959
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203755133
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203754454
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723843
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203720155
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203717231
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203723640
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203716797
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2809,21 +2809,19 @@ public void launchServer() throws Exception {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2763#discussion_r203724683
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -27,52 +28,63 @@
@SuppressWarnings("unchecked")
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2763
STORM-3150: Improve Gauge registration methods and refactored code
STORM-3150
You can merge this pull request into a Git repository by running:
$ git pull
27 matches
Mail list logo
