Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Yes, that would be great. It should be fairly easy since the reporter part of the code hasn’t changed. -Taylor > On May 7, 2018, at 5:40 PM, Artem Ervits wrote: > > actually, hit sent too fast, the PR is addressing fix for 1.2.2, I know > this thread is for 1.2 but do

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

actually, hit sent too fast, the PR is addressing fix for 1.2.2, I know this thread is for 1.2 but do you want a patch for 2.x branch as well? On Mon, May 7, 2018 at 5:39 PM, Artem Ervits wrote: > Taylor, patch is up https://github.com/apache/storm/pull/2665, please >

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Taylor, patch is up https://github.com/apache/storm/pull/2665, please include the PR in the 1.2.2. On Mon, May 7, 2018 at 4:41 PM, P. Taylor Goetz wrote: > The build for 1.2.2-rc3 finished just as this arrived in my inbox. ;) > > I’m happy to include a fix and rebuild the rc.

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

The build for 1.2.2-rc3 finished just as this arrived in my inbox. ;) I’m happy to include a fix and rebuild the rc. But I won’t have time to put together a pull request today. It’s an easy fix that can be copied from one of the other reporters. I’ll hold off on starting the rc3 until we come

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Is it possible to include https://issues.apache.org/jira/browse/STORM-2988 in 1.2.2 release? Seems like a legit bug and a quick fix. On 5/7/18, 8:45 AM, "P. Taylor Goetz" wrote: Canceling in order to include STORM-3059 in this release. -Taylor > On

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Canceling in order to include STORM-3059 in this release. -Taylor > On May 3, 2018, at 11:42 AM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.2.2 (rc2) > > Full list of changes in this release: > >

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

-1 I think we ought to include STORM-3059, since it's a regression compared to 1.2.1, and it prevents the spout from working at all in certain configurations. 2018-05-06 15:54 GMT+02:00 Alexandre Vermeerbergen : > Hello Stig, > > Yes you are right: "mvn clean install

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Hello Stig, Yes you are right: "mvn clean install -DskipTests" solved the build issue. Yes another excellent news : I have rebuilt my topologies with the modified storm-kafka-client.jar from your pull request (which shows 1.2.3-SNAPSHOP as its version), the topologie which had its spout crashing

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

I just realized that there's no md5/sha file for src tar.gz and zip, so please disregard the verification on source tar.gz and source zip. Please note that signature check still succeeds. It might be better if we can get missed md5/sha files and verify files exhaustively. 2018년 5월 6일 (일) 오후

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

+1 (binding) > source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 7 -- source, tar.gz : OK - build source dist --

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Alexandre, Could you try running just mvn clean install -DskipTests I think for some reason one of the dependencies isn't being built as it should by Maven. 2018-05-06 12:59 GMT+02:00 Alexandre Vermeerbergen : > Hello Stig, > > Thanks, I followed your instructions,

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Hello Stig, Thanks, I followed your instructions, but got a build failure: [INFO] --- maven-dependency-plugin:2.8:unpack (unpack) @ storm-core --- [INFO] Configured Artifact: org.apache.storm:multilang-ruby:1.2.3-SNAPSHOT:jar Downloading:

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Start by cloning the Storm repository: git clone https://github.com/apache/storm.git cd into the directory containing the Storm code, then fetch the branch corresponding to the PR git fetch origin pull/2663/head:STORM-3059-1.x In this case 2663 is the PR number of the PR you want to fetch

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Hello Stig, Yes I can try your fix very quickly if you have a binary artifact (storm-kafka-client.jar, I guess) which I could download. Or "copy paste" instructions that I could use to build it (I'm sorry : I tend to be slow at understanding how to retrieve specific pull requests to build

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

I put up what I believe should be a fix at https://github.com/apache/storm/pull/2663, would you be willing to try it out? Regarding killing the entire worker, you are right that it can be overkill in some cases, but there's a tradeoff you have to make. Heron runs each component (spout/bolt) in

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Hello Stig, Thank you very much for your very fast answer and for opening https://issues.apache.org/jira/browse/STORM-3059. Regarding my generic concern that Kafka Spout exceptions shouldn't kill it's worker process, I am still concerned by the scope of the "kill/recovery". Indeed, a worker

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

The exception is caused by the fix in STORM-2994, the new code should only run in AT_LEAST_ONCE mode, not in the others. Have raised https://issues.apache.org/jira/browse/STORM-3059 to fix it. I disagree that the spout should catch and swallow unknown/unexpected exceptions. Storm is designed to

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

Hello All, [ ] -1 Do not release this package because storm-kafka-client spout glitches can crash workers, leading to degraded performances. I have downloaded the binary artifacts of this storm 1.2.0rc2, copied the binaries of storm-kafka-client, flux and flux-wrapper from the Nessus staging

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

+1 I built it from the tag (e001672cf0ea59fe6989b563fb6bbb450fe8e7e5) since the tag did move recently. I ran all the unit tests, I started a single node cluster and ran some manual tests. Thanks, Bobby On Thu, May 3, 2018 at 12:18 PM P. Taylor Goetz wrote: > CORRECTION:

Re: [VOTE] Release Apache Storm 1.2.2 (rc2)

CORRECTION: The Nexus staging repository for this rc is: https://repository.apache.org/content/repositories/orgapachestorm-1064 > On May 3, 2018, at 11:42 AM, P. Taylor Goetz wrote: > > This is a call