Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/1993
Then this PR can be safely closed and discarded. Thanks for your input.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sakanaou closed the pull request at:
https://github.com/apache/storm/pull/1993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106342738
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -128,6 +128,15 @@
public abstract void deleteBlob(String key,
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106334482
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -128,6 +128,15 @@
public abstract void deleteBlob(String key, Subject
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1933
@satishd please find it here: https://github.com/apache/storm/pull/2010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2010
@satishd this is the 1.x-branch equivalent to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2010
STORM-2240: STORM PMML Bolt - Add Support to Load Models from Blob Store
- Created factory to create ModelRunner and ModelOutputs from Blobstore
- Updated example topology to support loading
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106342906
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -231,6 +231,18 @@ public void deleteBlob(String key, Subject who)
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106343405
--- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -128,6 +128,15 @@
public abstract void deleteBlob(String key, Subject
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2009
STORM-2407: KafkaTridentSpoutOpaque Doesn't Poll Data From All Topic-â¦
â¦Partitions When Parallelism Hint Not a Multiple Total Topic-Partitions
- Introduce logic to poll data from the
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2009
@harshach can you please review. This is the master branch equivalent to
https://github.com/apache/storm/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106340804
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -231,6 +231,18 @@ public void deleteBlob(String key, Subject who)
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106299675
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo so what will we decide to do as far as null? send or not send by
default ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1999
@hmcl Either one is fine by me. Keeping it consistent with the old spout is
probably the best solution. The only case where defaulting to emitting nulls
makes sense is if the user supplies a
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo Log compaction is only used very specific case like consumer_offsets
or streams topics. It only useful if you want to keep the latest data. So we
are not addressing those here.
@hmcl
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1993
@sakanaou The `RecordTranslator.apply` function isn't currently getting the
`KafkaSpoutMessageId/numRetries`, so I'm not sure you can implement the
redirect with the code as it is now. We might still
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106299441
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2008
STORM-2409: Storm-Kafka-Client KafkaSpout Support for Failed and NullTuples
- Created config property to make emit null tuples configurable
- Ack directly null tuples that are not emitted
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1999
@hmcl Googled it, it appears that null messages can be sent to delete
messages in Kafka (see
https://kafka.apache.org/documentation/#design_compactionbasics). It makes
sense to drop messages quietly
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106291741
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo we can make de default emit null. That's a trivial change. As I said,
I decided not to emit null because that is the default behavior in the old
spout, and users are either happy, or used to it.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo its better to have this on kafka spout itself, for one it reduces
unnecessary hope or another bolt that user need to add to filter out
unnecessary tuples.
---
If your project is set up for
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2007
Logger output Pattern for Integration-Tests/cluster.xml Matching
log42/cluster.xml
You can merge this pull request into a Git repository by running:
$ git pull
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2007
Please backport to 1.x-branch as well. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1999
@harshach Okay. I don't think filtering null tuples should be the default
though. We might be hiding errors in user code. I'd like them to have to
actively enable null filtering.
---
If your project
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106263320
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106280062
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1999
@srdo the changes proposed in this PR handle null tuples in identical
fashion that what is done in the old Kafka Spout as can be seen in the
following links.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1999#discussion_r106283741
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -383,23 +403,24 @@ private void
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2006
STORM-2412: Nimbus isLeader check while waiting for max replication
While using local FS blob store, nimbus goes into a state where it
indefinitely waits for max replication (with max
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2006
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2006
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
36 matches
Mail list logo
