[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1257#issuecomment-201153034 @jerrypeng @revans2 can you look at it again? Thank you very much! --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211460#comment-15211460 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj commented on the pull request:

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1257#issuecomment-201152514 Sorry I deleted the old branch about "supervisor" without attention, So I reopen the PR about supervisor. The PR is the same as before. If want look at thee old

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211459#comment-15211459 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj commented on the pull request:

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211456#comment-15211456 ] ASF GitHub Bot commented on STORM-1279: --- GitHub user hustfxj opened a pull request:

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-24 Thread hustfxj
GitHub user hustfxj opened a pull request: https://github.com/apache/storm/pull/1257 [STORM-1279] port backtype.storm.daemon.supervisor to java 1 port supervisor.clj to java; 2 Update all the callings to supervisor; 3 Supervisor's class hierarchy as follows:

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211452#comment-15211452 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj closed the pull request at:

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-24 Thread hustfxj
Github user hustfxj closed the pull request at: https://github.com/apache/storm/pull/1184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1235) port backtype.storm.security.auth.ReqContext-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211438#comment-15211438 ] ASF GitHub Bot commented on STORM-1235: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: Tests - STORM-1235, STORM-1236, STORM-1237, ST...

2016-03-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1200#issuecomment-201142861 @harshach - can you take a look at this PR? It's been pending for a while. Your comments have already been addressed. --- If your project is set up for it,

[jira] [Commented] (STORM-1581) Repair github links in the storm documentation

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211437#comment-15211437 ] ASF GitHub Bot commented on STORM-1581: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1581: Repair github links in storm docum...

2016-03-24 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1157#issuecomment-201142068 @harshach will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-676) Storm Trident support for sliding/tumbling windows

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211434#comment-15211434 ] ASF GitHub Bot commented on STORM-676: -- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-676 Trident implementation for sliding a...

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1072#issuecomment-201139676 @arunmahadevan looks like all comments are addressed. Can you please take a look. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-1544) Document Debug/Sampling of Topologies

2016-03-24 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211431#comment-15211431 ] Sriharsha Chintalapani commented on STORM-1544: --- [~arunmahadevan] any update on this doc. >

[jira] [Commented] (STORM-1581) Repair github links in the storm documentation

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211432#comment-15211432 ] ASF GitHub Bot commented on STORM-1581: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1581: Repair github links in storm docum...

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1157#issuecomment-201139468 @abhishekagarwal87 can you upmerge this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1271) port backtype.storm.daemon.task to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211430#comment-15211430 ] ASF GitHub Bot commented on STORM-1271: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211418#comment-15211418 ] ASF GitHub Bot commented on STORM-1654: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1654 HBaseBolt creates tick tuples with ...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1638) Integration tests are failing on Windows

2016-03-24 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211409#comment-15211409 ] Sriharsha Chintalapani commented on STORM-1638: --- We can do this in minor release. Moving it

[jira] [Resolved] (STORM-1537) Upgrade to Kryo 3

2016-03-24 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani resolved STORM-1537. --- Resolution: Fixed > Upgrade to Kryo 3 > - > >

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211408#comment-15211408 ] ASF GitHub Bot commented on STORM-1537: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1537: Upgrade to kryo3 in master

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211406#comment-15211406 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201133053 @roshannaik I updated the JIRA and removed the fixVersion, Epic for 1.0 release. Lets keep the PR open and see if there is a better option to keep the defaults and not

[jira] [Updated] (STORM-1632) Disable event logging by default

2016-03-24 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-1632: -- Fix Version/s: (was: 1.0.0) > Disable event logging by default >

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211366#comment-15211366 ] ASF GitHub Bot commented on STORM-1632: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201122231 Just to update, here's my numbers. ``` > -c topology.eventlogger.executors=0 -c topology.max.spout.pending=2000 -c topology.disruptor.batch.size=1

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211359#comment-15211359 ] ASF GitHub Bot commented on STORM-1632: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201120771 @hararha Keep in mind that anyone packaging Apache Storm is free to make changes. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211348#comment-15211348 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201119172 Just to break the stalemate here, I am doing +1 on going on with 1.0 release without this patch. Given that patch is open for 9 days we should be better about

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211336#comment-15211336 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201117315 @ptgoetz whats the timeline 1.0 release lets put up a date I am willing to push a patch for this tonight on the UI side. If thats what blocking the release. --- If

[jira] [Commented] (STORM-1271) port backtype.storm.daemon.task to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211334#comment-15211334 ] ASF GitHub Bot commented on STORM-1271: --- Github user hustfxj commented on a diff in the pull

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211333#comment-15211333 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201116132 @ptgoetz I understand it is not hard to change the config. But the default behavior shouldn't be affecting peformance. Going to 1.0 can hit 9% perf hit just because we

[jira] [Commented] (STORM-1279) port backtype.storm.daemon.supervisor to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211332#comment-15211332 ] ASF GitHub Bot commented on STORM-1279: --- Github user hustfxj commented on a diff in the pull

[GitHub] storm pull request: [STORM-1279] port backtype.storm.daemon.superv...

2016-03-24 Thread hustfxj
Github user hustfxj commented on a diff in the pull request: https://github.com/apache/storm/pull/1184#discussion_r57414646 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/SyncSupervisorEvent.java --- @@ -0,0 +1,632 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: [STORM-1611] port org.apache.storm.pacemaker.p...

2016-03-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1195#issuecomment-201114123 @redsanket @knusbaum @revans2 can you look it again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (STORM-1611) port org.apache.storm.pacemaker.pacemaker to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211330#comment-15211330 ] ASF GitHub Bot commented on STORM-1611: --- Github user hustfxj commented on the pull request:

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211274#comment-15211274 ] ASF GitHub Bot commented on STORM-1632: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201105956 Yes, there is a performance hit. Especially in a single node cluster (don't know if you were running multiple workers), and networking doesn't come into play . I'm

[jira] [Commented] (STORM-1655) Flux doesn't set return code to non-zero when there's any exception while deploying topology to remote cluster

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211257#comment-15211257 ] ASF GitHub Bot commented on STORM-1655: --- Github user ptgoetz commented on the pull request:

[GitHub] storm pull request: STORM-1655 (1.x) Flux doesn't set return code ...

2016-03-24 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/1254#issuecomment-201097134 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1655 (1.x) Flux doesn't set return code ...

2016-03-24 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1254#issuecomment-201091348 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1655) Flux doesn't set return code to non-zero when there's any exception while deploying topology to remote cluster

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211234#comment-15211234 ] ASF GitHub Bot commented on STORM-1655: --- Github user hustfxj commented on the pull request:

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-201081366 @wangli1426 it would be good to have on both. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211174#comment-15211174 ] ASF GitHub Bot commented on STORM-1057: --- Github user harshach commented on the pull request:

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211167#comment-15211167 ] ASF GitHub Bot commented on STORM-1632: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201079820 @HeartSaVioR @arunmahadevan @ptgoetz ran the topology from @roshannaik and these are the numbers I got on a single node cluster with single worker. with

[jira] [Commented] (STORM-1632) Disable event logging by default

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211141#comment-15211141 ] ASF GitHub Bot commented on STORM-1632: --- Github user roshannaik commented on the pull request:

[GitHub] storm pull request: STORM-1632 Disable event logging by default

2016-03-24 Thread roshannaik
Github user roshannaik commented on the pull request: https://github.com/apache/storm/pull/1217#issuecomment-201074919 Rewrote the topology so its easier for you folks to run. Uploaded into the jira and provided instructions here :

[jira] [Commented] (STORM-1654) HBaseBolt creates tick tuples with no interval when we don't set flushIntervalSecs

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211080#comment-15211080 ] ASF GitHub Bot commented on STORM-1654: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1654 HBaseBolt creates tick tuples with ...

2016-03-24 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1251#issuecomment-201059182 @priyank5485 Right. STORM-1626 is symptom of STORM-1654. Sorry I didn't recognize STORM-1654 exists. --- If your project is set up for it, you can reply to this

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211068#comment-15211068 ] ASF GitHub Bot commented on STORM-1300: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-1300] backtype.storm.scheduler.resource...

2016-03-24 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/1232#issuecomment-201057484 Hi @knusbaum , comments addressed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211054#comment-15211054 ] ASF GitHub Bot commented on STORM-1300: --- Github user zhuoliu commented on a diff in the pull

[GitHub] storm pull request: [STORM-1300] backtype.storm.scheduler.resource...

2016-03-24 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/1232#discussion_r57397001 --- Diff: storm-core/test/jvm/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -109,7 +112,7 @@ public static

[jira] [Updated] (STORM-1632) Disable event logging by default

2016-03-24 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roshan Naik updated STORM-1632: --- Attachment: BasicTopology.java uploading topology code to validate perf hit. To use it: .. 1) Copy

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57391018 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[GitHub] storm pull request: add private constructor to KafkaUtils

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: add private constructor to KafkaUtils

2016-03-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1186#issuecomment-201028459 +1. Not really necessary, but fine with me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: Revised wipeZeros() in SlotBasedCounter to avo...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57389473 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[GitHub] storm pull request: Revised wipeZeros() in SlotBasedCounter to avo...

2016-03-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1243#issuecomment-201024926 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210959#comment-15210959 ] ASF GitHub Bot commented on STORM-1300: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: [STORM-1300] backtype.storm.scheduler.resource...

2016-03-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1232#discussion_r57388801 --- Diff: storm-core/test/jvm/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -109,7 +112,7 @@ public static

[GitHub] storm pull request: [STORM-1300] backtype.storm.scheduler.resource...

2016-03-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1232#discussion_r57388639 --- Diff: storm-core/test/jvm/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java --- @@ -285,4 +288,72 @@ public static

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210958#comment-15210958 ] ASF GitHub Bot commented on STORM-1300: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57387622 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57387004 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57386690 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1256#discussion_r57385884 --- Diff: docs/Trident-RAS-API.md --- @@ -0,0 +1,49 @@ +--- +title: Trident RAS API +layout: documentation +documentation: true +---

[jira] [Commented] (STORM-1271) port backtype.storm.daemon.task to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210934#comment-15210934 ] ASF GitHub Bot commented on STORM-1271: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STORM-1271: Port backtype.storm.daemon.task to...

2016-03-24 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1249#discussion_r57385605 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java --- @@ -0,0 +1,247 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] storm pull request: STORM-1271: Port backtype.storm.daemon.task to...

2016-03-24 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1249#discussion_r57385384 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java --- @@ -0,0 +1,247 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1271) port backtype.storm.daemon.task to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210933#comment-15210933 ] ASF GitHub Bot commented on STORM-1271: --- Github user revans2 commented on a diff in the pull

[jira] [Closed] (STORM-1497) Repo Branches Cleanup

2016-03-24 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum closed STORM-1497. --- Resolution: Fixed > Repo Branches Cleanup > -- > > Key:

[jira] [Closed] (STORM-1340) Use Travis-CI build matrix to improve test execution times

2016-03-24 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum closed STORM-1340. --- Resolution: Won't Fix > Use Travis-CI build matrix to improve test execution times >

[GitHub] storm pull request: STORM-1625: Move storm-sql dependencies out of...

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1537: Upgrade to kryo3 in master

2016-03-24 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1255#issuecomment-201002831 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210892#comment-15210892 ] ASF GitHub Bot commented on STORM-1537: --- Github user kishorvpatil commented on the pull request:

[jira] [Commented] (STORM-1271) port backtype.storm.daemon.task to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210889#comment-15210889 ] ASF GitHub Bot commented on STORM-1271: --- Github user knusbaum commented on a diff in the pull

[GitHub] storm pull request: STORM-1271: Port backtype.storm.daemon.task to...

2016-03-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1249#discussion_r57380470 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java --- @@ -0,0 +1,247 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210885#comment-15210885 ] ASF GitHub Bot commented on STORM-1537: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: STORM-1537: Upgrade to kryo3 in master

2016-03-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1255#issuecomment-20091 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: STORM-1655 Flux doesn't set return code to non...

2016-03-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1253#issuecomment-200999693 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1655) Flux doesn't set return code to non-zero when there's any exception while deploying topology to remote cluster

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210884#comment-15210884 ] ASF GitHub Bot commented on STORM-1655: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: STORM-1655 (1.x) Flux doesn't set return code ...

2016-03-24 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1254#issuecomment-200999571 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: Adding documentation for Trident RAS API

2016-03-24 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/1256 Adding documentation for Trident RAS API You can merge this pull request into a Git repository by running: $ git pull https://github.com/knusbaum/incubator-storm master Alternatively you

[jira] [Commented] (STORM-1300) port backtype.storm.scheduler.resource-aware-scheduler-test to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210837#comment-15210837 ] ASF GitHub Bot commented on STORM-1300: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-1300] backtype.storm.scheduler.resource...

2016-03-24 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/1232#issuecomment-200985657 Hi @jerrypeng @d2r @revans2 , would you mind having a look at this one? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Resolved] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1268. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~Cody], I merged this into

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210815#comment-15210815 ] ASF GitHub Bot commented on STORM-1268: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1268) port backtype.storm.daemon.builtin-metrics to java

2016-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210814#comment-15210814 ] ASF GitHub Bot commented on STORM-1268: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1218 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1268] port builtin-metrics to java

2016-03-24 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1218#issuecomment-200982734 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Resolved] (STORM-1648) DRPCSpout should attempt reconnect if on fail it cannot reach client

2016-03-24 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1648. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abellina], I merged this

  1   2   >