[jira] [Commented] (STORM-1760) HiveState should retire idle or old writes with flushAndClose

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270124#comment-15270124 ] ASF GitHub Bot commented on STORM-1760: --- Github user harshach closed the pull request at:

[GitHub] storm pull request: STORM-1760. HiveState should retire idle or ol...

2016-05-03 Thread harshach
Github user harshach closed the pull request at: https://github.com/apache/storm/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [storm-elasticsearch]Upgrade elasticsearch ver...

2016-05-03 Thread sweetest
Github user sweetest commented on the pull request: https://github.com/apache/storm/pull/1396#issuecomment-216742378 I was also doing similar work, code change is almost the same. Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: [storm-elasticsearch]Upgrade elasticsearch ver...

2016-05-03 Thread kojiisd
GitHub user kojiisd opened a pull request: https://github.com/apache/storm/pull/1396 [storm-elasticsearch]Upgrade elasticsearch version from 1.6.0 to 2.3.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/kojiisd/storm 1.x-branch

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong commented on the pull request: https://github.com/apache/storm/pull/1388#issuecomment-216717573 sorry, please check https://github.com/apache/storm/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
Github user lujinhong closed the pull request at: https://github.com/apache/storm/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: storm-1726: use Put#addColumn to replace the d...

2016-05-03 Thread lujinhong
GitHub user lujinhong opened a pull request: https://github.com/apache/storm/pull/1395 storm-1726: use Put#addColumn to replace the deprecated Put#add You can merge this pull request into a Git repository by running: $ git pull https://github.com/lujinhong/storm 1.x-branch

[jira] [Commented] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269974#comment-15269974 ] ASF GitHub Bot commented on STORM-1761: --- Github user hustfxj commented on the pull request:

[GitHub] storm pull request: STORM-1761: Storm-Solr Example Throws ArrayInd...

2016-05-03 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1394#issuecomment-216716374 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [VOTE] Release Apache Storm 0.10.1 (rc2)

2016-05-03 Thread P. Taylor Goetz
Harsha is correct. The 0.10.x branch is in maintenance mode. So we shouldn't be adding to or modifying APIs. -Taylor > On May 3, 2016, at 8:55 PM, Harsha wrote: > > Roshan, >This is 0.10 maint release . We are not going to include the >new features

Re: [VOTE] Release Apache Storm 0.10.1 (rc2)

2016-05-03 Thread Harsha
Roshan, This is 0.10 maint release . We are not going to include the new features that went into 1.0. +1 (binding) Deployed on a 3-node cluster Ran example topologies verified signatures of binaries. Thanks, Harsha On Tue, May 3, 2016, at 05:16 PM, Roshan Naik wrote: >

[jira] [Updated] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1761: Assignee: Hugo Louro (was: Jungtaek Lim) > Storm-Solr Example Throws

[jira] [Reopened] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reopened STORM-1761: - We marked as 'Resolved' when all related pull requests are merged to respective branches. Since

[jira] [Commented] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269948#comment-15269948 ] ASF GitHub Bot commented on STORM-1761: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1761: Storm-Solr Example Throws ArrayInd...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1394#issuecomment-216712023 +1 Nice finding. Btw, I guess it's due to inconsistencies between sample / test topologies, one argument for only specifying topology name, or two arguments

[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269904#comment-15269904 ] P. Taylor Goetz commented on STORM-1757: My initial thoughts: I asked on the beam ml early on

Re: [VOTE] Release Apache Storm 0.10.1 (rc2)

2016-05-03 Thread Roshan Naik
This is missing HdfsSpout (STORM-1199) -roshan On 5/3/16, 3:39 PM, "Hugo Da Cruz Louro" wrote: >+1 (non binding) >- Found a very minor bug in the storm-solr test topology, for which there >is a very simple workaround and by NO means a blocker for the release. >-

[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269888#comment-15269888 ] Boyang Jerry Peng commented on STORM-1757: -- I think this would be a worth while project. The

Re: [jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Roshan Naik
Never mind my prev comment… got confused by looking at BEAM-216. -roshan On 5/3/16, 4:55 PM, "Roshan Naik" wrote: >Shouldn¹t we have a BEAM runner in Storm project instead of Storm runner >in Beam project ? >-roshan > >On 5/3/16, 1:15 PM, "Hugo Louro (JIRA)"

Re: [jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Roshan Naik
Shouldn¹t we have a BEAM runner in Storm project instead of Storm runner in Beam project ? -roshan On 5/3/16, 1:15 PM, "Hugo Louro (JIRA)" wrote: > >[ >https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.p

[jira] [Resolved] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hugo Louro resolved STORM-1761. --- Resolution: Fixed > Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster >

[jira] [Commented] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269847#comment-15269847 ] ASF GitHub Bot commented on STORM-1761: --- GitHub user hmcl opened a pull request:

[GitHub] storm pull request: STORM-1761: Storm-Solr Example Throws ArrayInd...

2016-05-03 Thread hmcl
GitHub user hmcl opened a pull request: https://github.com/apache/storm/pull/1394 STORM-1761: Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode Please cherry-pick this patch into 0.10.x-branch and 1.x-branch as well. You can merge this pull request

[jira] [Created] (STORM-1761) Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode

2016-05-03 Thread Hugo Louro (JIRA)
Hugo Louro created STORM-1761: - Summary: Storm-Solr Example Throws ArrayIndexOutOfBoundsException in Remote Cluster Mode Key: STORM-1761 URL: https://issues.apache.org/jira/browse/STORM-1761 Project:

Re: [VOTE] Release Apache Storm 0.10.1 (rc2)

2016-05-03 Thread Hugo Da Cruz Louro
+1 (non binding) - Found a very minor bug in the storm-solr test topology, for which there is a very simple workaround and by NO means a blocker for the release. - unzipped .zip sources and binaries - mvn clean install in unzipped sources - created uber jar for storm-solr - tested storm-solr in

Re: [VOTE] Release Apache Storm 1.0.1 (rc3)

2016-05-03 Thread Hugo Da Cruz Louro
+1 (non binding) - Found a very minor bug in the storm-solr test topology, for which there is a very simple workaround and by NO means a blocker for the release. - unzipped .zip sources and binaries - mvn clean install in unzipped sources - created uber jar for storm-solr and storm-kafka-client -

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269614#comment-15269614 ] ASF GitHub Bot commented on STORM-1674: --- GitHub user moesol opened a pull request:

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread moesol
GitHub user moesol opened a pull request: https://github.com/apache/storm/pull/1393 (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed * Allows minBytes in fetch request to be configured from KafkaConfig.fetchMinBytes. * Defaults new configuration

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269608#comment-15269608 ] ASF GitHub Bot commented on STORM-1674: --- Github user moesol commented on the pull request:

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread moesol
Github user moesol commented on the pull request: https://github.com/apache/storm/pull/1391#issuecomment-21896 Without the MaxWait being set to 100, it is set to 1, which means that the bolt will waiting for 10 seconds when no messages are available. On the 1.x branch, I was

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269582#comment-15269582 ] ASF GitHub Bot commented on STORM-1674: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1391#issuecomment-216663883 @moesol there is patch that merged into 1.0 release https://github.com/apache/storm/pull/1309/files . Does that changes work for you. Any reason for the MaxWait to be

[jira] [Commented] (STORM-1760) HiveState should retire idle or old writes with flushAndClose

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269572#comment-15269572 ] ASF GitHub Bot commented on STORM-1760: --- GitHub user harshach opened a pull request:

[GitHub] storm pull request: STORM-1760. HiveState should retire idle or ol...

2016-05-03 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/1392 STORM-1760. HiveState should retire idle or old writes with flushAndClose You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269570#comment-15269570 ] ASF GitHub Bot commented on STORM-1674: --- GitHub user moesol opened a pull request:

[GitHub] storm pull request: (STORM-1674) Idle KafkaSpout consumes more ban...

2016-05-03 Thread moesol
GitHub user moesol opened a pull request: https://github.com/apache/storm/pull/1391 (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed * Allows minBytes in fetch request to be configured from KafkaConfig.fetchMinBytes. * Defaults new configuration

[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-03 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269498#comment-15269498 ] Hugo Louro commented on STORM-1757: --- I also would like to work on this project. > Apache Beam Runner

[jira] [Commented] (STORM-1674) Idle KafkaSpout consumes more bandwidth than needed

2016-05-03 Thread Robert Hastings (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269303#comment-15269303 ] Robert Hastings commented on STORM-1674: Sure, in progress. > Idle KafkaSpout consumes more

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269032#comment-15269032 ] ASF GitHub Bot commented on STORM-1736: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216590606 @abhishekagarwal87 commented on your PR https://github.com/apache/storm/pull/1386 . --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: STORM-1755: Revert the kafka client version to...

2016-05-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1386#issuecomment-216590463 @abhishekagarwal87 what exactly are we trying to do here. Are we talking about the producer api not being comptabile with 0.8.x? . There was a suggested approach in

[jira] [Commented] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269030#comment-15269030 ] ASF GitHub Bot commented on STORM-1755: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216587066 @harshach - with this change, test compilation will fail once the #1386 is merged. Since this is the internal class used only in test, do we really need to

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269005#comment-15269005 ] ASF GitHub Bot commented on STORM-1736: --- Github user abhishekagarwal87 commented on the pull

[jira] [Created] (STORM-1760) HiveState should retire idle or old writes with flushAndClose

2016-05-03 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created STORM-1760: - Summary: HiveState should retire idle or old writes with flushAndClose Key: STORM-1760 URL: https://issues.apache.org/jira/browse/STORM-1760

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268960#comment-15268960 ] ASF GitHub Bot commented on STORM-1736: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216579561 @HeartSaVioR @abhishekagarwal87 this issues happens with Kafka 0.10 branch. Yes it does break test compatability with 0.8.x . Keep in mind that KafkaConfig is an

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216576871 Yeah, I guess Kafka doesn't strictly respect semantic versioning, or their major version seems to 2nd number of the version at least before reaching 1.0.0. --- If

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268946#comment-15268946 ] ASF GitHub Bot commented on STORM-1646: --- Github user HeartSaVioR commented on the pull request:

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268930#comment-15268930 ] ASF GitHub Bot commented on STORM-1646: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216573099 I might have been a bit quick on the trigger there. The Kafka coding guidelines target backward compatibility for one release only. So storm-kafka might not support

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216564619 storm-kafka will probably support 0.10.0, I believe the Kafka developers version their APIs so new clusters can talk to old clients. That shouldn't affect the choice of

[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1324#discussion_r61901102 --- Diff: storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java --- @@ -47,17 +68,71 @@ public void prepare(Map stormConf, TopologyContext

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268887#comment-15268887 ] ASF GitHub Bot commented on STORM-1646: --- Github user ppoulosk commented on the pull request:

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread ppoulosk
Github user ppoulosk commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216565610 Thanks for the explanation. Will revert that change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268881#comment-15268881 ] ASF GitHub Bot commented on STORM-1646: --- Github user srdo commented on the pull request:

[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268883#comment-15268883 ] ASF GitHub Bot commented on STORM-1700: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-03 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1324#discussion_r61899624 --- Diff: storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java --- @@ -47,17 +68,71 @@ public void prepare(Map stormConf, TopologyContext

[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268864#comment-15268864 ] ASF GitHub Bot commented on STORM-1700: --- Github user unsleepy22 commented on a diff in the pull

[jira] [Issue Comment Deleted] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elisey Zanko updated STORM-1758: Comment: was deleted (was: It works. Thanks!) > Distributed log search doesn't work in dockerized

[jira] [Commented] (STORM-1736) Change KafkaTestBroker.buildKafkaConfig to new KafkaConfig api.

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268861#comment-15268861 ] ASF GitHub Bot commented on STORM-1736: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1736. Change KafkaTestBroker.buildKafkaC...

2016-05-03 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1376#issuecomment-216560931 This would also break the compatibility of storm 1.0.0 with 0.8.x kafka client API. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268857#comment-15268857 ] ASF GitHub Bot commented on STORM-1700: --- Github user unsleepy22 commented on a diff in the pull

[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-03 Thread unsleepy22
Github user unsleepy22 commented on a diff in the pull request: https://github.com/apache/storm/pull/1324#discussion_r61898673 --- Diff: storm-core/src/jvm/org/apache/storm/metric/filter/FilterByMetricName.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268852#comment-15268852 ] Elisey Zanko commented on STORM-1758: - Actually it's only necessary to add this into the nimbus and

[jira] [Commented] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268850#comment-15268850 ] ASF GitHub Bot commented on STORM-1755: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: STORM-1755: Revert the kafka client version to...

2016-05-03 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1386#issuecomment-216558668 Yes. Good thing is storm-kafka doesn't use any api only available in kafka 0.9.x and thus can still run with kafka 0.8.x by simply excluding dependency. ---

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268836#comment-15268836 ] Elisey Zanko commented on STORM-1758: - It works. Thanks! > Distributed log search doesn't work in

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268834#comment-15268834 ] Elisey Zanko commented on STORM-1758: - It works. Thanks! > Distributed log search doesn't work in

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268793#comment-15268793 ] Jungtaek Lim commented on STORM-1758: - Could you add 'storm.local.hostname: ' to storm.yaml for each

[jira] [Created] (STORM-1759) Viewing logs from the Storm UI doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
Elisey Zanko created STORM-1759: --- Summary: Viewing logs from the Storm UI doesn't work in dockerized environment Key: STORM-1759 URL: https://issues.apache.org/jira/browse/STORM-1759 Project: Apache

[jira] [Issue Comment Deleted] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elisey Zanko updated STORM-1758: Comment: was deleted (was: That would work.) > Distributed log search doesn't work in dockerized

[jira] [Commented] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268773#comment-15268773 ] Elisey Zanko commented on STORM-1758: - That would work. > Distributed log search doesn't work in

[jira] [Created] (STORM-1758) Distributed log search doesn't work in dockerized environment

2016-05-03 Thread Elisey Zanko (JIRA)
Elisey Zanko created STORM-1758: --- Summary: Distributed log search doesn't work in dockerized environment Key: STORM-1758 URL: https://issues.apache.org/jira/browse/STORM-1758 Project: Apache Storm

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268756#comment-15268756 ] ASF GitHub Bot commented on STORM-1646: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216535715 Issue is that some users report that storm-kafka 1.0.0 with 0.9 is not working properly. Please refer https://issues.apache.org/jira/browse/STORM-1755 and

[jira] [Commented] (STORM-1646) Intermittent test failures in storm-kafka unit tests

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268721#comment-15268721 ] ASF GitHub Bot commented on STORM-1646: --- Github user ppoulosk commented on the pull request:

[GitHub] storm pull request: [STORM-1646] Fix Kafka unit tests

2016-05-03 Thread ppoulosk
Github user ppoulosk commented on the pull request: https://github.com/apache/storm/pull/1335#issuecomment-216529805 @HeartSaVioR, I assumed that because storm-kafka already builds against kafka 0.9 and that the changes to max.block.ms were only in unit test code it would not

[jira] [Commented] (STORM-1707) Improve supervisor latency by removing 2-min wait

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268709#comment-15268709 ] ASF GitHub Bot commented on STORM-1707: --- Github user ppoulosk commented on the pull request:

[GitHub] storm pull request: [STORM-1707] Remove two minute timeout after w...

2016-05-03 Thread ppoulosk
Github user ppoulosk commented on the pull request: https://github.com/apache/storm/pull/1370#issuecomment-216527257 Will do. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: STORM-1750 (0.10.x): Ensure worker dies when r...

2016-05-03 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1390 STORM-1750 (0.10.x): Ensure worker dies when report-error-and-die is … …called. Make cluster set-data try setting data if node creation fails because the node exists. Backport of

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268593#comment-15268593 ] ASF GitHub Bot commented on STORM-1756: --- GitHub user srdo reopened a pull request:

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268592#comment-15268592 ] ASF GitHub Bot commented on STORM-1756: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1387 STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker … …to prevent out of memory on large test classes. I'm not clear on whether JUnit keeps the reference for the

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216508276 I did see OOME due to KafkaServer resources. 8x 130MB byte arrays caused the VM to run out of memory. As I said, I can't reproduce it. It's probably not an issue on master

[jira] [Commented] (STORM-1750) Report-error-and-die may not kill the worker

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268575#comment-15268575 ] ASF GitHub Bot commented on STORM-1750: --- GitHub user srdo opened a pull request:

[GitHub] storm pull request: STORM-1750: Ensure worker dies when report-err...

2016-05-03 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/1389 STORM-1750: Ensure worker dies when report-error-and-die is called. M… …ake zookeeper_state_factory set-data try setting data if node creation fails because the node exists. Backport of

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268574#comment-15268574 ] ASF GitHub Bot commented on STORM-1756: --- Github user HeartSaVioR commented on the pull request:

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216505586 Please reopen this issue if you saw intermittent test failure. What I asked is that it's a theory or it occurred some issues. --- If your project is set up for it,

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268528#comment-15268528 ] ASF GitHub Bot commented on STORM-1745: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1380#issuecomment-216496822 @HeartSaVioR Sure. The current logs look like this "Starting Kafka 10.4.5.1:0 from offset 15520", which doesn't tell you which topic it's affecting. The logs in L259 and

[jira] [Resolved] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread JIRA
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stig Rohde Døssing resolved STORM-1756. --- Resolution: Cannot Reproduce Tried setting up some test classes with KafkaTestBroker

[jira] [Commented] (STORM-1735) Nimbus logs that replication was not reached when min-replication-count was reached exactly

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268514#comment-15268514 ] ASF GitHub Bot commented on STORM-1735: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1735: Nimbus should log that replication...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1369#issuecomment-216493707 @HeartSaVioR Sure, please do :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268491#comment-15268491 ] ASF GitHub Bot commented on STORM-1756: --- Github user srdo commented on the pull request:

[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-03 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1387#issuecomment-216490426 If this turns out to be a problem later, disabling the log cleaner thread during tests is probably a better fix. The tests don't make logs long enough to be compacted

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268480#comment-15268480 ] ASF GitHub Bot commented on STORM-1745: --- GitHub user srdo reopened a pull request:

[jira] [Commented] (STORM-1745) Add partition to PartitionManager logs where it's missing

2016-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268479#comment-15268479 ] ASF GitHub Bot commented on STORM-1745: --- Github user srdo closed the pull request at:

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
GitHub user srdo reopened a pull request: https://github.com/apache/storm/pull/1380 STORM-1745: Add partition to log output in PartitionManager Adding topic name and partition id to the log output makes it easier to debug when an issue arises. You can merge this pull request into

[GitHub] storm pull request: STORM-1745: Add partition to log output in Par...

2016-05-03 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/1380 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >