[GitHub] storm issue #1978: STORM-2387 Handle tick tuples properly for Bolts in exter...

2017-03-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1978 @satishd @priyank5485 Applied review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1981: STORM 2391 - Move HdfsSpoutTopology from storm-starter to...

2017-03-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1981 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1957: STORM-2373: HDFS Spout should support multiple ignore ext...

2017-03-01 Thread pasalkarsachin1
Github user pasalkarsachin1 commented on the issue: https://github.com/apache/storm/pull/1957 @roshannaik Thanks for document. Can you merge 8da34caf4938e8a8cc5ac9c745000ed5c6f82b2a? Then I will close PR. --- If your project is set up for it, you can reply to this email and have

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Jungtaek Lim
I guess it might be good time to think why we add all connectors to the binary distribution. Spark and Flink don't include them to binary dist. They even moved some or most of connectors out of repo, have been maintaining them in Apache Bahir. (Personally this is something I'm in favor of. We

[GitHub] storm pull request #1981: STORM 2391 - Move HdfsSpoutTopology from storm-sta...

2017-03-01 Thread roshannaik
GitHub user roshannaik opened a pull request: https://github.com/apache/storm/pull/1981 STORM 2391 - Move HdfsSpoutTopology from storm-starter to storm-hdfs-examples You can merge this pull request into a Git repository by running: $ git pull

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Roshan Naik
Looks like the formatting on my prev email got dropped. But observation is that storm-kafka-monitor and storm-druid are the biggest new contributors. -roshan On 3/1/17, 5:23 PM, "Roshan Naik" wrote: Once all of the shaded examples are included the size will go up

Re: Storm 1.x-branch won't build in IntelliJ anymore

2017-03-01 Thread Roshan Naik
That workaround of running a clean mvn build on the cmd line before building in IntellJ does not work for me anymore. It used sometime back (a month ago?). No matter what I try… I cant get it to build in IntelliJ. -roshan On 3/1/17, 5:20 PM, "Jungtaek Lim" wrote: The

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Roshan Naik
Once all of the shaded examples are included the size will go up further. But currently as they are not part of the tar.gz … something else is the culprit for the bloat. Below is a comparative listing of 1.0.3 vs 1.1.0 binary releases .. of files that are larger than 4MB. @Jungtaek

Re: Storm 1.x-branch won't build in IntelliJ anymore

2017-03-01 Thread Jungtaek Lim
The original plan was not adding anything related storm-core in 1.x version line and move out 2.0.0 fast. (That's what Bobby proposed for JStorm merger phases.) We didn't make it faster (sorry I couldn't contribute for this side at all), and we broke the plan, and it makes harder and harder to

[GitHub] storm issue #1957: STORM-2373: HDFS Spout should support multiple ignore ext...

2017-03-01 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/1957 https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Jungtaek Lim
About STORM-2249, since examples are shading their dependencies, binary dist will grow much bigger. I've left some comments regarding that. Btw, I have another view of this. Showing example codes is more important than just let users execute some topologies. That's what example modules are for. We

[GitHub] storm issue #1960: STORM-1772 Adding Perf module with topologies for measuri...

2017-03-01 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/1960 @harshach I have added the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Hugo Da Cruz Louro
Roshan, does this PR and JIRA address the missing jars problem that you mentioned. I had created it in December 2016, but there is an ongoing discussion if we should indeed put the jars in the examples

elastic 1.6 dependency issue

2017-03-01 Thread Sree V
Hi, Would someone look into this, please ?https://jira.apache.org/jira/browse/STORM-2379 Thanking you, in advance. With Regards Sree

[GitHub] storm issue #1957: STORM-2373: HDFS Spout should support multiple ignore ext...

2017-03-01 Thread pasalkarsachin1
Github user pasalkarsachin1 commented on the issue: https://github.com/apache/storm/pull/1957 @roshannaik Can you help m in squash this? I am not able to do it :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread P. Taylor Goetz
Yeah, I don’t think the file size is a killer/blocker. It’s largely due to shaded examples, etc. But it’s something to keep an eye on. Our binary releases shouldn’t have to be that big. -Taylor > On Mar 1, 2017, at 12:09 PM, Roshan Naik wrote: > > Have filed Jiras so

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Roshan Naik
Have filed Jiras so for the 3 issues mentioned. Not sure if we need a JIRA for the file size getting bloated by that much. Somebody better familiar with the matter may want to take about that? -roshan On 3/1/17, 8:13 AM, "P. Taylor Goetz" wrote: Thanks for bringing

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread P. Taylor Goetz
Thanks for bringing these up Roshan. Feel free to file JIRA tickets for these issues and assign the “Release Apache Storm 1.1.0” epic so they can be tracked for this release. -Taylor > On Mar 1, 2017, at 9:27 AM, Roshan Naik wrote: > > Found these additional issues: >

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.0 (RC2)

2017-03-01 Thread Roshan Naik
Found these additional issues: 1- BUG: Even if topology.eventlogger.executors=0, the event_logger bolt is instantiated … previously observed to cause ~10% degradation in perf even with logging disabled. 2- Missing Jars: The storm-*-examples jars are missing in the binary distro (other than

Re: Storm 1.x-branch won't build in IntelliJ anymore

2017-03-01 Thread Roshan Naik
If we leave 1.x in this state it will forever remain un-usable within IntelliJ .. hard to debug, UT etc. And 1.x will live for a while. Is rolling back some of the non-critical offending commits that are causing this an option ? i tried rolling back a bit but was unable to identify the

[GitHub] storm issue #1178: [STORM-1469] Remove SimpleTransportPlugin and configurati...

2017-03-01 Thread antoinetran
Github user antoinetran commented on the issue: https://github.com/apache/storm/pull/1178 Hi, This has not been merged yet in storm official repository, but it is in forked kishorvpatil repository. Is this normal? Is travis blocking this? Thank you. --- If your project is

[GitHub] storm pull request #1977: STORM-2388 JoinBolt breaks compilation against JDK...

2017-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is