Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
One thing that is worthy of noticing: Storm UI currently interweaves
different search API regarding searching functionalities and it's kind of
confusing.
Specifically:
1. For the
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2754
STORM-3133: Extend metrics on Nimbus and LogViewer
This PR is based on both #2743 and #2753 (merged) and implements the
following metrics:
LogViewer:
- [x] Time to complete one
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200435146
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200439312
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -295,9 +391,1104 @@ public static String getJsonResponseBody(Object
data, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200476039
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200437014
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -295,9 +391,1104 @@ public static String getJsonResponseBody(Object
data, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200474709
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200440315
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200436771
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -295,9 +391,1104 @@ public static String getJsonResponseBody(Object
data, String
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200454747
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -295,9 +391,1104 @@ public static String getJsonResponseBody(Object
data, String
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
The changes look good to me, +1. Left some comments, but I don't think it
makes sense to put too much effort into making the tests more realistic, or
refactoring, given that storm-kafka is being
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200456835
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh() {
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200456703
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java ---
@@ -140,6 +140,42 @@ public void testPartitionManagerRecreate()
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2753
STORM-3133: Fixed bug of unnecessary inclusion of empty search result
`FindNMatches()` didn't correctly filter out empty match result in
`substringSearch()` and hence send back an empty map to
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2751
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2750#discussion_r200445007
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -22,56 +22,53 @@
import java.util.List;
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200415886
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/filters/AuthorizedUserFilter.java ---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200433651
--- Diff: storm-core/test/jvm/org/apache/storm/ui/StormApiResourceTest.java
---
@@ -0,0 +1,19 @@
+package org.apache.storm.ui;
+
+import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200407479
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -77,6 +140,11 @@ public static String prettyUptimeStr(String val,
Object[][]
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200403357
--- Diff: conf/defaults.yaml ---
@@ -88,7 +88,7 @@ nimbus.topology.blobstore.deletion.delay.ms: 30
### ui.* configs are for the master
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200408980
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIServer.java ---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200404317
--- Diff: storm-core/pom.xml ---
@@ -194,10 +249,7 @@
java-hamcrest
test
-
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200408787
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIServer.java ---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200403856
--- Diff: storm-core/pom.xml ---
@@ -32,6 +32,9 @@
/etc/storm
${project.build.directory}/native/worker-launcher
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200430165
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200406284
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -59,6 +116,12 @@
new Object[]{ "d", null }
};
+/**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200407111
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -59,6 +116,12 @@
new Object[]{ "d", null }
};
+/**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200405995
--- Diff: storm-core/src/jvm/org/apache/storm/ui/StormUiApplication.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200429329
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200429402
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200431722
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200403478
--- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
@@ -55,5 +55,7 @@
public static final String COMMON_ONHEAP_MEMORY_RESOURCE_NAME =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200432708
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/resources/StormApiResource.java ---
@@ -0,0 +1,741 @@
+/*
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r200418105
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/filters/AuthorizedUserFilter.java ---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2747#discussion_r200417650
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -109,6 +133,7 @@ public void printCliHelp(String command, PrintStream
out) {
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2747
@agresch I added in the check that you wanted.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2752
I'll start looking at the code, but please fix the checkstyle issues so
that travis can finish the integration test.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2750#discussion_r200393309
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -22,56 +22,53 @@
import java.util.List;
import
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR
Hi, do you probably know release date of the next storm version where this
pull request potentially will be merged? We are facing this issue pretty often
in our cluster which
GitHub user govind-menon opened a pull request:
https://github.com/apache/storm/pull/2752
Storm 1311 Migration of UI from clj to Java
This PR basically duplicates the entire UI core in Java as an embedded
Jetty Server. The follow on PR will delete the clj code and substitute the
40 matches
Mail list logo
