Re: [VOTE] Release Apache Storm 2.0.0 RC5
L & N files usually differ between source and binary distributions. Usually due to shading, contents of lib directory, etc. Source distributions are simpler, since they can’t contain any binaries. For a binary distribution, the L & N files need to reflect everything in the binary dependencies. I think it’s important that we review licensing issues, so I’ll cancel this RC. Kudos to Stig for paying attention to license hygiene! -Taylor > On Mar 25, 2019, at 1:21 PM, Stig Rohde Døssing > wrote: > > Maybe something like this? https://github.com/apache/storm/pull/2980 > > Den man. 25. mar. 2019 kl. 14.12 skrev Stig Rohde Døssing < > stigdoess...@gmail.com>: > >> The ASF guideline says the file "should identify the third-party product, >> its licensing, and a url to the its homepage". If we can get away with >> including the license name and not the license text, I think >> THIRD-PARTY.txt contains what we need. E.g. Spark also only lists the >> license names, and not the texts. >> >> We can clean up the output a bit more, e.g. collapse all the Apache >> licenses together under one header, I just didn't bother because I didn't >> expect the file to be user facing. >> >> Den man. 25. mar. 2019 kl. 13.47 skrev Jungtaek Lim : >> >>> According to how other projects are doing right now, looks like we are >>> not doing. >>> >>> https://github.com/apache/flink/blob/master/NOTICE-binary >>> https://github.com/apache/spark/blob/master/LICENSE-binary >>> https://github.com/apache/kafka/blob/trunk/LICENSE >>> >>> If I understand correct, aether in storm-submit-tool is also EPL v1.0. >>> >>> Btw, I just ran the command "mvn generate-resources >>> -Dlicense.skipAggregateAddThirdParty=false" and see the output: the format >>> of output looks good though the output is a bit verbose. (Attached the >>> output file.) >>> >>> Would it be OK to include the file without cleaning up? >>> >>> 2019년 3월 25일 (월) 오후 8:19, Stig Rohde Døssing 님이 >>> 작성: >>> 0 Built and ran tests from source zip. Ran ExclamationTopology on local install set up from binary zip. Verified no unexpected error logs. Ran integration test locally. Clicked around in UI for a bit, checked that logviewer works. Ran the license check plugin, and verified that all dependency licenses are either category A or B. We have some category B dependencies, e.g. JAXB and Jersey under CDDL. https://apache.org/legal/resolved.html#appropriately-labelled-condition mentions that we should list category B dependencies somewhere visible to users. Do we do this currently? Den fre. 22. mar. 2019 kl. 21.23 skrev P. Taylor Goetz < ptgo...@gmail.com>: > This is a call to vote on releasing Apache Storm 2.0.0 (rc5) > > Full list of changes in this release: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=7e0a711e4ed5315f04f9f726caff61e0f169e320;hb=b5823809bd4b438e789a36f163f318d4b161ad13 > > The source archive being voted upon can be found here: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/ > > The release artifacts are signed with the following key: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1076 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor >>>
[GitHub] [storm] srdo edited a comment on issue #2980: STORM-3361: Include dependency license file in distributions, clean u…
srdo edited a comment on issue #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980#issuecomment-476297208 I would like to eventually be able to make the license file a little nicer. We currently have a bunch of extra headers for dependencies with multiple licenses. Ideally we could shove all Apache licensed dependencies under the Apache license header, even if they are dual licensed under GPL as well. I don't think there's a way to do it with the plugin currently though. Edit: Actually having looked at it a bit more, I wouldn't be comfortable doing that. Multiple licenses apparently aren't always e.g. "Apache OR GPL", but can also be "Apache AND GPL", so it's probably better that it's obvious that a dependency is multi licensed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 2.0.0 RC5
Maybe something like this? https://github.com/apache/storm/pull/2980 Den man. 25. mar. 2019 kl. 14.12 skrev Stig Rohde Døssing < stigdoess...@gmail.com>: > The ASF guideline says the file "should identify the third-party product, > its licensing, and a url to the its homepage". If we can get away with > including the license name and not the license text, I think > THIRD-PARTY.txt contains what we need. E.g. Spark also only lists the > license names, and not the texts. > > We can clean up the output a bit more, e.g. collapse all the Apache > licenses together under one header, I just didn't bother because I didn't > expect the file to be user facing. > > Den man. 25. mar. 2019 kl. 13.47 skrev Jungtaek Lim : > >> According to how other projects are doing right now, looks like we are >> not doing. >> >> https://github.com/apache/flink/blob/master/NOTICE-binary >> https://github.com/apache/spark/blob/master/LICENSE-binary >> https://github.com/apache/kafka/blob/trunk/LICENSE >> >> If I understand correct, aether in storm-submit-tool is also EPL v1.0. >> >> Btw, I just ran the command "mvn generate-resources >> -Dlicense.skipAggregateAddThirdParty=false" and see the output: the format >> of output looks good though the output is a bit verbose. (Attached the >> output file.) >> >> Would it be OK to include the file without cleaning up? >> >> 2019년 3월 25일 (월) 오후 8:19, Stig Rohde Døssing 님이 >> 작성: >> >>> 0 >>> >>> Built and ran tests from source zip. >>> Ran ExclamationTopology on local install set up from binary zip. >>> Verified no unexpected error logs. >>> Ran integration test locally. >>> Clicked around in UI for a bit, checked that logviewer works. >>> Ran the license check plugin, and verified that all dependency licenses >>> are >>> either category A or B. >>> >>> We have some category B dependencies, e.g. JAXB and Jersey under CDDL. >>> https://apache.org/legal/resolved.html#appropriately-labelled-condition >>> mentions that we should list category B dependencies somewhere visible to >>> users. Do we do this currently? >>> >>> Den fre. 22. mar. 2019 kl. 21.23 skrev P. Taylor Goetz < >>> ptgo...@gmail.com>: >>> >>> > This is a call to vote on releasing Apache Storm 2.0.0 (rc5) >>> > >>> > Full list of changes in this release: >>> > >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/RELEASE_NOTES.html >>> > >>> > The tag/commit to be voted upon is v2.0.0: >>> > >>> > >>> > >>> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=7e0a711e4ed5315f04f9f726caff61e0f169e320;hb=b5823809bd4b438e789a36f163f318d4b161ad13 >>> > >>> > The source archive being voted upon can be found here: >>> > >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/apache-storm-2.0.0-src.tar.gz >>> > >>> > Other release files, signatures and digests can be found here: >>> > >>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/ >>> > >>> > The release artifacts are signed with the following key: >>> > >>> > >>> > >>> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >>> > >>> > The Nexus staging repository for this release is: >>> > >>> > https://repository.apache.org/content/repositories/orgapachestorm-1076 >>> > >>> > Please vote on releasing this package as Apache Storm 2.0.0. >>> > >>> > When voting, please list the actions taken to verify the release. >>> > >>> > This vote will be open for at least 72 hours. >>> > >>> > [ ] +1 Release this package as Apache Storm 2.0.0 >>> > [ ] 0 No opinion >>> > [ ] -1 Do not release this package because... >>> > >>> > Thanks to everyone who contributed to this release. >>> > >>> > -Taylor >>> >>
[GitHub] [storm] srdo commented on issue #2980: STORM-3361: Include dependency license file in distributions, clean u…
srdo commented on issue #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980#issuecomment-476297208 I would like to eventually be able to make the license file a little nicer. We currently have a bunch of extra headers for dependencies with multiple licenses. Ideally we could shove all Apache licensed dependencies under the Apache license header, even if they are dual licensed under GPL as well. I don't think there's a way to do it with the plugin currently though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo opened a new pull request #2980: STORM-3361: Include dependency license file in distributions, clean u…
srdo opened a new pull request #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980 …p license merges a bit, make storm-dist use NOTICE/LICENSE from project root https://issues.apache.org/jira/browse/STORM-3361 The change here is so we include a DEPENDENCY-LICENSES file in our distributions and source listing our dependencies and their licenses. Regarding the new file, it is generated by running the license plugin as described in DEVELOPER. Ideally we will regenerate it before each release. It is being committed to git so it will be present in source releases. If we can generate it instead as part of the storm-dist/source build, that would probably be better though. There were NOTICE/LICENSE files in storm-dist/binary that are being included in distributions. To me it looks like they are supposed to be the same files as the ones we have in the project root, but I don't see why we would want to have a copy in storm-dist instead of just reading the root files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [storm] srdo commented on a change in pull request #2978: STORM-3311: Use Java 7 Files API for file IO
srdo commented on a change in pull request #2978: STORM-3311: Use Java 7 Files API for file IO URL: https://github.com/apache/storm/pull/2978#discussion_r268633035 ## File path: examples/storm-hdfs-examples/src/main/java/org/apache/storm/hdfs/bolt/SequenceFileTopology.java ## @@ -14,6 +14,8 @@ import java.io.FileInputStream; Review comment: Yes, will get this done. I'll probably use my IDE to organize the imports, so it might bloat the diff. Will put it in a new commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache Storm 2.0.0 RC5
The ASF guideline says the file "should identify the third-party product, its licensing, and a url to the its homepage". If we can get away with including the license name and not the license text, I think THIRD-PARTY.txt contains what we need. E.g. Spark also only lists the license names, and not the texts. We can clean up the output a bit more, e.g. collapse all the Apache licenses together under one header, I just didn't bother because I didn't expect the file to be user facing. Den man. 25. mar. 2019 kl. 13.47 skrev Jungtaek Lim : > According to how other projects are doing right now, looks like we are not > doing. > > https://github.com/apache/flink/blob/master/NOTICE-binary > https://github.com/apache/spark/blob/master/LICENSE-binary > https://github.com/apache/kafka/blob/trunk/LICENSE > > If I understand correct, aether in storm-submit-tool is also EPL v1.0. > > Btw, I just ran the command "mvn generate-resources > -Dlicense.skipAggregateAddThirdParty=false" and see the output: the format > of output looks good though the output is a bit verbose. (Attached the > output file.) > > Would it be OK to include the file without cleaning up? > > 2019년 3월 25일 (월) 오후 8:19, Stig Rohde Døssing 님이 > 작성: > >> 0 >> >> Built and ran tests from source zip. >> Ran ExclamationTopology on local install set up from binary zip. >> Verified no unexpected error logs. >> Ran integration test locally. >> Clicked around in UI for a bit, checked that logviewer works. >> Ran the license check plugin, and verified that all dependency licenses >> are >> either category A or B. >> >> We have some category B dependencies, e.g. JAXB and Jersey under CDDL. >> https://apache.org/legal/resolved.html#appropriately-labelled-condition >> mentions that we should list category B dependencies somewhere visible to >> users. Do we do this currently? >> >> Den fre. 22. mar. 2019 kl. 21.23 skrev P. Taylor Goetz > >: >> >> > This is a call to vote on releasing Apache Storm 2.0.0 (rc5) >> > >> > Full list of changes in this release: >> > >> > >> > >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/RELEASE_NOTES.html >> > >> > The tag/commit to be voted upon is v2.0.0: >> > >> > >> > >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=7e0a711e4ed5315f04f9f726caff61e0f169e320;hb=b5823809bd4b438e789a36f163f318d4b161ad13 >> > >> > The source archive being voted upon can be found here: >> > >> > >> > >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/apache-storm-2.0.0-src.tar.gz >> > >> > Other release files, signatures and digests can be found here: >> > >> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/ >> > >> > The release artifacts are signed with the following key: >> > >> > >> > >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> > >> > The Nexus staging repository for this release is: >> > >> > https://repository.apache.org/content/repositories/orgapachestorm-1076 >> > >> > Please vote on releasing this package as Apache Storm 2.0.0. >> > >> > When voting, please list the actions taken to verify the release. >> > >> > This vote will be open for at least 72 hours. >> > >> > [ ] +1 Release this package as Apache Storm 2.0.0 >> > [ ] 0 No opinion >> > [ ] -1 Do not release this package because... >> > >> > Thanks to everyone who contributed to this release. >> > >> > -Taylor >> >
Re: [VOTE] Release Apache Storm 2.0.0 RC5
According to how other projects are doing right now, looks like we are not doing. https://github.com/apache/flink/blob/master/NOTICE-binary https://github.com/apache/spark/blob/master/LICENSE-binary https://github.com/apache/kafka/blob/trunk/LICENSE If I understand correct, aether in storm-submit-tool is also EPL v1.0. Btw, I just ran the command "mvn generate-resources -Dlicense.skipAggregateAddThirdParty=false" and see the output: the format of output looks good though the output is a bit verbose. (Attached the output file.) Would it be OK to include the file without cleaning up? 2019년 3월 25일 (월) 오후 8:19, Stig Rohde Døssing 님이 작성: > 0 > > Built and ran tests from source zip. > Ran ExclamationTopology on local install set up from binary zip. > Verified no unexpected error logs. > Ran integration test locally. > Clicked around in UI for a bit, checked that logviewer works. > Ran the license check plugin, and verified that all dependency licenses are > either category A or B. > > We have some category B dependencies, e.g. JAXB and Jersey under CDDL. > https://apache.org/legal/resolved.html#appropriately-labelled-condition > mentions that we should list category B dependencies somewhere visible to > users. Do we do this currently? > > Den fre. 22. mar. 2019 kl. 21.23 skrev P. Taylor Goetz >: > > > This is a call to vote on releasing Apache Storm 2.0.0 (rc5) > > > > Full list of changes in this release: > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/RELEASE_NOTES.html > > > > The tag/commit to be voted upon is v2.0.0: > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=7e0a711e4ed5315f04f9f726caff61e0f169e320;hb=b5823809bd4b438e789a36f163f318d4b161ad13 > > > > The source archive being voted upon can be found here: > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/apache-storm-2.0.0-src.tar.gz > > > > Other release files, signatures and digests can be found here: > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/ > > > > The release artifacts are signed with the following key: > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > The Nexus staging repository for this release is: > > > > https://repository.apache.org/content/repositories/orgapachestorm-1076 > > > > Please vote on releasing this package as Apache Storm 2.0.0. > > > > When voting, please list the actions taken to verify the release. > > > > This vote will be open for at least 72 hours. > > > > [ ] +1 Release this package as Apache Storm 2.0.0 > > [ ] 0 No opinion > > [ ] -1 Do not release this package because... > > > > Thanks to everyone who contributed to this release. > > > > -Taylor > List of third-party dependencies grouped by their license type. Apache License * HttpClient (commons-httpclient:commons-httpclient:3.0.1 - http://jakarta.apache.org/commons/httpclient/) * HttpClient (commons-httpclient:commons-httpclient:3.1 - http://jakarta.apache.org/httpcomponents/httpclient-3.x/) * HttpClient (org.apache.httpcomponents:httpclient:4.2.5 - http://hc.apache.org/httpcomponents-client) * HttpCore (org.apache.httpcomponents:httpcore:4.2.4 - http://hc.apache.org/httpcomponents-core-ga) Apache License, Version 2.0 * ActiveMQ :: Broker (org.apache.activemq:activemq-broker:5.15.8 - http://activemq.apache.org/activemq-broker) * ActiveMQ :: Client (org.apache.activemq:activemq-client:5.15.8 - http://activemq.apache.org/activemq-client) * ActiveMQ :: KahaDB Store (org.apache.activemq:activemq-kahadb-store:5.15.8 - http://activemq.apache.org/activemq-kahadb-store) * ActiveMQ :: MQTT Protocol (org.apache.activemq:activemq-mqtt:5.15.8 - http://activemq.apache.org/activemq-mqtt) * ActiveMQ :: Openwire Legacy Support (org.apache.activemq:activemq-openwire-legacy:5.15.8 - http://activemq.apache.org/activemq-openwire-legacy) * ActiveMQ Protocol Buffers Implementation and Compiler (org.apache.activemq.protobuf:activemq-protobuf:1.1 - http://activemq.apache.org/activemq-protobuf) * Aether :: API (org.sonatype.aether:aether-api:1.7 - http://aether.sonatype.org/aether-api/) * Aether :: Implementation (org.sonatype.aether:aether-impl:1.7 - http://aether.sonatype.org/aether-impl/) * Aether :: SPI (org.sonatype.aether:aether-spi:1.7 - http://aether.sonatype.org/aether-spi/) * Aether :: Utilities (org.sonatype.aether:aether-util:1.7 - http://aether.sonatype.org/aether-util/) * Aggregate Designer Algorithm (net.hydromatic:aggdesigner-algorithm:6.0 - http://github.com/julianhyde/aggdesigner/aggdesigner-algorithm) * aircompressor (io.airlift:aircompressor:0.3 - http://github.com/airlift/aircompressor) * Annotation 1.0 (org.apache.geronimo.specs:geronimo-annotation_1.0_spec:1.1.1 -
Re: [VOTE] Release Apache Storm 2.0.0 RC5
0 Built and ran tests from source zip. Ran ExclamationTopology on local install set up from binary zip. Verified no unexpected error logs. Ran integration test locally. Clicked around in UI for a bit, checked that logviewer works. Ran the license check plugin, and verified that all dependency licenses are either category A or B. We have some category B dependencies, e.g. JAXB and Jersey under CDDL. https://apache.org/legal/resolved.html#appropriately-labelled-condition mentions that we should list category B dependencies somewhere visible to users. Do we do this currently? Den fre. 22. mar. 2019 kl. 21.23 skrev P. Taylor Goetz : > This is a call to vote on releasing Apache Storm 2.0.0 (rc5) > > Full list of changes in this release: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/RELEASE_NOTES.html > > The tag/commit to be voted upon is v2.0.0: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=7e0a711e4ed5315f04f9f726caff61e0f169e320;hb=b5823809bd4b438e789a36f163f318d4b161ad13 > > The source archive being voted upon can be found here: > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/apache-storm-2.0.0-src.tar.gz > > Other release files, signatures and digests can be found here: > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc5/ > > The release artifacts are signed with the following key: > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > The Nexus staging repository for this release is: > > https://repository.apache.org/content/repositories/orgapachestorm-1076 > > Please vote on releasing this package as Apache Storm 2.0.0. > > When voting, please list the actions taken to verify the release. > > This vote will be open for at least 72 hours. > > [ ] +1 Release this package as Apache Storm 2.0.0 > [ ] 0 No opinion > [ ] -1 Do not release this package because... > > Thanks to everyone who contributed to this release. > > -Taylor
