[GitHub] [storm] srdo edited a comment on issue #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build

2019-05-01 Thread GitBox
srdo edited a comment on issue #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build URL: https://github.com/apache/storm/pull/3006#issuecomment-488431750 One of the integration tests failed with an error I haven't seen before. Will raise an issue to track.

[GitHub] [storm] srdo commented on issue #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build

2019-05-01 Thread GitBox
srdo commented on issue #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build URL: https://github.com/apache/storm/pull/3006#issuecomment-488431750 One of the integration tests failed with an error I haven't seen before. Will raise an issue to track if it's intermittent.

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Stig Rohde Døssing
Subscription has been replaced with TopicFilter. Subscription isn't deprecated in 1.x because it is not possible to backport TopicFilter without breaking changes. The replacement is the TopicFilter and ManualPartitioner classes. getKey/ValueDeserializer is deprecated in the latest 1.x release,

[GitHub] [storm] srdo opened a new pull request #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build

2019-05-01 Thread GitBox
srdo opened a new pull request #3006: STORM-3386: Require Maven version 3.5.0 for Storm's build URL: https://github.com/apache/storm/pull/3006 https://issues.apache.org/jira/browse/STORM-3386 Checked that the build now won't run on 3.3.9, but will run on 3.5.0 and 3.6.1.

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Alexandre Vermeerbergen
Hello, Thanks, and my step issue with Storm 2.0.0 is with some Storm Kafka Client breaking changes in KafkaSpoutConfig class. See attached source for our homebrewed BasicKafkaSpout, I have at least the following compilation errors:

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Derek Dagit
> we can just bump it to something like 3.5.0. I'll raise an issue for it. +1 and Thanks Alexandre for finding this, it is a help. On Wed, May 1, 2019 at 2:18 PM Stig Rohde Døssing wrote: > Yes, we already have a check that the Maven version is above 3.0.0 ( >

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Stig Rohde Døssing
Yes, we already have a check that the Maven version is above 3.0.0 ( https://github.com/apache/storm/blob/master/pom.xml#L1439), IMO we can just bump it to something like 3.5.0. I'll raise an issue for it. Den ons. 1. maj 2019 kl. 20.59 skrev Alexandre Vermeerbergen < avermeerber...@gmail.com>:

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Alexandre Vermeerbergen
Hello Stig, Good catch: I upgraded Maven to version 3.6.1 and I rebuilt everything from source tar.gz without any trouble. So I delay my vote and I'm no longer blocked since I have storm-kafka-client-2.0.0.jar allowing me to rebuilt my topologies. Just a question: since my experience showed

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Stig Rohde Døssing
I haven't seen the error you're getting before, but it looks like it's a Maven issue, not a Storm issue. Could you try updating to the latest Maven version? Den ons. 1. maj 2019 kl. 19.30 skrev Alexandre Vermeerbergen < avermeerber...@gmail.com>: > Hello, > > I don't know if this is worth a -1

[GitHub] [storm] srdo commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
srdo commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005#issuecomment-488350038 No, I mean exitCodeCallback is already null in the line you're changing

[GitHub] [storm] Ethanlm edited a comment on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
Ethanlm edited a comment on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005#issuecomment-488349409 @srdo Yes it's the purpose of making it to null. So that separate thread can be skipped. Then

[GitHub] [storm] Ethanlm edited a comment on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
Ethanlm edited a comment on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005#issuecomment-488349409 @srdo Yes it's the purpose of making it to null. So that separate thread can be skipped. Then

[GitHub] [storm] Ethanlm commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
Ethanlm commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005#issuecomment-488349409 Yes it's the purpose of making it to null. So that separate thread can be skipped. Then there will be only

[GitHub] [storm] srdo commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
srdo commented on issue #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005#issuecomment-488327001 Won't the thread here be skipped, since exitCallback is null?

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Stig Rohde Døssing
Alexandre, I think we tend to assume people use a dependency management tool: https://storm.apache.org/releases/2.0.0-SNAPSHOT/Maven.html The easiest way for you to get a list of the jars that need to be on the classpath is to make a dummy Maven project, add the snippet I linked to the POM, and

[GitHub] [storm] Ethanlm opened a new pull request #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process

2019-05-01 Thread GitBox
Ethanlm opened a new pull request #3005: [STORM-3385] Avoid two threads reading from the same input stream of a process URL: https://github.com/apache/storm/pull/3005 https://issues.apache.org/jira/browse/STORM-3385 This is not causing any problem so far. But having two threads are

Re: [VOTE] Release Apache Storm 2.0.0 RC7

2019-05-01 Thread Alexandre Vermeerbergen
Hello, I tried to rebuild my topologies with 2.0, but I hit a first trivial issue: I used to rely on storm-core-.jar in our classpath to resolve Storm API dependencies, but storm-core-2.0.0.jar doesn't seem to contain anymore classes like org.apache.storm.task.OutputCollector which is used in our